- Engine-commits - oVirt List Archives

Change in jenkins[master]: lago-pipeline: support job names with 'github'
by Code Review 27 Feb '17

27 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: lago-pipeline: support job names with 'github' ...................................................................... lago-pipeline: support job names with 'github' Commit 159ff990('Factorise github specific yamls') will change GitHub jobs to the naming convention of 'project-branch-github-stage'. This patch adds detection of which jobs to look for, according to the generated job(GitHub or not). Change-Id: Ibf9495954498a0f0d9a5cbe1edae55ac9236ab6c Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- M jobs/confs/groovy-scripts/standard-pipeline.groovy 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Nadav Goldin: Verified; Ready for review Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf9495954498a0f0d9a5cbe1edae55ac9236ab6c Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: lago-pipeline: refactoring
by Code Review 27 Feb '17

27 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: lago-pipeline: refactoring ...................................................................... lago-pipeline: refactoring 1. Assert 'sha1' and 'REFSPEC' parameters are passed to the job, otherwise fail. This will be done inside a preliminary stage, thus allowing to use the proper Jenkins stage failure mechanism, and avoid messing with buildResult parameters. Did not include assertion for gerrit parameters, as we use this flow for github only at the moment. 2. Use 'params' instead of 'env' where applicable. 3. Use the new 'stage' syntax. 4. Remove code duplication and unify functions. 5. Use the new milestone syntax to guarantee only one job gets to the deploy stage. 6. Moved main() to the top of the code. 7. JJB variables will be substituted into the main function call. Change-Id: I13f3b9ac30266a6372e9b0e34de8511629f9453c Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- M jobs/confs/groovy-scripts/standard-pipeline.groovy 1 file changed, 70 insertions(+), 139 deletions(-) Approvals: Nadav Goldin: Verified; Ready for review Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72648 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f3b9ac30266a6372e9b0e34de8511629f9453c Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Text in templates
by Code Review 27 Feb '17

27 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: Text in templates ...................................................................... userportal,webadmin: Text in templates - Moved text that needed to be translated from Templates to Constants. Change-Id: I0c5a923530844916ada4deb5369abfbb0756e96c Bug-Url: https://bugzilla.redhat.com/1422455 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/OptionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/OptionsPopupView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/InfoIcon.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmImportGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoGeneral.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolGeneralView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 23 files changed, 150 insertions(+), 95 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c5a923530844916ada4deb5369abfbb0756e96c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix ComboBox
by Code Review 27 Feb '17

27 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix ComboBox ...................................................................... webadmin: Fix ComboBox - Fixed issue with ComboBox not working as before Change-Id: I5216d4de7bcb753d5715aac3833f663ad665b009 Bug-Url: https://bugzilla.redhat.com/1422779 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ComboBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ComboBox.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 5 files changed, 17 insertions(+), 90 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5216d4de7bcb753d5715aac3833f663ad665b009 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: update welcome and login pages for PF3
by Code Review 27 Feb '17

27 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: engine: update welcome and login pages for PF3 ...................................................................... engine: update welcome and login pages for PF3 Update the welcome, login, 404, 405, credentialsChange pages to use PF3. Change-Id: I45d28bb6f85f65a893dc693cfdcb7e3e93826978 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/header.tag M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp M packaging/branding/ovirt.brand/common.css M packaging/branding/ovirt.brand/patternfly-ovirt.css 9 files changed, 65 insertions(+), 87 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/73085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45d28bb6f85f65a893dc693cfdcb7e3e93826978 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix clicking on labels
by Code Review 27 Feb '17

27 Feb '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix clicking on labels ...................................................................... webadmin: Fix clicking on labels - Fixed a few more labels that were not properly associated with their associated radio/checkboxes Change-Id: I1e27cfdc4c3cade5dc056c6e539e3aebbc82747a Bug-Url: https://bugzilla.redhat.com/1414418 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 5 files changed, 26 insertions(+), 29 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e27cfdc4c3cade5dc056c6e539e3aebbc82747a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Bump release number
by Code Review 27 Feb '17

27 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Bump release number ...................................................................... Bump release number Recent changes in the way that the automation scripts work had the side effect of changing the RPM release number from 0.1 to 0. This means that the new RPMs built in the automation environment, with RPM release 0, are, from the RPM point of view, older than those with RPM release 0.1. To avoid that this patch changes the RPM release number contained in the .spec templates to 2, so that when decremented it will be 1, hence newer than the existing 0.1 packages. Change-Id: If64322d9a87fe6f099507e17076d17c84d6c5ba7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/spec.el7.in M packaging/spec.fc24.in M packaging/spec.fc25.in 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73167 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If64322d9a87fe6f099507e17076d17c84d6c5ba7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Prevent error in VM NUMA pinning dialog
by Code Review 27 Feb '17

27 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Prevent error in VM NUMA pinning dialog ...................................................................... webadmin: Prevent error in VM NUMA pinning dialog When dragging an icon from any part of the VM NUMA pinning dialog other than the 'unassigned virtual nodes' element, an exception is thrown causing an error to be displayed in the UI. This patch prevents the exception, avoiding the error. Change-Id: Iebc2adabb216a1b65d8ad31a2d6d9700e4baae4b Bug-Url: https://bugzilla.redhat.com/1427158 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/DragTargetScrollPanel.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/73158 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebc2adabb216a1b65d8ad31a2d6d9700e4baae4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Bump release number
by Code Review 27 Feb '17

27 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Bump release number ...................................................................... Bump release number Recent changes in the way that the automation scripts work had the side effect of changing the RPM release number from 0.1 to 0. This means that the new RPMs built in the automation environment, with RPM release 0, are, from the RPM point of view, older than those with RPM release 0.1. To avoid that this patch changes the RPM release number contained in the .spec templates to 2, so that when decremented it will be 1, hence newer than the existing 0.1 packages. Change-Id: If64322d9a87fe6f099507e17076d17c84d6c5ba7 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/spec.el7.in M packaging/spec.fc24.in M packaging/spec.fc25.in 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If64322d9a87fe6f099507e17076d17c84d6c5ba7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: Require collectd/fluentd+plugins
by Code Review 27 Feb '17

27 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: Require collectd/fluentd+plugins ...................................................................... packaging: spec: Require collectd/fluentd+plugins To allow collecting data and sending to a central store. Change-Id: Ie497bae2d80c7bf27ff4bd401e9c83dc49a33694 Bug-Url: https://bugzilla.redhat.com/1406005 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Objections: Yedidyah Bar David: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/71590 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie497bae2d80c7bf27ff4bd401e9c83dc49a33694 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0