- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Permission given to a group doesn't apply to its mem...
by yzaslavs＠redhat.com 19 Aug '12

19 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Permission given to a group doesn't apply to its member (#847333) ...................................................................... engine: Permission given to a group doesn't apply to its member (#847333) This patch fixes creation of user_permission_permissions_view. The error was that user of a group doesn't get the same permissions that the group does have. The user gets its own specific permissions only. This happens because the view user_permissions_permissions_view uses user_flat_groups in a wrong way, the view is supposed to make a table of permissions connected to user_id as permission_view, but this view connects also subusers of groups to their group's permissions. It uses ad_element_id instead of use_id field, that's the reason why GetPermissionsByAdElementIdQuery returns only permissions on specific user without including its group permissions. Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: VM subtab disks corrections (#846551)
by asaf＠redhat.com 19 Aug '12

19 Aug '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: VM subtab disks corrections (#846551) ...................................................................... webadmin: VM subtab disks corrections (#846551) https://bugzilla.redhat.com/846551 - Fixed auto collapse of snapshots when tree gets refreshed. - VMsTree supported DiskImage only, extended support for LunDisks as well. Change-Id: I059bf7a8b18232640eaa7f2f5c49ee1cbc6d5486 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/VMsTree.java 1 file changed, 70 insertions(+), 30 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I059bf7a8b18232640eaa7f2f5c49ee1cbc6d5486 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: avoid prms check when quota unchanged
by dfediuck＠redhat.com 19 Aug '12

19 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: avoid prms check when quota unchanged ...................................................................... core: avoid prms check when quota unchanged incase the quota refernce of an object (vm, disk or template) isn't changed, do not perform quota permission check on that quota. Change-Id: I6d1fe74b4d4c6f23077c70d4779265b354147259 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java 4 files changed, 22 insertions(+), 6 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d1fe74b4d4c6f23077c70d4779265b354147259 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing account disabled handling
by yzaslavs＠redhat.com 19 Aug '12

19 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing account disabled handling ...................................................................... core: Fixing account disabled handling The following patch fix account disabled handling. It fixes: 1. Improper usage of AuditLog to log account locked or disabled event 2. AuditLog also in case of OperationNotSUppotedException - this error might occure if account got locked after authentication succeeds. 3. Fix of EngineDirectoryServiceException - in case of OperationNotSuppoortedException there should be not attempt to proceed to next LDAP server and a proper detailed error should be printed. The fix fixes the detailed error printing Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6588 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/EngineDirectoryServiceException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ExceptionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchExceptionHandler.java 6 files changed, 23 insertions(+), 14 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59e875997b904cbdc058a45efd640f5bf1fc6588 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix disk permission view (#849404)
by yzaslavs＠redhat.com 19 Aug '12

19 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix disk permission view (#849404) ...................................................................... core: Fix disk permission view (#849404) https://bugzilla.redhat.com/show_bug.cgi?id=849404 This patch fixes the user disk permissions view, to contain disks from SDs and DCs the user has permissions on. The problem is that the current views return the image_id and not the image_group_id (disk id). Change-Id: I6cf88c61b054b0e791c7e2c2e4313908dd7a2fc5 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cf88c61b054b0e791c7e2c2e4313908dd7a2fc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: StoragePool storage_pool_format_type is lost in upda...
by asaf＠redhat.com 19 Aug '12

19 Aug '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: StoragePool storage_pool_format_type is lost in update (#845310) ...................................................................... engine: StoragePool storage_pool_format_type is lost in update (#845310) https://bugzilla.redhat.com/845310 StoragePool's storage_pool_format_type property is not set in params entity (as it's not visible in UI) so the value is lost during storage pool update, This patch copies the property value from the old entity. Change-Id: I4e19bc2102e40c818b8953a08d1203c3a9b042b0 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e19bc2102e40c818b8953a08d1203c3a9b042b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk[master]: sdk: make request error being capable to handle any type of ...
by mpastern＠redhat.com 19 Aug '12

19 Aug '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: make request error being capable to handle any type of response ...................................................................... sdk: make request error being capable to handle any type of response Change-Id: Ia457618f7b86977c14bd6b1fb1397de484dd0371 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/errors.py 1 file changed, 33 insertions(+), 23 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia457618f7b86977c14bd6b1fb1397de484dd0371 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Improved version support (#760546)
by yzaslavs＠redhat.com 19 Aug '12

19 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improved version support (#760546) ...................................................................... core: Improved version support (#760546) https://bugzilla.redhat.com/760546 The following patch provides the following: a. Elimination of VdsVersion and usage of RpmVersion instead b. Introducing new rpm_version column to vds_dynamic to store VDSM rpm version c. Presentation at UI of Vdsm Version Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e5 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Signed-off-by: Alexey Chub <achub(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1360_add_vdsm_rpm_version_column.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsVersion.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RpmVersion.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/common/AboutModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VersionRenderer.java 20 files changed, 169 insertions(+), 262 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9931a1aa804d9dc7aec1485ebc29bac45131d0e5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: use config value to decide if allow non vmnet [#84...
by alkaplan＠redhat.com 19 Aug '12

19 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: use config value to decide if allow non vmnet [#849408] ...................................................................... webadmin: use config value to decide if allow non vmnet [#849408] https://bugzilla.redhat.com/849408 - Use SupportBridgesReportByVDSM config value to decide if to allow non-vm networks on the cluster/dc. - When enabling/disabling the network dialog (according to the attached clusters), check the SupportBridgesReportByVDSM before enabling the vm network field. Change-Id: Id330b4c55f1ee7642371a94e0b607ae5505afa81 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 5 files changed, 290 insertions(+), 231 deletions(-) Approvals: Alona Kaplan: Verified Livnat Peer: Looks good to me, but someone else must approve Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id330b4c55f1ee7642371a94e0b607ae5505afa81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetwork] edit netork dialog- sync network cr...
by alkaplan＠redhat.com 19 Aug '12

19 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetwork] edit netork dialog- sync network cropped (#849409) ...................................................................... webadmin: [SetupNetwork] edit netork dialog- sync network cropped (#849409) https://bugzilla.redhat.com/849409 The are resolutions on which the sync network line in the dialog is cropped. Use "%" instead of "px" in order to avoid resolution/screen size differences. Change-Id: I1787366c91d4fcb9c624465ebc3b7f926fe67bd2 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1787366c91d4fcb9c624465ebc3b7f926fe67bd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0