- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Cleanup BackendApiResourceTest
by oliel＠redhat.com 22 Jul '12

22 Jul '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Cleanup BackendApiResourceTest ...................................................................... restapi: Cleanup BackendApiResourceTest Removed unused @RunWith statements, method parameters, and private methods. Change-Id: I433610d691246edc54182ffe916802a4082f577e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java 1 file changed, 9 insertions(+), 23 deletions(-) Approvals: Ori Liel: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/6280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I433610d691246edc54182ffe916802a4082f577e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RegisterVdsQuery - removal of '_' character from membe...
by mlipchuk＠redhat.com 22 Jul '12

22 Jul '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RegisterVdsQuery - removal of '_' character from members names ...................................................................... core: RegisterVdsQuery - removal of '_' character from members names Change-Id: I13959db4ffa8f2313971f155e11373eff174ab22 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 20 insertions(+), 20 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13959db4ffa8f2313971f155e11373eff174ab22 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RegisterVdsQuery -removed CanDoAction()
by mlipchuk＠redhat.com 22 Jul '12

22 Jul '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: RegisterVdsQuery -removed CanDoAction() ...................................................................... core: RegisterVdsQuery -removed CanDoAction() removed unneeded CanDoAction() method, the method contained various validations which were moved to validateInputs() method. Change-Id: I6c33cc1af4127da44fecd74559124090a535f574 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 2 files changed, 37 insertions(+), 46 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c33cc1af4127da44fecd74559124090a535f574 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: fixed logs location to /var/log/ovirt-engine
by ydary＠redhat.com 22 Jul '12

22 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed logs location to /var/log/ovirt-engine ...................................................................... packaging: fixed logs location to /var/log/ovirt-engine Change-Id: If072883b69027d8af316282cec442a9d57197860 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/ovirt-engine-history-db-install.sh M packaging/ovirt-engine-dwh-setup.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If072883b69027d8af316282cec442a9d57197860 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Default disk format, NFS-Thin Block-Preallocated
by derez＠redhat.com 22 Jul '12

22 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Default disk format, NFS-Thin Block-Preallocated ...................................................................... webadmin: Default disk format, NFS-Thin Block-Preallocated https://bugzilla.redhat.com/840327 When creating a new virtual disk, the default disk format should be: 'Thin Provision' for NFS and 'Preallocated' for Block Devices. Change-Id: I85ae8700ab13a37b777207da06f699b0cca36fb0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java 4 files changed, 38 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ae8700ab13a37b777207da06f699b0cca36fb0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: separate storage & cluster quota
by gchaplik＠redhat.com 22 Jul '12

22 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: separate storage & cluster quota ...................................................................... webadmin: separate storage & cluster quota This patch separates quota for storage and cluster limitation, from now on quota object will have only one sets of limitations: cluster or storage. Change-Id: Id8d23a8232d6b2cd8dcf4dfbde972dd9bfdd6420 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelRadioButtonEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/QuotaModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java 9 files changed, 263 insertions(+), 121 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8d23a8232d6b2cd8dcf4dfbde972dd9bfdd6420 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: quota - fix in relvant quota for entity
by gchaplik＠redhat.com 22 Jul '12

22 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: quota - fix in relvant quota for entity ...................................................................... core: quota - fix in relvant quota for entity added a check to the 'get relevant quota by cluster/storage' SP, that filters out the non-relevant quota. currently for relevant storage quota, we select also the cluster quota, and the other way around. the SPs have changed to filter out quota that doesnt have proper limitations, i.e. has null in the relevant limitation. Change-Id: I52b765acbeb97ec872de3cd265fe916b00dc4b8b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/quota_sp.sql 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52b765acbeb97ec872de3cd265fe916b00dc4b8b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: updating disks quota
by gchaplik＠redhat.com 22 Jul '12

22 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: updating disks quota ...................................................................... core: updating disks quota Currently when moving or coping a disk, the quota snapshots of that disk is not changed, according to the active image quota. added a SP that updates all snapshots quota according to the new quota by image_group_id Change-Id: Id5468de3ef6e09fdeabee7826973fab88c0673b8 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/images_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java 4 files changed, 21 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5468de3ef6e09fdeabee7826973fab88c0673b8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: quota fix-ups in webadmin
by gchaplik＠redhat.com 22 Jul '12

22 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: quota fix-ups in webadmin ...................................................................... webadmin: quota fix-ups in webadmin in pools, allowing selecting quota when creating a new vm from pool, and fixing a bug in the tree, where DC is not refreshed, when updating quota mode. Change-Id: I2cf1ca06fdbd7a86c62380db4aa1a2765359dcff Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 6 files changed, 23 insertions(+), 18 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cf1ca06fdbd7a86c62380db4aa1a2765359dcff Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: refactoring quota
by gchaplik＠redhat.com 22 Jul '12

22 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: refactoring quota ...................................................................... core: refactoring quota this patch is a combination of 8 patches, that are pushed together because there're dependent on each other: in gerrit they were pushed separately to ease the review process. Detailed description (original patches) core: refactoring quota Currently the quota is handled through static methods, involving db and cache. adding an inteface to handle quota only when command implements it. the quota manager should handle quota validation in cache. Change-Id: Idc7573082e777370cdf0b88dbe5bfedeb5d02baf Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> core: refactoring quota CRUD commands add, remove & update quota commands should inherit abstract command class, without the need to use quotaHelper. Change-Id: I78124bce99bad0d716e711b6dd76e9c763affbc6 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> core: quota command implements Quotable iface in every command that uses quota, we sholud implement Quotable. validate and rollback according to command & quota parameters. Change-Id: I9f7a4afa4b5308f96d9281fe3cc9791d9ac438e3 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> core: removing quota from backend base class quota ref will be provided only in need not everywhere (using quotable interface). Change-Id: I65974e59b9470c9cc3319aeaaed4d0ed9103cead Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> core: removing quota unnecessary code from tests Change-Id: I8b8ffbcee2ea74c4a88669d26939644dfe680c06 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> engine: removing default quota in db scripts (SP & views) in backend (DAO and bll layers) in webamind In the new quota design there is no need for default quota. Elements without quota, will have null/no quota. therefore, the upgrade scripts should not create default quotas and set the elements with it. hence removing the column is_default_quota in quota table, and all column's refs in views and SPs. Change-Id: I197ebf9aafb3919a17c8b10bd9971ab049f62ef8 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> core: check consume quota permission on assignment Currently there is no checks for permissions, on cosume quota. added to the quotable interface getPermissionQuotaSubject method, and all of its implementation must supply the relevent quota (quota(s) in case disk are involved). this check will be performed only when the quota mode isn't disabled. in the commnad base, when the command is quotable we will invoke the method, and add the permission check the the list. Change-Id: I6f2812af88eb7130dd3527ace4615b4515043d29 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> core: quota - fix tests and checkstyles Change-Id: I62ab51302c55de82e912e61ba5462297461eb78c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/quota_sp.sql M backend/manager/dbscripts/upgrade/03_01_0460_add_defalut_quota_column.sql M backend/manager/dbscripts/upgrade/03_01_0520_quota_upgrade_script.sql M backend/manager/dbscripts/upgrade/03_01_0960_fix_default_quota_name.sql A backend/manager/dbscripts/upgrade/03_01_1310_remove_default_quota.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/StorageQuotaValidationParameter.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddQuotaCommandTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QuotaHelperTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateQuotaCommandTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/Quotable.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java 58 files changed, 1,742 insertions(+), 2,841 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62ab51302c55de82e912e61ba5462297461eb78c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0