- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Engine: Ovf reader will fail if image StorageId doesnt exist...
by mkolesni＠redhat.com 01 Jul '12

01 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: Engine: Ovf reader will fail if image StorageId doesnt exists ...................................................................... Engine: Ovf reader will fail if image StorageId doesnt exists Change-Id: I7652cc4a0d750b72a83178a54cb042d4bd40b163 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/5344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7652cc4a0d750b72a83178a54cb042d4bd40b163 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix indentation in ManageDomains
by yzaslavs＠redhat.com 01 Jul '12

01 Jul '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fix indentation in ManageDomains ...................................................................... engine: Fix indentation in ManageDomains Change-Id: Idd9dfe92db7712d380e6161abca9690aecc8ad07 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sharad Mishra: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd9dfe92db7712d380e6161abca9690aecc8ad07 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Use an absolute URL for spice CABs
by vszocs＠redhat.com 29 Jun '12

29 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Use an absolute URL for spice CABs ...................................................................... webadmin: Use an absolute URL for spice CABs We are currently using URLs relative to the webadmin and user portal applications in order to locate the spice .cab files. This forces the spice package to be installed or symlinked inside the user portal application, which is not nice. This change uses an URL relative to the root of the server and configures the file servlet to get the .cab files from their original location in the file system. It currently assumes that .cab files are located in /usr/share/spice, but this can be quickly changed in the web.xml file of the root.war application. Change-Id: Id22b30f8120e281187572b164b88fa9c260f61dd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java 4 files changed, 96 insertions(+), 14 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id22b30f8120e281187572b164b88fa9c260f61dd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: SetupNetworks-add tooltip to disabled ok button
by tnisan＠redhat.com 28 Jun '12

28 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: SetupNetworks-add tooltip to disabled ok button ...................................................................... webadmin: SetupNetworks-add tooltip to disabled ok button https://bugzilla.redhat.com/823881 If the management network is detached, the host's networks configuration can't be saved. So the ok button is disabled. I"ve added a tooltip to the disabled ok button, to explain the user why the "ok" is diabled. Change-Id: Ie7679b5cb80f434265959179a7768f6281ca4a33 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5779 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7679b5cb80f434265959179a7768f6281ca4a33 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: SetupNetworks adding tooltip to checkConnectivity ...
by tnisan＠redhat.com 28 Jun '12

28 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: SetupNetworks adding tooltip to checkConnectivity and checkCommit ...................................................................... webadmin: SetupNetworks adding tooltip to checkConnectivity and checkCommit https://bugzilla.redhat.com/823881 Setup Networks- add ? icon next to the check connectivity and save network configuration checkboxes. Rolling over these icons displays a tooltip with explanation abuot the meaning of the checkboxes. Change-Id: I00a2edb1328cc499990c3fed023203f5b17ca2ed Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InfoIcon.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java 6 files changed, 92 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00a2edb1328cc499990c3fed023203f5b17ca2ed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Setup Networks- redesign nic and network tooltip
by tnisan＠redhat.com 28 Jun '12

28 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Setup Networks- redesign nic and network tooltip ...................................................................... webadmin: Setup Networks- redesign nic and network tooltip https://bugzilla.redhat.com/823881 Setup Networks- redesign nic and network tooltip - Add title - Add usages with image - design the tool tip Change-Id: I8f08798764590c4865399146f91be79357787bec Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/mgmt_net.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/network_monitor.png M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/network_vm.png 6 files changed, 61 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f08798764590c4865399146f91be79357787bec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use file servlet to serve documentation
by vszocs＠redhat.com 28 Jun '12

28 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: core: Use file servlet to serve documentation ...................................................................... core: Use file servlet to serve documentation The documentation will be deployed to the /usr/share/ovirt-engine/docs directory and the servlet will pick it from there using the /docs URL prefix. Change-Id: I7c182b2e67c5598589ac528ed40f930ccf7c0de8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/FileServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml 3 files changed, 121 insertions(+), 13 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c182b2e67c5598589ac528ed40f930ccf7c0de8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core: GetLunsByVgId - update LUNs path count"
by derez＠redhat.com 28 Jun '12

28 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: Revert "core: GetLunsByVgId - update LUNs path count" ...................................................................... Revert "core: GetLunsByVgId - update LUNs path count" This reverts commit 197d76ec5d0c5169671079f235034a1cd24ca4f4 Change-Id: Ied3e6b1cef56d40e264634fb25b77c4ad7898c0c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetLunsByVgIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetLunsByVgIdParameters.java 4 files changed, 3 insertions(+), 116 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied3e6b1cef56d40e264634fb25b77c4ad7898c0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "webadmin: calling GetLunsByVgId query by Host ID"
by derez＠redhat.com 28 Jun '12

28 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: Revert "webadmin: calling GetLunsByVgId query by Host ID" ...................................................................... Revert "webadmin: calling GetLunsByVgId query by Host ID" This reverts commit 47995055c464bc9ce23c9609ba72822a145c6ef4 Change-Id: Ife1f2ed9a2ffb6960ae40fa4d567d05425a08f9a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 8 insertions(+), 25 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5771 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife1f2ed9a2ffb6960ae40fa4d567d05425a08f9a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing remove user messages
by oourfali＠redhat.com 28 Jun '12

28 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixing remove user messages ...................................................................... core: fixing remove user messages This patch does some fixes in "cannot removed logged in user" message: 1. Add a space after the "." in the middle of the message 2. Add user type, so that it would appear in the message 3. Override setActionMessageParameters to get the correct action and type Change-Id: I479251005125d5285cd27af8c2c0a66f5f2322bc Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveUserCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 17 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I479251005125d5285cd27af8c2c0a66f5f2322bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0