- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add permission for changing custom properties
by ofrenkel＠redhat.com 24 Jun '12

24 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: add permission for changing custom properties ...................................................................... core: add permission for changing custom properties in order to change custom properties user need to have explicit permission permission check added to addVm, updateVm, importVm, runVm permission added to admin roles that have all vm actions allowed: super user, dc admin, cluster admin Change-Id: If7409927233901439e33ec31c1091dd5948953e7 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1250_add_custom_props_action_group.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 10 files changed, 94 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7409927233901439e33ec31c1091dd5948953e7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing task monitoring - run stateless
by yzaslavs＠redhat.com 24 Jun '12

24 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing task monitoring - run stateless ...................................................................... core: Fixing task monitoring - run stateless The following patch fixes task monitoring for run stateless command. A .It creates a step under EXECUTING to be the parent step of all create snapshots. B. It creates a step for RUNNING the stateless VM, after the snapshots creation succeeded. Change-Id: Ic51b5e60e526a84873014dbc2179ddfb2de1d834 Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 50 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51b5e60e526a84873014dbc2179ddfb2de1d834 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: Introducing a method to get a direct step.
by yzaslavs＠redhat.com 24 Jun '12

24 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: common: Introducing a method to get a direct step. ...................................................................... common: Introducing a method to get a direct step. A direct step is a step that does not have a parent step - It was created directly under a job. Example of usage: We may have a job that has a step for an internal command , which is a child step of its EXECUTING step. Since the step for the internal command invokes a command, a child step of EXECUTING step will be created to represent execution of the internal command. Since a job holds all its job tree, including for sub step, this method ensure that when needed the EXECUTING step that was created directly under the job will be returned (and not the EXECUTING step that was created for the internal command, as explained in the given example) Change-Id: If002b0e5f3036a17921d907811ff6308b18b1330 Acked-by: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If002b0e5f3036a17921d907811ff6308b18b1330 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding some helper methods for Task monitoring
by yzaslavs＠redhat.com 24 Jun '12

24 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding some helper methods for Task monitoring ...................................................................... core: Adding some helper methods for Task monitoring This patch addeds some helper methods for Task monitoring to CommandBase, in order to save some repetitive code when working with Task monitoring infra. Change-Id: I22ab1f3b9bac8a425cdf576a379386d3b8caaefd Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22ab1f3b9bac8a425cdf576a379386d3b8caaefd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding a few CTORs to CommandContext
by yzaslavs＠redhat.com 24 Jun '12

24 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding a few CTORs to CommandContext ...................................................................... core: Adding a few CTORs to CommandContext In order to fix some task monitoring issue it is required to create a CommandContext that takes both compensation and execution context from the parent command. I also introduced another CTOR for taking the contexts and the lock as parameter to provide complete flexability for command context creation Change-Id: Ib958c575208aa14eb497194a8e7d10f8bcaeedb4 Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib958c575208aa14eb497194a8e7d10f8bcaeedb4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: core: Close store file after use
by dfediuck＠redhat.com 24 Jun '12

24 Jun '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Close store file after use ...................................................................... core: Close store file after use We need to close the keystore file after using it, otherwise we will have a file descriptor leak. Change-Id: I3b0546374668113de4b50871e0fdd985740e04cf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a02822fd6e6c9a8e035242d543835c795494a8fe) --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified Doron Fediuck: Looks good to me, approved Ofer Schreiber: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b0546374668113de4b50871e0fdd985740e04cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Robert Middleswarth <robert(a)middleswarth.net>

1 0

Change in ovirt-engine-cli[master]: build: Fix build issue on centos 6.2
by mpastern＠redhat.com 24 Jun '12

24 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: build: Fix build issue on centos 6.2 ...................................................................... build: Fix build issue on centos 6.2 On centos 6.2 using git 1.7.1, the argument '-c' doesn't exist. Here, it uses 'git config' to set tar.umask instead of the argument. Change-Id: I85b1030423fa0e070fcd74a3fe76ab51064b6c33 Signed-off-by: jarod.w <work.iec23801(a)gmail.com> --- M Makefile 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85b1030423fa0e070fcd74a3fe76ab51064b6c33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Jarod.w <work.iec23801(a)gmail.com> Gerrit-Reviewer: Jarod.w <work.iec23801(a)gmail.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: 'cli: refactor auto-completion to support 3+ deep collection...
by mpastern＠redhat.com 24 Jun '12

24 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: 'cli: refactor auto-completion to support 3+ deep collections/resources' ...................................................................... 'cli: refactor auto-completion to support 3+ deep collections/resources' Change-Id: Ie2854495cd72e09e7c68f5101470d19529ad28c1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/command.py M src/ovirtcli/shell/cmdshell.py 2 files changed, 23 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2854495cd72e09e7c68f5101470d19529ad28c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: fix broken 2-level context related auto-completion
by mpastern＠redhat.com 24 Jun '12

24 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: fix broken 2-level context related auto-completion ...................................................................... cli: fix broken 2-level context related auto-completion Change-Id: I5376e5a3f89fae89432b155ed92eda1d3e06cf9c Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/cmdshell.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5376e5a3f89fae89432b155ed92eda1d3e06cf9c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: expend nested types as parameters overloads in show/cre...
by mpastern＠redhat.com 24 Jun '12

24 Jun '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: expend nested types as parameters overloads in show/create commands ...................................................................... cli: expend nested types as parameters overloads in show/create commands Change-Id: Ica6840dd529cbcfd63d3a2b560f0a027068b66c0 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/createcmdshell.py M src/ovirtcli/shell/showcmdshell.py 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica6840dd529cbcfd63d3a2b560f0a027068b66c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0