- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Adding brick order to Gluster volume bricks
by ofrenkel＠redhat.com 11 Jun '12

11 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Adding brick order to Gluster volume bricks ...................................................................... engine: Adding brick order to Gluster volume bricks Introduced the brick order field in GlusterBrickEntity and in gluster_volume_bricks table. Add / update the brick order. Update the volume type and replica/stripe count while adding/removing bricks. Change-Id: I6bce4cf0b75c49b4ab20494c48a012b0bd3d55f6 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql A backend/manager/dbscripts/upgrade/03_01_1170_add_volume_brick_order_column.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 12 files changed, 204 insertions(+), 39 deletions(-) Approvals: Selvasundaram: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bce4cf0b75c49b4ab20494c48a012b0bd3d55f6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disable global transaction at InitVdsOnUp
by mkublin＠redhat.com 11 Jun '12

11 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Disable global transaction at InitVdsOnUp ...................................................................... core: Disable global transaction at InitVdsOnUp We don't need to open transaction during InitVdsOnUp, all internal commands are called with out or inside own transaction. Change-Id: I0841a171512a8529315076f1bdd676d25b88b7f0 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0841a171512a8529315076f1bdd676d25b88b7f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: vds Error handling in gluster vdc commands.
by ofrenkel＠redhat.com 11 Jun '12

11 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: vds Error handling in gluster vdc commands. ...................................................................... engine: vds Error handling in gluster vdc commands. - Fix for the vds error handling in gluster vdc command. https://bugzilla.redhat.com/826458 Change-Id: Iec802defb06eb0581b331b4f075356059ef99d24 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/SetGlusterVolumeOptionVDSCommand.java 13 files changed, 42 insertions(+), 18 deletions(-) Approvals: Selvasundaram: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec802defb06eb0581b331b4f075356059ef99d24 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: canDoAction for No up server found validation added ...
by ofrenkel＠redhat.com 11 Jun '12

11 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: canDoAction for No up server found validation added in Remove vds ...................................................................... engine: canDoAction for No up server found validation added in Remove vds Added missing no up server found validation in Remove vds command. Change-Id: I314f21c0b238a230c5bfda013a44688121b10570 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 2 files changed, 39 insertions(+), 4 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/5114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I314f21c0b238a230c5bfda013a44688121b10570 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Event map for Gluster related events
by ofrenkel＠redhat.com 11 Jun '12

11 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Event map for Gluster related events ...................................................................... engine: Event map for Gluster related events - New upgrade script to add entries in event_map table - Added missing event notification entries in VdcEventNotificationUtils Change-Id: Ia92b179b830e2c3c82f3f494994ea254677e5061 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1210_gluster_event_map.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/4925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia92b179b830e2c3c82f3f494994ea254677e5061 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixed validation for gluster peer detach
by ofrenkel＠redhat.com 11 Jun '12

11 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Fixed validation for gluster peer detach ...................................................................... engine: Fixed validation for gluster peer detach The gluster peer detach should not be performed if the host being removed is the only one left in the cluster. This was being checked by comparing number of hosts across all clusters, whereas correct way is to check number of hosts in current cluster. Fixed the same. Change-Id: Id60b4f3387665f69e97fd9c0774fa3f5aa9a0004 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/4953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id60b4f3387665f69e97fd9c0774fa3f5aa9a0004 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add Single Level Snapshot Tests
by oliel＠redhat.com 11 Jun '12

11 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Add Single Level Snapshot Tests ...................................................................... restapi: Add Single Level Snapshot Tests Change-Id: Ie15da12a7e7c075427e774b0db730313fb9f622f Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java 10 files changed, 186 insertions(+), 234 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie15da12a7e7c075427e774b0db730313fb9f622f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: New query 'GetAllStorageDomains' to get all storage do...
by asaf＠redhat.com 11 Jun '12

11 Jun '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: New query 'GetAllStorageDomains' to get all storage domains (#783087) ...................................................................... core: New query 'GetAllStorageDomains' to get all storage domains (#783087) https://bugzilla.redhat.com/783087 Introducing a new query 'GetAllStorageDomains', used to retrieve all storage domains. This query has permission filtering support, used to retrieve only the storage domains that the user is allowed to read. Change-Id: I8c7029027849515480759b5690a379e5362b7f6b Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/dbscripts/storages_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllStorageDomainsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 7 files changed, 89 insertions(+), 3 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c7029027849515480759b5690a379e5362b7f6b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Public template allows all users access to power...
by gchaplik＠redhat.com 11 Jun '12

11 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Public template allows all users access to poweruser portal ...................................................................... userportal: Public template allows all users access to poweruser portal Solved by ignoring all permissiong, which are both: role: UserTemplateBasedVM user: Everyone This expands the set of ignored permissions comparing to the check before which ignored only the "blank" template. Change-Id: I6cd1892246d10f6cc18832f79e57089272cb4d46 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 1 file changed, 12 insertions(+), 19 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cd1892246d10f6cc18832f79e57089272cb4d46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Import of an existing template show two dialogs
by gchaplik＠redhat.com 11 Jun '12

11 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Import of an existing template show two dialogs ...................................................................... webadmin: Import of an existing template show two dialogs When importing a template that already exists on the data domain, GUI first shows this: "Import process has begun for Template(s): . You can check import status in the 'Events' tab of the specific destination storage domain, or in the main 'Events' tab" Then this: "Import Template failed - Template Id already exist in the system. Only the 2nd message should be shown to the user. This bug is closly related to the already fixed: http://gerrit.ovirt.org/#/c/1064 and it is fixed in the same way. In the future it should be generalized to a common parent class. Change-Id: I36c86320893abeb097e76db7aa444921c203e100 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java 1 file changed, 21 insertions(+), 15 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c86320893abeb097e76db7aa444921c203e100 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0