- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: edit cluster policy doesn't open
by gchaplik＠redhat.com 13 May '12

13 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: edit cluster policy doesn't open ...................................................................... webadmin: edit cluster policy doesn't open Change-Id: If818f056c1537ab6e01c57815116a2866c54ee2c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/cluster/ClusterPolicyPopupPresenterWidget.java 1 file changed, 1 insertion(+), 11 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If818f056c1537ab6e01c57815116a2866c54ee2c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: import VM, SD dropdown empty
by gchaplik＠redhat.com 13 May '12

13 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: import VM, SD dropdown empty ...................................................................... webadmin: import VM, SD dropdown empty for multiple VM the SD is empty, so the flow is stuck Change-Id: I236cecfc2c0462cdc94f301351043516bf1f0f24 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I236cecfc2c0462cdc94f301351043516bf1f0f24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-dwh[master]: etl: added vm_device history table.
by ydary＠redhat.com 13 May '12

13 May '12

Yaniv Dary has submitted this change and it was merged. Change subject: etl: added vm_device history table. ...................................................................... etl: added vm_device history table. Change-Id: I68014b1729db7c7bbaa9572eaa04becdfa2239dc Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_dwh/configurationsync_3_0/ConfigurationSync.java M data-warehouse/history_etl/tos_project/configuration/ExpressionBuilder/ConfigurationSync.xml M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.0.item M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.0.properties M data-warehouse/history_etl/tos_project/talend.project M data-warehouse/historydbscripts_postgres/create_views.sql A data-warehouse/historydbscripts_postgres/upgrade/03_00_0120_added_vm_device_table.sql 7 files changed, 8,194 insertions(+), 1,739 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68014b1729db7c7bbaa9572eaa04becdfa2239dc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: updated vm disk tables
by ydary＠redhat.com 13 May '12

13 May '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: updated vm disk tables ...................................................................... history: updated vm disk tables API now includes: - floating disks - vm disk name - shared disk cloumn Change-Id: I6c354b534d639fd3f492339a969d4714f3fe82df Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_dwh/aggregationtodaily_3_0/AggregationToDaily.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_dwh/aggregationtohourly_3_0/AggregationToHourly.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_dwh/configurationsync_3_0/ConfigurationSync.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_dwh/statisticssync_3_0/StatisticsSync.java M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.0.item M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.0.properties M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.0.item M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.0.properties M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.0.item M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.0.properties M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.0.item M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.0.properties M data-warehouse/history_etl/tos_project/talend.project M data-warehouse/historydbscripts_postgres/create_views.sql A data-warehouse/historydbscripts_postgres/upgrade/03_00_0110_added_vm_disks_config.sql 15 files changed, 1,661 insertions(+), 860 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c354b534d639fd3f492339a969d4714f3fe82df Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: history: added vm_device dwh view
by emesika＠redhat.com 13 May '12

13 May '12

Eli Mesika has submitted this change and it was merged. Change subject: history: added vm_device dwh view ...................................................................... history: added vm_device dwh view Change-Id: I0b2602041570a3b4b5dcd1e1e486327597968fac Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/create_dwh_views.sql M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1070_add_create_update_dates_to_vm_device.sql M backend/manager/dbscripts/vm_device_sp.sql 4 files changed, 46 insertions(+), 13 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b2602041570a3b4b5dcd1e1e486327597968fac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: history: updated vm disk dwh views
by emesika＠redhat.com 13 May '12

13 May '12

Eli Mesika has submitted this change and it was merged. Change subject: history: updated vm disk dwh views ...................................................................... history: updated vm disk dwh views Views now include: - floating disks - vm disk name - shared disk cloumn Change-Id: Ie0d367a01553ae6cd7497843d2a8792f15a64559 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/create_dwh_views.sql 1 file changed, 18 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d367a01553ae6cd7497843d2a8792f15a64559 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Edit Network dialog fixes (#821021)
by vszocs＠redhat.com 11 May '12

11 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Edit Network dialog fixes (#821021) ...................................................................... webadmin: Edit Network dialog fixes (#821021) https://bugzilla.redhat.com/821021 This bugfix patch includes: - DataCenterNetworkListModel.Edit() now uses null instead of empty string for undefined MTU value, this avoids NumberFormatException when DataCenterNetworkListModel tries to parse this (non-null) value later on - DataCenterNetwork presenter widget now enables/disables dialog input fields properly, in reaction to dialog model (DataCenterNetworkModel) "IsEnabled" property changes - Fixed "Detach all clusters" button failing due to corresponding UICommand being null (this command is set after setWindow() happens and therefore needs to be referenced through its model directly) Change-Id: I5b73073200159141b4b159db83c37ffc4daa33d1 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterNetworkPopupView.java 3 files changed, 14 insertions(+), 14 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b73073200159141b4b159db83c37ffc4daa33d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: remember domain selection (#810484)
by vszocs＠redhat.com 11 May '12

11 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: remember domain selection (#810484) ...................................................................... userportal: remember domain selection (#810484) https://bugzilla.redhat.com/810484 Every time a user opens up User Portal, the same domain is pre-selected. Fixed by remembering the selected domain after successful login in a local storage/cookie (depending on the browser support). Change-Id: Ieba0efb9530707e3ff71118b686ffe089ec66296 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginPopupPresenterWidget.java 4 files changed, 63 insertions(+), 6 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieba0efb9530707e3ff71118b686ffe089ec66296 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: clone VM create VM with wrong permissions(#80977...
by vszocs＠redhat.com 11 May '12

11 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: clone VM create VM with wrong permissions(#809778) ...................................................................... userportal: clone VM create VM with wrong permissions(#809778) https://bugzilla.redhat.com/809778 Extended->Virtual Machines->select one->Snapshots->select one->clone It created a new VM but invisible for the user which created it. The problem was in VmSnapshotListModel.OnCloneVM() which did not mark the creator to be the explicit owner (AddVmFromSnapshotParameters.setMakeCreatorExplicitOwner()) Solved by creating a snapshot model specially for user portal (UserPortalVmSnapshotListModel) which sets this flag to true. Change-Id: I25aa6e78a4c6d7d516a97a910e5d57e4a0447341 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTree.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalVmSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/extended/vm/SubTabExtendedVmSnapshotPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/vm/SubTabExtendedVmSnapshotView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmSnapshotListModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineSnapshotView.java 8 files changed, 41 insertions(+), 19 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25aa6e78a4c6d7d516a97a910e5d57e4a0447341 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Reports localization + report bug fixs
by gchaplik＠redhat.com 11 May '12

11 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Reports localization + report bug fixs ...................................................................... webadmin: Reports localization + report bug fixs no bz 1. Adding REPORT_LOCALE parameter to the reports url. 2. Fixing a bug- after logout->login the reports stoped working. The reason was the reports resovle command in ReportsActionHelper used the old model (the model before the logout). Need to pass the model provider and to get from it the new model. Change-Id: I7073704a06f61c7ada0373eb27e0cf778ec0a031 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/reports/ReportsListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractMainTabTableView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/ReportActionsHelper.java 9 files changed, 24 insertions(+), 10 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7073704a06f61c7ada0373eb27e0cf778ec0a031 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0