- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: packaging: pythonlib: service: Add time zone to log records
by Code Review 07 Feb '17

07 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: pythonlib: service: Add time zone to log records ...................................................................... packaging: pythonlib: service: Add time zone to log records Adds time zone to log records for all python services in engine, like ovirt-fence-kdump-listener and ovirt-websocket-proxy. Sample output: 2017-01-17 13:44:23,135+0100 ovirt-websocket-proxy: INFO msg:871 - Listen on *:6100 2017-01-17 13:44:23,135+0100 ovirt-websocket-proxy: INFO msg:871 - Flash security policy server 2017-01-17 13:44:23,136+0100 ovirt-websocket-proxy: INFO msg:871 - SSL/TLS support 2017-01-17 13:44:23,136+0100 ovirt-websocket-proxy: INFO msg:871 - Deny non-SSL/TLS connections 2017-01-17 13:44:23,137+0100 ovirt-websocket-proxy: INFO msg:871 - proxying from *:6100 to targets generated by str Change-Id: Icbac46cf8e8062179dc389df2cb9eb448beb8646 Bug-Url: https://bugzilla.redhat.com/1408193 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in M packaging/pythonlib/ovirt_engine/service.py 2 files changed, 23 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbac46cf8e8062179dc389df2cb9eb448beb8646 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-hosted-engine-setup: drop fc23
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-hosted-engine-setup: drop fc23 ...................................................................... ovirt-hosted-engine-setup: drop fc23 fc23 is EOL Change-Id: I1aea06ed31136fd5ae29c44f0327e268a614d4c4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup_standard.yaml 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aea06ed31136fd5ae29c44f0327e268a614d4c4 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-hosted-engine-ha: drop fc23
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-hosted-engine-ha: drop fc23 ...................................................................... ovirt-hosted-engine-ha: drop fc23 fc23 is EOL Change-Id: Id0ebff1944893d5b6099b458b93c1dc59780c99e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_standard.yaml 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0ebff1944893d5b6099b458b93c1dc59780c99e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-log-collector: drop fc23
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-log-collector: drop fc23 ...................................................................... ovirt-log-collector: drop fc23 fc23 is EOL Change-Id: I9bc60ba261407b7427cdf1b67ee98ea99ecd76bd Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_standard.yaml 2 files changed, 0 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bc60ba261407b7427cdf1b67ee98ea99ecd76bd Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: nsis-simple-service-plugin: drop fc23
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: nsis-simple-service-plugin: drop fc23 ...................................................................... nsis-simple-service-plugin: drop fc23 fc23 is EOL. Change-Id: I37e40786e68ddc73f71b5826ae172e776673b3b7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/nsis-simple-service-plugin/nsis-simple-service-plugin.yaml 1 file changed, 0 insertions(+), 17 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37e40786e68ddc73f71b5826ae172e776673b3b7 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: OvfManagerTest map
by Code Review 07 Feb '17

07 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfManagerTest map ...................................................................... core: OvfManagerTest map Use a local HashMap and put values in it instead of anonymously extending the HashMap and bloating up the class cache. Change-Id: Id9e4f2fad13c9e880308c9647d35e089699526fa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/71796 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9e4f2fad13c9e880308c9647d35e089699526fa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix OvfManagerTest
by Code Review 07 Feb '17

07 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix OvfManagerTest ...................................................................... core: Fix OvfManagerTest @Mock/@Spy annotations do not guarantee any order between them, making this test inherently racy - if iconDefaultsProvider is initialized first, it will be available when manager is initialized. If manager is initialized first, it's will have a null iconDefaultsProvider, causing some tests to fail. Since the OsRepository and OvfVmIconDefaultsProvider mocks are read only anyway, they should be static and initialized ONCE per test case instead of before every test in such a racy fashion. As a nice side effect, this will slightly improve the test's runtime. Change-Id: I5f547092e7934dd73bf2039e9ff08822b95c7fa9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 1 file changed, 13 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/71795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f547092e7934dd73bf2039e9ff08822b95c7fa9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: aaa-ldap: Switch to standard CI builds
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: aaa-ldap: Switch to standard CI builds ...................................................................... aaa-ldap: Switch to standard CI builds Change-Id: I9ce9dbb9895313a349721405537e6ae527c8b082 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- D jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml A jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 6 files changed, 51 insertions(+), 102 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ce9dbb9895313a349721405537e6ae527c8b082 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: optimize validation in create vm
by Code Review 07 Feb '17

07 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: optimize validation in create vm ...................................................................... core: optimize validation in create vm The validation of whether or not the VM is already being initialized is done by using Set#contains of ResourceManager#asyncRunningVms. This patch replaces this with a check of the returned value of Set#add. Change-Id: I60adf9e50c5b74ad43d6cefdbf534e39e6e3da4f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java 1 file changed, 31 insertions(+), 38 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60adf9e50c5b74ad43d6cefdbf534e39e6e3da4f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Automatically generate 'version.py'
by Code Review 07 Feb '17

07 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Automatically generate 'version.py' ...................................................................... Automatically generate 'version.py' Currently the 'version.py' file is updated manually with each release of the project, and it needs to be in sync with the version specified in the POM files. To avoid that this patch changes the SDK so that the 'version.py' file is atumatically generated, taking the version number from the root POM file. Change-Id: Ib9d5dce6b48c2e6c1a3dcc43fa17204c88096632 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M .gitignore M generator/src/main/java/org/ovirt/sdk/python/PythonBuffer.java M generator/src/main/java/org/ovirt/sdk/python/PythonNames.java M generator/src/main/java/org/ovirt/sdk/python/Tool.java A generator/src/main/java/org/ovirt/sdk/python/VersionGenerator.java D sdk/lib/ovirtsdk4/version.py M sdk/pom.xml M sdk/setup.py 8 files changed, 150 insertions(+), 37 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9d5dce6b48c2e6c1a3dcc43fa17204c88096632 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0