- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AttachNetworkToClusterInternalCommand type inference
by Code Review 06 Feb '17

06 Feb '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: AttachNetworkToClusterInternalCommand type inference ...................................................................... core: AttachNetworkToClusterInternalCommand type inference Change-Id: I587b56f2e0015ea8cd0bd114b042052c4bf7c5dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToClusterInternalCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71689 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I587b56f2e0015ea8cd0bd114b042052c4bf7c5dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix default verify grade value
by Code Review 06 Feb '17

06 Feb '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Fix default verify grade value ...................................................................... Fix default verify grade value Change-Id: Id2a90e77782299151dad189850cd3197d817fa33 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_target_milestone 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a90e77782299151dad189850cd3197d817fa33 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: USB autoshare conditionally disabled
by Code Review 06 Feb '17

06 Feb '17

>From Martin Betak <mbetak(a)redhat.com>: Martin Betak has submitted this change and it was merged. Change subject: webadmin: USB autoshare conditionally disabled ...................................................................... webadmin: USB autoshare conditionally disabled Widget Console options dialog > SPICE Options group > Enable USB autoshare is enabled only when USB support (~ spice usb redirection) is enabled. Change-Id: Ic13f0e0f6be444c38ac134aaaf224f6bd3fe7139 Bug-Url: https://bugzilla.redhat.com/1369175 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 4 files changed, 20 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic13f0e0f6be444c38ac134aaaf224f6bd3fe7139 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vcredist-x86: remove fc23
by Code Review 06 Feb '17

06 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: vcredist-x86: remove fc23 ...................................................................... vcredist-x86: remove fc23 fc23 is EOL. Side effect is that 3.6 and 4.0 builds has to be dropped being fc23 the only fedora version supported there. Change-Id: I0068920df0a90c0ac8a7ad2a339e3a74dbad65df Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/vcredist-x86/vcredist-x86.yaml 1 file changed, 0 insertions(+), 30 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0068920df0a90c0ac8a7ad2a339e3a74dbad65df Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-image-uploader: drop fc23
by Code Review 06 Feb '17

06 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-image-uploader: drop fc23 ...................................................................... ovirt-image-uploader: drop fc23 fc23 is EOL Change-Id: Id3701ef0b0a2dee7e7f9e15baef538fd6398f39e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-image-uploader/ovirt-image-uploader_standard.yaml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71635 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3701ef0b0a2dee7e7f9e15baef538fd6398f39e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: update actions availability of VMs list with "excl...
by Code Review 06 Feb '17

06 Feb '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: update actions availability of VMs list with "exclusive" lock ...................................................................... webadmin: update actions availability of VMs list with "exclusive" lock Updating webAdmin actions availability of VMs in VmListModel to treat a VM in an "exclusive" memory lock and in "Down" status as if it is in an "ImageLocked" DB status and therefore block relevant actions for it. This is implemented by adding a new entity for overriding the getStatus() method of the VM entity, used only by VmListModel. This fix the problem that till now VMs in an "ImageLocked" status were checked and relevant actions were blocked for them in Webadmin as required, but VMs in an "exclusive" memory lock status were treated as if they are in "Down"/"Up"/Maintenance" etc status so evethough they were in the middle of a process like importing, relevant actions were not blocked for them as required. Change-Id: I51776fba35828589604ca44374a7574e91b4a20c Bug-Url: https://bugzilla.redhat.com/1364137 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmWithStatusForExclusiveLock.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 57 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/71473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51776fba35828589604ca44374a7574e91b4a20c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: image-ng: added 4.1 and master on fc24
by Code Review 06 Feb '17

06 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: image-ng: added 4.1 and master on fc24 ...................................................................... image-ng: added 4.1 and master on fc24 Change-Id: I4311d5a02d0c18c8aaee960ac8fa86fcb24323e5 Signed-off-by: Yuval Turgeman <yturgema(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4311d5a02d0c18c8aaee960ac8fa86fcb24323e5 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: catch exception coming from the OpenStack client
by Code Review 06 Feb '17

06 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: catch exception coming from the OpenStack client ...................................................................... core: catch exception coming from the OpenStack client Uncaught OpenStack client exception led to a 500 error when attempting to retrieve images list from Glance (with a bad URL). Since the exception is unchecked we need to make sure we catch it ourselves and provide a proper message. Change-Id: Icbeb669135dfa51333cc1c3874bb387f6812feab Bug-Url: https://bugzilla.redhat.com/1379130 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/GetImagesListQueryBase.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Benny Zlotnik: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71707 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbeb669135dfa51333cc1c3874bb387f6812feab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: setup: let vmconsole proxy be stopped on cleanup
by Code Review 06 Feb '17

06 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: let vmconsole proxy be stopped on cleanup ...................................................................... setup: let vmconsole proxy be stopped on cleanup We must make sure that engine-cleanup actually cleans up the ovirt-vmconsole-proxy. This means stopping the service, if running. Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402 Bug-Url: https://bugzilla.redhat.com/1276670 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py M packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/__init__.py A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/misc.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py 5 files changed, 141 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/71365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmTemplate.actualDiskSize property not cached
by Code Review 06 Feb '17

06 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: VmTemplate.actualDiskSize property not cached ...................................................................... core: VmTemplate.actualDiskSize property not cached The problem with #actualDiskSize field was that it needed to be marked as @EditableVmTemplateField to allow UpdateVmTemplateCommand to be called with new template both with and without `diskImageMap` property set. This annotation was required even-though no disk related changes were actually performed by the UpdateVmTemplateCommand. Related bugs: https://bugzilla.redhat.com/1417597 https://bugzilla.redhat.com/1409579 >From now on VmTemplate.actualDiskSize is a computed property based on `diskImageMap` property. The only code that calls getActualDiskSize() repeatedly is VmTemplateComparerByDiskSize. Cache of `actualDiskSize` values was introduced in this class. Change-Id: Ie2011fa8a63c304c220be7a326c4142d81f7cd34 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java 2 files changed, 20 insertions(+), 17 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2011fa8a63c304c220be7a326c4142d81f7cd34 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0