- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix vNIC profile page for ja_JP locale
by Code Review 25 Nov '16

25 Nov '16

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix vNIC profile page for ja_JP locale ...................................................................... webadmin: Fix vNIC profile page for ja_JP locale Because the Japanese word for the checkbox label "public" consumes more horizontal space than then the English word, the VnicProfileWidget looked distorted a bit as the help button appears on a different line below other items on the page. Since the available horizontal space was allocated already, the margin of the label is squeezed, to avoid a second row for the VnicProfileWidget. Change-Id: I2b423d1d8353d7f72f119f22763a1034d324ab1e Bug-Url: https://bugzilla.redhat.com/1255257 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.ui.xml 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b423d1d8353d7f72f119f22763a1034d324ab1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: Add example that lists VM snapshots
by Code Review 25 Nov '16

25 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example that lists VM snapshots ...................................................................... Add example that lists VM snapshots This patch adds an example that lists all the snapshots that exist in the system, and where the disks are stored. Change-Id: I3141dbdf7c8edec0fb65df59dd2545bcc2a4a2a5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/list_vm_snapshots.py 1 file changed, 93 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Jenkins CI: Passed CI tests Jiri Belka: Verified -- To view, visit https://gerrit.ovirt.org/67286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3141dbdf7c8edec0fb65df59dd2545bcc2a4a2a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jiri Belka <jbelka(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: el7: epel: add python-simplejson
by Code Review 25 Nov '16

25 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: el7: epel: add python-simplejson ...................................................................... el7: epel: add python-simplejson python-simplejson is now a ovirt-engine dependency Change-Id: Id2bb732af9a8502c3140ba3ed6f3820354db2573 --- M ovirt-el7-deps.repo.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2bb732af9a8502c3140ba3ed6f3820354db2573 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: engine-backup: Allow hooks
by Code Review 24 Nov '16

24 Nov '16

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: engine-backup: Allow hooks ...................................................................... packaging: engine-backup: Allow hooks Bug-Url: https://bugzilla.redhat.com/1397409 Change-Id: Ice63783d610694b1836313772175dedda0113cd8 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/67278 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice63783d610694b1836313772175dedda0113cd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Add ovirt-engine-hosts-ansible-inventory
by Code Review 24 Nov '16

24 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Add ovirt-engine-hosts-ansible-inventory ...................................................................... packaging: Add ovirt-engine-hosts-ansible-inventory Change-Id: I62f5c9c67cf83deee35f7b12e2576bb1a520c48a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in A packaging/setup/bin/ovirt-engine-hosts-ansible-inventory 2 files changed, 215 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/66999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62f5c9c67cf83deee35f7b12e2576bb1a520c48a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: master_upgrade_from_master: Upgrade to self instead of snapshot
by Code Review 24 Nov '16

24 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: master_upgrade_from_master: Upgrade to self instead of snapshot ...................................................................... master_upgrade_from_master: Upgrade to self instead of snapshot Change-Id: I63e09056cabd420b93be059183fcc5b22c2ae0e0 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/ovirt-engine_upgrade_to_master/upgrade.sh 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63e09056cabd420b93be059183fcc5b22c2ae0e0 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix bug in LUN target login
by Code Review 24 Nov '16

24 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix bug in LUN target login ...................................................................... webadmin: Fix bug in LUN target login Change-Id: I6a416000ef72a204d6c7953a3da0fb232f29cc85 Bug-Url: https://bugzilla.redhat.com/1394567 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/66600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a416000ef72a204d6c7953a3da0fb232f29cc85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: fedora: add virt-preview repository
by Code Review 24 Nov '16

24 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: fedora: add virt-preview repository ...................................................................... fedora: add virt-preview repository Added virt-preview repository as fedora dependencies provider. Change-Id: I35b707bd091be16ddbd5a16025fe368fc18008f2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1398321 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-f24-deps.repo.in M ovirt-release-master.spec.in 3 files changed, 29 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/67270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35b707bd091be16ddbd5a16025fe368fc18008f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: deploy ovirt-engine-cli 3.6 to 4.0 and master repos as well
by Code Review 24 Nov '16

24 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: deploy ovirt-engine-cli 3.6 to 4.0 and master repos as well ...................................................................... deploy ovirt-engine-cli 3.6 to 4.0 and master repos as well Since we moved to use experimental the cli pkg from 3.6 wasn't published to 4.0/master repos, as we did with the old publishers. Change-Id: I4a2250dde855c6d12e9e44a29ca19aa747d0432c Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-cli/ovirt-engine-cli_build-artifacts.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a2250dde855c6d12e9e44a29ca19aa747d0432c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.6]: webadmin: Fix error in VM pool creation
by Code Review 24 Nov '16

24 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix error in VM pool creation ...................................................................... webadmin: Fix error in VM pool creation Up until patch I6f0f143e9a9109badc6adce4bf6d3ad733f8fada a request to create a thin provisioned VM based on a template with RAW disks would have been succeed while ignoring the RAW value as it doesn't make sense, after this patch this was blocked, aparently creation of a VM pool through webadmin sends the disks with RAW value to the command which was now blocked. Change-Id: Ib712fea26644f3f368e471041db489fccf5416ef Bug-Url: https://bugzilla.redhat.com/1397866 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/67266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib712fea26644f3f368e471041db489fccf5416ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0