- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: adding VdsmImagePoller
by Code Review 21 Nov '16

21 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: adding VdsmImagePoller ...................................................................... core: adding VdsmImagePoller This patch adds the VdsmImagePoller class. The poller is supposed to be used to determine the status of ongoing vdsm job on vdsm image when the job polling isn't possible. The poller uses the following logic: 1. The volume lease isn't FREE - the operation is running 2. The lease is free and the volume status is ILLEGAL - the operation has failed. 3. The lease is free, the volume status is OK and the generation was incremented - the operation has succeded. Any other case means that the job status couldn't have been determined using entity polling. Change-Id: Ibf3f4d27ece12b2d855cdf3c1f5a563019aa94cc Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/VdsmImagePoller.java 1 file changed, 56 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/66848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf3f4d27ece12b2d855cdf3c1f5a563019aa94cc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyDataCommand - use entity polling
by Code Review 21 Nov '16

21 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: CopyDataCommand - use entity polling ...................................................................... core: CopyDataCommand - use entity polling This patch adds use of entity polling in the CopyData command by making the following changes: 1. Pass the currnet volume generation when executing the copyData vdsm verb. 2. Implement the EntityPollingCommand interface. 3. Using VdsmImagePoller in order to poll the entity when needed. Change-Id: Ib4dbeb311120bba31361e5ae83963bec983febd1 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java 1 file changed, 36 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/66849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4dbeb311120bba31361e5ae83963bec983febd1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroupCommand - SPDM flow usage
by Code Review 21 Nov '16

21 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupCommand - SPDM flow usage ...................................................................... core: CopyImageGroupCommand - SPDM flow usage This patch changes CopyImageGroupCommand to use the newly added SPDM flow on the move disk flow and when collapse isn't used (as it not yet supported on the vdsm verb). Change-Id: Ib6950b587c6c2651a8345ce15fd34071d1c80328 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/67076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6950b587c6c2651a8345ce15fd34071d1c80328 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCallback - log before attempting to poll the...
by Code Review 21 Nov '16

21 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCallback - log before attempting to poll the entity ...................................................................... core: StorageJobCallback - log before attempting to poll the entity Change-Id: I052507bc0f0b955b0d29978bfa50bfaf1555e7a5 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/66846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I052507bc0f0b955b0d29978bfa50bfaf1555e7a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsmImageLocationInfo - adding the generation field
by Code Review 21 Nov '16

21 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: VdsmImageLocationInfo - adding the generation field ...................................................................... core: VdsmImageLocationInfo - adding the generation field Change-Id: If6bc7bda6250117d3c4c3b04f5e36e4f4d207fd4 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsmImageLocationInfo.java 3 files changed, 15 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/66847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6bc7bda6250117d3c4c3b04f5e36e4f4d207fd4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Implement Disk.sparsify REST API action
by Code Review 21 Nov '16

21 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Implement Disk.sparsify REST API action ...................................................................... restapi: Implement Disk.sparsify REST API action Implement sparsify REST API action on Disk resource that invokes SparsifyImageCommand on the disk. SparsifyImageCommand removes unused space from a disk image. Change-Id: Ibbad10f299a506f2829bc0fbb1ece280bb02e612 Bug-Url: https://bugzilla.redhat.com/734120 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/67023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbad10f299a506f2829bc0fbb1ece280bb02e612 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: don't publish ppc64le rpms to experimental
by Code Review 20 Nov '16

20 Nov '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: don't publish ppc64le rpms to experimental ...................................................................... don't publish ppc64le rpms to experimental We have an issue that fails experimental because both ppc64le and x86_64 are building noarch pkg and if one is deployed with a higher version before the other, add host will fail. This isn't optimal, but will have to do until we find a permenant solution (maybe deploying PPC64LE to a whole different directory tree) Change-Id: I8b8aca70f4f18ffecfa771d96966a3748e083236 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml M jobs/confs/yaml/templates/standard-stage.yaml 2 files changed, 13 insertions(+), 5 deletions(-) Approvals: Eyal Edri: Ready for merge Gil Shinar: Verified; Looks good to me; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/67068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8aca70f4f18ffecfa771d96966a3748e083236 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: entity progress report for commands with async tasks
by Code Review 20 Nov '16

20 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: entity progress report for commands with async tasks ...................................................................... core: entity progress report for commands with async tasks This patch adds support to progress report for commands creating async tasks by persist the command's StepSubjectEntity list when creating the task step. Change-Id: Ifaff1fb4027b2458deb423a274b2a9b3a5ee3a6f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaff1fb4027b2458deb423a274b2a9b3a5ee3a6f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: enable entity progress support for all steps
by Code Review 20 Nov '16

20 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: enable entity progress support for all steps ...................................................................... core: enable entity progress support for all steps Currently entity progress report is supported for commands that add a step by overriding getCommandStep() and getCommandStepSubjectEntities(). On flows adding steps using different infrastructures (like async task manager based flows) it may be required to report progress on the entities as well. The progress on the entity is a sum of the progress*entity weight for all the steps "related" to the entity (we currently use that on jobs that modifies an entity exclusively). Therefore In order to support entity progress report for all the steps, we need a progress for each of them and to support for adding the step subject entities. This patch includes the following changes: 1. Add support to include StepSubjectEntity list when adding any step. 2. Move the StepSubjectEntity handling to the JobRepository in order to reuse the code by all the callers. 3. Adding the step_progress view so that steps without progress report will be considered with progress of 100 when they are finished. 4. Update to the entity_step_progress accordingly. Change-Id: I1511291b18dbbb6e11f715a9a1e203c839cbaffa Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepository.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/JobRepositoryImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/job/JobRepositoryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepSubjectEntity.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql 12 files changed, 129 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1511291b18dbbb6e11f715a9a1e203c839cbaffa Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move/Copy disk flow - weight infra and usage
by Code Review 20 Nov '16

20 Nov '16

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: Move/Copy disk flow - weight infra and usage ...................................................................... core: Move/Copy disk flow - weight infra and usage When command is executed and defines a Job, its initial job weight is 100. If that command is executing child commands, it can split the job weight between them to represent the part of each command in the job. This patch adds the infra to calculate and pass the weight of executed child commands and makes use of that infra in the move/copy disk SDM flow. In order to avoid handling double values, we use integer for the weight of each commands - CommandsWeightsHelper.adjust() can be used in order to round and split the weight of the child commands according to the provided total weight. Change-Id: I5414609a17fd06dbc73591487e34619316e71ddb Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/CommandsWeightsUtils.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/CommandsWeightsUtilsTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java 12 files changed, 233 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5414609a17fd06dbc73591487e34619316e71ddb Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0