- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Set hibernation disks description correctly
by Code Review 29 Aug '17

29 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/81154 ) Change subject: core: Set hibernation disks description correctly ...................................................................... core: Set hibernation disks description correctly Change-Id: Ie8c82c0ac989e1a563828b6f0586f1d2799db63d Bug-Url: https://bugzilla.redhat.com/1483584 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryUtils.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8c82c0ac989e1a563828b6f0586f1d2799db63d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Improve SQL query for vms pinned
by Code Review 29 Aug '17

29 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/81138 ) Change subject: inventory: Improve SQL query for vms pinned ...................................................................... inventory: Improve SQL query for vms pinned The column dedicated_vm_for_vd from vm_static can contain a single hypervisor entry or multiple hypervisors (using delimiter comma). Based on that, we are extacting the hypervisors in the WITH statement and using it in the INNER JOIN. Change-Id: Ic6c00c794962687e886f0ab3aef11557965da21b Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/vms_query_pinned_virtual_machines.sql 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6c00c794962687e886f0ab3aef11557965da21b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: versioned option SpiceSecureChannels
by Code Review 29 Aug '17

29 Aug '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/81153 ) Change subject: core: versioned option SpiceSecureChannels ...................................................................... core: versioned option SpiceSecureChannels Replaced usage of general value for SpiceSecureChannels option with versioned one. Change-Id: I9310907089be269d9438128b460b86af7dbe5a6e Signed-off-by: Miroslava Voglova <mvoglova(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Miroslava Voglova: Verified Tomas Jelinek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/81153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9310907089be269d9438128b460b86af7dbe5a6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Miroslava Voglova <mvoglova(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Miroslava Voglova <mvoglova(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ManageNetworkClustersParameters type inference
by Code Review 29 Aug '17

29 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/81139 ) Change subject: core: ManageNetworkClustersParameters type inference ...................................................................... core: ManageNetworkClustersParameters type inference Change-Id: If30182b78b5673489caa38560eb7c2b5b44d11bc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/81139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If30182b78b5673489caa38560eb7c2b5b44d11bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: vdsbroker: Add Host.getLldp
by Code Review 29 Aug '17

29 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80507 ) Change subject: vdsbroker: Add Host.getLldp ...................................................................... vdsbroker: Add Host.getLldp The VDSM API is going to be extended by the new command Host.getLldp. The vdsbroker is extended to use this new command. Bug-Url: https://bugzilla.redhat.com/147967 Change-Id: I247f15a6c3333876067779bfe1078a594147ac4c Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit a8bdc9c440b2f5ba039e31d244186b518aad1143) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LldpReturn.java 3 files changed, 34 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247f15a6c3333876067779bfe1078a594147ac4c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: vdsbroker: Add GetLldpVDSCommand
by Code Review 29 Aug '17

29 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80508 ) Change subject: vdsbroker: Add GetLldpVDSCommand ...................................................................... vdsbroker: Add GetLldpVDSCommand The GetLldpVDSCommand is added to get the LLDP information as business entities from vdsbroker. Bug-Url: https://bugzilla.redhat.com/147967 Change-Id: Ic1cea600587137fbec582af0e7b1043b27bc6968 Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit 41a35c8476fa93d22bb15181f220cf62d4496bc6) --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetLldpVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetLldpVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 97 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1cea600587137fbec582af0e7b1043b27bc6968 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Add GetTlvsByHostNicIdQuery
by Code Review 29 Aug '17

29 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80509 ) Change subject: core: Add GetTlvsByHostNicIdQuery ...................................................................... core: Add GetTlvsByHostNicIdQuery The added GetTlvsByHostNicIdQuery utilizes the GetLldpVDSCommand directly to get the LLDP information from a host. Bug-Url: https://bugzilla.redhat.com/1479677 Change-Id: I130ca73f4ffdc6668bc4a4bd979ca4f488be8c7f Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit b21387151645b6ea7c699c169f7a67d9accde67b) --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetTlvsByHostNicIdQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetTlvsByHostNicIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 232 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I130ca73f4ffdc6668bc4a4bd979ca4f488be8c7f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restapi: Add LLDP
by Code Review 29 Aug '17

29 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80511 ) Change subject: restapi: Add LLDP ...................................................................... restapi: Add LLDP The Link Layer Discovery Protocol (LLDP) is a vendor-neutral networking protocol, used by network devices, especially switches, for advertising their identity, capabilities and management addresses on an IEEE 802 local area network (LAN). The restapi provides information received by LLDP on a host NIC. Bug-Url: https://bugzilla.redhat.com/1479677 Change-Id: I1dddb3b15c346a95fc69e2fd727035edb2f8ea1c Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit 2b6ccfd80421bca86af2328560d5db337c4be4ad) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendLinkLayerDiscoveryProtocolResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendLinkLayerDiscoveryProtocolResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/LinkLayerDiscoveryProtocolElementMapper.java 5 files changed, 213 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dddb3b15c346a95fc69e2fd727035edb2f8ea1c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: net: Add entities for LLDP
by Code Review 29 Aug '17

29 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80506 ) Change subject: net: Add entities for LLDP ...................................................................... net: Add entities for LLDP The Link Layer Discovery Protocol (LLDP) is a vendor-neutral networking protocol, used by network devices, especially switches, for advertising their identity, capabilities and management addresses on an IEEE 802 local area network (LAN). The added entities prepare oVirt hosts to gather information from their networking interfaces and let oVirt Engine use this information in a beneficial way. Bug-Url: https://bugzilla.redhat.com/1479677 Change-Id: Ib15ce5ef41218877eb074cd56ee3ca4ada667f26 Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit 8c40a8261a4149180c123c71fba3c40fdcecfa1e) --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/LldpInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Tlv.java 2 files changed, 204 insertions(+), 0 deletions(-) Approvals: Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib15ce5ef41218877eb074cd56ee3ca4ada667f26 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: disable s3/s4
by Code Review 29 Aug '17

29 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80969 ) Change subject: core: disable s3/s4 ...................................................................... core: disable s3/s4 Set: <pm> <suspend-to-disk enabled='no'/> <suspend-to-mem enabled='no'/> </pm> In the engine XML to disable guest-level suspension/hibernation. Change-Id: I60bedc9890c903ae4d13ecf3efd6d50eacefb6c8 Bug-Url: https://bugzilla.redhat.com/1437512 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Michal Skrivanek: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60bedc9890c903ae4d13ecf3efd6d50eacefb6c8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0