- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add example showing how to list system roles
by Code Review 07 Nov '16

07 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example showing how to list system roles ...................................................................... Add example showing how to list system roles This patch adds an example that shows how list all the roles available in the system. Change-Id: I6790b386f4af5f7b1aa303ab88da78ca49d95d08 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit b22c470bdf6a61106b0273ba33c0c134ccc046e0) --- A sdk/examples/list_roles.rb 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6790b386f4af5f7b1aa303ab88da78ca49d95d08 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example showing how to list system roles
by Code Review 07 Nov '16

07 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example showing how to list system roles ...................................................................... Add example showing how to list system roles This patch adds an example that shows how list all the roles available in the system. Change-Id: I6790b386f4af5f7b1aa303ab88da78ca49d95d08 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/list_roles.rb 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6790b386f4af5f7b1aa303ab88da78ca49d95d08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BackendClusterNetworksResource#getNetworks params
by Code Review 07 Nov '16

07 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: core: BackendClusterNetworksResource#getNetworks params ...................................................................... core: BackendClusterNetworksResource#getNetworks params getNetworks(String) is only ever called with the clusterId member, making having this parameter redundant and confusing. This patch cleans up the code by removing that parameter and using the data member directly. Change-Id: I8b67ff16e6fcd5035bf6ac82c1411c56be851859 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClusterNetworksResource.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b67ff16e6fcd5035bf6ac82c1411c56be851859 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove BackendVmResource#lookupCluster
by Code Review 07 Nov '16

07 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove BackendVmResource#lookupCluster ...................................................................... core: Remove BackendVmResource#lookupCluster Remove this unused private method. Change-Id: I83cf9ad42fb8af213050fe73915f9da670f9ec34 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83cf9ad42fb8af213050fe73915f9da670f9ec34 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add example showing how to list system roles
by Code Review 07 Nov '16

07 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example showing how to list system roles ...................................................................... Add example showing how to list system roles This patch adds an example that shows how list all the roles available in the system. Change-Id: I10ce2fdc1b13da16dd69600097354ce7968c5dbe Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListRoles.java 1 file changed, 52 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10ce2fdc1b13da16dd69600097354ce7968c5dbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Add example showing how to list system roles
by Code Review 07 Nov '16

07 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example showing how to list system roles ...................................................................... Add example showing how to list system roles This patch adds an example that shows how list all the roles available in the system. Change-Id: Icf7084d2b7ce7d7ce40750b879ac7a48f14c2926 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 770d11adbb00bf20e2e8b5a13b26e0a39728f806) --- A sdk/examples/list_roles.py 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf7084d2b7ce7d7ce40750b879ac7a48f14c2926 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add example showing how to list system roles
by Code Review 07 Nov '16

07 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example showing how to list system roles ...................................................................... Add example showing how to list system roles This patch adds an example that shows how list all the roles available in the system. Change-Id: Icf7084d2b7ce7d7ce40750b879ac7a48f14c2926 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/list_roles.py 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf7084d2b7ce7d7ce40750b879ac7a48f14c2926 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Improve dialog cleanup logic
by Code Review 07 Nov '16

07 Nov '16

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: webadmin,userportal: Improve dialog cleanup logic ...................................................................... webadmin,userportal: Improve dialog cleanup logic This patch ensures that dialog related resources (Views and Models) are cleaned up when both of the following conditions are satisfied: 1, a dialog has just been closed 2, there are no more active (visible) dialogs left This fixes issues where one dialog triggers another dialog, and we cannot simply clean up former dialog's Model as it might be needed later on. Change-Id: Iedd16549f19ea3630bc59f56e6a1a2f880239b27 Bug-Url: https://bugzilla.redhat.com/1368101 Bug-Url: https://bugzilla.redhat.com/1391466 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractPopupPresenterWidget.java 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Greg Sheremeta: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedd16549f19ea3630bc59f56e6a1a2f880239b27 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: VmLogonCommand should propogate errors
by Code Review 07 Nov '16

07 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: VmLogonCommand should propogate errors ...................................................................... engine: VmLogonCommand should propogate errors VmLogonCommand should propogate errors in running VmLogon vds command. Fixing a regression caused by f8da95ffe Change-Id: I23e5a22d16298027ffdd5814b26906cfdc9d60eb Bug-Url: https://bugzilla.redhat.com/1391146 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java 3 files changed, 25 insertions(+), 33 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23e5a22d16298027ffdd5814b26906cfdc9d60eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix error message in gluster host maintenance
by Code Review 06 Nov '16

06 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: fix error message in gluster host maintenance ...................................................................... engine: fix error message in gluster host maintenance Replacement for 'HostsList' validation message variable is missing in gluster host maintenance validation. This patch adds the mising missing replacement variable so that proper validation message is returned in host maintenance flow. Change-Id: I0ec8465a500aaa8f8a16d61c728c6c89d158c338 Bug-Url: https://bugzilla.redhat.com/1386265 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved; Passed CI tests Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/65810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ec8465a500aaa8f8a16d61c728c6c89d158c338 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0