- Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Convert 'all_content' parameter to 'All-Content' header
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Convert 'all_content' parameter to 'All-Content' header ...................................................................... Convert 'all_content' parameter to 'All-Content' header Older versions of the engine (before 4.1) only accepted the 'all_content' parameter as an HTTP header. To better support those versions of the engine this patch changes the SDK so that when the 'all_content' parameter is specified its value is copied to the 'All-Content' request header. So a request like this: GET /ovirt-engine/api/vms/123?all_content=true Will be translated into this: GET /ovirt-engine/api/vms/123?all_content=true All-Content: true Change-Id: I3c15fa5cc60a2c45406d4d892c68d1b6f54d38e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9dedf6aeb19ef9dedc89ff0212103a8474be134b) --- M sdk/lib/ovirtsdk4/connection.rb 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c15fa5cc60a2c45406d4d892c68d1b6f54d38e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Rename http.rb to connection.rb
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Rename http.rb to connection.rb ...................................................................... Rename http.rb to connection.rb The http.rb file contains the implementation of the Connection class, which is mostly independent of the underlying protocol, so connection.rb is a better name. Change-Id: Ia01cc15c52aa57002b0f767e5cfd6256f7ef9abf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit cf9844612c65d746809e73b7efe346c89d48d3e5) --- M sdk/lib/ovirtsdk4.rb R sdk/lib/ovirtsdk4/connection.rb 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia01cc15c52aa57002b0f767e5cfd6256f7ef9abf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Implement == and eql? for types
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Implement == and eql? for types ...................................................................... Implement == and eql? for types This patch changes the SDK so that struct types implement the '==' operator and the 'eql?' methods comparing the values of the instance variables. For example, the '==' operator generated for the 'ExternalVmImport' type is implemented like this: # # Returns `true` if `self` and `other` have the same attributes and # values. # def ==(other) super && @cluster == other.cluster && @cpu_profile == other.cpu_profile && @drivers_iso == other.drivers_iso && @host == other.host && @name == other.name && @password == other.password && @provider == other.provider && @quota == other.quota && @sparse == other.sparse && @storage_domain == other.storage_domain && @url == other.url && @username == other.username && @vm == other.vm end Change-Id: I945b79ba08fb9add2b47f862962d7487c1378868 Bug-Url: https://bugzilla.redhat.com/1383613 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9022c3fae787221175f680939800f0176e564439) --- M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java M sdk/lib/ovirtsdk4/type.rb M sdk/spec/type_spec.rb 3 files changed, 225 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I945b79ba08fb9add2b47f862962d7487c1378868 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Don't generate duplicate getters/setters
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Don't generate duplicate getters/setters ...................................................................... Don't generate duplicate getters/setters Currently the code generator generates the getters and setters for attributes without taking into account that they may also be defined in base classes. This patch fixes that. Change-Id: I15517c90ccf738518072658746aa4200ded5c636 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit a199906ba48006a272969d0b78f30014e0964826) --- M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java 1 file changed, 20 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65532 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15517c90ccf738518072658746aa4200ded5c636 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: let the user customize MNT_OPTIONS
by stirabos＠redhat.com 18 Oct '16

18 Oct '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: let the user customize MNT_OPTIONS ...................................................................... storage: let the user customize MNT_OPTIONS Let the user customize MNT_OPTIONS for NFS and gluster storage domains. Change-Id: I54c588adfff30b94f59bd54fee3ac4a077ca6ec7 Bug-Url: https://bugzilla.redhat.com/1263602 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-setup/storage/blockd.py M src/plugins/gr-he-setup/storage/nfs.py M src/plugins/gr-he-setup/storage/storage.py 3 files changed, 45 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54c588adfff30b94f59bd54fee3ac4a077ca6ec7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: convert memory volumes only on active snapshots to dis...
by mperina＠redhat.com 18 Oct '16

18 Oct '16

Martin Peřina has submitted this change and it was merged. Change subject: core: convert memory volumes only on active snapshots to disks properly ...................................................................... core: convert memory volumes only on active snapshots to disks properly We have no vm_configuration on snapshots of type ACTIVE, thus we need special treatment for this case. The solution is: - If the same memory resides on both ACTIVE and other than ACTIVE snapshots, process one of the snapshots that is not ACTIVE. - If the memory resides only on ACTIVE snapshot, compute its size according to the values in vm_static rather than in vm_configuration. Change-Id: I715082f267b5eaa325cc2bb8988b25ac89e3b043 Bug-Url: https://bugzilla.redhat.com/1382746 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 1 file changed, 33 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715082f267b5eaa325cc2bb8988b25ac89e3b043 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Rename http.rb to connection.rb
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Rename http.rb to connection.rb ...................................................................... Rename http.rb to connection.rb The http.rb file contains the implementation of the Connection class, which is mostly independent of the underlying protocol, so connection.rb is a better name. Change-Id: Ia01cc15c52aa57002b0f767e5cfd6256f7ef9abf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4.rb R sdk/lib/ovirtsdk4/connection.rb 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia01cc15c52aa57002b0f767e5cfd6256f7ef9abf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Convert 'all_content' parameter to 'All-Content' header
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Convert 'all_content' parameter to 'All-Content' header ...................................................................... Convert 'all_content' parameter to 'All-Content' header Older versions of the engine (before 4.1) only accepted the 'all_content' parameter as an HTTP header. To better support those versions of the engine this patch changes the SDK so that when the 'all_content' parameter is specified its value is copied to the 'All-Content' request header. So a request like this: GET /ovirt-engine/api/vms/123?all_content=true Will be translated into this: GET /ovirt-engine/api/vms/123?all_content=true All-Content: true Change-Id: I3c15fa5cc60a2c45406d4d892c68d1b6f54d38e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/connection.rb 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65470 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c15fa5cc60a2c45406d4d892c68d1b6f54d38e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Implement == and eql? for types
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Implement == and eql? for types ...................................................................... Implement == and eql? for types This patch changes the SDK so that struct types implement the '==' operator and the 'eql?' methods comparing the values of the instance variables. For example, the '==' operator generated for the 'ExternalVmImport' type is implemented like this: # # Returns `true` if `self` and `other` have the same attributes and # values. # def ==(other) super && @cluster == other.cluster && @cpu_profile == other.cpu_profile && @drivers_iso == other.drivers_iso && @host == other.host && @name == other.name && @password == other.password && @provider == other.provider && @quota == other.quota && @sparse == other.sparse && @storage_domain == other.storage_domain && @url == other.url && @username == other.username && @vm == other.vm end Change-Id: I945b79ba08fb9add2b47f862962d7487c1378868 Bug-Url: https://bugzilla.redhat.com/1383613 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java M sdk/lib/ovirtsdk4/type.rb M sdk/spec/type_spec.rb 3 files changed, 225 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I945b79ba08fb9add2b47f862962d7487c1378868 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Don't generate duplicate getters/setters
by juan.hernandez＠redhat.com 18 Oct '16

18 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: Don't generate duplicate getters/setters ...................................................................... Don't generate duplicate getters/setters Currently the code generator generates the getters and setters for attributes without taking into account that they may also be defined in base classes. This patch fixes that. Change-Id: I15517c90ccf738518072658746aa4200ded5c636 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/TypesGenerator.java 1 file changed, 20 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15517c90ccf738518072658746aa4200ded5c636 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0