- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UpdateStorageServerConnectionCommandTest collections
by amureini＠redhat.com 13 Oct '16

13 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateStorageServerConnectionCommandTest collections ...................................................................... core: UpdateStorageServerConnectionCommandTest collections Use the specialized Arrays.asList, Collections.singletonList and Collections.emptyList instead of the general purpose ArrayList to improve the code's readability and gain an (ever so slight) performance boost. Change-Id: I82665768a7a8420c4ee4c57d89aa8325f60d07c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java 1 file changed, 14 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82665768a7a8420c4ee4c57d89aa8325f60d07c5 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageHandlingCommandBase#getAllRunningVdssInPool
by amureini＠redhat.com 13 Oct '16

13 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageHandlingCommandBase#getAllRunningVdssInPool ...................................................................... core: StorageHandlingCommandBase#getAllRunningVdssInPool This method was only used by the StoragePoolStatusHandler. This patch moves the method to the class that uses it in order to decouple a false dependency between it and the command. Change-Id: I3f07248baf52f0096ac450108600a20801196519 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolStatusHandler.java 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f07248baf52f0096ac450108600a20801196519 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: UpdateStorageServerConnectionCommandTest local vars
by amureini＠redhat.com 13 Oct '16

13 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateStorageServerConnectionCommandTest local vars ...................................................................... core: UpdateStorageServerConnectionCommandTest local vars Remove redundant local variables. Change-Id: I45881ccbeff88a478509d4f6a413158a5420e382 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45881ccbeff88a478509d4f6a413158a5420e382 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez＠redhat.com 13 Oct '16

13 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: I1c2adb6ae337868920e0a87571d9f58a8e032714 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c2adb6ae337868920e0a87571d9f58a8e032714 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Release 3.6.9.2
by juan.hernandez＠redhat.com 13 Oct '16

13 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Release 3.6.9.2 ...................................................................... cli: Release 3.6.9.2 Change-Id: I3e86a5f75ab0364fb711cfa3c84aeb3bfa38f3d6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e86a5f75ab0364fb711cfa3c84aeb3bfa38f3d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[refs/meta/config]: Update permissions to be inherited from All-Projects
by sbendavi＠redhat.com 13 Oct '16

13 Oct '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Update permissions to be inherited from All-Projects ...................................................................... Update permissions to be inherited from All-Projects Change-Id: Ib1e68d5f817bc2407619fcdd1766fa8043a903ad --- M groups M project.config 2 files changed, 1 insertion(+), 13 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1e68d5f817bc2407619fcdd1766fa8043a903ad Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: refs/meta/config Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Base should be None when there is no base
by juan.hernandez＠redhat.com 13 Oct '16

13 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Base should be None when there is no base ...................................................................... cli: Base should be None when there is no base Currently when a base object can't be found the 'resolve_base' method returns the starting point for the search, the 'connection' object. This is wrong, it should return 'None', as that is what callers expect. This patch fixes that issue. Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Bug-Url: https://bugzilla.redhat.com/1383735 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 42080df2d9405e3f9577106b588c8a93b2220008) --- M src/ovirtcli/command/command.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[master]: cli: Base should be None when there is no base
by juan.hernandez＠redhat.com 13 Oct '16

13 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Base should be None when there is no base ...................................................................... cli: Base should be None when there is no base Currently when a base object can't be found the 'resolve_base' method returns the starting point for the search, the 'connection' object. This is wrong, it should return 'None', as that is what callers expect. This patch fixes that issue. Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Bug-Url: https://bugzilla.redhat.com/1383735 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I971624874935ef7342cd7fb193783893fc7cdc84 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: setup: plugins: add constant duplication check
by sbonazzo＠redhat.com 13 Oct '16

13 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: plugins: add constant duplication check ...................................................................... setup: plugins: add constant duplication check Check for constants duplication in all constants.py files Change-Id: I5c7a1d419b658bb712e135b3e5c5a94341b8ac51 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1263785 --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py A packaging/setup/plugins/ovirt-engine-common/base/core/duplicated_constants_check.py 3 files changed, 125 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c7a1d419b658bb712e135b3e5c5a94341b8ac51 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix get_bug_url function in check_product hook
by sbendavi＠redhat.com 13 Oct '16

13 Oct '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Fix get_bug_url function in check_product hook ...................................................................... Fix get_bug_url function in check_product hook - Add hard coded bz_server for the new regex search in get_bug_url function - Replace old links with new ones Change-Id: Ia8878f3f45763bb7a6f17f2372099cfe61975a0c Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_product A hooks/custom_hooks/patchset-created.bz.2.correct_product R hooks/custom_hooks/patchset-created.bz.2.correct_product-not-used R hooks/custom_hooks/patchset-created.bz.2.correct_product.py 4 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8878f3f45763bb7a6f17f2372099cfe61975a0c Gerrit-PatchSet: 2 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0