- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Validate 'nfs_timeo' and 'nfs_retrans' range
by tnisan＠redhat.com 13 Sep '16

13 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Validate 'nfs_timeo' and 'nfs_retrans' range ...................................................................... restapi: Validate 'nfs_timeo' and 'nfs_retrans' range Current the 'nfs_timeo' and 'nfs_retrans' values used when adding NFS storage aren't validated, their values are just truncated and passed to the backend. That is wrong. As the backend receives a 'short' and the API uses an 'integer' it isn't possible to do the validation in the backend, thus it needs to be done in the API. This patch changes the API so that it performs explicitly this check before trying to do anything with the storage. If the check fails, for example if the value of 'nfs_timeo' is 131077, the operation will fail with error code 400 (Bad Request) and the following response body will be returned: <fault> <reason>Value out of range</reason> <detail>The value 131077 of attribute 'nfs_timeio' is outside of range 0 to 65535.</detail> </fault> Change-Id: I3e26b58879b2a3e0ed54fbdb9a1c70aa4efcc73c Bug-Url: https://bugzilla.redhat.com/1373581 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit df3dc73d94ef4020c32c1449b5619a09ccf431d5) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/logging/Messages.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/resources/org/ovirt/engine/api/restapi/logging/Messages.properties 4 files changed, 28 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63663 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e26b58879b2a3e0ed54fbdb9a1c70aa4efcc73c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Validate images existance for unregistered Template.
by mlipchuk＠redhat.com 13 Sep '16

13 Sep '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate images existance for unregistered Template. ...................................................................... core: Validate images existance for unregistered Template. Once an unregister Template entity is being registered to the engine, the engine should verify all its disks existance in the Storage. The reason the engine should perform this validation is since the Template's OVF might not be synced with the disks in the Storage. If one of the disks doesn't exists, the engine should block the operation. This behavior should be compatible with the behavior being performed today once a Template is being imported from an export domain. Change-Id: I3b890bd831c34770d6fd43416d5b15888b45f85b Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1367488 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromConfigurationCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/63490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b890bd831c34770d6fd43416d5b15888b45f85b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Require WildFly 10.1.0
by sbonazzo＠redhat.com 13 Sep '16

13 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: Require WildFly 10.1.0 ...................................................................... core: Require WildFly 10.1.0 Adds requirement on WildFly 10.1.0 Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Bug-Url: https://bugzilla.redhat.com/1368985 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Add example of changing VM CD
by omachace＠redhat.com 12 Sep '16

12 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add example of changing VM CD ...................................................................... Add example of changing VM CD This patch adds example of changing VM CD. Change-Id: I957ed6b34f489ba4cc7c231c40a5cc1a9051e1f8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 5fc83c983d0949b45074e46475a6afc3726835b8) --- A sdk/examples/change_vm_cd.py 1 file changed, 75 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63676 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I957ed6b34f489ba4cc7c231c40a5cc1a9051e1f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: avoid using interface cfg entries
by stirabos＠redhat.com 12 Sep '16

12 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: network: avoid using interface cfg entries ...................................................................... network: avoid using interface cfg entries Since patch https://gerrit.ovirt.org/#/c/58226 , vdsm doesn't provide anymore the cfg in netinfo entries. Avoid using it. Change-Id: I63017df607b017844d45bea0649667a8e9adf90b Depends-On: https://gerrit.ovirt.org/#/c/58226 Depends-On: https://gerrit.ovirt.org/#/c/58351 Bug-Url: https://bugzilla.redhat.com/1313881 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vds_info.py M src/plugins/gr-he-common/network/bridge.py M src/plugins/gr-he-setup/engine/add_host.py 3 files changed, 27 insertions(+), 79 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63017df607b017844d45bea0649667a8e9adf90b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: virt: adding a graphic device
by stirabos＠redhat.com 12 Sep '16

12 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: virt: adding a graphic device ...................................................................... virt: adding a graphic device VDSM from master requires also a graphic device, adding it. Change-Id: I00fcda8779fcc70e650438ea659c3b0a82685bb2 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M templates/vm.conf.in 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00fcda8779fcc70e650438ea659c3b0a82685bb2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use try-with-resource
by amureini＠redhat.com 12 Sep '16

12 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use try-with-resource ...................................................................... core: Use try-with-resource Wherever possible, use try-with-resource to reduce code bloating. Change-Id: I7c2352779afac23dbc97b0f37137b45fc61d20ba Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java M backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/Configuration.java M backend/manager/modules/extensions-manager/src/test/java/org/ovirt/engine/core/extensions/mgr/ConfigurationTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/StandaloneDataSource.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ServletUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java 9 files changed, 28 insertions(+), 146 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c2352779afac23dbc97b0f37137b45fc61d20ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseDaoTestCase exceptions
by amureini＠redhat.com 12 Sep '16

12 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: BaseDaoTestCase exceptions ...................................................................... core: BaseDaoTestCase exceptions If a datasource cannot be loaded, allow the exception to be thrown all the way up so JUnit can handle the proper printing of the stacktrace instead of reinventing the wheel. Change-Id: Ie01c2191c3ba6608507edad430f4c751d05e2dda Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie01c2191c3ba6608507edad430f4c751d05e2dda Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove DbUtils
by amureini＠redhat.com 12 Sep '16

12 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove DbUtils ...................................................................... core: Remove DbUtils DbUtils' closeQuietly methods were just a nicety to avoid boiler-plated code in the finally block of a try block handling JDBC resources. Since Java 7, all JDBC resources are autoclosable, so there's a much cleaner way of handling these issues - with a try-with-resource block. This patch converts all the usages of DbUtils to standard Java try-with-resource blocks and removes this now-useless class completely. Change-Id: I6620228031c9f723b350e10820c5a8035fef241f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/DbUtils.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/dao/EventsManager.java 3 files changed, 26 insertions(+), 136 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/63691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6620228031c9f723b350e10820c5a8035fef241f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: services: Inject Backend directly into Servlets
by mperina＠redhat.com 12 Sep '16

12 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: services: Inject Backend directly into Servlets ...................................................................... services: Inject Backend directly into Servlets Replaced manual EJB JNDI lookup with direct CDI injection. Change-Id: If8ca3b748ad78b66b15cf5309f4b1011c1fb0f6d Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetSessionUser.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/HealthStatus.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/SsoCallbackServlet.java 4 files changed, 17 insertions(+), 20 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Alexander Wels: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/63623 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8ca3b748ad78b66b15cf5309f4b1011c1fb0f6d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0