- Engine-commits - oVirt List Archives

Change in ovirt-image-uploader[master]: Spec file: Add nfs-util dependency
by sbonazzo＠redhat.com 30 Aug '16

30 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Spec file: Add nfs-util dependency ...................................................................... Spec file: Add nfs-util dependency Change-Id: I3daca6e165c1c996eca008d06afceabaf8be58cd Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335169 --- M ovirt-image-uploader.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3daca6e165c1c996eca008d06afceabaf8be58cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Next run config dialog - texts moved to ui.xml
by mbetak＠redhat.com 30 Aug '16

30 Aug '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Next run config dialog - texts moved to ui.xml ...................................................................... webadmin: Next run config dialog - texts moved to ui.xml Localization moved from VmNextRunConfigurationWidget.localize() to appropriate ui.xml file where possible. Change-Id: I14d28f6e7788256d49716ff34ca720bf81d4b4b4 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml 2 files changed, 12 insertions(+), 25 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14d28f6e7788256d49716ff34ca720bf81d4b4b4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: jsonrpc: safely parsing empty responses
by msivak＠redhat.com 30 Aug '16

30 Aug '16

Martin Sivák has submitted this change and it was merged. Change subject: jsonrpc: safely parsing empty responses ...................................................................... jsonrpc: safely parsing empty responses jsonrpc responces dictionary doesn't contain the 'jsonrpc' key if there is no value to pass. Correctly handling it. Change-Id: I135b20ab22f2ffd55059f6992f27dc75e64a2501 Bug-Url: https://bugzilla.redhat.com/1365242 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/image.py M ovirt_hosted_engine_ha/lib/ovf/ovf_store.py M ovirt_hosted_engine_ha/lib/storage_server.py M ovirt_hosted_engine_ha/lib/upgrade.py 4 files changed, 26 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I135b20ab22f2ffd55059f6992f27dc75e64a2501 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: upgrade: enforcing current aaa mechanism
by stirabos＠redhat.com 30 Aug '16

30 Aug '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: enforcing current aaa mechanism ...................................................................... upgrade: enforcing current aaa mechanism Enforce that all the available aaa domains are using the new ovirt-engine-extension mechanism since engine 4.0 supports only that one. Change-Id: I7c64d5a45a67d6a222e65d3fd8fb183d33f5e8ba Bug-Url: https://bugzilla.redhat.com/1368604 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit a4cbb100feaf4ca4f288777af80e7a8ec8cb4553) --- M src/plugins/gr-he-upgradeappliance/vm/configurevm.py 1 file changed, 168 insertions(+), 1 deletion(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c64d5a45a67d6a222e65d3fd8fb183d33f5e8ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add generic reader
by juan.hernandez＠redhat.com 30 Aug '16

30 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add generic reader ...................................................................... Add generic reader Currently the SDK doesn't provide any mechanism to read an XML object without explicitly specifying its type. For example, to read a virtual machine the only method available is "VmReader.read_one". But there are situations where the SDK can't know in advance what type of object is going to be received from the server, for example "action" or "fault". To support that, this patch adds a new "Reader.read" method that decides the type of object based on the name of the first tag, and invokes the corresponding specific reader to read it. Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 66ad419477cb644727cecaf62815bf4fe46d84ac) --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/lib/ovirtsdk4/reader.rb M sdk/spec/reader_spec.rb 3 files changed, 164 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add generic reader
by juan.hernandez＠redhat.com 30 Aug '16

30 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add generic reader ...................................................................... Add generic reader Currently the SDK doesn't provide any mechanism to read an XML object without explicitly specifying its type. For example, to read a virtual machine the only method available is "VmReader.read_one". But there are situations where the SDK can't know in advance what type of object is going to be received from the server, for example "action" or "fault". To support that, this patch adds a new "Reader.read" method that decides the type of object based on the name of the first tag, and invokes the corresponding specific reader to read it. Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/lib/ovirtsdk4/reader.rb M sdk/spec/reader_spec.rb 3 files changed, 164 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62572 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b8c9a4c1118e7b261a589e8185861c9acf36921 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: console: remove virt-viewer dependency
by stirabos＠redhat.com 30 Aug '16

30 Aug '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: console: remove virt-viewer dependency ...................................................................... console: remove virt-viewer dependency Remove virt-viewer dependency in favor of virsh console over TLS. Change-Id: Ifee27639ab3c65611b6328cd6bc03dc7ce575f22 Bug-Url: https://bugzilla.redhat.com/1333449 Bug-Url: https://bugzilla.redhat.com/1343882 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M ovirt-hosted-engine-setup.spec.in M src/bin/hosted-engine.in 3 files changed, 27 insertions(+), 19 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61930 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifee27639ab3c65611b6328cd6bc03dc7ce575f22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-4.0]: automation: drop suffix on manual tarball build
by sbonazzo＠redhat.com 30 Aug '16

30 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: drop suffix on manual tarball build ...................................................................... automation: drop suffix on manual tarball build We don't want to change anything in the versioning of the RPM built from tarball since it can be used for a release. Change-Id: Ia89e2970ad801066d5011a5b488ca002c5a89550 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts-manual.sh 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia89e2970ad801066d5011a5b488ca002c5a89550 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid using static for config value.
by mlipchuk＠redhat.com 30 Aug '16

30 Aug '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Avoid using static for config value. ...................................................................... core: Avoid using static for config value. There is not reason to use static value for config value since this value is already cached from the DB. Change-Id: Ideb5d770cf836dd4a4e6519c6aac7db0f13e23f9 Bug-Url: https://bugzilla.redhat.com/1348405 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidatorTest.java 4 files changed, 1 insertion(+), 28 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/62946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ideb5d770cf836dd4a4e6519c6aac7db0f13e23f9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Next run config applyCpuLater -> applyLater
by mbetak＠redhat.com 30 Aug '16

30 Aug '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin: Next run config applyCpuLater -> applyLater ...................................................................... webadmin: Next run config applyCpuLater -> applyLater "Cpu" removed from names of VmNextRunConfigurationModel.applyCpuLater and VmNextRunConfigurationWidget.applyCpuLaterEditor since it deals with both cpu and memory. Change-Id: Ia9a7f0a4ffe303bc623f7a098b17325f66dcf6ab Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java 5 files changed, 13 insertions(+), 13 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62614 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9a7f0a4ffe303bc623f7a098b17325f66dcf6ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0