- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix compensation mechanism in RefreshLunsSizeCommand
by amureini＠redhat.com 28 Aug '16

28 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix compensation mechanism in RefreshLunsSizeCommand ...................................................................... core: fix compensation mechanism in RefreshLunsSizeCommand This patch fixes two issues in RefreshLunsSizeCommand's compensation mechanism: 1. RefreshLunsSizeCommand doesn't contain the required compensation constructor. 2. The updateStorageDomain method takes a snapshot of the new storage domain dynamic object instead of the old one, which leads the compensation of the same object in the db, instead of the old one. Change-Id: I60d802529533aa073b178c273f4f21c89975b5ea Bug-Url: https://bugzilla.redhat.com/1370912 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/62887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60d802529533aa073b178c273f4f21c89975b5ea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: fix change-merged.set_MODIFIED hook
by eedri＠redhat.com 28 Aug '16

28 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: fix change-merged.set_MODIFIED hook ...................................................................... fix change-merged.set_MODIFIED hook The current state of the hook is that it moves bugs from POST ==> MODIFIED with wrong logic. Example 1: bug target milestone: ovirt-4.0.2 change branch: master After merge the bug will be moved automatically from POST ==> MODIFIED although it was merged to master to perform a backport Example 2: bug target milestone: ovirt-4.0.2 change branch: ovirt-engine-4.0 After merge the bug will be moved automatically from POST ==> MODIFIED although the branch ovirt-engine-4.0.2 exist The new logic is as follows: 1. changes on master branch with any bug tm_suffix. ==> bug will be skipped (stay on POST) 2. changes that their branch_suffix match bug tm_suffix (i.e tm_suffix=4.0.2 and branch_suffix=4.0.2) ==> bug will be moved (POST ==> MODIFIED) 3. changes that their branch_suffix match bug tm_suffix (X.Y) and branch (ovirt-engine-4.0.4) isn't exist (i.e tm_suffix=4.0.4 and branch_suffix=4.0) ==> bug will be moved (POST ==> MODIFIED) else ==> bug will be skipped (stay on POST) Change-Id: I248346f923e5ec0002526cc7e4e94733c9be4524 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 55 insertions(+), 57 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I248346f923e5ec0002526cc7e4e94733c9be4524 Gerrit-PatchSet: 8 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: ui: Import KVM guest image: cannot convert VM with block dev...
by shavivi＠redhat.com 28 Aug '16

28 Aug '16

Shahar Havivi has submitted this change and it was merged. Change subject: ui: Import KVM guest image: cannot convert VM with block device to block device ...................................................................... ui: Import KVM guest image: cannot convert VM with block device to block device Warn the user that we allocate the virtual size of the images until we have the solution of physical size from Libvirt (bz 1332019) Bug-Url: https://bugzilla.redhat.com/1362525 Change-Id: I1d254930978629bdc79459556ccded650668a9b1 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 5 files changed, 39 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d254930978629bdc79459556ccded650668a9b1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Import KVM guest image: cannot convert VM with block d...
by shavivi＠redhat.com 28 Aug '16

28 Aug '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: Import KVM guest image: cannot convert VM with block device to block device ...................................................................... core: Import KVM guest image: cannot convert VM with block device to block device For now the solution is to allocate the virtual size of the images until we have the physical size from Libvirt (bz 1332019) Change-Id: I8b71719b3b960528320cb625eca1e88b4e2c1145 Bug-Url: https://bugzilla.redhat.com/1362525 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b71719b3b960528320cb625eca1e88b4e2c1145 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: add finish report on multi-host network commands
by masayag＠redhat.com 28 Aug '16

28 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: add finish report on multi-host network commands ...................................................................... engine: add finish report on multi-host network commands The change adds reporting of finish applying network changes to the hosts that were done asynchronously. Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a Bug-Url: https://bugzilla.redhat.com/1300220 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunction.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/util/ReportFailedChildHostOperationsUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/PropagateLabeledNetworksToClusterHostsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandCoordinatorUtil.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/util/HostIdToLoggableNameFunctionTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ManageNetworkClustersParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 11 files changed, 283 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93eeccdd6695ddabbcfe26517fc372134ddc0e6a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Make Reports-related Dashboard main tab initially ...
by tnisan＠redhat.com 28 Aug '16

28 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Make Reports-related Dashboard main tab initially hidden ...................................................................... webadmin: Make Reports-related Dashboard main tab initially hidden In 4.0, even though we don't ship Reports anymore, UI still contains code for Reports integration: (Reports related) "Dashboard" main tab will be shown on the right-hand side of tab panel for a brief moment, until the UI detects unavailability of Reports & hiding that tab. This is unrelated to the "Dashboard" main tab shown on the left-hand side of tab panel, representing the oVirt Dashboard feature introduced in 4.0. This patch simply sets the (Reports related) "Dashboard" main tab to be initially hidden, which fixes the above mentioned UX issue. Due to Reports not available in 4.0, that tab will never become visible. Change-Id: I155ac581eb71febb55df84b339a6ab46b729dde7 Bug-Url: https://bugzilla.redhat.com/1365980 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/62219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I155ac581eb71febb55df84b339a6ab46b729dde7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: Allow provisioning postgresql role
by tnisan＠redhat.com 28 Aug '16

28 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: Allow provisioning postgresql role ...................................................................... packaging: setup: Allow provisioning postgresql role ... without provisioning also a database. Change-Id: I40c88ad48f8f7c2b8e06802137870b0c198b5129 Bug-Url: https://bugzilla.redhat.com/1369757 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/database.py 2 files changed, 136 insertions(+), 36 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/62849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40c88ad48f8f7c2b8e06802137870b0c198b5129 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: engine-backup: Create extra users on provisioning
by tnisan＠redhat.com 28 Aug '16

28 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: engine-backup: Create extra users on provisioning ...................................................................... packaging: engine-backup: Create extra users on provisioning If passing --provision-*, and the dump file containts extra GRANT statements, create these users before restore. Change-Id: I61c7d2fd8eee8158434fc4b9df20c965195fdb00 Bug-Url: https://bugzilla.redhat.com/1369757 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit be0cf8f79ec8cb263e50e8c1f8f755d7e7f8ac5d) --- M packaging/bin/engine-backup.sh.in 1 file changed, 49 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/62850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61c7d2fd8eee8158434fc4b9df20c965195fdb00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: otopi-config-query: fix interpreter
by didi＠redhat.com 28 Aug '16

28 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: otopi-config-query: fix interpreter ...................................................................... otopi-config-query: fix interpreter Use /usr/bin/python instead of /usr/bin/env python Fixes rpmlint error: otopi.noarch: E: wrong-script-interpreter /usr/bin/otopi-config-query /usr/bin/env python Change-Id: If8221cc066dfa2ae19d36e2ceda79705ee7a9347 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/bin/otopi-config-query 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8221cc066dfa2ae19d36e2ceda79705ee7a9347 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: remove check-merged from 3.6.9
by eedri＠redhat.com 28 Aug '16

28 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: remove check-merged from 3.6.9 ...................................................................... remove check-merged from 3.6.9 We already run build artifacts for 3.6.9 and also check-merged for 3.6, this job has little use and not worth the resources. Change-Id: Ifbc5a164e82e7e4d0fffe410f18065e0ca3b0144 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbc5a164e82e7e4d0fffe410f18065e0ca3b0144 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0