- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VdsmImageLocationInfo - adding default ctor
by laravot＠redhat.com 09 Aug '16

09 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: VdsmImageLocationInfo - adding default ctor ...................................................................... core: VdsmImageLocationInfo - adding default ctor As VdsmImageLocationInfo is used in params class it may be serialized/deserialized, default ctor is needed for the deserialization. Change-Id: I6ef7f33352e7504edeb78586584947d8824467b3 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsmImageLocationInfo.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/61649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef7f33352e7504edeb78586584947d8824467b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Don't call finazlize on image upload progress.
by derez＠redhat.com 09 Aug '16

09 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Don't call finazlize on image upload progress. ...................................................................... webadmin: Don't call finazlize on image upload progress. Currently, when a progress callback triggered while uploading an image, and the upload status is not "TRANSFERRING", there is a call to finalize upload. This is wrong, because in any scenario in which the status becomes anything other than "TRANSFERRING", finalizing the upload already happens. that means that currently a call for finalizing will happen twice. Remove the call for finalizeUpload in onProgress(). Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/62017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Set Disk 'active' properly in V3
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Set Disk 'active' properly in V3 ...................................................................... restapi: Set Disk 'active' properly in V3 When using the old V3 VM disks server we should set the active value from the Disk to the DiskAttachment otherwise it will be ignored down the chain Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Martin Peřina: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add active propery back to Disk
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add active propery back to Disk ...................................................................... restapi: Add active propery back to Disk This patch fixes a regression introduced by: https://gerrit.ovirt.org/#/c/61737/ which removed the 'active' property on disk Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Ori Liel <oliel(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M pom.xml 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: network: fixing the detection of existing management bridge
by sbonazzo＠redhat.com 09 Aug '16

09 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: fixing the detection of existing management bridge ...................................................................... network: fixing the detection of existing management bridge Look for an already configured management bridge using the management bridge name from the answerfile instead of the default one. Change-Id: I6688b55d7efed73bd759788048d4e6613514f153 Bug-Url: https://bugzilla.redhat.com/1365184 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 2 files changed, 28 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6688b55d7efed73bd759788048d4e6613514f153 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: LockMessage introduced
by ahadas＠redhat.com 09 Aug '16

09 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: LockMessage introduced ...................................................................... core: LockMessage introduced It allows to conveniently create strings of form "engineMessage$var1Name var1Value$var2Name var2Value" used as lock messages. Method LockMessagesMatchUtil .makeLockingPair(LockingGroup group, LockMessage messageBuilder) added allowing seamless creation of locking pairs using LockMessage. This path is meant to update all lock message creations with varialbes to use LockMessage. Change-Id: Ie85694d87676c4fa92e4d465568dcd575430f56f Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockMessage.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockMessagesMatchUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskAlignmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ExportRepoImageCommand.java 19 files changed, 125 insertions(+), 136 deletions(-) Approvals: Jakub Niedermertl: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie85694d87676c4fa92e4d465568dcd575430f56f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: automation: use 4.0 repos
by piotr.kliczewski＠gmail.com 09 Aug '16

09 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: automation: use 4.0 repos ...................................................................... automation: use 4.0 repos Change-Id: Ib1869d928a19871a9bc26873a1a26ba1df743e46 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit ccd83ecd18b274353653e9a98bd020411ab19937) --- M automation/build-artifacts.repos M automation/check-merged.repos M automation/check-patch.repos 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Eyal Edri: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62096 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1869d928a19871a9bc26873a1a26ba1df743e46 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Edit error message in DC operation failure dialog
by rgolan＠redhat.com 09 Aug '16

09 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Edit error message in DC operation failure dialog ...................................................................... webadmin: Edit error message in DC operation failure dialog This patch makes the following changes to the error dialogue generated when a user attempts to upgrade the compatibility level of a data center to a level greater than that of any of its clusters: 1. Changes "Clusters" to "clusters" 2. Adds a colon between the error message and the list of problematic clusters Change-Id: If4f074f6030bc68042137fb33e5de1e8be8e4c3d Bug-Url: https://bugzilla.redhat.com/1287540 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/62091 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4f074f6030bc68042137fb33e5de1e8be8e4c3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add audit log messages for affinity labels
by rgolan＠redhat.com 09 Aug '16

09 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: core: Add audit log messages for affinity labels ...................................................................... core: Add audit log messages for affinity labels This patch adds messages to the AuditLogMessages.properties file that correspond to the AuditLogType values used for affinity label commands. This ensures messages are displayed in the UI and avoids translation errors in the engine log. Change-Id: Ia7120f4288b825c2a511b4507b1f17021a137cad Bug-Url: https://bugzilla.redhat.com/1351519 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddLabelCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LabelCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 20 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/61903 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7120f4288b825c2a511b4507b1f17021a137cad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClusterValidatorTest type inference
by amureini＠redhat.com 09 Aug '16

09 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ClusterValidatorTest type inference ...................................................................... core: ClusterValidatorTest type inference Change-Id: I6aef938e68b98680f70ac842b55c5582153afc46 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ClusterValidatorTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6aef938e68b98680f70ac842b55c5582153afc46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0