- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: Revert "engine: Create default network QoS for ovirtmgmt upo...
by tnisan＠redhat.com 07 Aug '16

07 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" ...................................................................... Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" This reverts commit 7bbfdab92ac600994319aac2bc5ee35ec11f3dc9. Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java 1 file changed, 1 insertion(+), 35 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Revert "engine: allow QoS and non-QoS networks to be attache...
by tnisan＠redhat.com 07 Aug '16

07 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: allow QoS and non-QoS networks to be attached to a nic" ...................................................................... Revert "engine: allow QoS and non-QoS networks to be attached to a nic" This reverts commit 984878ccbb5084fa936dca5df39f2bf2b8fc740a. Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 118 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Call super method getJobMessageProperties
by amureini＠redhat.com 07 Aug '16

07 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Call super method getJobMessageProperties ...................................................................... engine: Call super method getJobMessageProperties Add a call to super method in getJobMessageProperties in order to get CommandBase implementation invoked before adding properties. This patch fixes coverity issue #1353695 Change-Id: I4f86794fed438b640ec139f782e51519e26cb5b6 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Passed CI tests Freddy Rolland: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f86794fed438b640ec139f782e51519e26cb5b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: userportal: Fix first vm creation in session
by rgolan＠redhat.com 07 Aug '16

07 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: webadmin: userportal: Fix first vm creation in session ...................................................................... webadmin: userportal: Fix first vm creation in session When creating a vm on a local storage domain it should be pinned to a specific host that is available for this domain. When creating a vm on local storage for the first time it wouldn't be created with a pinned host due to an async code that would not run in the expected order. When editing such a vm the user would get an error since it seems that he is editing the pinned host. To ensure the correct order of execution the handling of the local storage was moved to the end of the block of code that is run asynchronously. Change-Id: I99918ef35099546734cf8835e5abe5bfcef33d08 Bug-Url: https://bugzilla.redhat.com/1284472 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve Jenny Tokar: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99918ef35099546734cf8835e5abe5bfcef33d08 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "engine: Create default network QoS for ovirtmgmt upo...
by masayag＠redhat.com 07 Aug '16

07 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" ...................................................................... Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" This reverts commit 7bbfdab92ac600994319aac2bc5ee35ec11f3dc9. Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java 1 file changed, 1 insertion(+), 35 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/61914 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "engine: allow QoS and non-QoS networks to be attache...
by masayag＠redhat.com 07 Aug '16

07 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: Revert "engine: allow QoS and non-QoS networks to be attached to a nic" ...................................................................... Revert "engine: allow QoS and non-QoS networks to be attached to a nic" This reverts commit 984878ccbb5084fa936dca5df39f2bf2b8fc740a. Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 118 insertions(+), 1 deletion(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/61915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClusterValidator: clean up boolean expression
by amureini＠redhat.com 07 Aug '16

07 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ClusterValidator: clean up boolean expression ...................................................................... core: ClusterValidator: clean up boolean expression Remove parentheses and explicit "false" in versionSupported() to make the boolean expression more straight forward and easier to read. Change-Id: I1cefa45708cdee9c276db41d6bb5a9e1fcda879c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62013 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cefa45708cdee9c276db41d6bb5a9e1fcda879c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ClusterValidator type inference
by amureini＠redhat.com 07 Aug '16

07 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ClusterValidator type inference ...................................................................... core: ClusterValidator type inference Change-Id: Ic8e97ee064492fe339581e8793a4f391c06d7d55 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8e97ee064492fe339581e8793a4f391c06d7d55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: move ovirt-system-tests to run on fc24
by eedri＠redhat.com 07 Aug '16

07 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: move ovirt-system-tests to run on fc24 ...................................................................... move ovirt-system-tests to run on fc24 We don't maintain anymore fc23 repos for master Change-Id: Ia081be48612229f8919e66fdc043d46b90a6e941 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-system-tests/ovirt-system-tests_standard.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia081be48612229f8919e66fdc043d46b90a6e941 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: VM > Containers subtab hashname fix
by mbetak＠redhat.com 05 Aug '16

05 Aug '16

Martin Betak has submitted this change and it was merged. Change subject: webadmin, userportal: VM > Containers subtab hashname fix ...................................................................... webadmin, userportal: VM > Containers subtab hashname fix VM > Containers subtab hash name was inconsistent causing warning: "org.ovirt.engine.ui.common.uicommon.ContextSensitiveHelpManager INFO: No context-sensitive help was found on the server. It will not be available for this session." Change-Id: I0e5f98d06c6c61da4c3cce6241597dc46faed5e3 Bug-Url: https://bugzilla.redhat.com/1364466 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestContainerListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/UserPortalApplicationPlaces.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e5f98d06c6c61da4c3cce6241597dc46faed5e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0