- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GetImageInfo to use GetVolumeInfo
by laravot＠redhat.com 26 Jul '16

26 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: GetImageInfo to use GetVolumeInfo ...................................................................... core: GetImageInfo to use GetVolumeInfo GetImageInfoVDSCommand is an IRS command that executes getVolumeInfo on the SPM. Additionally, we have the GetVolumeInfoVDSCommand that executes getVolumeInfo on the passed host in the parameters. Currently GetVolumeInfoVDSCommand doesn't return the actual image info, but only if it managed to get the volume information. As we need to use it to get the actual info instead of duplicating the code or exporting it to a helper class we can change GetImageInfo to use GetVolumeInfo and to pass it the SPM host id, maintaining the same behavior with less code. Change-Id: Iebfd4678e2422352567cba61ca363348867541c2 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VolumeInfoReturnForXmlRpc.java 8 files changed, 83 insertions(+), 175 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebfd4678e2422352567cba61ca363348867541c2 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: BaseImagesCommand - isDataOperationsByHSM() logic
by laravot＠redhat.com 26 Jul '16

26 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: BaseImagesCommand - isDataOperationsByHSM() logic ...................................................................... core: BaseImagesCommand - isDataOperationsByHSM() logic SDM flows would be implemented in such a way that in case that the host which is performing the operation will go non responsive we'll be able to poll using a different host by check the actual entity on the storage. In order to do that on oVirt images, we intend to use the volume leases so we can determine if the operation on the volume was ended or is still running. Export domains and local storage domains doesn't support volume leases therefore if the performing host goes non responsive there's no way to track the operation, therefore the SDM verbs aren't supposed to support those. This patches update isDataOperationsByHSM() to return false if the domain isn't data domain or if it is a local domain. Change-Id: I7826ef8317a667d2a563a702a5e6931f382f638d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7826ef8317a667d2a563a702a5e6931f382f638d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: IrsProxyData - pool status/domain status SDM logic
by laravot＠redhat.com 26 Jul '16

26 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: IrsProxyData - pool status/domain status SDM logic ...................................................................... core: IrsProxyData - pool status/domain status SDM logic This patch removes the remains of the IrsProxyData SDM changes as we keep relying on the SPM for now. Change-Id: I6eabba9cb4afe6b4e2b49300bd0195998e208d31 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxyData.java 1 file changed, 2 insertions(+), 22 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/61086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eabba9cb4afe6b4e2b49300bd0195998e208d31 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCommand/Parameters - job id generation
by laravot＠redhat.com 26 Jul '16

26 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCommand/Parameters - job id generation ...................................................................... core: StorageJobCommand/Parameters - job id generation The command should generate the job id only if not present. There's no need to generate the job id in the command parameters class. Change-Id: Iacaeb45c4db22fe15815d4f4823c0e07f64b65fd Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageJobCommandParameters.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/61084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacaeb45c4db22fe15815d4f4823c0e07f64b65fd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateVolumeParameters - set srcImageId
by laravot＠redhat.com 26 Jul '16

26 Jul '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CreateVolumeParameters - set srcImageId ...................................................................... core: CreateVolumeParameters - set srcImageId Change-Id: Iaeb9ede9a1de7ab99555a646cf3cdcbd0e644133 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateVolumeParameters.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61344 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaeb9ede9a1de7ab99555a646cf3cdcbd0e644133 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Restapi access should create sessions only if persisten...
by piotr.kliczewski＠gmail.com 26 Jul '16

26 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Restapi access should create sessions only if persistent_auth is requested ...................................................................... aaa: Restapi access should create sessions only if persistent_auth is requested Restapi authentication filters should not create sessions for bearer auth, only basic auth requests should have sessions created. Change-Id: I6f769c358e32637fa6289636542dd8548f786069 Bug-Url: https://bugzilla.redhat.com/1358434 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoRestApiAuthFilter.java M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SsoRestApiNegotiationFilter.java 3 files changed, 4 insertions(+), 13 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f769c358e32637fa6289636542dd8548f786069 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: after dwh build for 4.0.2
by Shirly Radco 26 Jul '16

26 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: after dwh build for 4.0.2 ...................................................................... build: after dwh build for 4.0.2 Change-Id: I2e6e217691600bf90bb12435b0064959d4cbc9e5 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e6e217691600bf90bb12435b0064959d4cbc9e5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: dwh build for 4.0.2
by Shirly Radco 26 Jul '16

26 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: dwh build for 4.0.2 ...................................................................... build: dwh build for 4.0.2 Change-Id: I0cbe7e2eb772d2d035d44d1b418fdeed9cb76c29 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cbe7e2eb772d2d035d44d1b418fdeed9cb76c29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: restapi: Add V3 support for disks detail
by oourfali＠redhat.com 26 Jul '16

26 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Add V3 support for disks detail ...................................................................... restapi: Add V3 support for disks detail Version 3 of the API supports a `detail` parameter that can be used to include inline details into certain objects. In particular it can be used to request details about the disks of a virtual machine: GET /ovirt-engine/api/vms Version: 3 Accept: application/xml; detail=disks This capability has been removed in version 4 of the API, but needs to be preserved in version 3, and it works for all the objects that it used to work, except for disks, because the "disks" collection has been replaced with "diskattachments". To fix this issue this patch moves the logic that handles the "detail" parameter to the V3 compatibility layer, where the "disks" collection still exists. Change-Id: Icac0bea3503b542e60edf61fad5da0a1af9bac19 Bug-Url: https://bugzilla.redhat.com/1358860 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit aad61b8c3c1911983c8851d7b04aa8ed67819d96) (cherry picked from commit 37e1269dd6fcb11958cd945875aa70ce6b43233f) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 5 files changed, 51 insertions(+), 17 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icac0bea3503b542e60edf61fad5da0a1af9bac19 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: restapi: Fix V3 VM and template disks collection links
by oourfali＠redhat.com 26 Jul '16

26 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix V3 VM and template disks collection links ...................................................................... restapi: Fix V3 VM and template disks collection links The "disks" collection has been replaced by "diskattachments" in version 4 of the API. As a result the V3 links for the "disks" collectin can't be reliably calculated. This patch changes the V3 layer so that it discards the links calculated by V4 and replaces them with the correct ones. Change-Id: Id01803427188b1b4a3fe008a0545468980241e8f Bug-Url: https://bugzilla.redhat.com/1358860 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8993ba46f25231e43e3ab56e1afc6c49c09ac1cd) (cherry picked from commit 26c0fad4b7ac0f13326030b119bff6b3de965cdf) --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3TemplateHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplateServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3TemplatesServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 11 files changed, 190 insertions(+), 87 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id01803427188b1b4a3fe008a0545468980241e8f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0