- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.2]: core: check if also switch type is in sync
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: check if also switch type is in sync ...................................................................... core: check if also switch type is in sync added new ReportedConfigurationType and updated NetworkInSyncWithVdsNetworkInterface so that switch type differences are taken into account and reported Bug-Url: https://bugzilla.redhat.com/1195208 Change-Id: I68f4cf0ce93123bef1e620193631afd707244170 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetNetworkAttachmentsByHostIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFiller.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/ReportedConfigurationsFillerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ReportedConfigurationType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterface.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkInSyncWithVdsNetworkInterfaceTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/NetworkImplementationDetailsUtils.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/BaseNetworkImplementationDetailsUtilsTest.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkOutOfSyncPanel.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 11 files changed, 242 insertions(+), 106 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f4cf0ce93123bef1e620193631afd707244170 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: Fix exception in general->software
by oourfali＠redhat.com 25 Jul '16

25 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix exception in general->software ...................................................................... webadmin: Fix exception in general->software - Fixed IOOB exception in Host->general->software sub sub tab. Change-Id: Id23b023c90000fc10003b658230ceef096194a91 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1359504 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Greg Sheremeta: Looks good to me, approved Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id23b023c90000fc10003b658230ceef096194a91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Fix exception in general->software
by oourfali＠redhat.com 25 Jul '16

25 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix exception in general->software ...................................................................... webadmin: Fix exception in general->software - Fixed IOOB exception in Host->general->software sub sub tab. Change-Id: Id23b023c90000fc10003b658230ceef096194a91 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1359504 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id23b023c90000fc10003b658230ceef096194a91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: new VM->select a template than blank fails
by oourfali＠redhat.com 25 Jul '16

25 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: new VM->select a template than blank fails ...................................................................... webadmin: new VM->select a template than blank fails There were 2 problems: - when a template without disks has been selected, the disk allocation was not updated - the setIsDisksAvailable was triggered before the disks have been set causing the listeners being executed with the old disks Change-Id: Ic59da6257f844d460c76b50f039d9c16d453aa60 Bug-Url: https://bugzilla.redhat.com/1351886 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic59da6257f844d460c76b50f039d9c16d453aa60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Add Hosted Engine VM detection
by sbonazzo＠redhat.com 25 Jul '16

25 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Add Hosted Engine VM detection ...................................................................... packaging: Add Hosted Engine VM detection Add code to detect if we're running under Hosted Engine VM and abort the setup if the system is not currently in the Global Maintenance mode. An override key of 'OVESETUP_CONFIG/continueSetupOnHEVM' was added to allow skipping this test. Change-Id: I26a291b8e31d41e92515a6f8df61c3847f0207e9 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1290073 --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/he.py 3 files changed, 133 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Objections: Yedidyah Bar David: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/60275 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a291b8e31d41e92515a6f8df61c3847f0207e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix exception in general->software
by awels＠redhat.com 25 Jul '16

25 Jul '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Fix exception in general->software ...................................................................... webadmin: Fix exception in general->software - Fixed IOOB exception in Host->general->software sub sub tab. Change-Id: Id23b023c90000fc10003b658230ceef096194a91 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1359504 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id23b023c90000fc10003b658230ceef096194a91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: virt-viewer with sso-token support required
by tjelinek＠redhat.com 25 Jul '16

25 Jul '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: virt-viewer with sso-token support required ...................................................................... core: virt-viewer with sso-token support required Upgraded value of 'RemoteViewerSupportedVersions' config option to require virt-viewers supporting 'sso-token' row in *.vv files. There is no build of virt-viewer for RHEL6 supporting 'sso-token' thus it is banned by unexisting high version number (https://bugzilla.redhat.com/1347656) Change-Id: I0f377b0765136a1958b16fa3198ae9833a621504 Bug-Url: https://bugzilla.redhat.com/1285883 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f377b0765136a1958b16fa3198ae9833a621504 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CreateAllSnapshotsFromVm - CreateAllCinderSnapshots ex...
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: CreateAllSnapshotsFromVm - CreateAllCinderSnapshots execution ...................................................................... core: CreateAllSnapshotsFromVm - CreateAllCinderSnapshots execution Currently CreateAllSnapshotsFromVm always executes CreateAllCinderSnapshots. The execution may lead to FK constraint violation - this patch alters the command to execute it only if the snapshot contains cinder disks. This fix is for 3.6 branch only, as cinder support is on tech preview on that version this patch fixes the issue for snapshot the includes image disks. On the master branch the code is very different so this issue isn't relevant. Change-Id: Iffb8fad4db3a2cea4000dff2491b40308cc2e986 Bug-Url: https://bugzilla.redhat.com/1357361 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 16 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/61316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb8fad4db3a2cea4000dff2491b40308cc2e986 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Packaging: spec: Make engine-setup require jre 1.8
by piotr.kliczewski＠gmail.com 25 Jul '16

25 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: Packaging: spec: Make engine-setup require jre 1.8 ...................................................................... Packaging: spec: Make engine-setup require jre 1.8 oVirt engine 3.6 could have worked with either jre 1.7 or 1.8. 4.0 requires 1.8. But engine-setup checks if required java version is available prior to upgrading the engine. So engine-setup will fail when upgrading from 3.6 with 1.7. Fix this by requiring the correct version by the package setup-plugin-ovirt-engine-common, which is where the check is done. Change-Id: I059daa2533e62ba3370608a507797f2b898f3235 Bug-Url: https://bugzilla.redhat.com/1350397 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 35f51a719f64ad4863eccc40bc32ba6061e56303) --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I059daa2533e62ba3370608a507797f2b898f3235 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: dal: Fix NUMA node deserialization
by oourfali＠redhat.com 25 Jul '16

25 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: dal: Fix NUMA node deserialization ...................................................................... dal: Fix NUMA node deserialization The List implementation returned by ResultSet#getArray causes deserialization issues in GWT. The list can be serialized and used in GWT but when deserializing it again in the backend this exception occures: Exception while dispatching incoming RPC call: java.lang.NumberFormatException: For input string: "undefined" To work around that the array in question is copied to a normal ArrayList. Change-Id: I5a32b219c091bb37c05b330547ddeeaa5c0e3d3a Bug-Url: https://bugzilla.redhat.com/1350861 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDaoImpl.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Roman Mohr: Verified Roy Golan: Looks good to me, approved Oved Ourfali: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a32b219c091bb37c05b330547ddeeaa5c0e3d3a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0