- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "restapi:fix overcommit accepts negative values"
by rgolan＠redhat.com 14 Jul '16

14 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: Revert "restapi:fix overcommit accepts negative values" ...................................................................... Revert "restapi:fix overcommit accepts negative values" This reverts commit d82d7133af6ee606270840aa55cc94c4302d36f5. Change-Id: I266797a2f059a37b33640a26fc091474423bb595 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClusterOperationCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 9 insertions(+), 86 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I266797a2f059a37b33640a26fc091474423bb595 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsm-jsonrpc-java: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm-jsonrpc-java: move from fc22 to fc24 ...................................................................... vdsm-jsonrpc-java: move from fc22 to fc24 - drop fc22 gone EOL - move master to fc24 Change-Id: I5af334c2b6fd3a59bb53d34e9f5a1017cec99dd3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_standard.yaml 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5af334c2b6fd3a59bb53d34e9f5a1017cec99dd3 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Update to model 4.0.27 and metamodel 1.0.16
by omachace＠redhat.com 14 Jul '16

14 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.0.27 and metamodel 1.0.16 ...................................................................... Update to model 4.0.27 and metamodel 1.0.16 The most relevant change in this version of the model is that the virtual machine and template "disks" collection has been replaced by the concept of "disk attachments", so the examples need to be modified accordingly. Change-Id: I6c25dc938b496aa938142e68025ba3561f161882 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 93afb42da9e89554b3be9e29c4feb459c815b2c7) --- M pom.xml M sdk/examples/add_vm_disk.py M sdk/examples/follow_vm_links.py M sdk/examples/list_vm_disks.py M sdk/lib/ovirtsdk4/__init__.py 5 files changed, 35 insertions(+), 29 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c25dc938b496aa938142e68025ba3561f161882 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Update to model 4.1.5 and metamodel 1.1.1
by omachace＠redhat.com 14 Jul '16

14 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.1.5 and metamodel 1.1.1 ...................................................................... Update to model 4.1.5 and metamodel 1.1.1 The most relevant change in this version of the model is that the virtual machine and template "disks" collection has been replaced by the concept of "disk attachments", so the examples need to be modified accordingly. Change-Id: I6c25dc938b496aa938142e68025ba3561f161882 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml M sdk/examples/add_vm_disk.py M sdk/examples/follow_vm_links.py M sdk/examples/list_vm_disks.py M sdk/lib/ovirtsdk4/__init__.py 5 files changed, 35 insertions(+), 29 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c25dc938b496aa938142e68025ba3561f161882 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-optimizer: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-optimizer: move from fc22 to fc24 ...................................................................... ovirt-optimizer: move from fc22 to fc24 - drop fc22 gone EOL - move master to fc24 Change-Id: I0065a226df3f6b7e96df377ab41d6bc5a1c22cf1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-optimizer/ovirt-optimizer_standard.yaml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0065a226df3f6b7e96df377ab41d6bc5a1c22cf1 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: continue refactoring VmInfoBuilder
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: continue refactoring VmInfoBuilder ...................................................................... core: continue refactoring VmInfoBuilder * Move VmInfoBuilder related classes to a separate package in order to define and enforce the proper visiblity. * Rename VmInfoBuilder to VmInfoBuilderImpl. * Extract VmInfoBuilder interface and make other classes to know only that. * Collapse VmInfoBuilder into its base class as that is the single existent derrivative. Change-Id: I9fa380ee56e74c46f8f6319ce4439563868506db Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/DiskImageByBootAndSnapshotComparator.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilder.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderFactory.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VnicProfileProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVmInterfaceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderFactoryTest.java 15 files changed, 816 insertions(+), 758 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa380ee56e74c46f8f6319ce4439563868506db Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: change labels ovirt-appliance build can run on
by eedri＠redhat.com 14 Jul '16

14 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: change labels ovirt-appliance build can run on ...................................................................... change labels ovirt-appliance build can run on Change-Id: I2e03a15a504a3d90c21ea4353ba77e4d598d6142 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests Anatoly Litovsky: Looks good to me -- To view, visit https://gerrit.ovirt.org/60736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e03a15a504a3d90c21ea4353ba77e4d598d6142 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: removing el7 checks from 3.6
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: removing el7 checks from 3.6 ...................................................................... removing el7 checks from 3.6 3.6 is EOL, and el6 is the most supported platform for it, so dropping el7 checks (keeping builds) to allow adding more tests on 4.0 and master Change-Id: I4077544e2f444275a6a21b98ca6aedf9eeca80b0 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4077544e2f444275a6a21b98ca6aedf9eeca80b0 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Filter orphaned Host Devieces on refresh
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: backend: Filter orphaned Host Devieces on refresh ...................................................................... backend: Filter orphaned Host Devieces on refresh In some hotplug scenarios (especially those related to SCSI devices) it can happen that libvirt reports to VDSM an internally inconsistent list of devices, namely that the parent_device points to a device not in the list or is empty altogether. Those cases violate the DB constraint imposed on the host_device and cause the RefreshHostDevicesCommand transaction to fail. Since those cases are impossible to handle at lower layers and we need to maintain consistend view of the host devices for our main business logic, we now ignore those invalid devices in the hostdev refresh cycle. Change-Id: I520d7b6cc7ef099da7b6a67381a7cdc8d2ae0e64 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315100 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommandTest.java 2 files changed, 118 insertions(+), 4 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I520d7b6cc7ef099da7b6a67381a7cdc8d2ae0e64 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix WELD-001410
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: engine: fix WELD-001410 ...................................................................... engine: fix WELD-001410 Make NumaValidator Singleton instead of ApplicationScoped. This fixes "WELD-001410: The injection point has non-proxyable dependencies". Change-Id: Ie747dda3d8664116ab8d766b60f40bca8ff10d95 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Arik Hadas: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/60741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie747dda3d8664116ab8d766b60f40bca8ff10d95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0