[JIRA] (OVIRT-1193) Re: Howto message for every gerrit review
by Martin Sivak (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jir... ]
Martin Sivak commented on OVIRT-1193:
-------------------------------------
> This is doable, but I think experienced users may find this annoying
> it ifs too long.
>
> I'm thinking it may be better to have such a message just suggesting
> to type something like '@ci help' to get the full help.
It does not have to be long, just a summary of all the links once when
the change is posted (so the links can contain the proper change id
and jenkins links).
I am actually more annoyed by the fact that I have to look for the information.
> It may even be possible to make it clickable with some trickery rather
> then just copy-and-paster ready (I will need to check if its possible
> to inject links into Gerrit comments).
That would be even better
> Apart from that, Roy offered to write a Gerrit plugin that will add
> buttons with the various CI commands.
That might work too, but I feel a bot sending a message is faster and
easier to do.
Martin
On Thu, Feb 23, 2017 at 2:18 PM, Barak Korren <bkorren(a)redhat.com> wrote:
> On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote:
>> Hi,
>>
>> do you think it would make sense to send a copy-and-paste ready
>> message with help to every new gerrit change?
>>
>> It could provide all the system test (lago) links, mention the Rerun
>> hooks syntax and so on. Just so we do not have to search for it all
>> the time?
>
> This is doable, but I think experienced users may find this annoying
> it ifs too long.
>
> I'm thinking it may be better to have such a message just suggesting
> to type something like '@ci help' to get the full help.
>
> It may even be possible to make it clickable with some trickery rather
> then just copy-and-paster ready (I will need to check if its possible
> to inject links into Gerrit comments).
>
> Apart from that, Roy offered to write a Gerrit plugin that will add
> buttons with the various CI commands.
>
> Adding infra-support to get a Jira ticket opened.
>
> --
> Barak Korren
> bkorren(a)redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/
> Re: Howto message for every gerrit review
> -----------------------------------------
>
> Key: OVIRT-1193
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193
> Project: oVirt - virtualization made easy
> Issue Type: By-EMAIL
> Components: Gerrit/git
> Reporter: Barak Korren
> Assignee: infra
>
> On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote:
> > Hi,
> >
> > do you think it would make sense to send a copy-and-paste ready
> > message with help to every new gerrit change?
> >
> > It could provide all the system test (lago) links, mention the Rerun
> > hooks syntax and so on. Just so we do not have to search for it all
> > the time?
> This is doable, but I think experienced users may find this annoying
> it ifs too long.
> I'm thinking it may be better to have such a message just suggesting
> to type something like '@ci help' to get the full help.
> It may even be possible to make it clickable with some trickery rather
> then just copy-and-paster ready (I will need to check if its possible
> to inject links into Gerrit comments).
> Apart from that, Roy offered to write a Gerrit plugin that will add
> buttons with the various CI commands.
> Adding infra-support to get a Jira ticket opened.
> --
> Barak Korren
> bkorren(a)redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/
--
This message was sent by Atlassian JIRA
(v1000.773.3#100032)
7 years, 9 months
[JIRA] (OVIRT-1193) Re: Howto message for every gerrit review
by Barak Korren (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jir... ]
Barak Korren updated OVIRT-1193:
--------------------------------
Component/s: Gerrit/git
> Re: Howto message for every gerrit review
> -----------------------------------------
>
> Key: OVIRT-1193
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193
> Project: oVirt - virtualization made easy
> Issue Type: By-EMAIL
> Components: Gerrit/git
> Reporter: Barak Korren
> Assignee: infra
>
> On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote:
> > Hi,
> >
> > do you think it would make sense to send a copy-and-paste ready
> > message with help to every new gerrit change?
> >
> > It could provide all the system test (lago) links, mention the Rerun
> > hooks syntax and so on. Just so we do not have to search for it all
> > the time?
> This is doable, but I think experienced users may find this annoying
> it ifs too long.
> I'm thinking it may be better to have such a message just suggesting
> to type something like '@ci help' to get the full help.
> It may even be possible to make it clickable with some trickery rather
> then just copy-and-paster ready (I will need to check if its possible
> to inject links into Gerrit comments).
> Apart from that, Roy offered to write a Gerrit plugin that will add
> buttons with the various CI commands.
> Adding infra-support to get a Jira ticket opened.
> --
> Barak Korren
> bkorren(a)redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/
--
This message was sent by Atlassian JIRA
(v1000.773.3#100032)
7 years, 9 months
[JIRA] (OVIRT-1193) Re: Howto message for every gerrit review
by Barak Korren (oVirt JIRA)
Barak Korren created OVIRT-1193:
-----------------------------------
Summary: Re: Howto message for every gerrit review
Key: OVIRT-1193
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193
Project: oVirt - virtualization made easy
Issue Type: By-EMAIL
Reporter: Barak Korren
Assignee: infra
On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote:
> Hi,
>
> do you think it would make sense to send a copy-and-paste ready
> message with help to every new gerrit change?
>
> It could provide all the system test (lago) links, mention the Rerun
> hooks syntax and so on. Just so we do not have to search for it all
> the time?
This is doable, but I think experienced users may find this annoying
it ifs too long.
I'm thinking it may be better to have such a message just suggesting
to type something like '@ci help' to get the full help.
It may even be possible to make it clickable with some trickery rather
then just copy-and-paster ready (I will need to check if its possible
to inject links into Gerrit comments).
Apart from that, Roy offered to write a Gerrit plugin that will add
buttons with the various CI commands.
Adding infra-support to get a Jira ticket opened.
--
Barak Korren
bkorren(a)redhat.com
RHCE, RHCi, RHV-DevOps Team
https://ifireball.wordpress.com/
--
This message was sent by Atlassian JIRA
(v1000.773.3#100032)
7 years, 9 months
[JIRA] (OVIRT-1154) Improve and automate the jenkins-whitelist mechanism
by Martin Sivak (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1154?page=com.atlassian.jir... ]
Martin Sivak commented on OVIRT-1154:
-------------------------------------
I am not opposed to Gerrit comments, but those need to be part of the message the user gets so we do not have to search for the right syntax. Barak asked me to paste my email about the matter here, so here you go:
> Btw, I just found a project that uses whitelist - kubernetes. But they
> make it very easy for maintainers to accept patches. Check for example
> this pull request: https://github.com/kubernetes/kubernetes/pull/41119
>
> The idea I like is that the CI will immediately tell me what needs to
> be done in the comments. No need to search through documentation for
> the right keyword.
>
> - The bot told the contributor who the relevant maintainers are,
> computed the list of people with enough permissions and notified them
> too. And just a comment by maintainer was needed to enable CI for the
> pull request.
> - The same for failing tests - they provide the command to retrigger
> it directly in the message
>
> It all basically boils down to "Do not make me think" approach.
> Everything that needs to be done is immediately obvious without
> searching. And that I could accept even with the whitelist enabled.
> Improve and automate the jenkins-whitelist mechanism
> ----------------------------------------------------
>
> Key: OVIRT-1154
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1154
> Project: oVirt - virtualization made easy
> Issue Type: Improvement
> Components: Jenkins
> Reporter: Barak Korren
> Assignee: infra
>
> Right now our white list is based on a text file with email addresses in it. Its kinda silly when we already have lists and groups of users in Gerrit.
> Some suggestions:
> * make any members of a project's "maintainers" group automatically white-listed
> * make a specific group for other white-listed people
--
This message was sent by Atlassian JIRA
(v1000.773.3#100032)
7 years, 9 months