[JIRA] (OVIRT-1296) review Rebase Always submit strategy on Gerrit
by Barak Korren (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1296?page=com.atlassian.jir... ]
Barak Korren edited comment on OVIRT-1296 at 5/1/17 10:12 PM:
--------------------------------------------------------------
We should close this ticket, i don`t think its gonna be useful for anything. Read my comment above.
'Rebase always' is just like 'Rebase when necessary' for all practical purposes, only it guarantees that the commit that ends up being merged will always be different then the one the developer that wrote it has locally. This will just be annoying.
was (Author: bkorren(a)redhat.com):
We should close this ticket, i don`t think its gonna be useful for anything. Read my comment above.
'Rebase always' is just like 'Rebase when necessary' fir all practical purposes, only it guarantees that the commit that ends up being merged will always be different then the one the developer that wrote it has locally. This will just be annoying.
> review Rebase Always submit strategy on Gerrit
> ----------------------------------------------
>
> Key: OVIRT-1296
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1296
> Project: oVirt - virtualization made easy
> Issue Type: Improvement
> Reporter: Evgheni Dereveanchin
> Assignee: infra
> Priority: Lowest
>
> A new submit strategy was included in recent builds of Gerrit: Rebase Always.
> [Docs|https://gerrit-review.googlesource.com/Documentation/project-configu...]:
> {quote}Basically, the same as Rebase If Necessary, but it creates a new patchset even if fast forward is possible AND like Cherry Pick it ensures footers such as Change-Id, Reviewed-On, and others are present in resulting commit that is merged.
> Thus, Rebase Always can be considered similar to Cherry Pick, but with the important distinction that Rebase Always does not ignore dependencies.{quote}
> It is only available in [2.14|https://gerrit.googlesource.com/gerrit/+/stable-2.14/gerrit-server/s...] while we are still at 2.12 and [2.13|https://gerrit.googlesource.com/gerrit/+/stable-2.13/gerrit-server/s...] is the current stable branch.
--
This message was sent by Atlassian JIRA
(v1000.929.1#100040)
7 years, 6 months
[JIRA] (OVIRT-1356) Fwd: ansible-suite-master failure
by Nadav Goldin (oVirt JIRA)
Nadav Goldin created OVIRT-1356:
-----------------------------------
Summary: Fwd: ansible-suite-master failure
Key: OVIRT-1356
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1356
Project: oVirt - virtualization made easy
Issue Type: By-EMAIL
Reporter: Nadav Goldin
Assignee: infra
+infra-support to open ticket.
This is the failure:
10:35:15 TASK [ovirt-deploy : Remove default datacenter]
********************************
10:35:18 An exception occurred during task execution. To see the full
traceback, use -vvv. The error was: TypeError: expected string or
buffer
10:35:18 fatal: [lago-ansible-suite-master-engine]: FAILED! =>
{"changed": false, "failed": true, "msg": "expected string or buffer"}
10:35:18 to retry, use: --limit
@/home/jenkins/workspace/ovirt-system-tests_master_check-patch-el7-x86_64/ovirt-system-tests/ansible-suite-master/engine.retry
10:35:18
10:35:18 PLAY RECAP
*********************************************************************
Replicated again in:
http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x8...
---------- Forwarded message ----------
From: Nadav Goldin <ngoldin(a)redhat.com>
Date: Sun, Apr 30, 2017 at 7:59 PM
Subject: ansible-suite-master failure
To: Ondra Machacek <omachace(a)redhat.com>
Cc: infra <infra(a)ovirt.org>
Hi Ondra,
By coincidence when working on a different patch [1] I noticed the
ansible suite is failing on the infra side, this should be fixed in
[2], but now it is failing[3] on something else:
16:46:27 TASK [ovirt-deploy : Remove default datacenter]
********************************
16:46:29 An exception occurred during task execution. To see the full
traceback, use -vvv. The error was: TypeError: expected string or
buffer
16:46:29 fatal: [lago-ansible-suite-master-engine]: FAILED! =>
{"changed": false, "failed": true, "msg": "expected string or buffer"}
16:46:29 to retry, use: --limit
@/home/jenkins/workspace/ovirt-system-tests_master_check-patch-el7-x86_64/ovirt-system-tests/ansible-suite-master/engine.retry
16:46:29
16:46:29 PLAY RECAP
*********************************************************************
16:46:29 lago-ansible-suite-master-engine : ok=14 changed=1
unreachable=0 failed=1
As the none-ansible suite is not failing, I assume this is something
on the ansible side, could you please take a look?
Thanks,
Nadav.
[1] https://gerrit.ovirt.org/#/c/76225
[2] https://gerrit.ovirt.org/#/c/76250
[3] http://jenkins.ovirt.org/job/ovirt-system-tests_master_check-patch-el7-x8...
--
This message was sent by Atlassian JIRA
(v1000.929.1#100040)
7 years, 6 months