[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by eedri (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jir... ]
eedri commented on OVIRT-1500:
------------------------------
bq. CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?
The current configuration skips any change that doesn't include 'code change':
"Exclude changes without code change from triggering build
If set, this will ignore any patchset which Gerrit considers without any code changes from triggering this build. These patches did not contain any differences in code from the previous patchset and did not change the parent commit.
"
So i'm not sure which inheritance are you reffering to, CI shouldn't run on patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no?
> CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
> -------------------------------------------------------------------
>
> Key: OVIRT-1500
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Gerrit/git, oVirt CI
> Reporter: Allon Mureinik
> Assignee: infra
>
> In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit.
> Looking through gerrit's history, here's what I *think* is going on:
> 08:41 - patchset #1 is submitted
> 08:41 - CI (check-patch) starts for both EL7 and fc25
> _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_
> 08:42 - patchset #2 is submitted
> _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_
> 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason.
> Expected behavior:
> If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)
7 years, 4 months
[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Gil Shinar (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jir... ]
Gil Shinar commented on OVIRT-1500:
-----------------------------------
Saw it before. If the results of a certain patchset comes after the user has sent a new patchset, the CI will not get +1. All jobs should be retriggered for it to get the +1
> CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
> -------------------------------------------------------------------
>
> Key: OVIRT-1500
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Gerrit/git, oVirt CI
> Reporter: Allon Mureinik
> Assignee: infra
>
> In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit.
> Looking through gerrit's history, here's what I *think* is going on:
> 08:41 - patchset #1 is submitted
> 08:41 - CI (check-patch) starts for both EL7 and fc25
> _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_
> 08:42 - patchset #2 is submitted
> _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_
> 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason.
> Expected behavior:
> If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)
7 years, 4 months
[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jir... ]
Allon Mureinik updated OVIRT-1500:
----------------------------------
Description:
In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit.
Looking through gerrit's history, here's what I *think* is going on:
08:41 - patchset #1 is submitted
08:41 - CI (check-patch) starts for both EL7 and fc25
_At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_
08:42 - patchset #2 is submitted
_CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_
09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason.
Expected behavior:
If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.
was:
In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit.
Looking through gerrit's history, here's what I *think* is going on:
08:41 - patchset #1 is submitted
08:41 - CI (check-patch) starts for both EL7 and fc25
* At this point I noticed a typo in the commit method. I fixed it and posted patchset #2 *
08:42 - patchset #2 is submitted
* CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message ? *
09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason.
Expected behavior:
If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.
> CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
> -------------------------------------------------------------------
>
> Key: OVIRT-1500
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Gerrit/git, oVirt CI
> Reporter: Allon Mureinik
> Assignee: infra
>
> In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit.
> Looking through gerrit's history, here's what I *think* is going on:
> 08:41 - patchset #1 is submitted
> 08:41 - CI (check-patch) starts for both EL7 and fc25
> _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_
> 08:42 - patchset #2 is submitted
> _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_
> 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason.
> Expected behavior:
> If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)
7 years, 4 months
[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA)
Allon Mureinik created OVIRT-1500:
-------------------------------------
Summary: CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
Key: OVIRT-1500
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500
Project: oVirt - virtualization made easy
Issue Type: Bug
Components: Gerrit/git, oVirt CI
Reporter: Allon Mureinik
Assignee: infra
In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit.
Looking through gerrit's history, here's what I *think* is going on:
08:41 - patchset #1 is submitted
08:41 - CI (check-patch) starts for both EL7 and fc25
* At this point I noticed a typo in the commit method. I fixed it and posted patchset #2 *
08:42 - patchset #2 is submitted
* CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message ? *
09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason.
Expected behavior:
If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)
7 years, 4 months
[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jir... ]
Allon Mureinik updated OVIRT-1500:
----------------------------------
Epic Link: OVIRT-400
> CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
> -------------------------------------------------------------------
>
> Key: OVIRT-1500
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Gerrit/git, oVirt CI
> Reporter: Allon Mureinik
> Assignee: infra
>
> In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit.
> Looking through gerrit's history, here's what I *think* is going on:
> 08:41 - patchset #1 is submitted
> 08:41 - CI (check-patch) starts for both EL7 and fc25
> * At this point I noticed a typo in the commit method. I fixed it and posted patchset #2 *
> 08:42 - patchset #2 is submitted
> * CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message ? *
> 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason.
> Expected behavior:
> If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited.
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)
7 years, 4 months
[JIRA] (OVIRT-1097) review ovirt snapshot static repos and remove not needed RPMs
by eedri (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1097?page=com.atlassian.jir... ]
eedri reassigned OVIRT-1097:
----------------------------
Assignee: eedri (was: infra)
> review ovirt snapshot static repos and remove not needed RPMs
> -------------------------------------------------------------
>
> Key: OVIRT-1097
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1097
> Project: oVirt - virtualization made easy
> Issue Type: Task
> Reporter: eedri
> Assignee: eedri
> Priority: High
>
> We should aim to drop the static repos, any RPMs oVirt needs should come from one of the following sources:
> 1. Built in standard CI via build artifacts job
> 2. If its external, then we need to use the origin repo and not copy it to be on oVirt.
> We can start from master and move to stable versions when its verified.
> existing RPMS on master static: (showing el7 as most OS should be similar )
> .
> ├── noarch
> │ ├── ebay-cors-filter-1.0.1-3.el7.noarch.rpm
> │ ├── ebay-cors-filter-javadoc-1.0.1-3.el7.noarch.rpm
> │ ├── nsis-simple-service-plugin-1.30-1.noarch.rpm
> │ ├── openvswitch-selinux-policy-2.6.90-1.el7.centos.noarch.rpm
> │ ├── openvswitch-test-2.6.90-1.el7.centos.noarch.rpm
> │ ├── ovirt-engine-wildfly-overlay-10.0.0-1.el7.noarch.rpm
> │ ├── python-openvswitch-2.6.90-1.el7.centos.noarch.rpm
> │ ├── rubygem-fluent-plugin-rewrite-tag-filter-1.5.5-1.el7.centos.noarch.rpm
> │ └── rubygem-fluent-plugin-rewrite-tag-filter-doc-1.5.5-1.el7.centos.noarch.rpm
> ├── ppc64
> │ ├── python-cpopen-1.3-4.el7.ppc64.rpm
> │ └── python-cpopen-debuginfo-1.3-4.el7.ppc64.rpm
> ├── ppc64le
> ├── repodata
> │ ├── 008d859bb942a115e9b0077bd65c84f49e5a01eca2209ad393c27a036237783f-filelists.xml.gz
> │ ├── 14a142882a77ec4120c34a7d88dd69bdcf9463915c34d0f139fe6a9f01a78ca5-filelists.sqlite.bz2
> │ ├── 3299fdf213c4ee0e8bea41142691d1ab861496291a2302dfa32a7247eb43660c-primary.xml.gz
> │ ├── 648a0a77bce1ba70babe4c8f5ac90b8f4b89103f8fa429903d572022066367be-primary.sqlite.bz2
> │ ├── 715d2c608d40b1982b5a02c1c98bc6fca827e46d260849afc8eec6ad928caa6f-other.xml.gz
> │ ├── f54bf13a0e486128a9bc41a975e4ecf597b553c47a7cdb70c169ce8c042c3b94-other.sqlite.bz2
> │ └── repomd.xml
> ├── SRPMS
> │ ├── ebay-cors-filter-1.0.1-3.el7.src.rpm
> │ ├── nsis-simple-service-plugin-1.30-1.src.rpm
> │ ├── openvswitch-2.6.90-1.el7.centos.src.rpm
> │ ├── ovirt-engine-wildfly-10.1.0-1.el7.src.rpm
> │ ├── ovirt-engine-wildfly-overlay-10.0.0-1.el7.src.rpm
> │ ├── ovirt-web-ui-0.1.0-4.el7.centos.src.rpm
> │ ├── ovirt-web-ui-0.1.1-2.el7.centos.src.rpm
> │ ├── repodata
> │ │ ├── 1f13684ed34daa19755884e49132dcee7b60eafd38b52a51f945a92e63459e65-filelists.xml.gz
> │ │ ├── 3f20e34cc666f1df8667288b5cdf3eb449fed6ab8b032e1a0d9be0fc78d53b56-primary.sqlite.bz2
> │ │ ├── 7e260234efc35f032a0d22f976d17758b28555566d742c04911a4758c3552db1-primary.xml.gz
> │ │ ├── 87cdc086330908e1dc39ca53c50eb9b6ba3627b2b562e0d278a0e899fd925167-other.xml.gz
> │ │ ├── e2cb0de1abd9d51f783862d7d498ead766a96261dd942230f0182afee7195bdb-other.sqlite.bz2
> │ │ ├── ed15cb166756bbf49aecd3f8e65ca0da96ca860d64e4fc80a141280a9114e5ee-filelists.sqlite.bz2
> │ │ └── repomd.xml
> │ ├── rubygem-fluent-plugin-rewrite-tag-filter-1.5.5-1.el7.centos.src.rpm
> │ └── vhostmd-0.5-11.el7.src.rpm
> └── x86_64
> ├── openvswitch-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-debuginfo-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-devel-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-central-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-common-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-docker-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-host-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-vtep-2.6.90-1.el7.centos.x86_64.rpm
> ├── ovirt-engine-wildfly-10.1.0-1.el7.x86_64.rpm
> ├── ovirt-web-ui-0.1.0-4.el7.centos.x86_64.rpm
> ├── ovirt-web-ui-0.1.1-2.el7.centos.x86_64.rpm
> ├── vhostmd-0.5-11.el7.x86_64.rpm
> ├── vhostmd-debuginfo-0.5-11.el7.x86_64.rpm
> ├── vm-dump-metrics-0.5-11.el7.x86_64.rpm
> └── vm-dump-metrics-devel-0.5-11.el7.x86_64.rpm
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)
7 years, 4 months
[JIRA] (OVIRT-1097) review ovirt snapshot static repos and remove not needed RPMs
by eedri (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1097?page=com.atlassian.jir... ]
eedri updated OVIRT-1097:
-------------------------
Priority: High (was: Medium)
> review ovirt snapshot static repos and remove not needed RPMs
> -------------------------------------------------------------
>
> Key: OVIRT-1097
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1097
> Project: oVirt - virtualization made easy
> Issue Type: Task
> Reporter: eedri
> Assignee: infra
> Priority: High
>
> We should aim to drop the static repos, any RPMs oVirt needs should come from one of the following sources:
> 1. Built in standard CI via build artifacts job
> 2. If its external, then we need to use the origin repo and not copy it to be on oVirt.
> We can start from master and move to stable versions when its verified.
> existing RPMS on master static: (showing el7 as most OS should be similar )
> .
> ├── noarch
> │ ├── ebay-cors-filter-1.0.1-3.el7.noarch.rpm
> │ ├── ebay-cors-filter-javadoc-1.0.1-3.el7.noarch.rpm
> │ ├── nsis-simple-service-plugin-1.30-1.noarch.rpm
> │ ├── openvswitch-selinux-policy-2.6.90-1.el7.centos.noarch.rpm
> │ ├── openvswitch-test-2.6.90-1.el7.centos.noarch.rpm
> │ ├── ovirt-engine-wildfly-overlay-10.0.0-1.el7.noarch.rpm
> │ ├── python-openvswitch-2.6.90-1.el7.centos.noarch.rpm
> │ ├── rubygem-fluent-plugin-rewrite-tag-filter-1.5.5-1.el7.centos.noarch.rpm
> │ └── rubygem-fluent-plugin-rewrite-tag-filter-doc-1.5.5-1.el7.centos.noarch.rpm
> ├── ppc64
> │ ├── python-cpopen-1.3-4.el7.ppc64.rpm
> │ └── python-cpopen-debuginfo-1.3-4.el7.ppc64.rpm
> ├── ppc64le
> ├── repodata
> │ ├── 008d859bb942a115e9b0077bd65c84f49e5a01eca2209ad393c27a036237783f-filelists.xml.gz
> │ ├── 14a142882a77ec4120c34a7d88dd69bdcf9463915c34d0f139fe6a9f01a78ca5-filelists.sqlite.bz2
> │ ├── 3299fdf213c4ee0e8bea41142691d1ab861496291a2302dfa32a7247eb43660c-primary.xml.gz
> │ ├── 648a0a77bce1ba70babe4c8f5ac90b8f4b89103f8fa429903d572022066367be-primary.sqlite.bz2
> │ ├── 715d2c608d40b1982b5a02c1c98bc6fca827e46d260849afc8eec6ad928caa6f-other.xml.gz
> │ ├── f54bf13a0e486128a9bc41a975e4ecf597b553c47a7cdb70c169ce8c042c3b94-other.sqlite.bz2
> │ └── repomd.xml
> ├── SRPMS
> │ ├── ebay-cors-filter-1.0.1-3.el7.src.rpm
> │ ├── nsis-simple-service-plugin-1.30-1.src.rpm
> │ ├── openvswitch-2.6.90-1.el7.centos.src.rpm
> │ ├── ovirt-engine-wildfly-10.1.0-1.el7.src.rpm
> │ ├── ovirt-engine-wildfly-overlay-10.0.0-1.el7.src.rpm
> │ ├── ovirt-web-ui-0.1.0-4.el7.centos.src.rpm
> │ ├── ovirt-web-ui-0.1.1-2.el7.centos.src.rpm
> │ ├── repodata
> │ │ ├── 1f13684ed34daa19755884e49132dcee7b60eafd38b52a51f945a92e63459e65-filelists.xml.gz
> │ │ ├── 3f20e34cc666f1df8667288b5cdf3eb449fed6ab8b032e1a0d9be0fc78d53b56-primary.sqlite.bz2
> │ │ ├── 7e260234efc35f032a0d22f976d17758b28555566d742c04911a4758c3552db1-primary.xml.gz
> │ │ ├── 87cdc086330908e1dc39ca53c50eb9b6ba3627b2b562e0d278a0e899fd925167-other.xml.gz
> │ │ ├── e2cb0de1abd9d51f783862d7d498ead766a96261dd942230f0182afee7195bdb-other.sqlite.bz2
> │ │ ├── ed15cb166756bbf49aecd3f8e65ca0da96ca860d64e4fc80a141280a9114e5ee-filelists.sqlite.bz2
> │ │ └── repomd.xml
> │ ├── rubygem-fluent-plugin-rewrite-tag-filter-1.5.5-1.el7.centos.src.rpm
> │ └── vhostmd-0.5-11.el7.src.rpm
> └── x86_64
> ├── openvswitch-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-debuginfo-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-devel-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-central-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-common-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-docker-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-host-2.6.90-1.el7.centos.x86_64.rpm
> ├── openvswitch-ovn-vtep-2.6.90-1.el7.centos.x86_64.rpm
> ├── ovirt-engine-wildfly-10.1.0-1.el7.x86_64.rpm
> ├── ovirt-web-ui-0.1.0-4.el7.centos.x86_64.rpm
> ├── ovirt-web-ui-0.1.1-2.el7.centos.x86_64.rpm
> ├── vhostmd-0.5-11.el7.x86_64.rpm
> ├── vhostmd-debuginfo-0.5-11.el7.x86_64.rpm
> ├── vm-dump-metrics-0.5-11.el7.x86_64.rpm
> └── vm-dump-metrics-devel-0.5-11.el7.x86_64.rpm
--
This message was sent by Atlassian JIRA
(v1000.1092.1#100053)
7 years, 4 months