12:56 p.m.
------=_Part_15512153_114164037.1465293395010
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
----- Original Message -----
From: "Martin Perina" <mperina(a)redhat.com>
To: "Eli Mesika" <emesika(a)redhat.com>
Cc: "Eyal Edri" <eedri(a)redhat.com>, "infra"
<infra(a)ovirt.org>
Sent: Tuesday, June 7, 2016 11:45:28 AM
Subject: Re: Duplicate upgrade scripts issue
On Tue, Jun 7, 2016 at 11:42 AM, Eli Mesika < emesika(a)redhat.com
> wrote:
> Ha , one more thing :
=20
> We would like to force the existence of such hooks if possible
...
=20
=E2=80=8B+1
The hook should be included by default after git clone=E2=80=8B if
possib=
le. And if
it's then I'd also force inclusion of commit message hook
which generates
change-id
Git does not allow 'autodownloading' hooks, you can't distribute them by gi=
t clone, the client must explicitly install them herself=20
> On Tue, Jun 7, 2016 at 12:41 PM, Eli Mesika <
emesika(a)redhat.com > wrot=
e:
=20
> > > Hi guys
> =20
=20
> > I have talked with Eyal about the $Subject and he asked me
to write a=
nd
> > > send
> > > this email
> =20
=20
> > As you probably know, we have from time to time an issue
with duplica=
te
> > upgrade scripts that are merged by mistake, each such issue
forces us=
to
> > > publish a fixing patch that renames the duplicated file.
> =20
=20
> > > I was discussed
this issue today with Marin P on out weekly meeting
> =20
=20
> > We would like to write some kind of a hook that will check
on each pa=
tch
> > set
> > if it has DB upgrade files and rename them (if necessary) such that i=
t
> > will
> > have the correct numbering according to the last existing upgrade pat=
ch
> > > on
> > > the related branch.
> =20
=20
> > The hook should be done upon 'git push' request so
it will also preve=
nt
> > > CI
> > > tests to fail on this issue
> =20
=20
> > > I will be happy to get your ideas/comments on that
> =20
=20
> > > Thanks
> =20
=20
> > > Eli Mesika
> =20
=20
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
------=_Part_15512153_114164037.1465293395010
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable
<html><body><div style=3D"font-family: times new roman, new york,
times, se=
rif; font-size: 12pt; color:
#000000"><div><br></div><div><br></div><hr
id=
=3D"zwchr"><blockquote style=3D"border-left:2px solid
#1010FF;margin-left:5=
px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-de=
coration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>Fr=
om: </b>"Martin Perina"
&lt;mperina(a)redhat.com&gt;<br><b>To: </b>"Eli Mesik=
a" &lt;emesika(a)redhat.com&gt;<br><b>Cc: </b>"Eyal
Edri" &lt;eedri(a)redhat.co=
m>, "infra" &lt;infra(a)ovirt.org&gt;<br><b>Sent:
</b>Tuesday, June 7, 201=
6 11:45:28 AM<br><b>Subject: </b>Re: Duplicate upgrade scripts
issue<br><di=
v><br></div><div dir=3D"ltr"><div
class=3D"gmail_default" style=3D"font-fam=
ily:arial,helvetica,sans-serif"><br></div><div
class=3D"gmail_extra"><br><d=
iv class=3D"gmail_quote">On Tue, Jun 7, 2016 at 11:42 AM, Eli Mesika <span
=
dir=3D"ltr"><<a href=3D"mailto:emesika@redhat.com"
target=3D"_blank">eme=
sika(a)redhat.com</a>&gt;</span> wrote:<br><blockquote
class=3D"gmail_quote" =
style=3D"margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex"><di=
v dir=3D"ltr"><div style=3D"font-size:large">Ha , one more
thing :<br><div>=
<br></div></div><div style=3D"font-size:large">We would
like to force the e=
xistence of such hooks if possible
...<br></div></div></blockquote><div><br=
<div class=3D"gmail_default"
style=3D"font-family:arial,helvetica,sans-ser=
if;display:inline">=E2=80=8B+1<br><div><br></div></div><div
class=3D"gmail_=
default"
style=3D"font-family:arial,helvetica,sans-serif;display:inline">Th=
e hook should be included by default after git clone=E2=80=8B if possible. =
And if it's then I'd also force inclusion of commit message hook which gene=
rates
change-id</div></div></div></div></div></blockquote><div><br></div><d=
iv><br>Git does not allow 'autodownloading' hooks, you can't
distribute the=
m by git clone, the client must explicitly install them
herself<br></div><d=
iv><br></div><blockquote style=3D"border-left:2px solid
#1010FF;margin-left=
:5px;padding-left:5px;color:#000;font-weight:normal;font-style:normal;text-=
decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><di=
v dir=3D"ltr"><div class=3D"gmail_extra"><div
class=3D"gmail_quote"><div><d=
iv class=3D"gmail_default"
style=3D"font-family:arial,helvetica,sans-serif;=
display:inline"><br><div><br></div></div></div><blockquote
class=3D"gmail_q=
uote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1e=
x"><div class=3D"gmail_extra"><br><div
class=3D"gmail_quote">On Tue, Jun 7,=
2016 at 12:41 PM, Eli Mesika <span dir=3D"ltr"><<a
href=3D"mailto:emesi=
ka(a)redhat.com"
target=3D"_blank">emesika(a)redhat.com</a>&gt;</span>
wrote:<b=
r><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0
.8ex;border-left:=
1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div
style=3D"font-size:l=
arge">Hi guys <br><div><br></div></div><div
style=3D"font-size:large">I hav=
e talked with Eyal about the $Subject and he asked me to write and send thi=
s email <br><div><br></div></div><div
style=3D"font-size:large">As you prob=
ably know, we have from time to time an issue with duplicate upgrade script=
s that are merged by mistake, each such issue forces us to publish a fixing=
patch that renames the duplicated file.<br></div><div
style=3D"font-size:l=
arge">I was discussed this issue today with Marin P on out weekly meeting <=
br><div><br></div></div><div
style=3D"font-size:large">We would like to wri=
te some kind of a hook that will check on each patch set if it has DB upgra=
de files and rename them (if necessary) such that it will have the correct =
numbering according to the last existing upgrade patch on the related branc=
h.<br><div><br></div></div><div
style=3D"font-size:large">The hook should b=
e done upon 'git push' request so it will also prevent CI tests to fail on =
this issue <br></div><div
style=3D"font-size:large"><br></div><div style=3D=
"font-size:large">I will be happy to get your ideas/comments on that
<br><d=
iv><br></div></div><div
style=3D"font-size:large">Thanks <br><span><span st=
yle=3D"color: #888888;" data-mce-style=3D"color: #888888;"
color=3D"#888888=
"><br></span></span></div><span><span
style=3D"color: #888888;" data-mce-st=
yle=3D"color: #888888;" color=3D"#888888"><div
style=3D"font-size:large">El=
i Mesika
<br></div></span></span></div></blockquote></div><br></div></block=
quote></div><br></div></div><br>___________________________________________=
____<br>Infra mailing
list<br>Infra@ovirt.org<br>http://lists.ovirt.org/mai=
lman/listinfo/infra<br></blockquote><div><br></div></div></body></html>
------=_Part_15512153_114164037.1465293395010--