[JIRA] (OVIRT-1895) CI votes not forwarded on commit message change

Wednesday, 14 February 2018

This is a multi-part message in MIME format...

------------=_1518592365-27516-116
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

     [
https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=com.atlassian.jir...
]

Barak Korren updated OVIRT-1895:
--------------------------------
    Component/s: Gerrit/git
      Epic Link: OVIRT-400
     Issue Type: Bug  (was: By-EMAIL)

...
 CI votes not forwarded on commit message change
 -----------------------------------------------

                 Key: OVIRT-1895
                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
             Project: oVirt - virtualization made easy
          Issue Type: Bug
          Components: Gerrit/git
            Reporter: Yedidyah Bar David
            Assignee: infra

 Hi all,
 If a change goes through this flow:
 1. Push an update N
 2. CI triggers check-patch for N
 3. Push another update N+1 that changes only commit message
 4. CI marks +1 N
 Then we have logic to not trigger CI for N+1 (with the assumption that
 a change to commit message should not affect the result), but also do
 not mark +1 N+1, leaving the patch unmarked.
 We should either forward the +1, when giving it, to all consecutive
 future patchsets that only changed the commit message, or give up on
 the optimization and always trigger CI.
 As an example, see:
 https://gerrit.ovirt.org/87515
 Best regards,
 -- 
 Didi 

--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100079)

------------=_1518592365-27516-116
Content-Type: text/html; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

<html><body>
<pre>[
https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=com.atlassian.jir...
]</pre>
<h3>Barak Korren updated OVIRT-1895:</h3>
<pre>Component/s: Gerrit/git
  Epic Link: OVIRT-400
 Issue Type: Bug  (was: By-EMAIL)</pre>
<blockquote><h3>CI votes not forwarded on commit message change</h3>
<pre>     Key: OVIRT-1895
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
 Project: oVirt - virtualization made easy
         Issue Type: Bug
         Components: Gerrit/git
Reporter: Yedidyah Bar David
Assignee: infra</pre>
<p>Hi all, If a change goes through this flow:</p>
<ol><li><p>Push an update N</p></li>
<li><p>CI triggers check-patch for N</p></li>
<li><p>Push another update N+1 that changes only commit
message</p></li>
<li><p>CI marks +1 N</p></li></ol>
<p>Then we have logic to not trigger CI for N+1 (with the assumption that a change
to commit message should not affect the result), but also do not mark +1 N+1, leaving the
patch unmarked. We should either forward the +1, when giving it, to all consecutive future
patchsets that only changed the commit message, or give up on the optimization and always
trigger CI. As an example, see: <a
href="https://gerrit.ovirt.org/87515">https://gerrit.ovirt.o...
Best regards, &mdash; Didi</p></blockquote>
<p>&mdash; This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100079)</p>

------------=_1518592365-27516-116--

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011