[JIRA] (OVIRT-1000) Java SDK 4.1 branch don't execute jenkins jobs
by Juan Hernández (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1000?page=com.atlassian.jir... ]
Juan Hernández commented on OVIRT-1000:
---------------------------------------
Having the project and the RPM named the same is a price that I would't like to pay. This has always been the case, even before the introduction of V4. The name of the Python SDK, for example was ovirt-engine-sdk, but the name of the RPM was ovirt-engine-sdk-python. For the Ruby SDK (which only has V4) the name is also different: the repo is ovirt-engine-sdk-ruby but the name of the RPM is rubygem-ovirt-engine-sdk4. We can't (or should not) force projects to adopt the names that the distribution packaging requires.
> Java SDK 4.1 branch don't execute jenkins jobs
> ----------------------------------------------
>
> Key: OVIRT-1000
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1000
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Jenkins
> Reporter: Ondra Machacek
> Assignee: infra
>
> Jenkins job are not still executed from sdk_4.1 branch of the Java SDK project,
> you can see an example here: https://gerrit.ovirt.org/#/c/69455/1
> I've created a patch[1] which I think should fix build-artifacts job, not sure about check-patch job.
> [1] https://gerrit.ovirt.org/#/c/69459/
--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
7 years, 11 months
[JIRA] (OVIRT-1000) Java SDK 4.1 branch don't execute jenkins jobs
by Juan Hernández (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1000?page=com.atlassian.jir... ]
Juan Hernández commented on OVIRT-1000:
---------------------------------------
No objection from my side then. Let me insist that what I would like is to preserve the existing ovirt-engine-sdk and ovirt-engine-sdk-java git repositories for V4, and create new repositories for the old V3. If you agree with that, then proceed to create the new repositories and I will take ownership of the rest of required changes. I will however need your help if there is something that I don't know how to handle.
> Java SDK 4.1 branch don't execute jenkins jobs
> ----------------------------------------------
>
> Key: OVIRT-1000
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1000
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Jenkins
> Reporter: Ondra Machacek
> Assignee: infra
>
> Jenkins job are not still executed from sdk_4.1 branch of the Java SDK project,
> you can see an example here: https://gerrit.ovirt.org/#/c/69455/1
> I've created a patch[1] which I think should fix build-artifacts job, not sure about check-patch job.
> [1] https://gerrit.ovirt.org/#/c/69459/
--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
7 years, 11 months
[JIRA] (OVIRT-1000) Java SDK 4.1 branch don't execute jenkins jobs
by Juan Hernández (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1000?page=com.atlassian.jir... ]
Juan Hernández commented on OVIRT-1000:
---------------------------------------
I am OK with separating the repositories. My only concern is preserving the existing repositories for V4, as doing otherwise would disrupt the development in the current active branches (V4 is active, V3 isn't). [~gshinar] told me that creating new repositories for V3 won't solve the problem. My understanding is that the problem is solved if we have different repositories for both versions, no matter if the new ones are for V3 or V4. I also understand that creating new repositories for the old versions may involve more work, maybe renaming or updating more jobs. I am open to pay that price. Lets say that we create the new two git repositories:
ovirt-engine-sdk-v3 - For V3 of the Python SDK.
ovirt-engine-sdk-java-v3 - For V3 of the Java SDK
The existing jobs will need to be updated so that they only build V4, and then new jobs will need to be created to build V3. Am I missing something?
> Java SDK 4.1 branch don't execute jenkins jobs
> ----------------------------------------------
>
> Key: OVIRT-1000
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1000
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Jenkins
> Reporter: Ondra Machacek
> Assignee: infra
>
> Jenkins job are not still executed from sdk_4.1 branch of the Java SDK project,
> you can see an example here: https://gerrit.ovirt.org/#/c/69455/1
> I've created a patch[1] which I think should fix build-artifacts job, not sure about check-patch job.
> [1] https://gerrit.ovirt.org/#/c/69459/
--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
7 years, 11 months
[JIRA] (OVIRT-1000) Java SDK 4.1 branch don't execute jenkins jobs
by eyal edri [Administrator] (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1000?page=com.atlassian.jir... ]
eyal edri [Administrator] commented on OVIRT-1000:
--------------------------------------------------
[~juan@redhat.com][~omachace(a)redhat.com] we have too many hacks right now to make SDK work on the same repos for V3 and V4.
We can't continue to do it as you see it generate problems.
We need to decide on a split of repos so each project will have its own repo ( it already has its own name and differnet rpm version ).
otherwise we're bound to keep hitting issues with this setup.
> Java SDK 4.1 branch don't execute jenkins jobs
> ----------------------------------------------
>
> Key: OVIRT-1000
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1000
> Project: oVirt - virtualization made easy
> Issue Type: Bug
> Components: Jenkins
> Reporter: Ondra Machacek
> Assignee: infra
>
> Jenkins job are not still executed from sdk_4.1 branch of the Java SDK project,
> you can see an example here: https://gerrit.ovirt.org/#/c/69455/1
> I've created a patch[1] which I think should fix build-artifacts job, not sure about check-patch job.
> [1] https://gerrit.ovirt.org/#/c/69459/
--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
7 years, 11 months
[JIRA] (OVIRT-990) Re: Gerrit don't check for "Signed-Off" anymore
by eyal edri [Administrator] (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-990?page=com.atlassian.jira... ]
eyal edri [Administrator] updated OVIRT-990:
--------------------------------------------
Resolution: Fixed
Status: Done (was: To Do)
> Re: Gerrit don't check for "Signed-Off" anymore
> -----------------------------------------------
>
> Key: OVIRT-990
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-990
> Project: oVirt - virtualization made easy
> Issue Type: By-EMAIL
> Reporter: eyal edri [Administrator]
> Assignee: Shlomo Ben David
>
> On Wed, Dec 28, 2016 at 11:42 AM, Tal Nisan <tnisan(a)redhat.com> wrote:
> > Last night I've push a serious of patches and forgot to sign off, up until
> > not long ago there was a hook that enforces that but it seems like it's not
> > working anymore and I was able to push the patches without the sign off:
> > https://gerrit.ovirt.org/#/c/69219/1
> >
> >
> Its not a hook, its a definition per project, each project has the
> defenition if to enforce signed-off commit:
> 'Require Signed-off-by in commit message:' - and its on TRUE now for
> ovirt-engine, so I'm not sure how its possible that a patch got in, we'll
> need to check gerrit logs to see.
> Opening a ticket on it.
> >
> > _______________________________________________
> > Infra mailing list
> > Infra(a)ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R&D
> Red Hat Israel
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
7 years, 11 months
[JIRA] (OVIRT-990) Re: Gerrit don't check for "Signed-Off" anymore
by Tal Nisan (oVirt JIRA)
[ https://ovirt-jira.atlassian.net/browse/OVIRT-990?page=com.atlassian.jira... ]
Tal Nisan commented on OVIRT-990:
---------------------------------
Tested yesterday and it seems to be working OK, can close
On Tue, Jan 3, 2017 at 9:56 AM, eyal edri [Administrator] (oVirt JIRA) <
> Re: Gerrit don't check for "Signed-Off" anymore
> -----------------------------------------------
>
> Key: OVIRT-990
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-990
> Project: oVirt - virtualization made easy
> Issue Type: By-EMAIL
> Reporter: eyal edri [Administrator]
> Assignee: Shlomo Ben David
>
> On Wed, Dec 28, 2016 at 11:42 AM, Tal Nisan <tnisan(a)redhat.com> wrote:
> > Last night I've push a serious of patches and forgot to sign off, up until
> > not long ago there was a hook that enforces that but it seems like it's not
> > working anymore and I was able to push the patches without the sign off:
> > https://gerrit.ovirt.org/#/c/69219/1
> >
> >
> Its not a hook, its a definition per project, each project has the
> defenition if to enforce signed-off commit:
> 'Require Signed-off-by in commit message:' - and its on TRUE now for
> ovirt-engine, so I'm not sure how its possible that a patch got in, we'll
> need to check gerrit logs to see.
> Opening a ticket on it.
> >
> > _______________________________________________
> > Infra mailing list
> > Infra(a)ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R&D
> Red Hat Israel
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
7 years, 11 months