June 2018 - Infra - oVirt List Archives

[JIRA] (OVIRT-2191) remove the mountpoint creation phase from mock_runner
by Barak Korren (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-2191?page=com.atlassian.jira.… ] Barak Korren updated OVIRT-2191: -------------------------------- Epic Link: OVIRT-2189 > remove the mountpoint creation phase from mock_runner > ----------------------------------------------------- > > Key: OVIRT-2191 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2191 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: mock_runner > Reporter: Barak Korren > Assignee: infra > > There is a part in mock_runner code that runs mock in order to create mount points for things that are going to be bind mounted into it. Since mock 1.4.10 can create its own mount point we can remove that code from mock runner. > This should reduce the amount of times mock is called from mock_runner -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-2032) Mounting device files prevents using systemd-nspawn in mock
by Barak Korren (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-2032?page=com.atlassian.jira.… ] Barak Korren updated OVIRT-2032: -------------------------------- Assignee: Barak Korren (was: infra) Status: In Progress (was: To Do) > Mounting device files prevents using systemd-nspawn in mock > ----------------------------------------------------------- > > Key: OVIRT-2032 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-2032 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: mock_runner > Reporter: Barak Korren > Assignee: Barak Korren > Labels: upstream-issue > > The systemd-nspawn functionality in mock is introduced in OVIRT-2031. > When using systemd-nspawn mock uses some kind of a layered FS that is created when it starts and removed when it exits. This is different from the way it works when using chroot where the directory that the chroot is configured in stays around until it is explicitly removed. > mock had an issue where if you tried to bind-mount something into the mock environment, you had to have the mount point ready for it. We worked around this in {{mock_runner}} by using the fact the chroot was persistent, going into it and setting up the mount points as needed before actually starting to use it to run the STDCI script. > Since the mock authors were aware of the issue when the implemented the systemd-nspawn functionality, they made mock pre-create mount point in the container as needed. However, they only supported directory mount points, so if we tried to bind-mount a socket we would get en error message failing to mount a socket file on a directory. > We reported this issue to the mock developers as issue [#87|https://github.com/rpm-software-management/mock/issues/87] -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1678) Move gerrit-admin project to be standard CI
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1678?page=com.atlassian.jira.… ] eyal edri updated OVIRT-1678: ----------------------------- Epic Link: (was: OVIRT-411) > Move gerrit-admin project to be standard CI > ------------------------------------------- > > Key: OVIRT-1678 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1678 > Project: oVirt - virtualization made easy > Issue Type: Task > Components: Gerrit/git, Gerrit Hooks > Reporter: eyal edri > Assignee: infra > > Since we're moving all projects on CI to be a std-ci project ( i.e have automation/ dir with all the relevant scripts inside ), we should also move the gerrit-admin project which holds all the code for the Gerrit hooks. > This will help lay the ground for adding unit-tests and deployments for the hooks in a standard way. > I would start with adding a 'check-patch.sh' script which will do basic sanity on the code, maybe using partner-bugizlla instance and a test bug for testing the hooks. > It's also a great way to learn more about how to create a stanard CI project. > More info on it can be found on the infra docs page: > http://ovirt-infra-docs.readthedocs.io/en/latest/CI/Build_and_test_standard… -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1678) Move gerrit-admin project to be standard CI
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1678?page=com.atlassian.jira.… ] eyal edri updated OVIRT-1678: ----------------------------- Epic Link: (was: OVIRT-411) > Move gerrit-admin project to be standard CI > ------------------------------------------- > > Key: OVIRT-1678 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1678 > Project: oVirt - virtualization made easy > Issue Type: Task > Components: Gerrit/git, Gerrit Hooks > Reporter: eyal edri > Assignee: infra > > Since we're moving all projects on CI to be a std-ci project ( i.e have automation/ dir with all the relevant scripts inside ), we should also move the gerrit-admin project which holds all the code for the Gerrit hooks. > This will help lay the ground for adding unit-tests and deployments for the hooks in a standard way. > I would start with adding a 'check-patch.sh' script which will do basic sanity on the code, maybe using partner-bugizlla instance and a test bug for testing the hooks. > It's also a great way to learn more about how to create a stanard CI project. > More info on it can be found on the infra docs page: > http://ovirt-infra-docs.readthedocs.io/en/latest/CI/Build_and_test_standard… -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1678) Move gerrit-admin project to be standard CI
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1678?page=com.atlassian.jira.… ] eyal edri updated OVIRT-1678: ----------------------------- Component/s: Gerrit Hooks > Move gerrit-admin project to be standard CI > ------------------------------------------- > > Key: OVIRT-1678 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1678 > Project: oVirt - virtualization made easy > Issue Type: Task > Components: Gerrit/git, Gerrit Hooks > Reporter: eyal edri > Assignee: infra > > Since we're moving all projects on CI to be a std-ci project ( i.e have automation/ dir with all the relevant scripts inside ), we should also move the gerrit-admin project which holds all the code for the Gerrit hooks. > This will help lay the ground for adding unit-tests and deployments for the hooks in a standard way. > I would start with adding a 'check-patch.sh' script which will do basic sanity on the code, maybe using partner-bugizlla instance and a test bug for testing the hooks. > It's also a great way to learn more about how to create a stanard CI project. > More info on it can be found on the infra docs page: > http://ovirt-infra-docs.readthedocs.io/en/latest/CI/Build_and_test_standard… -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1812) [Gerrit Hooks] bug-url hook should not verify bugs w/o bug-url: prefix
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1812?page=com.atlassian.jira.… ] eyal edri updated OVIRT-1812: ----------------------------- Epic Link: (was: OVIRT-411) > [Gerrit Hooks] bug-url hook should not verify bugs w/o bug-url: prefix > ---------------------------------------------------------------------- > > Key: OVIRT-1812 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1812 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit Hooks > Reporter: Nir Soffer > Assignee: Anton Marchukov > > Gerrit bug check code is treating unrelated urls as Bug-Url: > Patch Set 1: Verified-1 > - Check Bug-Url::1520068::WARN, failed to get bug info (private bug or > bug doesn't exist) > - Check Bug-Url::1527827::OK, classification: 'Red Hat', product: 'Red > Hat Enterprise Virtualization Manager' (-1) > - Check Product::WARN, failed to get bug info (private bug or bug > doesn't exist) > - Check TM::WARN, failed to get bug info (private bug or bug doesn't > exist) > - Check Backport::OK, The patch backported to all the relevant stable > branches. > - Set POST::#1520068::WARN, failed to get bug info (private bug or bug > doesn't exist) > - Update Tracker::#1520068::WARN, failed to get bug info (private bug or > bug doesn't exist) > - Update Tracker::#1527827::OK, tracker status: POST > The commit message is: > commit 1b666da534c50321ada448e4bf397cab0306fcf1 > Author: Nir Soffer <nsoffer(a)redhat.com> > Date: Tue Dec 5 23:47:24 2017 +0200 > fileSD: Use InterruptibleDirectFile backend > FileStorgeDomainManifest uses now InterruptibleDirectFile for the > external leases backend. This ensure that the process does not become > uninterruptible if storage is non-responsive. > This change bypass the python bug[1] causing the entire process to hang > when opening the special xleases volume. Now the operation is done in > the child process outside of Vdsm. > [1] https://bugzilla.redhat.com/1520068 > Change-Id: I8a0eb42baa73b6c0a877ad9acbe53ac51f31bfea > Bug-Url: https://bugzilla.redhat.com/1527827 > Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> > There is exactly one Bur-Url. The other url is a bugzilla url but it should > be consumed only by humans, not by machines. Machines should use > only the Bug-Url. > Nir -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1812) [Gerrit Hooks] bug-url hook should not verify bugs w/o bug-url: prefix
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1812?page=com.atlassian.jira.… ] eyal edri updated OVIRT-1812: ----------------------------- Epic Link: (was: OVIRT-411) > [Gerrit Hooks] bug-url hook should not verify bugs w/o bug-url: prefix > ---------------------------------------------------------------------- > > Key: OVIRT-1812 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1812 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit Hooks > Reporter: Nir Soffer > Assignee: Anton Marchukov > > Gerrit bug check code is treating unrelated urls as Bug-Url: > Patch Set 1: Verified-1 > - Check Bug-Url::1520068::WARN, failed to get bug info (private bug or > bug doesn't exist) > - Check Bug-Url::1527827::OK, classification: 'Red Hat', product: 'Red > Hat Enterprise Virtualization Manager' (-1) > - Check Product::WARN, failed to get bug info (private bug or bug > doesn't exist) > - Check TM::WARN, failed to get bug info (private bug or bug doesn't > exist) > - Check Backport::OK, The patch backported to all the relevant stable > branches. > - Set POST::#1520068::WARN, failed to get bug info (private bug or bug > doesn't exist) > - Update Tracker::#1520068::WARN, failed to get bug info (private bug or > bug doesn't exist) > - Update Tracker::#1527827::OK, tracker status: POST > The commit message is: > commit 1b666da534c50321ada448e4bf397cab0306fcf1 > Author: Nir Soffer <nsoffer(a)redhat.com> > Date: Tue Dec 5 23:47:24 2017 +0200 > fileSD: Use InterruptibleDirectFile backend > FileStorgeDomainManifest uses now InterruptibleDirectFile for the > external leases backend. This ensure that the process does not become > uninterruptible if storage is non-responsive. > This change bypass the python bug[1] causing the entire process to hang > when opening the special xleases volume. Now the operation is done in > the child process outside of Vdsm. > [1] https://bugzilla.redhat.com/1520068 > Change-Id: I8a0eb42baa73b6c0a877ad9acbe53ac51f31bfea > Bug-Url: https://bugzilla.redhat.com/1527827 > Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> > There is exactly one Bur-Url. The other url is a bugzilla url but it should > be consumed only by humans, not by machines. Machines should use > only the Bug-Url. > Nir -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1812) [Gerrit Hooks] bug-url hook should not verify bugs w/o bug-url: prefix
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1812?page=com.atlassian.jira.… ] eyal edri updated OVIRT-1812: ----------------------------- Component/s: Gerrit Hooks > [Gerrit Hooks] bug-url hook should not verify bugs w/o bug-url: prefix > ---------------------------------------------------------------------- > > Key: OVIRT-1812 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1812 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit Hooks > Reporter: Nir Soffer > Assignee: Anton Marchukov > > Gerrit bug check code is treating unrelated urls as Bug-Url: > Patch Set 1: Verified-1 > - Check Bug-Url::1520068::WARN, failed to get bug info (private bug or > bug doesn't exist) > - Check Bug-Url::1527827::OK, classification: 'Red Hat', product: 'Red > Hat Enterprise Virtualization Manager' (-1) > - Check Product::WARN, failed to get bug info (private bug or bug > doesn't exist) > - Check TM::WARN, failed to get bug info (private bug or bug doesn't > exist) > - Check Backport::OK, The patch backported to all the relevant stable > branches. > - Set POST::#1520068::WARN, failed to get bug info (private bug or bug > doesn't exist) > - Update Tracker::#1520068::WARN, failed to get bug info (private bug or > bug doesn't exist) > - Update Tracker::#1527827::OK, tracker status: POST > The commit message is: > commit 1b666da534c50321ada448e4bf397cab0306fcf1 > Author: Nir Soffer <nsoffer(a)redhat.com> > Date: Tue Dec 5 23:47:24 2017 +0200 > fileSD: Use InterruptibleDirectFile backend > FileStorgeDomainManifest uses now InterruptibleDirectFile for the > external leases backend. This ensure that the process does not become > uninterruptible if storage is non-responsive. > This change bypass the python bug[1] causing the entire process to hang > when opening the special xleases volume. Now the operation is done in > the child process outside of Vdsm. > [1] https://bugzilla.redhat.com/1520068 > Change-Id: I8a0eb42baa73b6c0a877ad9acbe53ac51f31bfea > Bug-Url: https://bugzilla.redhat.com/1527827 > Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> > There is exactly one Bur-Url. The other url is a bugzilla url but it should > be consumed only by humans, not by machines. Machines should use > only the Bug-Url. > Nir -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1849) enable all gerrit hooks for cockpit-ovirt project
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1849?page=com.atlassian.jira.… ] eyal edri reassigned OVIRT-1849: -------------------------------- Assignee: Anton Marchukov (was: infra) > enable all gerrit hooks for cockpit-ovirt project > ------------------------------------------------- > > Key: OVIRT-1849 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1849 > Project: oVirt - virtualization made easy > Issue Type: Task > Components: Gerrit Hooks > Reporter: eyal edri > Assignee: Anton Marchukov > Priority: High > > It looks like the cockpit-ovirt project doesn't have all hooks enabled, current these are the hooks its using: > /home/gerrit2/review_site/hooks/custom_hooks/update_tracker > /home/gerrit2/review_site/hooks/custom_hooks/comment-added.propagate_review_values > If we want that the hooks will also update bz status and do other verification like backporing, we need to add more hooks. > [~sbonazzo(a)redhat.com] [~msivak(a)redhat.com] please comment which hooks you'd like to enable or all of them. > Info on the hooks can be found here :http://ovirt-infra-docs.readthedocs.io/en/latest/General/Creating_Gerrit_Projects/index.html#enabling-custom-gerrit-hooks > [~amarchuk] fyi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0

[JIRA] (OVIRT-1849) enable all gerrit hooks for cockpit-ovirt project
by eyal edri (oVirt JIRA) 12 Jun '18

12 Jun '18

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1849?page=com.atlassian.jira.… ] eyal edri updated OVIRT-1849: ----------------------------- Epic Link: (was: OVIRT-411) > enable all gerrit hooks for cockpit-ovirt project > ------------------------------------------------- > > Key: OVIRT-1849 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1849 > Project: oVirt - virtualization made easy > Issue Type: Task > Components: Gerrit Hooks > Reporter: eyal edri > Assignee: infra > Priority: High > > It looks like the cockpit-ovirt project doesn't have all hooks enabled, current these are the hooks its using: > /home/gerrit2/review_site/hooks/custom_hooks/update_tracker > /home/gerrit2/review_site/hooks/custom_hooks/comment-added.propagate_review_values > If we want that the hooks will also update bz status and do other verification like backporing, we need to add more hooks. > [~sbonazzo(a)redhat.com] [~msivak(a)redhat.com] please comment which hooks you'd like to enable or all of them. > Info on the hooks can be found here :http://ovirt-infra-docs.readthedocs.io/en/latest/General/Creating_Gerrit_Projects/index.html#enabling-custom-gerrit-hooks > [~amarchuk] fyi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100087)

1 0