- Infra - oVirt List Archives

[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jira.… ] Allon Mureinik edited comment on OVIRT-1500 at 7/3/17 11:52 AM: ---------------------------------------------------------------- {quote} So i'm not sure which inheritance are you reffering to, CI shouldn't run on patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no? {quote} Eyal - the behavior of just marking patchset #1 with CI=+1 is correct. I want this value *copied* to patchset #2, so it's visible from gerrit's dashboard. Otherwise, I need to see there's no CI score on the dashboard, go into this patch, read through the history to understand why it was never triggered on patchset #2 and mark CI=+1 myself (or manually trigger) in order to merge. Nothing here is technically "wrong", but it's a poor UX for gerrit users, and we should strive to improve it if possible. was (Author: mureinik): > So i'm not sure which inheritance are you reffering to, CI shouldn't run on patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no? Eyal - the behavior of just marking patchset #1 with CI=+1 is correct. I want this value **copied** to patchset #2, so it's visible from gerrit's dashboard. Otherwise, I need to see there's no CI score on the dashboard, go into this patch, read through the history to understand why it was never triggered on patchset #2 and mark CI=+1 myself (or manually trigger) in order to merge. Nothing here is technically "wrong", but it's a poor UX for gerrit users, and we should strive to improve it if possible. > CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit > ------------------------------------------------------------------- > > Key: OVIRT-1500 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git, oVirt CI > Reporter: Allon Mureinik > Assignee: infra > > In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. > Looking through gerrit's history, here's what I *think* is going on: > 08:41 - patchset #1 is submitted > 08:41 - CI (check-patch) starts for both EL7 and fc25 > _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_ > 08:42 - patchset #2 is submitted > _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_ > 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. > Expected behavior: > If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jira.… ] Allon Mureinik commented on OVIRT-1500: --------------------------------------- > So i'm not sure which inheritance are you reffering to, CI shouldn't run on patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no? Eyal - the behavior of just marking patchset #1 with CI=+1 is correct. I want this value **copied** to patchset #2, so it's visible from gerrit's dashboard. Otherwise, I need to see there's no CI score on the dashboard, go into this patch, read through the history to understand why it was never triggered on patchset #2 and mark CI=+1 myself (or manually trigger) in order to merge. Nothing here is technically "wrong", but it's a poor UX for gerrit users, and we should strive to improve it if possible. > CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit > ------------------------------------------------------------------- > > Key: OVIRT-1500 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git, oVirt CI > Reporter: Allon Mureinik > Assignee: infra > > In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. > Looking through gerrit's history, here's what I *think* is going on: > 08:41 - patchset #1 is submitted > 08:41 - CI (check-patch) starts for both EL7 and fc25 > _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_ > 08:42 - patchset #2 is submitted > _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_ > 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. > Expected behavior: > If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1468) Use CI mirrors for the slaves
by eedri (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1468?page=com.atlassian.jira.… ] eedri commented on OVIRT-1468: ------------------------------ Let's discuss on the next CI meeting. > Use CI mirrors for the slaves > ----------------------------- > > Key: OVIRT-1468 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1468 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: oVirt Infra > Reporter: Barak Korren > Assignee: infra > Priority: High > Labels: jenkins, mirrors, slaves > > Since we've seen that issues like OVIRT-1467 can very quickly break our entire infrastructure, it may be advisable to use out mirrors to isolate the slave VMs from the upstream repos as well, and not just the testing environments. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1468) Use CI mirrors for the slaves
by eedri (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1468?page=com.atlassian.jira.… ] eedri updated OVIRT-1468: ------------------------- Priority: High (was: Medium) > Use CI mirrors for the slaves > ----------------------------- > > Key: OVIRT-1468 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1468 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: oVirt Infra > Reporter: Barak Korren > Assignee: infra > Priority: High > Labels: jenkins, mirrors, slaves > > Since we've seen that issues like OVIRT-1467 can very quickly break our entire infrastructure, it may be advisable to use out mirrors to isolate the slave VMs from the upstream repos as well, and not just the testing environments. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by eedri (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jira.… ] eedri commented on OVIRT-1500: ------------------------------ bq. CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message? The current configuration skips any change that doesn't include 'code change': "Exclude changes without code change from triggering build If set, this will ignore any patchset which Gerrit considers without any code changes from triggering this build. These patches did not contain any differences in code from the previous patchset and did not change the parent commit. " So i'm not sure which inheritance are you reffering to, CI shouldn't run on patchset #2 since it was just commit msg update and returned +1 on the 1st patchset, no? > CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit > ------------------------------------------------------------------- > > Key: OVIRT-1500 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git, oVirt CI > Reporter: Allon Mureinik > Assignee: infra > > In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. > Looking through gerrit's history, here's what I *think* is going on: > 08:41 - patchset #1 is submitted > 08:41 - CI (check-patch) starts for both EL7 and fc25 > _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_ > 08:42 - patchset #2 is submitted > _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_ > 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. > Expected behavior: > If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1468) Use CI mirrors for the slaves
by Barak Korren (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1468?page=com.atlassian.jira.… ] Barak Korren commented on OVIRT-1468: ------------------------------------- Another case of job that has failed because of lack of this: http://jenkins.ovirt.org/job/ovirt-engine_master_build-artifacts-el7-x86_64… We need to move forward. > Use CI mirrors for the slaves > ----------------------------- > > Key: OVIRT-1468 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1468 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: oVirt Infra > Reporter: Barak Korren > Assignee: infra > Labels: jenkins, mirrors, slaves > > Since we've seen that issues like OVIRT-1467 can very quickly break our entire infrastructure, it may be advisable to use out mirrors to isolate the slave VMs from the upstream repos as well, and not just the testing environments. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Gil Shinar (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jira.… ] Gil Shinar commented on OVIRT-1500: ----------------------------------- Saw it before. If the results of a certain patchset comes after the user has sent a new patchset, the CI will not get +1. All jobs should be retriggered for it to get the +1 > CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit > ------------------------------------------------------------------- > > Key: OVIRT-1500 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git, oVirt CI > Reporter: Allon Mureinik > Assignee: infra > > In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. > Looking through gerrit's history, here's what I *think* is going on: > 08:41 - patchset #1 is submitted > 08:41 - CI (check-patch) starts for both EL7 and fc25 > _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_ > 08:42 - patchset #2 is submitted > _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_ > 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. > Expected behavior: > If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jira.… ] Allon Mureinik updated OVIRT-1500: ---------------------------------- Description: In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. Looking through gerrit's history, here's what I *think* is going on: 08:41 - patchset #1 is submitted 08:41 - CI (check-patch) starts for both EL7 and fc25 _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_ 08:42 - patchset #2 is submitted _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_ 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. Expected behavior: If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. was: In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. Looking through gerrit's history, here's what I *think* is going on: 08:41 - patchset #1 is submitted 08:41 - CI (check-patch) starts for both EL7 and fc25 * At this point I noticed a typo in the commit method. I fixed it and posted patchset #2 * 08:42 - patchset #2 is submitted * CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message ? * 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. Expected behavior: If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. > CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit > ------------------------------------------------------------------- > > Key: OVIRT-1500 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git, oVirt CI > Reporter: Allon Mureinik > Assignee: infra > > In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. > Looking through gerrit's history, here's what I *think* is going on: > 08:41 - patchset #1 is submitted > 08:41 - CI (check-patch) starts for both EL7 and fc25 > _At this point I noticed a typo in the commit method. I fixed it and posted patchset #2_ > 08:42 - patchset #2 is submitted > _CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message?_ > 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. > Expected behavior: > If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA) 03 Jul '17

03 Jul '17

Allon Mureinik created OVIRT-1500: ------------------------------------- Summary: CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit Key: OVIRT-1500 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 Project: oVirt - virtualization made easy Issue Type: Bug Components: Gerrit/git, oVirt CI Reporter: Allon Mureinik Assignee: infra In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. Looking through gerrit's history, here's what I *think* is going on: 08:41 - patchset #1 is submitted 08:41 - CI (check-patch) starts for both EL7 and fc25 * At this point I noticed a typo in the commit method. I fixed it and posted patchset #2 * 08:42 - patchset #2 is submitted * CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message ? * 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. Expected behavior: If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0

[JIRA] (OVIRT-1500) CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit
by Allon Mureinik (oVirt JIRA) 03 Jul '17

03 Jul '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1500?page=com.atlassian.jira.… ] Allon Mureinik updated OVIRT-1500: ---------------------------------- Epic Link: OVIRT-400 > CI on ovirt-engine patch succeeded, but didn't mark CI=+1 on gerrit > ------------------------------------------------------------------- > > Key: OVIRT-1500 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1500 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git, oVirt CI > Reporter: Allon Mureinik > Assignee: infra > > In my recent engine patch https://gerrit.ovirt.org/#/c/78911 the CI passed, but was not marked as so in gerrit. > Looking through gerrit's history, here's what I *think* is going on: > 08:41 - patchset #1 is submitted > 08:41 - CI (check-patch) starts for both EL7 and fc25 > * At this point I noticed a typo in the commit method. I fixed it and posted patchset #2 * > 08:42 - patchset #2 is submitted > * CI was never triggered for patchset #2. Is this because the only difference between it and patchset #1 is the commit message ? * > 09:15 - CI for patchset #1 completes, and marks *patchset #1* with CI=+1. This is not inherited to patchset #2 for some reason. > Expected behavior: > If CI for patchset #1 passed and the only difference is the commit message (not the parent commit and not the content), I'd expect the CI score to be inherited. -- This message was sent by Atlassian JIRA (v1000.1092.1#100053)

1 0