- Infra - oVirt List Archives

[JIRA] (OVIRT-839) [gerrit hooks] retype classification message
by eyal edri [Administrator] (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-839?page=com.atlassian.jira.p… ] eyal edri [Administrator] commented on OVIRT-839: ------------------------------------------------- [~sbendavi(a)redhat.com] is this still relevant? > [gerrit hooks] retype classification message > -------------------------------------------- > > Key: OVIRT-839 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-839 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Reporter: Shlomo Ben David > Assignee: infra > > The current message isn't consistent in all hooks. > If the bug classification is not 'oVirt' return the following message: > [hook name]::[bug id]::IGNORE: not relevant for '[other classification]' classification. -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1193) add on request 'ci help' command via Gerrit
by eyal edri [Administrator] (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jira.… ] eyal edri [Administrator] commented on OVIRT-1193: -------------------------------------------------- I still think its worth asking the developers again, proposing the relevant options, after all it was their request as you say. Also, one or two developers might have different ideas then the majority, so we'll need an agreement on one suggestion from the majority. > add on request 'ci help' command via Gerrit > ------------------------------------------- > > Key: OVIRT-1193 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote: > > Hi, > > > > do you think it would make sense to send a copy-and-paste ready > > message with help to every new gerrit change? > > > > It could provide all the system test (lago) links, mention the Rerun > > hooks syntax and so on. Just so we do not have to search for it all > > the time? > This is doable, but I think experienced users may find this annoying > it ifs too long. > I'm thinking it may be better to have such a message just suggesting > to type something like '@ci help' to get the full help. > It may even be possible to make it clickable with some trickery rather > then just copy-and-paster ready (I will need to check if its possible > to inject links into Gerrit comments). > Apart from that, Roy offered to write a Gerrit plugin that will add > buttons with the various CI commands. > Adding infra-support to get a Jira ticket opened. > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1193) add on request 'ci help' command via Gerrit
by Barak Korren (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jira.… ] Barak Korren commented on OVIRT-1193: ------------------------------------- I think top of gerrit or the 1st comment in gerrit are visually equivalent, with the difference that the 1st comment is easier to implement atm... WRT to developer survey - remember that the suggestion for this came from the developers... > add on request 'ci help' command via Gerrit > ------------------------------------------- > > Key: OVIRT-1193 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote: > > Hi, > > > > do you think it would make sense to send a copy-and-paste ready > > message with help to every new gerrit change? > > > > It could provide all the system test (lago) links, mention the Rerun > > hooks syntax and so on. Just so we do not have to search for it all > > the time? > This is doable, but I think experienced users may find this annoying > it ifs too long. > I'm thinking it may be better to have such a message just suggesting > to type something like '@ci help' to get the full help. > It may even be possible to make it clickable with some trickery rather > then just copy-and-paster ready (I will need to check if its possible > to inject links into Gerrit comments). > Apart from that, Roy offered to write a Gerrit plugin that will add > buttons with the various CI commands. > Adding infra-support to get a Jira ticket opened. > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1193) add on request 'ci help' command via Gerrit
by eyal edri [Administrator] (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jira.… ] eyal edri [Administrator] commented on OVIRT-1193: -------------------------------------------------- Another option is to add it to the top of the Gerrit as part of the layout. But anyhow, I think its best to do a short survey on the devel list before implementing this. > add on request 'ci help' command via Gerrit > ------------------------------------------- > > Key: OVIRT-1193 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote: > > Hi, > > > > do you think it would make sense to send a copy-and-paste ready > > message with help to every new gerrit change? > > > > It could provide all the system test (lago) links, mention the Rerun > > hooks syntax and so on. Just so we do not have to search for it all > > the time? > This is doable, but I think experienced users may find this annoying > it ifs too long. > I'm thinking it may be better to have such a message just suggesting > to type something like '@ci help' to get the full help. > It may even be possible to make it clickable with some trickery rather > then just copy-and-paster ready (I will need to check if its possible > to inject links into Gerrit comments). > Apart from that, Roy offered to write a Gerrit plugin that will add > buttons with the various CI commands. > Adding infra-support to get a Jira ticket opened. > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1193) add on request 'ci help' command via Gerrit
by Barak Korren (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jira.… ] Barak Korren commented on OVIRT-1193: ------------------------------------- The thing is - if last week's events taught us anything is that people are not willing to remember anything - not even one command. I thing that a short enough message, that will appear once and only once when a patch (patch! not patchset!) is created, is unobtrusive enough to not be annoying. The huge benefit of this is that now no one can say he never heard that there is a CI system and it has commands. This will also be a good place to warn new contributors about not being in the whitelist and tell them what to do. > add on request 'ci help' command via Gerrit > ------------------------------------------- > > Key: OVIRT-1193 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote: > > Hi, > > > > do you think it would make sense to send a copy-and-paste ready > > message with help to every new gerrit change? > > > > It could provide all the system test (lago) links, mention the Rerun > > hooks syntax and so on. Just so we do not have to search for it all > > the time? > This is doable, but I think experienced users may find this annoying > it ifs too long. > I'm thinking it may be better to have such a message just suggesting > to type something like '@ci help' to get the full help. > It may even be possible to make it clickable with some trickery rather > then just copy-and-paster ready (I will need to check if its possible > to inject links into Gerrit comments). > Apart from that, Roy offered to write a Gerrit plugin that will add > buttons with the various CI commands. > Adding infra-support to get a Jira ticket opened. > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1193) add on request 'ci help' command via Gerrit
by eyal edri [Administrator] (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jira.… ] eyal edri [Administrator] edited comment on OVIRT-1193 at 2/26/17 6:19 PM: --------------------------------------------------------------------------- I think people will be annoyed by that, it willl spam the comments in all patches. I think it makes sense to developers to know one command - 'ci please help' e.g., and we need to add it to the signatures of emails from infra to devel, to the Jenkins UI and ovirt site. So people will only need to remember one command, and once they type it, it will give them info on what is available. was (Author: eedri): I think people will be annoyed by that, i'll spam the comments in all patches. I think it makes sense to developers to know one command - 'ci please help' e.g., and we need to add it to the signatures of emails from infra to devel, to the Jenkins UI and ovirt site. So people will only need to remember one command, and once they type it, it will give them info on what is available. > add on request 'ci help' command via Gerrit > ------------------------------------------- > > Key: OVIRT-1193 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote: > > Hi, > > > > do you think it would make sense to send a copy-and-paste ready > > message with help to every new gerrit change? > > > > It could provide all the system test (lago) links, mention the Rerun > > hooks syntax and so on. Just so we do not have to search for it all > > the time? > This is doable, but I think experienced users may find this annoying > it ifs too long. > I'm thinking it may be better to have such a message just suggesting > to type something like '@ci help' to get the full help. > It may even be possible to make it clickable with some trickery rather > then just copy-and-paster ready (I will need to check if its possible > to inject links into Gerrit comments). > Apart from that, Roy offered to write a Gerrit plugin that will add > buttons with the various CI commands. > Adding infra-support to get a Jira ticket opened. > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1193) add on request 'ci help' command via Gerrit
by eyal edri [Administrator] (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1193?page=com.atlassian.jira.… ] eyal edri [Administrator] commented on OVIRT-1193: -------------------------------------------------- I think people will be annoyed by that, i'll spam the comments in all patches. I think it makes sense to developers to know one command - 'ci please help' e.g., and we need to add it to the signatures of emails from infra to devel, to the Jenkins UI and ovirt site. So people will only need to remember one command, and once they type it, it will give them info on what is available. > add on request 'ci help' command via Gerrit > ------------------------------------------- > > Key: OVIRT-1193 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1193 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > On 23 February 2017 at 15:10, Martin Sivak <msivak(a)redhat.com> wrote: > > Hi, > > > > do you think it would make sense to send a copy-and-paste ready > > message with help to every new gerrit change? > > > > It could provide all the system test (lago) links, mention the Rerun > > hooks syntax and so on. Just so we do not have to search for it all > > the time? > This is doable, but I think experienced users may find this annoying > it ifs too long. > I'm thinking it may be better to have such a message just suggesting > to type something like '@ci help' to get the full help. > It may even be possible to make it clickable with some trickery rather > then just copy-and-paster ready (I will need to check if its possible > to inject links into Gerrit comments). > Apart from that, Roy offered to write a Gerrit plugin that will add > buttons with the various CI commands. > Adding infra-support to get a Jira ticket opened. > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1181) Remove the CI-whitelsit GitHub mirror
by eyal edri [Administrator] (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1181?page=com.atlassian.jira.… ] eyal edri [Administrator] commented on OVIRT-1181: -------------------------------------------------- ovirt-site is a Github project, not Gerrit, so the comparison isn't relevant. jenkins-whitelist is an infra project and as all infra repos, managed in Gerrit. The same reason we won't accept engine or vdsm patches from GitHub because they are managed in Gerrit, we can't accept it for this project. It happens that 99% percent of patches or requests are done via Gerrit currently, So I don't see a strong reason to move the jenkins-whitelist to GitHub. New projects like 'ovirt-web-ui' that existing only in GitHub are already supported, so you can't say we don't support PRs from GitHub. As for making it private repo on Gerrit, we can consider it, though unless you can spoof yourself into Gerrit with fake email, not sure if its needed. > Remove the CI-whitelsit GitHub mirror > ------------------------------------- > > Key: OVIRT-1181 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1181 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Jenkins > Reporter: Barak Korren > Assignee: infra > > Having this on GitHub makes the a list of people's email-addresses far too public. > It also makes people confused and try to update it with GitHub pull requests. > We should probably remove the GitHub mirror, and also make sure the Gerrit repo is also not that easy to look into. -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1181) Remove the CI-whitelsit GitHub mirror
by Nir Soffer (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1181?page=com.atlassian.jira.… ] Nir Soffer commented on OVIRT-1181: ----------------------------------- On Sun, Feb 26, 2017 at 5:47 PM, Barak Korren (oVirt JIRA) < Any ovirt patch on github contains the email address of the author. There is no privacy, and there should be no privacy on free software project. This change is not needed and very wrong; we should make it easy to add someone to the whitelist. The correct change would be to accept pull requests on github, like ovirt-site. Nir > Remove the CI-whitelsit GitHub mirror > ------------------------------------- > > Key: OVIRT-1181 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1181 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Jenkins > Reporter: Barak Korren > Assignee: infra > > Having this on GitHub makes the a list of people's email-addresses far too public. > It also makes people confused and try to update it with GitHub pull requests. > We should probably remove the GitHub mirror, and also make sure the Gerrit repo is also not that easy to look into. -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

1 0

[JIRA] (OVIRT-1181) Remove the CI-whitelsit GitHub mirror
by Barak Korren (oVirt JIRA) 26 Feb '17

26 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1181?page=com.atlassian.jira.… ] Barak Korren commented on OVIRT-1181: ------------------------------------- we should probably make it private too, like the infra-hiera repo > Remove the CI-whitelsit GitHub mirror > ------------------------------------- > > Key: OVIRT-1181 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1181 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Jenkins > Reporter: Barak Korren > Assignee: infra > > Having this on GitHub makes the a list of people's email-addresses far too public. > It also makes people confused and try to update it with GitHub pull requests. > We should probably remove the GitHub mirror, and also make sure the Gerrit repo is also not that easy to look into. -- This message was sent by Atlassian JIRA (v1000.784.2#100032)

2 1