- Infra - oVirt List Archives

[JIRA] (OVIRT-1154) Make jenkins-whitelist use Gerrit groups
by Barak Korren (oVirt JIRA) 20 Feb '17

20 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1154?page=com.atlassian.jira.… ] Barak Korren commented on OVIRT-1154: ------------------------------------- Looks like scanning for commiters in Git can be pretty fast with something like: {code} git log --pretty=format:%ae 'HEAD@{360 days ago}..' | sort -u {code} Here is timing this for engine master on my laptop: {code} $ time git log --pretty=format:%ae 'HEAD@{360 days ago}..' | sort -u | wc -l 118 real 0m0.143s user 0m0.124s sys 0m0.043s {code} So we can probably do this per-job. But it may cause issues if we want to switch to sparse or shallow clones. In the case we will need some kind of a nightly job to scan all branches of all projects to find committers and then store them somewhere. That 'somewhere' should probably just be a Gerrit group (Can it be? Need to check how easy is it to map emails to Gerrit users in practice). It may be more useful to somehow let maintainers (know contributors?) "confirm" a patch so that CI will check it, like we do for Lago. > Make jenkins-whitelist use Gerrit groups > ---------------------------------------- > > Key: OVIRT-1154 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1154 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Jenkins > Reporter: Barak Korren > Assignee: infra > > Right now our white list is based on a text file with email addresses in it. Its kinda silly when we already have lists and groups of users in Gerrit. > Some suggestions: > * make any members of a project's "maintainers" group automatically white-listed > * make a specific group for other white-listed people -- This message was sent by Atlassian JIRA (v1000.769.1#100032)

1 0

[JIRA] (OVIRT-1154) Make jenkins-whitelist use Gerrit groups
by Barak Korren (oVirt JIRA) 20 Feb '17

20 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1154?page=com.atlassian.jira.… ] Barak Korren edited comment on OVIRT-1154 at 2/20/17 4:43 PM: -------------------------------------------------------------- We don't want to significantly slow down the CI because of this. A good guideline should be for the whole whitelist matching process to take: # At most 1 network fetch (right now it fetches once via cloning from Gerrit) # At most O\(n) time to search the match, where 'n' is the *number of contributors* as opposed to *number of patches* AFAIK we don't keep lists of contributors anywhere ATM, so we'll probably need to scan patches to see who contributed. We may not be able to practically do this fast enough. We will need to check if Git or Gerrit can do this efficiently for us ahead of time. We also need some proper definition of who is considered a contributor. I don't think that someone with a merged patch ever is a good heuristic, should probably be something like N patches merged in the last M months. was (Author: bkorren(a)redhat.com) We don't want to significantly slow down the CI because of this, a good guideline should be for the whole whitelist matching process to take: # At most 1 network fetch (right not if fetches once via cloning from Gerrit) # At most O\(n) time to search the match, where 'n' is the *number of contributors* as opposed to *number of patches* AFAIK we don't keep lists of contributors anywhere ATM, so we'll probably need to scan patches to see who contributed. We may not be able to practically do this fast enough. We will need to check if Git or Gerrit can do this efficiently for us ahead of time. We also need some proper definition of who is considered a contributor. I don't think that someone with a merged patch ever is a good heuristic, should probably be something like N patches merged in the last M months. > Make jenkins-whitelist use Gerrit groups > ---------------------------------------- > > Key: OVIRT-1154 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1154 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Jenkins > Reporter: Barak Korren > Assignee: infra > > Right now our white list is based on a text file with email addresses in it. Its kinda silly when we already have lists and groups of users in Gerrit. > Some suggestions: > * make any members of a project's "maintainers" group automatically white-listed > * make a specific group for other white-listed people -- This message was sent by Atlassian JIRA (v1000.769.1#100032)

1 0

[JIRA] (OVIRT-1165) Please add 'gerrit reviewer plugin'
by eyal edri [Administrator] (oVirt JIRA) 20 Feb '17

20 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1165?page=com.atlassian.jira.… ] eyal edri [Administrator] reassigned OVIRT-1165: ------------------------------------------------ Assignee: Evgheni Dereveanchin (was: infra) > Please add 'gerrit reviewer plugin' > ----------------------------------- > > Key: OVIRT-1165 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1165 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: rgolan > Assignee: Evgheni Dereveanchin > > Hi infra > It would be very useful for projects to use the 'reviewers' gerrit plugin. > It's a prefix configuration base pluging to add users or gerrit groups. > Every project maintainers would have to then decide on the configuration. > Example [1] of a project's `reviewers.config` > [filter "*"] > reviewer = john.doe(a)example.com > [filter "branch:main file:^lib/.*"] > reviewer = jane.doe(a)example.com > [filter "branch:stable-2.10"] > reviewer = QAGroup > [filter "file:^build/modules/.*"] > reviewer = john.doe(a)example.com > [filter "file:^build/.*"] > reviewer = jane.doe(a)example.com > Thanks, > Roy > [1] https://gerrit.googlesource.com/plugins/reviewers/+/master/src/main/resourc… -- This message was sent by Atlassian JIRA (v1000.769.1#100032)

1 0

[JIRA] (OVIRT-1165) Please add 'gerrit reviewer plugin'
by rgolan (oVirt JIRA) 20 Feb '17

20 Feb '17

rgolan created OVIRT-1165: ----------------------------- Summary: Please add 'gerrit reviewer plugin' Key: OVIRT-1165 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1165 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: rgolan Assignee: infra Hi infra It would be very useful for projects to use the 'reviewers' gerrit plugin. It's a prefix configuration base pluging to add users or gerrit groups. Every project maintainers would have to then decide on the configuration. Example [1] of a project's `reviewers.config` [filter "*"] reviewer = john.doe(a)example.com [filter "branch:main file:^lib/.*"] reviewer = jane.doe(a)example.com [filter "branch:stable-2.10"] reviewer = QAGroup [filter "file:^build/modules/.*"] reviewer = john.doe(a)example.com [filter "file:^build/.*"] reviewer = jane.doe(a)example.com Thanks, Roy [1] https://gerrit.googlesource.com/plugins/reviewers/+/master/src/main/resourc… -- This message was sent by Atlassian JIRA (v1000.769.1#100032)

1 0

[ OST Failure Report ] [ ovirt 4.0 ] [ 17.02.17 ] [ add hosts ]
by Dusan Fodor 20 Feb '17

20 Feb '17

Hello, python cpopen missing error occured while deploying host: 2017-02-16 21:44:28 ERROR otopi.plugins.otopi.packagers.yumpackager yumpackager.error:85 Yum [u'python-ioprocess-0.16.1-1.el7.noarch requires python-cpopen', u'vdsm-4.18.21-1.el7.centos.x86_64 requires python-cpopen >= 1.4', u'vdsm-python-4.18.21-1.el7.centos.noarch requires python-cpopen >= 1.4'] Could you please assist? Thanks Link to build: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt_4.0_system-t… Link to host-deploy log: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt_4.0_system-t…

4 4

[JIRA] (OVIRT-1154) Make jenkins-whitelist use Gerrit groups
by Michal Skrivanek (oVirt JIRA) 20 Feb '17

20 Feb '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1154?page=com.atlassian.jira.… ] Michal Skrivanek commented on OVIRT-1154: ----------------------------------------- - I suppose the list of contributors should be cached and refreshed e.g. once a day - single merged patch should be good enough, maybe not the whole history indeed, perhaps last 2 years would be ok > Make jenkins-whitelist use Gerrit groups > ---------------------------------------- > > Key: OVIRT-1154 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1154 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Jenkins > Reporter: Barak Korren > Assignee: infra > > Right now our white list is based on a text file with email addresses in it. Its kinda silly when we already have lists and groups of users in Gerrit. > Some suggestions: > * make any members of a project's "maintainers" group automatically white-listed > * make a specific group for other white-listed people -- This message was sent by Atlassian JIRA (v1000.769.1#100032)

1 0

[oVirt Jenkins] test-repo_ovirt_experimental_master - Build #5417 - FAILURE!
by jenkins＠jenkins.phx.ovirt.org 20 Feb '17

20 Feb '17

------=_Part_239_1951712946.1487587788855 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Build: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/5417/, Build Number: 5417, Build Status: FAILURE ------=_Part_239_1951712946.1487587788855--

1 1

[oVirt Jenkins] test-repo_ovirt_experimental_4.1 - Build #709 - FAILURE!
by jenkins＠jenkins.phx.ovirt.org 20 Feb '17

20 Feb '17

------=_Part_234_1582267572.1487560757781 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Build: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_4.1/709/, Build Number: 709, Build Status: FAILURE ------=_Part_234_1582267572.1487560757781--

1 1

Build failed in Jenkins: system-sync_mirrors-fedora-updates-fc24-x86_64 #17
by jenkins＠jenkins.phx.ovirt.org 19 Feb '17

19 Feb '17

See <http://jenkins.ovirt.org/job/system-sync_mirrors-fedora-updates-fc24-x86_64…> ------------------------------------------ Started by timer [EnvInject] - Loading node environment variables. Building remotely on mirrors.phx.ovirt.org (mirrors) in workspace <http://jenkins.ovirt.org/job/system-sync_mirrors-fedora-updates-fc24-x86_64…> > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url http://gerrit.ovirt.org/jenkins.git # timeout=10 Cleaning workspace > git rev-parse --verify HEAD # timeout=10 Resetting working tree > git reset --hard # timeout=10 > git clean -fdx # timeout=10 Pruning obsolete local branches Fetching upstream changes from http://gerrit.ovirt.org/jenkins.git > git --version # timeout=10 > git fetch --tags --progress http://gerrit.ovirt.org/jenkins.git +refs/heads/*:refs/remotes/origin/* --prune ERROR: Error fetching remote repo 'origin' hudson.plugins.git.GitException: Failed to fetch from http://gerrit.ovirt.org/jenkins.git at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:799) at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1055) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1086) at hudson.scm.SCM.checkout(SCM.java:495) at hudson.model.AbstractProject.checkout(AbstractProject.java:1278) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:604) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529) at hudson.model.Run.execute(Run.java:1728) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:404) Caused by: hudson.plugins.git.GitException: Command "git fetch --tags --progress http://gerrit.ovirt.org/jenkins.git +refs/heads/*:refs/remotes/origin/* --prune" returned status code 128: stdout: stderr: error: RPC failed; result=6, HTTP code = 0 fatal: The remote end hung up unexpectedly at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1784) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1513) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:64) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:315) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:152) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:145) at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) at ......remote call to mirrors.phx.ovirt.org(Native Method) at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1537) at hudson.remoting.UserResponse.retrieve(UserRequest.java:253) at hudson.remoting.Channel.call(Channel.java:822) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:145) at sun.reflect.GeneratedMethodAccessor385.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:131) at com.sun.proxy.$Proxy75.execute(Unknown Source) at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:797) ... 11 more ERROR: null

1 1

[oVirt Jenkins] test-repo_ovirt_experimental_4.0 - Build #3791 - FAILURE!
by jenkins＠jenkins.phx.ovirt.org 19 Feb '17

19 Feb '17

------=_Part_171_981730414.1487263659431 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Build: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_4.0/3791/, Build Number: 3791, Build Status: FAILURE ------=_Part_171_981730414.1487263659431--

2 14