- Infra - oVirt List Archives

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit
by ybronhei (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.p… ] ybronhei commented on OVIRT-900: -------------------------------- you can always ignore the patchset and push your version again. otherwise you cant rebase your patch on it I think On Sun, Dec 4, 2016 at 3:00 PM, eyal edri [Administrator] (oVirt JIRA) < -- *Yaniv Bronhaim.* > Re: Rebase over other author's patch cannot be pushed to gerrit > --------------------------------------------------------------- > > Key: OVIRT-900 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Barak Korren > Assignee: Shlomo Ben David > > Forwarding to infra-support. > On 1 December 2016 at 18:03, Yaniv Bronheim <ybronhei(a)redhat.com> wrote: > > Not sure since when it was changed, but I noticed that I can't push patches > > if I'm not the author > > > > Counting objects: 50, done. > > Delta compression using up to 4 threads. > > Compressing objects: 100% (50/50), done. > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done. > > Total 50 (delta 34), reused 0 (delta 0) > > remote: Resolving deltas: 100% (34/34) > > remote: Processing changes: refs: 1, done > > remote: > > remote: ERROR: In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4 > > remote: ERROR: author email address rnachimu(a)redhat.com > > remote: ERROR: does not match your user account. > > remote: ERROR: > > remote: ERROR: The following addresses are currently registered: > > remote: ERROR: bronhaim(a)gmail.com > > remote: ERROR: ybronhei(a)redhat.com > > remote: ERROR: > > remote: ERROR: To register an email address, please visit: > > remote: ERROR: https://gerrit.ovirt.org/#/settings/contact > > remote: > > remote: > > To ssh://ybronhei@gerrit.ovirt.org:29418/vdsm > > ! [remote rejected] HEAD -> refs/for/master (invalid author) > > error: failed to push some refs to > > 'ssh://ybronhei@gerrit.ovirt.org:29418/vdsm' > > > > We must have permissions to do that, this is part of the rebasing part, and > > I think its fine to fix patches on behalf of someone else.. but its not the > > best practice for reviewing. > > anyway, please undo this change, unless its something that related only to > > my env.. let me know > > > > Thanks > > > > -- > > Yaniv Bronhaim. > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

1 0

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit
by eyal edri [Administrator] (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.p… ] eyal edri [Administrator] commented on OVIRT-900: ------------------------------------------------- So what you're saying is any 'registered user' should have 'forge author identity' permission? Isn't that a bit of a security issue? On Sun, Dec 4, 2016 at 2:58 PM, ybronhei (oVirt JIRA) < -- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ) > Re: Rebase over other author's patch cannot be pushed to gerrit > --------------------------------------------------------------- > > Key: OVIRT-900 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Barak Korren > Assignee: Shlomo Ben David > > Forwarding to infra-support. > On 1 December 2016 at 18:03, Yaniv Bronheim <ybronhei(a)redhat.com> wrote: > > Not sure since when it was changed, but I noticed that I can't push patches > > if I'm not the author > > > > Counting objects: 50, done. > > Delta compression using up to 4 threads. > > Compressing objects: 100% (50/50), done. > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done. > > Total 50 (delta 34), reused 0 (delta 0) > > remote: Resolving deltas: 100% (34/34) > > remote: Processing changes: refs: 1, done > > remote: > > remote: ERROR: In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4 > > remote: ERROR: author email address rnachimu(a)redhat.com > > remote: ERROR: does not match your user account. > > remote: ERROR: > > remote: ERROR: The following addresses are currently registered: > > remote: ERROR: bronhaim(a)gmail.com > > remote: ERROR: ybronhei(a)redhat.com > > remote: ERROR: > > remote: ERROR: To register an email address, please visit: > > remote: ERROR: https://gerrit.ovirt.org/#/settings/contact > > remote: > > remote: > > To ssh://ybronhei@gerrit.ovirt.org:29418/vdsm > > ! [remote rejected] HEAD -> refs/for/master (invalid author) > > error: failed to push some refs to > > 'ssh://ybronhei@gerrit.ovirt.org:29418/vdsm' > > > > We must have permissions to do that, this is part of the rebasing part, and > > I think its fine to fix patches on behalf of someone else.. but its not the > > best practice for reviewing. > > anyway, please undo this change, unless its something that related only to > > my env.. let me know > > > > Thanks > > > > -- > > Yaniv Bronhaim. > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

2 1

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit
by ybronhei (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.p… ] ybronhei commented on OVIRT-900: -------------------------------- no.. this is not the issue here. I don't try to merge, I try to push a change on a patch that im not the author of it. everyone should allow to do so On Sun, Dec 4, 2016 at 1:25 PM, eyal edri [Administrator] (oVirt JIRA) < -- *Yaniv Bronhaim.* > Re: Rebase over other author's patch cannot be pushed to gerrit > --------------------------------------------------------------- > > Key: OVIRT-900 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Barak Korren > Assignee: Shlomo Ben David > > Forwarding to infra-support. > On 1 December 2016 at 18:03, Yaniv Bronheim <ybronhei(a)redhat.com> wrote: > > Not sure since when it was changed, but I noticed that I can't push patches > > if I'm not the author > > > > Counting objects: 50, done. > > Delta compression using up to 4 threads. > > Compressing objects: 100% (50/50), done. > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done. > > Total 50 (delta 34), reused 0 (delta 0) > > remote: Resolving deltas: 100% (34/34) > > remote: Processing changes: refs: 1, done > > remote: > > remote: ERROR: In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4 > > remote: ERROR: author email address rnachimu(a)redhat.com > > remote: ERROR: does not match your user account. > > remote: ERROR: > > remote: ERROR: The following addresses are currently registered: > > remote: ERROR: bronhaim(a)gmail.com > > remote: ERROR: ybronhei(a)redhat.com > > remote: ERROR: > > remote: ERROR: To register an email address, please visit: > > remote: ERROR: https://gerrit.ovirt.org/#/settings/contact > > remote: > > remote: > > To ssh://ybronhei@gerrit.ovirt.org:29418/vdsm > > ! [remote rejected] HEAD -> refs/for/master (invalid author) > > error: failed to push some refs to > > 'ssh://ybronhei@gerrit.ovirt.org:29418/vdsm' > > > > We must have permissions to do that, this is part of the rebasing part, and > > I think its fine to fix patches on behalf of someone else.. but its not the > > best practice for reviewing. > > anyway, please undo this change, unless its something that related only to > > my env.. let me know > > > > Thanks > > > > -- > > Yaniv Bronhaim. > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

1 0

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit
by eyal edri [Administrator] (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.p… ] eyal edri [Administrator] commented on OVIRT-900: ------------------------------------------------- OK, so as I suggested its best to verify the list of people in those groups and add/remove people who are missing. > Re: Rebase over other author's patch cannot be pushed to gerrit > --------------------------------------------------------------- > > Key: OVIRT-900 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Barak Korren > Assignee: Shlomo Ben David > > Forwarding to infra-support. > On 1 December 2016 at 18:03, Yaniv Bronheim <ybronhei(a)redhat.com> wrote: > > Not sure since when it was changed, but I noticed that I can't push patches > > if I'm not the author > > > > Counting objects: 50, done. > > Delta compression using up to 4 threads. > > Compressing objects: 100% (50/50), done. > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done. > > Total 50 (delta 34), reused 0 (delta 0) > > remote: Resolving deltas: 100% (34/34) > > remote: Processing changes: refs: 1, done > > remote: > > remote: ERROR: In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4 > > remote: ERROR: author email address rnachimu(a)redhat.com > > remote: ERROR: does not match your user account. > > remote: ERROR: > > remote: ERROR: The following addresses are currently registered: > > remote: ERROR: bronhaim(a)gmail.com > > remote: ERROR: ybronhei(a)redhat.com > > remote: ERROR: > > remote: ERROR: To register an email address, please visit: > > remote: ERROR: https://gerrit.ovirt.org/#/settings/contact > > remote: > > remote: > > To ssh://ybronhei@gerrit.ovirt.org:29418/vdsm > > ! [remote rejected] HEAD -> refs/for/master (invalid author) > > error: failed to push some refs to > > 'ssh://ybronhei@gerrit.ovirt.org:29418/vdsm' > > > > We must have permissions to do that, this is part of the rebasing part, and > > I think its fine to fix patches on behalf of someone else.. but its not the > > best practice for reviewing. > > anyway, please undo this change, unless its something that related only to > > my env.. let me know > > > > Thanks > > > > -- > > Yaniv Bronhaim. > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

2 1

[JIRA] (OVIRT-902) Speed up mock_runner.sh setup time by using caches.
by Barak Korren (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-902?page=com.atlassian.jira.p… ] Barak Korren reassigned OVIRT-902: ---------------------------------- Assignee: Barak Korren (was: infra) > Speed up mock_runner.sh setup time by using caches. > --------------------------------------------------- > > Key: OVIRT-902 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-902 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Reporter: Barak Korren > Assignee: Barak Korren > Priority: High > Labels: mock, mock_runner.sh, standard-ci > > We've already known that setting up mock takes a while, but mock has some built-in caching features that should allow us to speed this up. > We need to ensure those features are enabled by mock_runner.sh. The mock options to look at are: > * root_cache_enable > * yum_cache_enable > Both these options should be set to true in the mock chroot config file. > We've been using these option downstream in minimead and the vdsm build scripts, so they should be safe to use. -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

1 0

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit
by Shlomo Ben David (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.p… ] Shlomo Ben David commented on OVIRT-900: ---------------------------------------- Only the 'vdsm-master-maintainers' group have full permissions on the master branch (and 'vdsm-maintainers' group as the owner of the project) The user has permission as a registered user: push, verify, code-review on the 'master' branch because he is not a member of that group. > Re: Rebase over other author's patch cannot be pushed to gerrit > --------------------------------------------------------------- > > Key: OVIRT-900 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Barak Korren > Assignee: Shlomo Ben David > > Forwarding to infra-support. > On 1 December 2016 at 18:03, Yaniv Bronheim <ybronhei(a)redhat.com> wrote: > > Not sure since when it was changed, but I noticed that I can't push patches > > if I'm not the author > > > > Counting objects: 50, done. > > Delta compression using up to 4 threads. > > Compressing objects: 100% (50/50), done. > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done. > > Total 50 (delta 34), reused 0 (delta 0) > > remote: Resolving deltas: 100% (34/34) > > remote: Processing changes: refs: 1, done > > remote: > > remote: ERROR: In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4 > > remote: ERROR: author email address rnachimu(a)redhat.com > > remote: ERROR: does not match your user account. > > remote: ERROR: > > remote: ERROR: The following addresses are currently registered: > > remote: ERROR: bronhaim(a)gmail.com > > remote: ERROR: ybronhei(a)redhat.com > > remote: ERROR: > > remote: ERROR: To register an email address, please visit: > > remote: ERROR: https://gerrit.ovirt.org/#/settings/contact > > remote: > > remote: > > To ssh://ybronhei@gerrit.ovirt.org:29418/vdsm > > ! [remote rejected] HEAD -> refs/for/master (invalid author) > > error: failed to push some refs to > > 'ssh://ybronhei@gerrit.ovirt.org:29418/vdsm' > > > > We must have permissions to do that, this is part of the rebasing part, and > > I think its fine to fix patches on behalf of someone else.. but its not the > > best practice for reviewing. > > anyway, please undo this change, unless its something that related only to > > my env.. let me know > > > > Thanks > > > > -- > > Yaniv Bronhaim. > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > -- > Barak Korren > bkorren(a)redhat.com > RHCE, RHCi, RHV-DevOps Team > https://ifireball.wordpress.com/ -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

1 0

[JIRA] (OVIRT-903) master-to-master CI upgrade tests
by eyal edri [Administrator] (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-903?page=com.atlassian.jira.p… ] eyal edri [Administrator] commented on OVIRT-903: ------------------------------------------------- Also, you might want to change the ticket name for " fixing/updating upgrade job" the current title is misleading On Sun, Dec 4, 2016 at 1:11 PM, eyal edri [Administrator] (oVirt JIRA) < -- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ) > master-to-master CI upgrade tests > --------------------------------- > > Key: OVIRT-903 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-903 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Yedidyah Bar David > Assignee: infra > > Hi all, > Recently a patch to the engine [1] added a new package, > with a certain set of dependencies, which broke upgrade. > This is similar to [2] but for a new package. > CI wasn't affected, I think because of [3]. > To make CI test such flows, we should have a job that: > 1. Builds, installs and sets up the version we want to test > 2. Pushes a dummy change to the local git repo (to force > a new version), build the patched tree, create a yum repo > with the build and add it to yum.repos.d. > 3. yum update > 4. engine-setup > Another option is to revert [3], or to duplicate - have > both "upgrade current to self" and "upgrade latest snapshot > to current". The downside is that it will be checked later > than above plan - instead of in the same build, will only > be tested in the first build that uses the snapshot after > it was updated, and also will be misleading, as the reason > why that job failed will not be apparent (which was why > [3] was added). > Please handle. I can of course try to help. Best, > [1] https://gerrit.ovirt.org/66999 > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1321249 > [3] https://gerrit.ovirt.org/67263 > -- > Didi -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

1 0

[JIRA] (OVIRT-903) master-to-master CI upgrade tests
by eyal edri [Administrator] (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-903?page=com.atlassian.jira.p… ] eyal edri [Administrator] commented on OVIRT-903: ------------------------------------------------- well, depending on the amount of effort needed to update the job, we might want to wait with it until the jobs are moved to an ost suit, which is in progress. On Dec 4, 2016 13:07, "Yedidyah Bar David" <didi(a)redhat.com> wrote: On Sun, Dec 4, 2016 at 11:06 AM, eyal edri [Administrator] (oVirt atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel&focusedCommentId=23805#comment-23805 ] from-master_el7_merged/ Indeed, and I explained in the ticket why it's not enough as-is. Best, -- Didi _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra > master-to-master CI upgrade tests > --------------------------------- > > Key: OVIRT-903 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-903 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Yedidyah Bar David > Assignee: infra > > Hi all, > Recently a patch to the engine [1] added a new package, > with a certain set of dependencies, which broke upgrade. > This is similar to [2] but for a new package. > CI wasn't affected, I think because of [3]. > To make CI test such flows, we should have a job that: > 1. Builds, installs and sets up the version we want to test > 2. Pushes a dummy change to the local git repo (to force > a new version), build the patched tree, create a yum repo > with the build and add it to yum.repos.d. > 3. yum update > 4. engine-setup > Another option is to revert [3], or to duplicate - have > both "upgrade current to self" and "upgrade latest snapshot > to current". The downside is that it will be checked later > than above plan - instead of in the same build, will only > be tested in the first build that uses the snapshot after > it was updated, and also will be misleading, as the reason > why that job failed will not be apparent (which was why > [3] was added). > Please handle. I can of course try to help. Best, > [1] https://gerrit.ovirt.org/66999 > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1321249 > [3] https://gerrit.ovirt.org/67263 > -- > Didi -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

2 1

Re: [JIRA] (OVIRT-903) master-to-master CI upgrade tests
by Eyal Edri 04 Dec '16

04 Dec '16

well, depending on the amount of effort needed to update the job, we might want to wait with it until the jobs are moved to an ost suit, which is in progress. On Dec 4, 2016 13:07, "Yedidyah Bar David" <didi(a)redhat.com> wrote: On Sun, Dec 4, 2016 at 11:06 AM, eyal edri [Administrator] (oVirt JIRA) <jira(a)ovirt-jira.atlassian.net> wrote: > > [ https://ovirt-jira.atlassian.net/browse/OVIRT-903?page=com. atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel&focusedCommentId=23805#comment-23805 ] > > eyal edri [Administrator] commented on OVIRT-903: > ------------------------------------------------- > > We have master->master upgrade job: > http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade- from-master_el7_merged/ Indeed, and I explained in the ticket why it's not enough as-is. Best, -- Didi _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

1 0

[JIRA] (OVIRT-903) master-to-master CI upgrade tests
by Yedidyah Bar David (oVirt JIRA) 04 Dec '16

04 Dec '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-903?page=com.atlassian.jira.p… ] Yedidyah Bar David commented on OVIRT-903: ------------------------------------------ On Sun, Dec 4, 2016 at 11:06 AM, eyal edri [Administrator] (oVirt Indeed, and I explained in the ticket why it's not enough as-is. Best, -- Didi > master-to-master CI upgrade tests > --------------------------------- > > Key: OVIRT-903 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-903 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Yedidyah Bar David > Assignee: infra > > Hi all, > Recently a patch to the engine [1] added a new package, > with a certain set of dependencies, which broke upgrade. > This is similar to [2] but for a new package. > CI wasn't affected, I think because of [3]. > To make CI test such flows, we should have a job that: > 1. Builds, installs and sets up the version we want to test > 2. Pushes a dummy change to the local git repo (to force > a new version), build the patched tree, create a yum repo > with the build and add it to yum.repos.d. > 3. yum update > 4. engine-setup > Another option is to revert [3], or to duplicate - have > both "upgrade current to self" and "upgrade latest snapshot > to current". The downside is that it will be checked later > than above plan - instead of in the same build, will only > be tested in the first build that uses the snapshot after > it was updated, and also will be misleading, as the reason > why that job failed will not be apparent (which was why > [3] was added). > Please handle. I can of course try to help. Best, > [1] https://gerrit.ovirt.org/66999 > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1321249 > [3] https://gerrit.ovirt.org/67263 > -- > Didi -- This message was sent by Atlassian JIRA (v1000.610.2#100023)

1 0