- Infra - oVirt List Archives

[JIRA] (OVIRT-801) [gerrit hooks] enable check_bug_url for master branch
by Shlomo Ben David (oVirt JIRA) 31 Oct '16

31 Oct '16

Shlomo Ben David created OVIRT-801: -------------------------------------- Summary: [gerrit hooks] enable check_bug_url for master branch Key: OVIRT-801 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-801 Project: oVirt - virtualization made easy Issue Type: Task Reporter: Shlomo Ben David Assignee: infra - Currently we are not checking bug urls for master branch. - We need to enable check_bug_url for master branch and set it to be optional for 'master' branch but mandatory for 'stable' branches. -- This message was sent by Atlassian JIRA (v1000.482.3#100017)

1 0

[JIRA] (OVIRT-801) [gerrit hooks] enable check_bug_url for master branch
by Shlomo Ben David (oVirt JIRA) 31 Oct '16

31 Oct '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-801?page=com.atlassian.jira.p… ] Shlomo Ben David reassigned OVIRT-801: -------------------------------------- Assignee: Shlomo Ben David (was: infra) > [gerrit hooks] enable check_bug_url for master branch > ----------------------------------------------------- > > Key: OVIRT-801 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-801 > Project: oVirt - virtualization made easy > Issue Type: Task > Reporter: Shlomo Ben David > Assignee: Shlomo Ben David > > - Currently we are not checking bug urls for master branch. > - We need to enable check_bug_url for master branch and set it to be optional for 'master' > branch but mandatory for 'stable' branches. -- This message was sent by Atlassian JIRA (v1000.482.3#100017)

1 0

[oVirt Jenkins] 'test-repo_ovirt_experimental_3.6' - Build #3149 - SUCCESS!
by jenkins＠jenkins.phx.ovirt.org 31 Oct '16

31 Oct '16

------=_Part_411_199881220.1477928070722 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Build: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_3.6/3149/, Build Number: 3149, Build Status: SUCCESS ------=_Part_411_199881220.1477928070722--

1 0

[JIRA] (OVIRT-800) Build oVirt 4.0.5 RC5
by sbonazzo (oVirt JIRA) 31 Oct '16

31 Oct '16

sbonazzo created OVIRT-800: ------------------------------ Summary: Build oVirt 4.0.5 RC5 Key: OVIRT-800 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-800 Project: oVirt - virtualization made easy Issue Type: Task Components: Repositories Mgmt Reporter: sbonazzo Assignee: infra Priority: Highest -- This message was sent by Atlassian JIRA (v1000.482.3#100017)

1 0

[JIRA] (OVIRT-800) Build oVirt 4.0.5 RC5
by sbonazzo (oVirt JIRA) 31 Oct '16

31 Oct '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-800?page=com.atlassian.jira.p… ] sbonazzo updated OVIRT-800: --------------------------- Epic Link: OVIRT-411 > Build oVirt 4.0.5 RC5 > --------------------- > > Key: OVIRT-800 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-800 > Project: oVirt - virtualization made easy > Issue Type: Task > Components: Repositories Mgmt > Reporter: sbonazzo > Assignee: infra > Priority: Highest > -- This message was sent by Atlassian JIRA (v1000.482.3#100017)

1 0

[JIRA] (OVIRT-800) Build oVirt 4.0.5 RC5
by sbonazzo (oVirt JIRA) 31 Oct '16

31 Oct '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-800?page=com.atlassian.jira.p… ] sbonazzo reassigned OVIRT-800: ------------------------------ Assignee: lveyde (was: infra) > Build oVirt 4.0.5 RC5 > --------------------- > > Key: OVIRT-800 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-800 > Project: oVirt - virtualization made easy > Issue Type: Task > Components: Repositories Mgmt > Reporter: sbonazzo > Assignee: lveyde > Priority: Highest > -- This message was sent by Atlassian JIRA (v1000.482.3#100017)

1 0

Subject: oVirt 4.0.5 RC5 merge / branch / tag / bugzilla reminder
by Sandro Bonazzola 31 Oct '16

31 Oct '16

All stable branch maintainers, please make sure to - merge all relevant open bugs until Wednesday morning 11:00 AM TLV time. For each package that need to be built (i.e oVirt product) please make sure every bug in MODIFIED has the right Target Release and Target Milestone. A Target release should state the version of the package you're building and should include the same version you used for the tag you just used for this build. (e.g. for ovirt-engine, tag: ovirt-engine-4.0.5, tr: 4.0.5) A list of bugs that require attention is here: - https://bugzilla.redhat.com/buglist.cgi?quicksearch=target_milestone%3A4.0.… -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>

1 0

Gerrit emails - Returned mail: see transcript for details
by Martin Sivak 31 Oct '16

31 Oct '16

Hi, there might be something bad in our SPF config. Please check. Martin ---------- Forwarded message ---------- From: Mail Delivery Subsystem <MAILER-DAEMON(a)gerrit.ovirt.org> Date: Mon, Oct 31, 2016 at 2:05 PM Subject: Returned mail: see transcript for details To: msivak(a)redhat.com The original message was received at Mon, 31 Oct 2016 09:05:24 -0400 from gerrit.ovirt.org [127.0.0.1] ----- The following addresses had permanent fatal errors ----- <laravot(a)redhat.com> (reason: 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT) <akrejcir(a)redhat.com> (reason: 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT) <ahadas(a)redhat.com> (reason: 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT) ----- Transcript of session follows ----- ... while talking to mx1.redhat.com.: >>> DATA <<< 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT 550 5.1.1 <ahadas(a)redhat.com>... User unknown <<< 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT 550 5.1.1 <akrejcir(a)redhat.com>... User unknown <<< 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT 550 5.1.1 <laravot(a)redhat.com>... User unknown <<< 554 5.5.1 Error: no valid recipients Final-Recipient: RFC822; laravot(a)redhat.com Action: failed Status: 5.7.1 Remote-MTA: DNS; mx1.redhat.com Diagnostic-Code: SMTP; 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT Last-Attempt-Date: Mon, 31 Oct 2016 09:05:25 -0400 Final-Recipient: RFC822; akrejcir(a)redhat.com Action: failed Status: 5.7.1 Remote-MTA: DNS; mx1.redhat.com Diagnostic-Code: SMTP; 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT Last-Attempt-Date: Mon, 31 Oct 2016 09:05:25 -0400 Final-Recipient: RFC822; ahadas(a)redhat.com Action: failed Status: 5.7.1 Remote-MTA: DNS; mx1.redhat.com Diagnostic-Code: SMTP; 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT Last-Attempt-Date: Mon, 31 Oct 2016 09:05:25 -0400 ---------- Forwarded message ---------- From: msivak(a)redhat.com To: Arik Hadas <ahadas(a)redhat.com> Cc: Andrej Krejcir <akrejcir(a)redhat.com>, Liron Aravot <laravot(a)redhat.com> Date: Mon, 31 Oct 2016 09:05:24 -0400 Subject: Change in ovirt-engine[master]: core: Update OVF in storage domains for HE VM edit Hello Arik Hadas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/65085 to review the following change. Change subject: core: Update OVF in storage domains for HE VM edit ...................................................................... core: Update OVF in storage domains for HE VM edit Updating hosted engine VM saves OVF to storage domain as well as to the DB. This patch is complementary to: https://gerrit.ovirt.org/#/c/51842 Change-Id: Ib02d41136458677399428c62c8e475b4cb2fcb79 Bug-Url: https://bugzilla.redhat.com/1372000 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java 2 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/65085/3 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java index 3c0bada..9c64003 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java @@ -22,6 +22,7 @@ import org.ovirt.engine.core.bll.quota.QuotaConsumptionParameter; import org.ovirt.engine.core.bll.quota.QuotaSanityParameter; import org.ovirt.engine.core.bll.quota.QuotaVdsDependent; +import org.ovirt.engine.core.bll.storage.ovfstore.OvfDataUpdater; import org.ovirt.engine.core.bll.utils.IconUtils; import org.ovirt.engine.core.bll.utils.PermissionSubject; import org.ovirt.engine.core.bll.validator.IconValidator; @@ -37,7 +38,6 @@ import org.ovirt.engine.core.common.action.LockProperties; import org.ovirt.engine.core.common.action.LockProperties.Scope; import org.ovirt.engine.core.common.action.PlugAction; -import org.ovirt.engine.core.common.action.ProcessOvfUpdateForStoragePoolParameters; import org.ovirt.engine.core.common.action.RngDeviceParameters; import org.ovirt.engine.core.common.action.UpdateVmVersionParameters; import org.ovirt.engine.core.common.action.VdcActionType; @@ -178,7 +178,17 @@ // Trigger OVF update for hosted engine VM only if (getVm().isHostedEngine()) { - registerRollbackHandler(new HostedEngineEditNotifier(getVm())); + registerRollbackHandler(new TransactionCompletionListener() { + @Override + public void onSuccess() { + OvfDataUpdater.getInstance().triggerNow(); + } + + @Override + public void onRollback() { + // No notification is needed + } + }); } // save user selected value for hotplug before overriding with db values (when updating running vm) @@ -1150,25 +1160,6 @@ public VmValidator createVmValidator(VM vm) { return new VmValidator(vm); - } - - private static class HostedEngineEditNotifier implements TransactionCompletionListener { - final VM vm; - - public HostedEngineEditNotifier(VM vm) { - this.vm = vm; - } - - @Override - public void onSuccess() { - Backend.getInstance().runInternalAction(VdcActionType.ProcessOvfUpdateForStoragePool, - new ProcessOvfUpdateForStoragePoolParameters(vm.getStoragePoolId())); - } - - @Override - public void onRollback() { - // No notification is needed - } } protected InClusterUpgradeValidator getClusterUpgradeValidator() { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java index 6dc3881..788e046 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java @@ -27,6 +27,8 @@ private static final Logger log = LoggerFactory.getLogger(OvfDataUpdater.class); private static final OvfDataUpdater INSTANCE = new OvfDataUpdater(); + private volatile String updateTimerJobId; + private OvfDataUpdater() { } @@ -40,7 +42,7 @@ public void initOvfDataUpdater() { SchedulerUtil scheduler = Injector.get(SchedulerUtilQuartzImpl.class); - scheduler.scheduleAFixedDelayJob(this, "ovfUpdateTimer", new Class[] {}, + updateTimerJobId = scheduler.scheduleAFixedDelayJob(this, "ovfUpdateTimer", new Class[] {}, new Object[] {}, Config.<Integer> getValue(ConfigValues.OvfUpdateIntervalInMinutes), Config.<Integer> getValue(ConfigValues.OvfUpdateIntervalInMinutes), TimeUnit.MINUTES); log.info("Initialization of OvfDataUpdater completed successfully."); @@ -84,4 +86,11 @@ } } } + + public void triggerNow() { + if (updateTimerJobId != null) { + SchedulerUtil scheduler = Injector.get(SchedulerUtilQuartzImpl.class); + scheduler.triggerJob(updateTimerJobId); + } + } } -- To view, visit https://gerrit.ovirt.org/65085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib02d41136458677399428c62c8e475b4cb2fcb79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

2 1

[JIRA] (OVIRT-799) Gerrit emails - Returned mail: see transcript for details
by Evgheni Dereveanchin (oVirt JIRA) 31 Oct '16

31 Oct '16

Evgheni Dereveanchin created OVIRT-799: ------------------------------------------ Summary: Gerrit emails - Returned mail: see transcript for details Key: OVIRT-799 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-799 Project: oVirt - virtualization made easy Issue Type: Bug Reporter: Evgheni Dereveanchin Assignee: infra Mails coming from Gerrit are rejected by Red Hat due to the change in SPF policy enforcement: <<< 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT This likely happens due to the fact that Gerrit uses the authors emails in the From: field which is likely to be marked as SPAM. We should use a sender address in the ovirt.org domain for all mail sent by Gerrit to avoid this. -- This message was sent by Atlassian JIRA (v1000.482.3#100017)

1 0

[JIRA] (OVIRT-799) Gerrit emails - Returned mail: see transcript for details
by Evgheni Dereveanchin (oVirt JIRA) 31 Oct '16

31 Oct '16

[ https://ovirt-jira.atlassian.net/browse/OVIRT-799?page=com.atlassian.jira.p… ] Evgheni Dereveanchin reassigned OVIRT-799: ------------------------------------------ Assignee: Shlomo Ben David (was: infra) > Gerrit emails - Returned mail: see transcript for details > --------------------------------------------------------- > > Key: OVIRT-799 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-799 > Project: oVirt - virtualization made easy > Issue Type: Bug > Reporter: Evgheni Dereveanchin > Assignee: Shlomo Ben David > > Mails coming from Gerrit are rejected by Red Hat due to the change in SPF policy enforcement: > <<< 551 5.7.1 SPF fail: 'gerrit.ovirt.org'[107.22.212.69], 'redhat.com'; REJECT > This likely happens due to the fact that Gerrit uses the authors emails in the From: field which is likely to be marked as SPAM. We should use a sender address in the ovirt.org domain for all mail sent by Gerrit to avoid this. -- This message was sent by Atlassian JIRA (v1000.482.3#100017)

1 0