Re: Fwd: Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely

On 02/02 11:45, Yedidyah Bar David wrote: > (Sorry, this time to the right address) > > > ---------- Forwarded message ---------- > From: Yedidyah Bar David <didi(a)redhat.com&gt; > Date: Sun, Jan 31, 2016 at 1:20 PM > Subject: Re: Change in ovirt-engine[ovirt-engine-3.6]: packaging: > rename: Handle storage domains more nicely > To: Jenkins CI <gerrit2(a)gerrit.ovirt.org&gt; > > > On Sun, Jan 31, 2016 at 12:57 PM, Jenkins CI <gerrit2(a)gerrit.ovirt.org&gt; wrote: > > Jenkins CI has posted comments on this change. > > > > Change subject: packaging: rename: Handle storage domains more nicely > > ...................................................................... > > > > > > Patch Set 1: Continuous-Integration-1 > > > > Build Failed > > > > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el6-x86_64/1312/ : FAILURE > > > > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-el7-x86_64/1410/ : FAILURE > > Both of these are pep8: > > packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:311:21: > E126 continuation line over-indented for hanging indent > packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py:312:21: > E126 continuation line over-indented for hanging indent > > > > > http://jenkins.ovirt.org/job/ovirt-engine_3.6_check-patch-fc23-x86_64/1004/ : SUCCESS > > How come this one passed? > > Do we have different versions/configuration of pep8 in different > OSes? Unless you are explicitly specifying a version of pep8 yes, they probably have different versions for different oses.

> > Also note that E126 is ignored by default, see e.g.: > > https://github.com/PyCQA/pep8/issues/265 > https://github.com/PyCQA/pep8/pull/360 > It's up to the project owners to decide what to test and how, for what I can see the script that runs pep8/pyflakes on the code is under, build/python-check.sh.in, and it was written by abarlev, so maybe you should talk to whomever inherited he's responsabilities (I don't know who that is, sorry, try on devel list)