Re: your patch https://gerrit.ovirt.org/#/c/40346/ broke oVirt vdsm jobs

hi, Dan. makes sense to me to focus on 2 use cases: - pre-commit hook running everything jenkins is running - locally

- pros: - nearly identical checks/tests jenkins would running - doesn't care about IDE/editor - cons: - slower - can be annoying to commit (locally) broken code for later squashing =20 - editor/IDE marriage with tests/checks running - pros: - dev has full control over what runs in checks/tests - allows to commit "dirty" commit - shorter =3D=3D> quicker than the quickest jenkins option - cons: - depends on IDE/editor support - less checks/tests =3D> higher risk =20 I did both with: intelliJ/PyCharm and vim, almost 100% sure PyDev allows =

=20 either allows ease of running tests - in 1st case upon git commit, in the latter - via a button/shortcut in the devtool. I can help with setting up either to an early adopter. Then give it a week or two to get some feedback later how well it goes. =20 Besides, we're also trying to speedup jenkins response all the time =20 WDYT? =20 =20 =20 =20 On Wed, Apr 29, 2015 at 10:57:14PM +0100, Dan Kenigsberg wrote: > On Wed, Apr 29, 2015 at 11:16:37AM -0400, Barak Korren wrote: > > Patch does not pass pyflakes: > > > > ./tests/samplingTests.py:30: 'libvirtconnection' imported but unused > > ./tests/samplingTests.py:36: 'MonkeyPatch' imported but unused > > make: *** [pyflakes] Error 1 > > > > You could clearly see that the tests did not pass for patchset #6 > > Please do not merge patches with failing tests! > > Barak, thanks for reporting this mistake of ours. > https://gerrit.ovirt.org/#/c/40408/ would fix it momentarily. > > I believe that it stems from two reasons: > - Ido did not run `make check` or `make pyflakes` before ticking > "verified" on the patch > - I failed to wait for the jenkins job to finish. > > To make sure that this does not repeat I should avoid merging > freshly-posted patches. Ido should take better care for pep8 and > pyflakes. I have vim plugins that help me avoid such mistakes > I hear that http://www.vim.org/scripts/script.php?script_id=3D4440 is > better than what I actually have. > > Regards, > Dan. > ---end quoted text--- =20 -- Max Kovgan =20 Senior Software Engineer Red Hat - EMEA ENG Virtualization R&D Tel.: +972 9769 2060 Email: mkovgan [at] redhat [dot] com Web: http://www.redhat.com RHT Global #: 82-72060

_______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVSHsdAAoJEEBxx+HSYmnDgGMH/14wSRAlcNGQlThBM98PkQG1 cwjVBVTaHUdr2gngaMoxDyR5V7uou99WYMYNnJDM5zcTlqulaN2NMAkouKtHeCJs bAJkWjKCFyAnvvFUpX/y6Ktjt+0JlO5NvhG4Hreq4iC+YafJ8luPAgV/5RJ/8b2P p1dAdnt/G0qykarecPYNL65iteLQfT/WZSI59m8xfyrAqGch9Hhm0OPSaNILvg3l Yw3iPbXiAMbpOkcuVStY3+oJiD4OEKvphiQ8RUWhqhw2MWavlE78+7hlVQXxW57A aO6I/JHHHC4GKdmXIT0Oi0Q1PJ8p5zrJ4Xa57JSHoumzlkR/RGik/zTNbhb1I6U= =+Ewf -----END PGP SIGNATURE-----