This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--aea2b0PgCn5HD67RexwFcgX827SEvUFqP
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
On Tue 17 Jun 2014 10:24:49 AM CEST, Dan Kenigsberg wrote:
On Tue, Jun 17, 2014 at 03:40:51AM -0400, Vered Volansky wrote:
>
>
> ----- Original Message -----
>> From: "Dan Kenigsberg" <danken(a)redhat.com>
>> To: "Vered Volansky" <vered(a)redhat.com>
>> Cc: "infra" <infra(a)ovirt.org>
>> Sent: Monday, June 16, 2014 11:29:42 AM
>> Subject: Re: Bad setup code in vdsm_master_storage_functional_tests_l=
ocalfs_gerrit
>>
>> On Sun, Jun 15, 2014 at 04:11:53AM -0400, Vered Volansky wrote:
>>> The job with this issue is gone, let me know if it's risen again.
>>
>> The fragile code is still in
>>
http://jenkins.ovirt.org/view/All/job/vdsm_master_storage_functional_=
tests_localfs_gerrit/configure
>> why not make it more robust before /var/log/vdsm disappears
and make =
it
>> break again?
>
> because I don't understand the issue. The file is only created if
> missing. The directory should be there.
It was fixed by me some time ago (I added the mkdir -p before the=20
touch, just in case)
sudo mkdir -p /var/log/vdsm
sudo chown vdsm:kvm
sudo sh -c 'echo "" > /var/log/vdsm/vdsm.log'
sudo sh -c 'echo "" > /var/log/vdsm/supervdsm.log'
However, apparently it was not there, which made the echo fail, which
led to the job failing. We should understand why it disappeared.
dcaro, eedri - do you have any idea?
Totally agree, and, if it was meant to be there, I'll remove the mkdir=20
to make the test fail if it's not there.
But for what I see on the job, there's nothing that ensures you that=20
the directory will be there, vdsm might never have been installed on=20
that machine, or might have been properly cleaned at some point=20
(removing logs and leftovers).
So, In my opinion the issue is that we are not cleaning up properly=20
after the vdsm jobs and leaving the logs behind.
Also, to which point can these tests run on docker? Anyone have tried?=20
Because it would make it fit to be run in parallel and on any slave=20
with any specific deps.
--
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro(a)redhat.com
Web:
www.redhat.com
RHT Global #: 82-62605
--aea2b0PgCn5HD67RexwFcgX827SEvUFqP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJTn/1UAAoJEEBxx+HSYmnDgOkH/3elCRKZyw+SuTdrpTKKjeCJ
q38TSjRMWUl+RG0sm13QfN3i+mADgrNScvzSXujQrETiFHZpa5tI5Jp9iuCUsYE9
36Q1NIOb5Te7dIa+IJBcbvc44L7KEKPBv0RFxsiQiMEv05K8FsaW1z3RuM0InlIC
z8N5jYOFgbb2+4x9loWzT8+PkQgwptYX/VSGrgMB7Mpgeqy/40jq+NK9Wp+uMw51
LueNxdZwdP7Dr+SKg3xmJCv95Hygbl7DHgpiEECv3aCUZONCWuzBdULZURvSeLcn
qwJ/zTTsd/ZSPFKopjvNGYWV0zBdvXXx6gHhTqmzwxEZpAo9IK47AHxIzrJy8K0=
=8wxD
-----END PGP SIGNATURE-----
--aea2b0PgCn5HD67RexwFcgX827SEvUFqP--