Infra scripting style guide proposal
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rRmM8sVGfCgpNRVi44ORWtJIn8JVIFknC Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi everyone, Following the discussion thread and seeing that there's no more input the= re, I'd like to propose this style guide: http://www.ovirt.org/Bash_style_guide As standard for our infrastructure scripts and guideline when reviewing s= cripts. All the infra members please review the style guide and answer this email= with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add= also a description of the problems you see so we can work on them. All the non-infra people, you are welcome to vote also and give input, bu= t your single vote will not be decisive. I'll close the voting next monday if no changes to the Style guide are pr= oposed. Thanks! dcaro +1 --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --rRmM8sVGfCgpNRVi44ORWtJIn8JVIFknC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTHg+5AAoJEEBxx+HSYmnDh9wH/3pKMrStWQB8Z0i/NNKB8siM M9ARLBhPGbjoS5fbIrOyDuXlXRgRj7xbdA5PZF6xmiZnlftE+Eb5LXLW/S5X6NDa hzl0YNSRAWAoci/MMpnrbXnh4FokK0EfVoSwapltl6ugP40kLnrAYo6CrU4GiYdl xQGwUlPKvh2MstFy+WKDuJHbun3L1DOdcxxtAbU17WwwGUxYteKhbZnICnB1Cqhp WV+BIkapZyO1YkT2WN1STHkMmAlPCltPU9vrN1g8VTblgnMZj4xuQFj7CrZ/hYpw Xuk4wLUh/Ut7SOCgfz8ideKV4ITP53teHt4AFvIv13tVOLs1nLEkyT99kVuH79M= =5pPM -----END PGP SIGNATURE----- --rRmM8sVGfCgpNRVi44ORWtJIn8JVIFknC--
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, March 10, 2014 9:17:13 PM Subject: Infra scripting style guide proposal
Hi everyone,
Following the discussion thread and seeing that there's no more input there, I'd like to propose this style guide:
http://www.ovirt.org/Bash_style_guide
As standard for our infrastructure scripts and guideline when reviewing scripts.
All the infra members please review the style guide and answer this email with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add also a description of the problems you see so we can work on them.
Hi David First of all thanks for your efforts in writing that, I am certainly for standards. However, I feel that we have to decide what kind of scripts we want to write. Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' from the infra code, lately we had turned all dbscripts/dbutils code from bash to POSIX. So, I think that we should decide first on the direction ('to bash or not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differently, and even if each has its code style guidelines, I believe that it makes our development environment harder to maintain and more buggy ...
All the non-infra people, you are welcome to vote also and give input, but your single vote will not be decisive.
I'll close the voting next monday if no changes to the Style guide are proposed.
Thanks!
dcaro +1
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 1:32:40 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, March 10, 2014 9:17:13 PM Subject: Infra scripting style guide proposal
Hi everyone,
Following the discussion thread and seeing that there's no more input there, I'd like to propose this style guide:
http://www.ovirt.org/Bash_style_guide
As standard for our infrastructure scripts and guideline when reviewing scripts.
All the infra members please review the style guide and answer this email with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add also a description of the problems you see so we can work on them.
Hi David First of all thanks for your efforts in writing that, I am certainly for standards. However, I feel that we have to decide what kind of scripts we want to write. Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' from the infra code, lately we had turned all dbscripts/dbutils code from bash to POSIX. So, I think that we should decide first on the direction ('to bash or not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differently, and even if each has its code style guidelines, I believe that it makes our development environment harder to maintain and more buggy ...
Hello Eli, Scripts that are going to be shipped with the product should be written in POSIX shell and this is correct. But here we are talking about scripts that we (infra team) are going to use to maintain our infrastructure - so there should be no problem to use bash here, since those scripts wont be shipped with the product. - Kiril
All the non-infra people, you are welcome to vote also and give input, but your single vote will not be decisive.
I'll close the voting next monday if no changes to the Style guide are proposed.
Thanks!
dcaro +1
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Correct. It seems that ovirt is targeted also to non-gnu oses (in the future I suppose) so portability inside the product is an issue, thus making the strict POSIX standard the appropriate tool. I'm not sure if there's any milestone set for that, but as I see it, is quite far, as I've been more than one year in the project, and we haven't got out of redhat based distributions, I see really hard to support non-gnu oses but if that's what was decided, let's go for it. But for any script we use to maintain the infrastructure of the project, from running a jenkins job, to creating repositories or adding a nagios check, we don't need to limit ourselves with POSIX, so we can benefit from the whole range of advantages and features bash offers and that gives us easy to write and easy to read scripts, making it easier to maintain and debug. ----- Original Message -----
From: "Kiril Nesenko" <knesenko@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "David Caro" <dcaroest@redhat.com>, "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 9:11:28 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 1:32:40 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, March 10, 2014 9:17:13 PM Subject: Infra scripting style guide proposal
Hi everyone,
Following the discussion thread and seeing that there's no more input there, I'd like to propose this style guide:
http://www.ovirt.org/Bash_style_guide
As standard for our infrastructure scripts and guideline when reviewing scripts.
All the infra members please review the style guide and answer this email with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add also a description of the problems you see so we can work on them.
Hi David First of all thanks for your efforts in writing that, I am certainly for standards. However, I feel that we have to decide what kind of scripts we want to write. Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' from the infra code, lately we had turned all dbscripts/dbutils code from bash to POSIX. So, I think that we should decide first on the direction ('to bash or not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differently, and even if each has its code style guidelines, I believe that it makes our development environment harder to maintain and more buggy ...
Hello Eli,
Scripts that are going to be shipped with the product should be written in POSIX shell and this is correct. But here we are talking about scripts that we (infra team) are going to use to maintain our infrastructure - so there should be no problem to use bash here, since those scripts wont be shipped with the product.
- Kiril
All the non-infra people, you are welcome to vote also and give input, but your single vote will not be decisive.
I'll close the voting next monday if no changes to the Style guide are proposed.
Thanks!
dcaro +1
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
I strongly feel the wiki page name should reflect that it is for infra. The current name is very generic and leads to assuptions that it's for the entire project. And you know what happens when you assume[1]. Other than that, I agree with you. [1]: https://xkcd.com/1339/ On Tue, Mar 11, 2014 at 04:35:11AM -0400, David Caro Estevez wrote:
Correct.
It seems that ovirt is targeted also to non-gnu oses (in the future I suppose) so portability inside the product is an issue, thus making the strict POSIX standard the appropriate tool. I'm not sure if there's any milestone set for that, but as I see it, is quite far, as I've been more than one year in the project, and we haven't got out of redhat based distributions, I see really hard to support non-gnu oses but if that's what was decided, let's go for it.
But for any script we use to maintain the infrastructure of the project, from running a jenkins job, to creating repositories or adding a nagios check, we don't need to limit ourselves with POSIX, so we can benefit from the whole range of advantages and features bash offers and that gives us easy to write and easy to read scripts, making it easier to maintain and debug.
----- Original Message -----
From: "Kiril Nesenko" <knesenko@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "David Caro" <dcaroest@redhat.com>, "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 9:11:28 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 1:32:40 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, March 10, 2014 9:17:13 PM Subject: Infra scripting style guide proposal
Hi everyone,
Following the discussion thread and seeing that there's no more input there, I'd like to propose this style guide:
http://www.ovirt.org/Bash_style_guide
As standard for our infrastructure scripts and guideline when reviewing scripts.
All the infra members please review the style guide and answer this email with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add also a description of the problems you see so we can work on them.
Hi David First of all thanks for your efforts in writing that, I am certainly for standards. However, I feel that we have to decide what kind of scripts we want to write. Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' from the infra code, lately we had turned all dbscripts/dbutils code from bash to POSIX. So, I think that we should decide first on the direction ('to bash or not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differently, and even if each has its code style guidelines, I believe that it makes our development environment harder to maintain and more buggy ...
Hello Eli,
Scripts that are going to be shipped with the product should be written in POSIX shell and this is correct. But here we are talking about scripts that we (infra team) are going to use to maintain our infrastructure - so there should be no problem to use bash here, since those scripts wont be shipped with the product.
- Kiril
All the non-infra people, you are welcome to vote also and give input, but your single vote will not be decisive.
I'll close the voting next monday if no changes to the Style guide are proposed.
Thanks!
dcaro +1
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xvMtfUX5HHjXEqJwuW5CnHdISAmO6Dw61 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue 11 Mar 2014 10:41:47 AM CET, Ewoud Kohl van Wijngaarden wrote:
I strongly feel the wiki page name should reflect that it is for infra.=
The current name is very generic and leads to assuptions that it's for the entire project. And you know what happens when you assume[1].
Agree, I'll change it, it's not clear is for infra at first sight (it=20 says so in the first lines, but in the title would make it a lot=20 clearer).
Other than that, I agree with you.
hehehehe, good one xd
On Tue, Mar 11, 2014 at 04:35:11AM -0400, David Caro Estevez wrote:
Correct.
It seems that ovirt is targeted also to non-gnu oses (in the future I =
suppose) so portability inside the product is an issue, thus making the s= trict POSIX standard the appropriate tool. I'm not sure if there's any mi= lestone set for that, but as I see it, is quite far, as I've been more th= an one year in the project, and we haven't got out of redhat based distri= butions, I see really hard to support non-gnu oses but if that's what was= decided, let's go for it.
But for any script we use to maintain the infrastructure of the projec=
t, from running a jenkins job, to creating repositories or adding a nagio= s check, we don't need to limit ourselves with POSIX, so we can benefit f= rom the whole range of advantages and features bash offers and that gives= us easy to write and easy to read scripts, making it easier to maintain = and debug.
----- Original Message -----
From: "Kiril Nesenko" <knesenko@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "David Caro" <dcaroest@redhat.com>, "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 9:11:28 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 1:32:40 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, March 10, 2014 9:17:13 PM Subject: Infra scripting style guide proposal
Hi everyone,
Following the discussion thread and seeing that there's no more inp=
ut
there, I'd like to propose this style guide:
http://www.ovirt.org/Bash_style_guide
As standard for our infrastructure scripts and guideline when revie= wing scripts.
All the infra members please review the style guide and answer this= email with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -= 1, add also a description of the problems you see so we can work on them.
Hi David First of all thanks for your efforts in writing that, I am certainly= for standards. However, I feel that we have to decide what kind of scripts we want = to write. Alon (Bar Lev), for example , is for removing what he is calling 'ba= shisem' from the infra code, lately we had turned all dbscripts/dbutils code= from bash to POSIX. So, I think that we should decide first on the direction ('to bash o= r not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differe= ntly, and even if each has its code style guidelines, I believe that it makes = our development environment harder to maintain and more buggy ...
Hello Eli,
Scripts that are going to be shipped with the product should be writt= en in POSIX shell and this is correct. But here we are talking about scripts that we (infra team) are going = to use to maintain our infrastructure - so there should be no problem to use= bash here, since those scripts wont be shipped with the product.
- Kiril
All the non-infra people, you are welcome to vote also and give inp=
ut,
but your single vote will not be decisive.
I'll close the voting next monday if no changes to the Style guide = are proposed.
Thanks!
dcaro +1
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --xvMtfUX5HHjXEqJwuW5CnHdISAmO6Dw61 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTHveeAAoJEEBxx+HSYmnDNosIAJoemDWsjjhRROesYWMaT44W kaHjTEUYl5Jpd1zUm9g2Elbj1/W6S0LHj6+Cmqb1JCXA3vDGWHXH/qzwvkjq+DQu vhvCrTP75ylNG++Ad3kc1p/3eFAg/slm/rk4uOAsx88N0z/TKjYl3Ef6kN+BRNfD MrRn5mIMV6lbPYjCqzJ3DTBc+XdwG03pmGqkh3WgPyJVWz5I+R0r+VeaHybg1Irb I52qEoTUofDjL3JD+575btLxyu551/VD7t2cgfiQDmK1z9hXG4ExbM5F32GuIxYG 64iQhOrkr3L9EU+ih5fzOuho1wLCvad2nj9xGuIqm934GX3ojwiqbT+t95H4sBg= =Q+13 -----END PGP SIGNATURE----- --xvMtfUX5HHjXEqJwuW5CnHdISAmO6Dw61--
On 03/11/2014 10:35 AM, David Caro Estevez wrote:
Correct.
It seems that ovirt is targeted also to non-gnu oses (in the future I suppose) so portability inside the product is an issue, thus making the strict POSIX standard the appropriate tool. I'm not sure if there's any milestone set for that, but as I see it, is quite far, as I've been more than one year in the project, and we haven't got out of redhat based distributions, I see really hard to support non-gnu oses but if that's what was decided, let's go for it.
But for any script we use to maintain the infrastructure of the project, from running a jenkins job, to creating repositories or adding a nagios check, we don't need to limit ourselves with POSIX, so we can benefit from the whole range of advantages and features bash offers and that gives us easy to write and easy to read scripts, making it easier to maintain and debug.
but will be running the infra and jenkins scripts/jobs on such target slaves. why not keep it to a single standard?
----- Original Message -----
From: "Kiril Nesenko" <knesenko@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "David Caro" <dcaroest@redhat.com>, "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 9:11:28 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 1:32:40 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, March 10, 2014 9:17:13 PM Subject: Infra scripting style guide proposal
Hi everyone,
Following the discussion thread and seeing that there's no more input there, I'd like to propose this style guide:
http://www.ovirt.org/Bash_style_guide
As standard for our infrastructure scripts and guideline when reviewing scripts.
All the infra members please review the style guide and answer this email with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add also a description of the problems you see so we can work on them.
Hi David First of all thanks for your efforts in writing that, I am certainly for standards. However, I feel that we have to decide what kind of scripts we want to write. Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' from the infra code, lately we had turned all dbscripts/dbutils code from bash to POSIX. So, I think that we should decide first on the direction ('to bash or not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differently, and even if each has its code style guidelines, I believe that it makes our development environment harder to maintain and more buggy ...
Hello Eli,
Scripts that are going to be shipped with the product should be written in POSIX shell and this is correct. But here we are talking about scripts that we (infra team) are going to use to maintain our infrastructure - so there should be no problem to use bash here, since those scripts wont be shipped with the product.
- Kiril
All the non-infra people, you are welcome to vote also and give input, but your single vote will not be decisive.
I'll close the voting next monday if no changes to the Style guide are proposed.
Thanks!
dcaro +1
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jM9Cksk0LkTUqU9SsX1i776iurP7s9bO5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue 11 Mar 2014 02:56:13 PM CET, Itamar Heim wrote:
On 03/11/2014 10:35 AM, David Caro Estevez wrote:
Correct.
It seems that ovirt is targeted also to non-gnu oses (in the future I suppose) so portability inside the product is an issue, thus making th= e strict POSIX standard the appropriate tool. I'm not sure if there's an= y milestone set for that, but as I see it, is quite far, as I've been mo= re than one year in the project, and we haven't got out of redhat based distributions, I see really hard to support non-gnu oses but if that's= what was decided, let's go for it.
But for any script we use to maintain the infrastructure of the projec= t, from running a jenkins job, to creating repositories or adding a nagios che= ck, we don't need to limit ourselves with POSIX, so we can benefit from the w= hole range of advantages and features bash offers and that gives us easy to= write and easy to read scripts, making it easier to maintain and debug.
but will be running the infra and jenkins scripts/jobs on such target s= laves. why not keep it to a single standard?
Well, for infra this style guide will allow us to be quite more effective= , even if we have to develop a couple POSIX compliant scripts to run jobs on tho= se non-gnu target systems in the future, all our infra servers (not jenkins = slaves) are and most probably will be gnu-based (fedora, centos, debian, ubuntu, = suse, sl, ...), so there's no need for portability for us. And in the worst cas= e, we can just install bash to support the infra scripts as it's available virt= ually on all the missing OSes. And I have no decision control over what the developers do in other teams= , and it seems (as per Alon comments) that they want to enforce POSIX scripts, = the only reason to do so, is for portability to non-gnu OSes out of the box, = so I suppose that it's a must being able to build the projects on those oses (*BSD/Sun/AIX/HP-UX). And also that it is a MUST. In my opinion we are qu= ite far from even thinking about porting to non-gnu systems, but I don't set the development goals. And it's not that big an issue to use bash, as is also= available on most of those OSes (you just have to install it as a build d= ep, just as you'd have to install maven, ant, make, python or whatever). Having only one standard forces one of the parts to give away it's best t= ool and get restricted to use the other one, so if we want to use just one standa= rd, we have to balance bash advantages vs out of the box portability to *BSD. If the portability to *BSD really is an issue, I don't think that we shou= ld enforce just one standard as there would be two very different use cases.= And I think that restricting infra to POSIX will notably slow down our work. But of course, I'm open to discussion.
----- Original Message -----
From: "Kiril Nesenko" <knesenko@redhat.com> To: "Eli Mesika" <emesika@redhat.com> Cc: "David Caro" <dcaroest@redhat.com>, "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 9:11:28 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "Eli Mesika" <emesika@redhat.com> To: "David Caro" <dcaroest@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Tuesday, March 11, 2014 1:32:40 AM Subject: Re: Infra scripting style guide proposal
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "infra" <infra@ovirt.org> Sent: Monday, March 10, 2014 9:17:13 PM Subject: Infra scripting style guide proposal
Hi everyone,
Following the discussion thread and seeing that there's no more inp=
ut
there, I'd like to propose this style guide:
http://www.ovirt.org/Bash_style_guide
As standard for our infrastructure scripts and guideline when revie= wing scripts.
All the infra members please review the style guide and answer this= email with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -= 1, add also a description of the problems you see so we can work on them.
Hi David First of all thanks for your efforts in writing that, I am certainly= for standards. However, I feel that we have to decide what kind of scripts we want = to write. Alon (Bar Lev), for example , is for removing what he is calling 'ba= shisem' from the infra code, lately we had turned all dbscripts/dbutils code= from bash to POSIX. So, I think that we should decide first on the direction ('to bash o= r not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differe= ntly, and even if each has its code style guidelines, I believe that it makes = our development environment harder to maintain and more buggy ...
Hello Eli,
Scripts that are going to be shipped with the product should be writt= en in POSIX shell and this is correct. But here we are talking about scripts that we (infra team) are going = to use to maintain our infrastructure - so there should be no problem to use= bash here, since those scripts wont be shipped with the product.
- Kiril
All the non-infra people, you are welcome to vote also and give inp=
ut,
but your single vote will not be decisive.
I'll close the voting next monday if no changes to the Style guide = are proposed.
Thanks!
dcaro +1
--=20 David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --jM9Cksk0LkTUqU9SsX1i776iurP7s9bO5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTHyhdAAoJEEBxx+HSYmnD3ssIAJanhXBAokNyn0oxdB9vB8CF SC5vQKaWhhKdYVWeGEFuAz1MCbXCM0WVtMigRqFd37TXF95siQTW+2+sKOgXZLW5 Z1N6/m/K/1sZ8WCHX/bZtDNk02Z6XJWxyQiJoPhV2oGRvB8JjFraznnuUe1skIVQ R4ZgzMDkUKLiXC7i4fIbYB7X9MCp6N2C/bT85S7A0s5n2DF7HFz3ICmtVgAtzFVl xPVBWA4vQ3/fYKGONNmHNXuatbBUgCHEFokMqm/5amXbgFYSD5Nq94wZyink0vLu PNH6WP0Fmcwr0cefb63DGpokqVVIYd4lTEsUqYMla7Om5TJv+3C+nWwr5hK4qTU= =VuTD -----END PGP SIGNATURE----- --jM9Cksk0LkTUqU9SsX1i776iurP7s9bO5--
Hi everyone, =20 Following the discussion thread and seeing that there's no more input t= here, I'd like to propose this style guide: =20 http://www.ovirt.org/Bash_style_guide =20 As standard for our infrastructure scripts and guideline when reviewing=
=20 All the infra members please review the style guide and answer this ema= il with your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, a=
description of the problems you see so we can work on them. =20 All the non-infra people, you are welcome to vote also and give input, = but your single vote will not be decisive. =20 I'll close the voting next monday if no changes to the Style guide are =
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7n63FehLfCtFEeRRkaXT2MWvCfDrFQVpw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/10/2014 08:17 PM, David Caro wrote: scripts. dd also a proposed.
=20 Thanks! =20 dcaro +1 =20 =20 =20 _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra =20 Ok so it's been a bit more than a week, and no votes against (just a smal= l modification on the page name).
So I say that we start using this guide as base for all the infra scripts= and reviews. Of course, it's open to review at anytime. Thanks everyone for participating! Let's code! --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --7n63FehLfCtFEeRRkaXT2MWvCfDrFQVpw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTKrSoAAoJEEBxx+HSYmnDLKkIAJFEtfSQ5ytt/XUugX4wAT0a ViFUhmDiqu8lzkzydb3J7BDVijaDdVxjNlOiy1CxDBNg1kcxMQkWVlQPQbWWp1GS 6E9SjbYb6lHDBD6t9iFTESCvxaurHVLj1EcWG8gnaWOw2Sp5z5M+0I1RWjiX+BVq MY1XpktnbBKu0Rpxjf0VCPWj/anEG9k6Qd+Yp9zDPLRX/4oG6UK9zP49Nyx72ITO v0Rg/k/ZBk5JI4hzFBEP8FCyfU7ZGSmHLTK6f061EMRt5pv/4iqgPOZWCaAXeym7 TE78sbbt5rnrQUKzm8fA3IhXId7FUjIrLRM/5bLUY4S+oBBVkw2N+k8hZM+1HWE= =HHrW -----END PGP SIGNATURE----- --7n63FehLfCtFEeRRkaXT2MWvCfDrFQVpw--
participants (6)
-
David Caro -
David Caro Estevez
-
Eli Mesika -
Ewoud Kohl van Wijngaarden -
Itamar Heim -
Kiril Nesenko