July 2016 - Kimchi-devel - oVirt List Archives

[PATCH v2] [Kimchi] Issue #956: Unable to assign pci passthrough devices through kimchi
by sguimaraes943＠gmail.com 26 Jul '16

26 Jul '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This commit fixes an issue with PCI passthrough devices through Kimchi. It also addresses an enhancement to display success messages when some actions doesn't require the Save button and there's no UI feedback to the user (Issue #975). v2 - Added error callbacks for kimchi.addVMPCIDevice() and kimchi.removeVMPCIDevice() to display error messages before if starts to track ongoing tasks. Samuel Guimarães (1): Issue #956: Unable to assign pci passthrough devices through kimchi model/vmhostdevs.py | 2 +- ui/css/kimchi.css | 5 + ui/css/src/modules/_edit-guests.scss | 4 + ui/js/src/kimchi.guest_edit_main.js | 236 +++++++++++++++++++++++------------ ui/js/src/kimchi.guest_main.js | 10 +- ui/pages/guest-edit.html.tmpl | 20 ++- ui/pages/i18n.json.tmpl | 2 + 7 files changed, 180 insertions(+), 99 deletions(-) -- 1.9.3

4 10

[PATCH V3] [Wok] Use system's nginx proxy service.
by pvital＠linux.vnet.ibm.com 26 Jul '16

26 Jul '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch-set works on Fedora 23 and 24, RHEL 7.2, Ubuntu 16.04, Debian 8.5 and OpenSUSE 42.1 Just pay attention to follow current steps reported in Troubleshooting wiki page of Wok: https://github.com/kimchi-project/wok/blob/master/docs/troubleshooting.md V3: - removed unnecessary semanage command. V2: - fixed PEP8 errors V1: This patch removes the code that executes a dedicated nginx proxy, making Wok to use the system's nginx service. This is a requirement to make Wok acceptable in community repositories. It also make sure that a Wok executed from path different than installed (from a cloned and builded source code, for example) will create a symbolic link in system's nginx config dir to the running configuration file. This patch solves part of issue #25 Paulo Vital (1): Use system's nginx proxy service. src/nginx/wok.conf.in | 95 +++++++++++++++++++++------------------------------ src/wok/config.py.in | 6 +++- src/wok/i18n.py | 2 ++ src/wok/proxy.py | 28 ++++++++------- src/wok/server.py | 6 +--- 5 files changed, 63 insertions(+), 74 deletions(-) -- 2.7.4

4 5

[PATCH V4] [Wok] Use system's nginx proxy service.
by pvital＠linux.vnet.ibm.com 26 Jul '16

26 Jul '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch works on Fedora 23 and 24, RHEL 7.2, Ubuntu 16.04, Debian 8.5 and OpenSUSE 42.1 It's recommended to follow the current steps reported in Troubleshooting wiki page of Wok: https://github.com/kimchi-project/wok/blob/master/docs/troubleshooting.md V4: - Use values of session timeout from configuration to set proxy timeout - remove un-necessary method to check if Wok is installed V3: - removed unnecessary semanage command. V2: - fixed PEP8 errors V1: This patch removes the code that executes a dedicated nginx proxy, making Wok to use the system's nginx service. This is a requirement to make Wok acceptable in community repositories. It also make sure that a Wok executed from path different than installed (from a cloned and builded source code, for example) will create a symbolic link in system's nginx config dir to the running configuration file. This patch solves part of issue #25 Paulo Vital (1): Use system's nginx proxy service. src/nginx/wok.conf.in | 95 +++++++++++++++++++++------------------------------ src/wok/config.py.in | 3 +- src/wok/i18n.py | 2 ++ src/wok/proxy.py | 28 ++++++++------- src/wok/server.py | 6 +--- 5 files changed, 60 insertions(+), 74 deletions(-) -- 2.7.4

2 2

[PATCH V4] [Wok] Use system's nginx proxy service.
by pvital＠linux.vnet.ibm.com 26 Jul '16

26 Jul '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch works on Fedora 23 and 24, RHEL 7.2, Ubuntu 16.04, Debian 8.5 and OpenSUSE 42.1 It's recommended to follow the current steps reported in Troubleshooting wiki page of Wok: https://github.com/kimchi-project/wok/blob/master/docs/troubleshooting.md V4: - Use values of session timeout from configuration to set proxy timeout - remove un-necessary method to check if Wok is installed V3: - removed unnecessary semanage command. V2: - fixed PEP8 errors V1: This patch removes the code that executes a dedicated nginx proxy, making Wok to use the system's nginx service. This is a requirement to make Wok acceptable in community repositories. It also make sure that a Wok executed from path different than installed (from a cloned and builded source code, for example) will create a symbolic link in system's nginx config dir to the running configuration file. This patch solves part of issue #25 Paulo Vital (1): Use system's nginx proxy service. src/nginx/wok.conf.in | 95 +++++++++++++++++++++------------------------------ src/wok/config.py.in | 3 +- src/wok/i18n.py | 2 ++ src/wok/proxy.py | 28 ++++++++------- src/wok/server.py | 6 +--- 5 files changed, 60 insertions(+), 74 deletions(-) -- 2.7.4

2 2

[RFC] Using WebSockets and Server Sent Events for handling tasks in Wok and plugins
by Samuel Henrique De Oliveira Guimaraes 26 Jul '16

26 Jul '16

Hi team, I was thinking that combining websockets with local/session storage could solve the problems that we have with asynchronous tasks but after reading this, I think it could also be used for notifications and error messages as well. Check this out: https://www.sitepoint.com/real-time-apps-websockets-server-sent-events/ I think it is already enabled for the Serial Console in Kimchi, am I right? Regards, Samuel

3 2

[PATCH] [Wok] User session alert UI
by peterpnns＠gmail.com 26 Jul '16

26 Jul '16

From: peterpennings <peterpnns(a)gmail.com> This patch get a request header parameter to trigger a counter which shows up a alert to the user when the session is getting to expire peterpennings (1): User session timeout alert (UI) ui/css/src/wok.scss | 27 ++++ ui/css/wok.css | 30 ++++ ui/js/src/wok.api.js | 23 +++ ui/js/src/wok.session.js | 67 +++++++++ ui/pages/i18n.json.tmpl | 2 + ui/pages/wok-ui.html.tmpl | 15 +- 5 files changed, 443 insertions(+), 20 deletions(-) create mode 100644 ui/js/src/wok.session.js -- 2.5.0

3 3

[PATCH v2] [Wok] Kimchi kills Wokd due to sys.exit() calls in files networks.py and storagepools.py
by bianca＠linux.vnet.ibm.com 26 Jul '16

26 Jul '16

From: Bianca Carvalho <bianca(a)linux.vnet.ibm.com> Added an Exception to not load kimchi plugin (servers.py) in case network or storagepool does not exist or is not active. Signed-off-by: Bianca Carvalho <bianca(a)linux.vnet.ibm.com> --- src/wok/server.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wok/server.py b/src/wok/server.py index 8a02596..04bf1bc 100644 --- a/src/wok/server.py +++ b/src/wok/server.py @@ -179,6 +179,7 @@ class Server(object): self.app = cherrypy.tree.mount(WokRoot(model_instance, dev_env), config=self.configObj) + self._load_plugins(options) # Terminate proxy when cherrypy server is terminated @@ -201,7 +202,7 @@ class Server(object): try: plugin_app = import_class(plugin_class)(options) - except ImportError, e: + except (ImportError, Exception), e: cherrypy.log.error_log.error( "Failed to import plugin %s, " "error: %s" % (plugin_class, e.message) -- 2.7.4

3 2

[PATCH] [Wok] Kimchi kills Wokd due to sys.exit() calls in files networks.py and storagepools.py
by bianca＠linux.vnet.ibm.com 25 Jul '16

25 Jul '16

From: Bianca Carvalho <bianca(a)linux.vnet.ibm.com> Removed all sys.exit(1) calls from both files to avoid killing Wokd. Also added an Exception to not load kimchi plugin (servers.py) in case network or storagepool does not exist or is not active. Signed-off-by: Bianca Carvalho <bianca(a)linux.vnet.ibm.com> --- src/wok/server.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wok/server.py b/src/wok/server.py index 8a02596..04bf1bc 100644 --- a/src/wok/server.py +++ b/src/wok/server.py @@ -179,6 +179,7 @@ class Server(object): self.app = cherrypy.tree.mount(WokRoot(model_instance, dev_env), config=self.configObj) + self._load_plugins(options) # Terminate proxy when cherrypy server is terminated @@ -201,7 +202,7 @@ class Server(object): try: plugin_app = import_class(plugin_class)(options) - except ImportError, e: + except (ImportError, Exception), e: cherrypy.log.error_log.error( "Failed to import plugin %s, " "error: %s" % (plugin_class, e.message) -- 2.7.4

2 1

[Wok][RFC] Manage async tasks.
by Peter Pennings 21 Jul '16

21 Jul '16

Hey guys, We want to suggest here a new discussion which can maybe turn into a new feature to improve the system. During the development of some activities involving assincronous tasks, we were thinking about a new way to manage a tasks queue and a new way to get informed about the tasks in the system. We divided the idea into two parts: *1-)* First of all, an idea to the backend take care of a tasks queue, allowing the user to trigger tasks as many as he wants. Any request involving an async task triggered by the user, will be pushed into a queue in the back-end. There will be a consumer of this queue, getting the first task to process, and the others will be set with a "Waiting" status. This "consumer" will manage the queue of tasks. One idea to implement this is using the "Publish Subscribe" Desing Pattern. Another idea is to keep the task with a "Waiting" status in the database, and the consumer consumes from this database instead of a queue (updating the status and message of the task). At the moment, we don't have a way to control this queue, when it's necessary, the frontend try to do it. The problem is when the user wants to trigger more then one task, then he can't make a logout in the system because he will lose this queue. *2-)* Develop a new tab in Wok to show the tasks in the system. We can show the tasks for each plugin separeted. For example: if the user has kimchi, ginger and gingerbase installed, this tab will contain three sections, each one with a table of tasks containg the id, status (running, waiting, failure, etc), message and target uri of each task. We can develop a filter for this tables too, allowing the user to search the tasks respecting some filters. The main idea with this suggestion, is a way to display what is happening in the system with the async tasks and allow the user to make more then one async request without waiting for the last getting finished. All of this is just a suggestion, we are open to any doubts or to discuss and improve this idea. Feel free to any suggestions or criticizes. :) Thank you. Peter Pennings

4 4

Re: [Kimchi-devel] [PATCH V2][Wok 00/12] FVT testcases wok framework
by Aline Manera 21 Jul '16

21 Jul '16

Hi Archana, First of all, thanks for contribution to this patch set. I did some comments and have some doubts that I asked in the patch set. Hopefully, we can go through that soon and make it available upstream. Also sorry about the delay to review the patches. Regards, Aline Manera On 05/30/2016 04:10 AM, archus(a)linux.vnet.ibm.com wrote: > From: Archana Singh <archus(a)linux.vnet.ibm.com> > > Patch for adding FVT testcases wok framework which can be used across plugins. > The changes are: > 1) Added fvt package inside tests directory. > 2) Added config file inside fvt package to have session details. > 3) restapilib.py to have common classes/methods for REST API calls. > 4) fvt_base.py, a base test class to take care of doing > common setup and treadown required for any fvt test cases like > creating/destroying session using config file and restapilib.py. > 5) run_test.sh.in script to install all the dependencies and to run all FVT. > 6) make file changes to have 'make check-fvt' for running all the FVT. > 7) Instruction added in REDME.md for make check-fvt. > 8) Added tests/fvt/config into IBM license blacklist. > > Archana Singh (12): > FVT: Package for functional verification testcases. > FVT: Wok level config file to have 'sectionsi required for fvt common > across plugins. > FVT: Lists all dependecies for fvt testcases. > FVT: Common classes/methods for API calls as per config file > configuration. > FVT: Base test class, takes care common actions required for any FVT > test cases. > FVT: Install all the dependencies from requirements.txt and runs FVT > testcases > FVT: Makefile needed for build and run fvt. > FVT: Added fvt as subdirs and check-fvt to run fvt testcases using > make. > FVT: Added FVT Makefile path in AC_CONFIG_FILES list. > FVT: Added check-fvt to run FVT testcases using make and venv dir to > be cleaned. > FVT: Added Readme instruction for running fvt testcases. > Added tests/fvt/config file into backlist. > > IBM-license-blacklist | 1 + > Makefile.am | 6 + > configure.ac | 1 + > docs/README.md | 8 + > tests/Makefile.am | 7 + > tests/fvt/Makefile.am | 43 +++ > tests/fvt/__init__.py | 18 ++ > tests/fvt/config | 7 + > tests/fvt/fvt_base.py | 92 ++++++ > tests/fvt/requirements.txt | 23 ++ > tests/fvt/restapilib.py | 738 +++++++++++++++++++++++++++++++++++++++++++++ > tests/fvt/run_tests.sh.in | 92 ++++++ > 12 files changed, 1036 insertions(+) > create mode 100644 tests/fvt/Makefile.am > create mode 100644 tests/fvt/__init__.py > create mode 100644 tests/fvt/config > create mode 100644 tests/fvt/fvt_base.py > create mode 100644 tests/fvt/requirements.txt > create mode 100644 tests/fvt/restapilib.py > create mode 100755 tests/fvt/run_tests.sh.in >

1 0