- Kimchi-devel - oVirt List Archives

[PATCH] [Wok 0/3] Multiple UI patches for DataTables redesigned panels
by sguimaraes943＠gmail.com 26 Aug '16

26 Aug '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patchtset contains some updates that are required for the new redesigned panels in Ginger Samuel Guimarães (3): Minor change in Wok Drop-Downs to fix text alignment with different icons and locales Fixed minor issue with sortable icons on Datatables.net CSS and with default DOM in JS Added IP Address sorting plugin for Datatables.net configure.ac | 2 + ui/css/datatables.bootstrap.css | 9 ++ ui/css/src/datatables.bootstrap.scss | 8 ++ ui/css/src/modules/_buttons.scss | 9 ++ ui/css/src/modules/_menu-flat.scss | 44 +++++++-- ui/css/wok.css | 102 ++++++++++++++++++-- ui/js/src/wok.datatables.js | 2 +- ui/libs/datatables/js/Makefile.am | 2 + ui/libs/datatables/js/plugins/Makefile.am | 19 ++++ ui/libs/datatables/js/plugins/ip-address/LICENSE | 20 ++++ .../datatables/js/plugins/ip-address/Makefile.am | 21 +++++ .../datatables/js/plugins/ip-address/ip-address.js | 103 +++++++++++++++++++++ ui/pages/wok-ui.html.tmpl | 1 + 13 files changed, 327 insertions(+), 15 deletions(-) create mode 100644 ui/libs/datatables/js/plugins/Makefile.am create mode 100644 ui/libs/datatables/js/plugins/ip-address/LICENSE create mode 100644 ui/libs/datatables/js/plugins/ip-address/Makefile.am create mode 100644 ui/libs/datatables/js/plugins/ip-address/ip-address.js -- 2.5.5

2 4

[PATCH V2] [Wok 0/3] Issue #158: Move AsyncTask information to memory
by pvital＠linux.vnet.ibm.com 26 Aug '16

26 Aug '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> V2: - moved all tasks_queue infrastructure to wok.asynctask - modified some user messages. V1: this patch-set moves AsyncTask information from objectstore to memory and it is dependency to solve Issue #122. Paulo Vital (3): Issue #158: Move AsyncTask information to memory Issue #158: Update model/tasks.py with AsyncTasks in memory. Issue #158: Add AsyncTasks testcases src/wok/asynctask.py | 58 +++++++++++++++-------- src/wok/i18n.py | 3 +- src/wok/model/tasks.py | 22 +++++---- src/wok/objectstore.py | 6 --- src/wok/utils.py | 19 -------- tests/test_tasks.py | 124 +++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 177 insertions(+), 55 deletions(-) create mode 100644 tests/test_tasks.py -- 2.7.4

3 8

[PATCH] [Kimchi] Check if VM is off before detaching multifn PCI
by Jose Ricardo Ziviani 26 Aug '16

26 Aug '16

- this commit fix a bug when detaching multifunction pci devices because hotplug/coldplug need a different approach with libvirt upstream. Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- model/vmhostdevs.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/model/vmhostdevs.py b/model/vmhostdevs.py index ef39de3..e2299e2 100644 --- a/model/vmhostdevs.py +++ b/model/vmhostdevs.py @@ -686,6 +686,9 @@ class VMHostDevModel(object): return devices def _hotunplug_multifunction_pci(self, dom, hostdev, dev_name): + if DOM_STATE_MAP[dom.info()[0]] == "shutoff": + return False + domain, bus, slot, _ = dev_name.split('_')[1:] # get all devices attached to the guest in the same domain+bus+slot # that the one we are going to detach because they must be detached -- 2.7.4

3 2

[PATCH] [Kimchi] Github #986: create '/data/virtviewerfiles' dir automatically
by dhbarboza82＠gmail.com 26 Aug '16

26 Aug '16

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> This patch makes the '/data/virtviewerfiles' dir behave the same as '/data/screenshots', being created automatically at Kimchi startup if it doesn't exists. Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> --- root.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/root.py b/root.py index a88f97d..90680b4 100644 --- a/root.py +++ b/root.py @@ -37,7 +37,8 @@ class Kimchi(WokRoot): make_dirs = [ os.path.dirname(os.path.abspath(config.get_object_store())), os.path.abspath(config.get_distros_store()), - os.path.abspath(config.get_screenshot_path()) + os.path.abspath(config.get_screenshot_path()), + os.path.abspath(config.get_virtviewerfiles_path()) ] for directory in make_dirs: if not os.path.isdir(directory): -- 2.5.5

4 3

[PATCH] [Kimchi] Revert "Fix frontend vcpu hotplug"
by Jose Ricardo Ziviani 26 Aug '16

26 Aug '16

This reverts commit 7cc96b592191b521effac1a6bb98a2b4dbf29474, this commit must be available only in HostOS repository for now. --- ui/js/src/kimchi.guest_edit_main.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ui/js/src/kimchi.guest_edit_main.js b/ui/js/src/kimchi.guest_edit_main.js index 9b6eab6..dcaafb8 100644 --- a/ui/js/src/kimchi.guest_edit_main.js +++ b/ui/js/src/kimchi.guest_edit_main.js @@ -815,13 +815,12 @@ kimchi.guest_edit_main = function() { for (var key in data) { valueFromUI = data[key]; if (valueFromUI instanceof Object) { - // Compare if Objects of original and data are identical. - // Handle special case when key is memory and guest is - // running as valueFromUI will return a null for max mem - // since it is disabled. + // Compare if Objects of original and data are identical + // Handle special case when key is memory and guest is running as valueFromUI will return a null for max mem + // since it is disabled; for cpu_info, when guest is running, just skip it since no processing is required if (kimchi.thisVMState === 'running' || kimchi.thisVMState === 'paused') { if (key === 'cpu_info') { - data['cpu_info']['maxvcpus'] = org.cpu_info.maxvcpus; + continue; } if (key === 'memory') { // Replace valueFromUI of max mem with one from original as otherwise the value is undefined -- 2.7.4

3 2

[PATCH] [Wok 0/3] Issue #158: Move AsyncTask information to memory
by pvital＠linux.vnet.ibm.com 26 Aug '16

26 Aug '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> this patch-set moves AsyncTask information from objectstore to memory and it is dependency to solve Issue #122. Paulo Vital (3): Issue #158: Move AsyncTask information to memory Issue #158: Update model/tasks.py with AsyncTasks in memory. Issue #158: Add AsyncTasks testcases src/wok/asynctask.py | 25 ++------- src/wok/i18n.py | 3 +- src/wok/model/tasks.py | 22 ++++---- src/wok/objectstore.py | 6 --- src/wok/utils.py | 31 ++++++++--- tests/test_tasks.py | 136 +++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 178 insertions(+), 45 deletions(-) create mode 100644 tests/test_tasks.py -- 2.7.4

4 13

[RFC] Issue# 979 Create UI to change boot order
by Socorro Stoppler 25 Aug '16

25 Aug '16

Per discussion w/Samuel, here is what the proposed UI looks like. A menu item - 'Change boot order' - in Actions for each guest will be added to invoke this. Dragging the entries will cause the order to change. Thoughts? Thanks! -Socorro

3 5

[RFC] Should not be allowed to remove "default" storagepool and network
by Ramon Medeiros 25 Aug '16

25 Aug '16

Propose: avoid to delete default network and storage pool: files affected: Create a error message at i18n.py Check at delete() method on model to verify Doubt: Where is defined the default pool and network? I did not see it in kimchi.conf Should i create a entry to deal it? -- Ramon Nunes Medeiros Kimchi Developer Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn(a)br.ibm.com

1 0

[RFC] listing of ovs bridges
by Suresh Babu Angadi 25 Aug '16

25 Aug '16

New API: SimpleCollection: OVSBridges URI: /plugins/kimchi/ovsbridges Methods: GET: Retrieve list of OVS bridges of the host Back end changes: Currently ginger plugin has full fledged ovs functionality. So best bet would be to have listing of ovs bridges to gingerbase which can be used by kimchi and ginger apis. -- Regards, Suresh Babu Angadi

1 0

[WIP][Wok 0/2] Use javascript libraries from rpms, not hardcoded
by Ramon Medeiros 24 Aug '16

24 Aug '16

This isn't a patch yet since the commit "Change configuration files" are not working well. I need to change ui/libs/Makefile.am to set SUBDIRS variable (that trigger javascript hardcoded libs build) and change ui/pages/Makefile.am, to copy the template according to distro. Can you guys help me on makefile syntax? Ramon Medeiros (2): Use javascript libraries from rpms Change configuration files configure.ac | 11 ++ docs/fedora-deps.md | 4 +- docs/ubuntu-deps.md | 3 +- src/wok/config.py.in | 22 +++ ui/libs/Makefile.am | 10 +- ui/pages/Makefile.am | 9 ++ ui/pages/login.html.tmpl.fedora | 332 +++++++++++++++++++++++++++++++++++++++ ui/pages/login.html.tmpl.ubuntu | 332 +++++++++++++++++++++++++++++++++++++++ ui/pages/wok-ui.html.tmpl.fedora | 231 +++++++++++++++++++++++++++ ui/pages/wok-ui.html.tmpl.ubuntu | 231 +++++++++++++++++++++++++++ 10 files changed, 1182 insertions(+), 3 deletions(-) create mode 100644 ui/pages/login.html.tmpl.fedora create mode 100644 ui/pages/login.html.tmpl.ubuntu create mode 100644 ui/pages/wok-ui.html.tmpl.fedora create mode 100644 ui/pages/wok-ui.html.tmpl.ubuntu -- 2.5.5

4 9