- Kimchi-devel - oVirt List Archives

[PATCH][Wok] wokd service not comes up after reboot when enabled
by chandra＠linux.vnet.ibm.com 05 Feb '16

05 Feb '16

From: Chandra Shekhar Reddy Potula <chandra(a)linux.vnet.ibm.com> Fixed Issue #31 : Even after wokd service enabled, wokd service not comes up after reboot. Chandra Shekhar Reddy Potula (1): wokd service not comes up after reboot when enabled contrib/wokd.service.fedora | 1 + 1 file changed, 1 insertion(+) -- 2.5.4 (Apple Git-61)

6 9

[PATCH] [Kimchi] Fix error message for IOMMU configuration.
by pvital＠linux.vnet.ibm.com 04 Feb '16

04 Feb '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> Modified the error message with the correct configuration file and parameter to explain how to configure host kernel parameter to add support to IOMMU. All latest version of supported distro at this moment (Fedora 23, Ubuntu 15.10, Debian 8, RHEL 7.2 and OpenSUSE Leap) have the configuration file (/etc/default/grub) and the kernel parameter (GRUB_CMDLINE_LINUX) to be configured. Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- i18n.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/i18n.py b/i18n.py index a575922..6e453f3 100644 --- a/i18n.py +++ b/i18n.py @@ -136,8 +136,8 @@ messages = { "KCHVMHDEV0002E": _("The host device %(dev_name)s is not allowed to directly assign to VM."), "KCHVMHDEV0003E": _("No IOMMU groups found. Host PCI pass through needs IOMMU group to function correctly. " "Please enable Intel VT-d or AMD IOMMU in your BIOS, then verify the Kernel is compiled with IOMMU support. " - "For Intel CPU, add intel_iommu=on to your Kernel parameter in /boot/grub2/grub.conf. " - "For AMD CPU, add iommu=pt iommu=1."), + "For Intel CPU, add 'intel_iommu=on' to GRUB_CMDLINE_LINUX parameter in /etc/default/grub file. " + "For AMD CPU, add 'iommu=pt iommu=1'."), "KCHVMHDEV0004E": _('"name" should be a device name string'), "KCHVMHDEV0005E": _('The device %(name)s is probably in use by the host. Unable to attach it to the guest.'), -- 2.5.0

3 2

[PATCH][Kimchi] Remove hack that disables vhosts-net
by Ramon Medeiros 04 Feb '16

04 Feb '16

Vhosts-net wasn't support on the past. Now, as it works, enable the feature. Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- xmlutils/interface.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/xmlutils/interface.py b/xmlutils/interface.py index 814caf9..de80524 100644 --- a/xmlutils/interface.py +++ b/xmlutils/interface.py @@ -18,7 +18,6 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA import lxml.etree as ET -from distutils.version import LooseVersion from lxml.builder import E from wok.plugins.kimchi import osinfo @@ -62,12 +61,4 @@ def get_iface_xml(params, arch=None, os_distro=None, os_version=None): if mac is not None: interface.append(E.mac(address=mac)) - # Hack to disable vhost feature in Ubuntu LE and SLES LE (PPC) - if arch == 'ppc64' and \ - ((os_distro == 'ubuntu' and - LooseVersion(os_version) >= LooseVersion('14.04')) or - (os_distro == 'sles' and - LooseVersion(os_version) >= LooseVersion('12'))): - interface.append(E.driver(name='qemu')) - return ET.tostring(interface, encoding='utf-8', pretty_print=True) -- 2.1.0

3 2

[PATCH] [Wok] Add function for inserting an XML element
by Lucio Correia 04 Feb '16

04 Feb '16

- Plus a minor fix Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- src/wok/xmlutils/utils.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/wok/xmlutils/utils.py b/src/wok/xmlutils/utils.py index d02139c..cabb859 100644 --- a/src/wok/xmlutils/utils.py +++ b/src/wok/xmlutils/utils.py @@ -36,6 +36,15 @@ def xpath_get_text(xml, expr): return res +def xml_item_insert(xml, xpath, item_xml): + root = ET.fromstring(xml) + + element = root.find(xpath) + element.insert(0, ET.fromstring(item_xml)) + + return ET.tostring(root, encoding="utf-8") + + def xml_item_update(xml, xpath, value, attr=None): root = ET.fromstring(xml) item = root.find(xpath) @@ -51,7 +60,7 @@ def xml_item_remove(xml, xpath): element = root.find(xpath) parent = root.find(xpath + "/..") - if parent: + if parent is not None: parent.remove(element) return ET.tostring(root, encoding="utf-8") -- 1.9.1

2 1

[PATCH] [Kimchi] New UI for adding network bridges
by peterpnns＠gmail.com 03 Feb '16

03 Feb '16

From: peterpennings <peterpnns(a)gmail.com> This patch adds Linux and OVS bridges. netinfo.py had to be updated to show OVS bridges in order to reflect the changes made in the UI. peterpennings (1): Issue #791: New UI for adding network bridges netinfo.py | 3 +- ui/js/src/kimchi.network.js | 2 + ui/js/src/kimchi.network_add_main.js | 146 ++++++++++++++++++++++------------- ui/pages/network-add.html.tmpl | 3 +- 4 files changed, 96 insertions(+), 58 deletions(-) -- 2.5.0

1 0

[RFC][Kimchi] Guest Max memory setup and update
by Rodrigo Trujillo 02 Feb '16

02 Feb '16

Hi all, The guest xml tag <max_memory> is necessary to allow memory hotplug. Currently, max_memory is the lesser value among "guest memory X4", "Host Memory" or "1TB". It is also not possible to user, to set it. Proposal: Modify backend and frontend in order to allow users to increase/decrease max_memory value. In other words, user will be allowed to set the amount of memory that will be possible to hotplug. BACKEND (a previous patch was already sent to mailing list, must sent new version) - Remove current settings when guest is created. Set max_memory equal guest memory.; - Does not allow change max_memory when guest is running; - When hotplug, continue with slots of 1GB, but restrict 32 slots in PowerPC; - Update/Add tests; - Change JSON memory field to: memory: { current: XXX, maxmemory: YYYY }; FRONTEND - In guest edit window, modify memory input field. Change it to a increase/decrease ( +/- ) input box; - Create a hidden area which will hold max memory input box (increase/decrease); - Increments will be of 1GB; - Create a "More Options" link besides Memory , that is going to show/hide max memory area; - If guest is online: * max memory field will be disabled; * memory will be enabled, allowing hotplug; - When guest is offline, it is ok to change max memory, enable it; API CHANGES: JSON must be changed in requests and responses: - When updating guest (PUT), memory field will become: memory: { current: <memory new value>, maxmemory: <maxmemory new value> } - response (GET): memory: { current: <memory new value>, maxmemory: <maxmemory new value> } It is not necessary to include maxmemory if was not changed. Thoughts ? Rodrigo Trujillo

4 8

[PATCH] [WoK 0/2] Makefile changes - whitespace check and others
by dhbarboza82＠gmail.com 02 Feb '16

02 Feb '16

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> This patch set implements enhancements in the Makefile.am of WoK, including whitespace checks and fixes for the existing whitespaces. Daniel Henrique Barboza (2): Makefile.am targets enhancements Whitespace fixes in existing code Makefile.am | 26 ++++++++++++++++++-------- configure.ac | 1 + ui/css/src/modules/_login.scss | 4 ++-- ui/css/src/modules/_modal-flat.scss | 10 +++++----- ui/css/src/modules/_navbar-flat.scss | 6 +++--- ui/css/src/modules/_wok-confirm.scss | 4 ++-- ui/css/src/modules/_wok-grid.scss | 6 +++--- ui/css/src/modules/_wok-variables.scss | 6 +++--- ui/images/theme-default/edit-alt.svg | 4 ++-- ui/js/src/wok.grid.js | 4 ++-- ui/js/src/wok.line-chart.js | 10 +++++----- ui/js/src/wok.list.js | 6 +++--- ui/js/src/wok.login.js | 6 +++--- ui/js/src/wok.main.js | 6 +++--- 14 files changed, 55 insertions(+), 44 deletions(-) -- 2.5.0

2 3

Fix add storage device to VM using existing diskFrom 1b81e79af52d9248a0e62fbfbc58c21d9777c7f6 Mon Sep 17 00:00:00 2001
by Socorro Stoppler 29 Jan '16

29 Jan '16

This patch fixes the error of not being able to attach a storage device to a VM using an existing disk. The problem was due to a change in the html file, the name attribute of the select component no longer exists which was still being referenced in the code. Socorro Stoppler (1): Fix add storage device to VM using existing disk ui/js/src/kimchi.guest_storage_add.main.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) -- 1.9.1

2 2

[PATCH] [Kimchi 0/2] Makefile changes - whitespace check and others
by dhbarboza82＠gmail.com 29 Jan '16

29 Jan '16

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> This patch set implements enhancements in the Makefile.am, such as whitespace check and allowing ChangeLog to run in a submodule checkout of Kimchi. Daniel Henrique Barboza (2): Makefile.am targets enhancements Whitespace fixes in existing code Makefile.am | 24 ++++++++++++++++++------ configure.ac | 3 ++- kimchi.conf | 1 - ui/css/src/modules/_network.scss | 12 ++++++------ ui/js/src/kimchi.network_add_main.js | 4 ++-- ui/pages/guest-edit.html.tmpl | 2 +- 6 files changed, 29 insertions(+), 17 deletions(-) -- 2.5.0

3 4

[PATCH] [Wok] Add function for removing XML element
by Lucio Correia 29 Jan '16

29 Jan '16

Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- src/wok/xmlutils/utils.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/wok/xmlutils/utils.py b/src/wok/xmlutils/utils.py index b75ca51..d02139c 100644 --- a/src/wok/xmlutils/utils.py +++ b/src/wok/xmlutils/utils.py @@ -1,7 +1,7 @@ # # Project Wok # -# Copyright IBM, Corp. 2014-2015 +# Copyright IBM, Corp. 2014-2016 # # Code derived from Project Kimchi # @@ -46,6 +46,17 @@ def xml_item_update(xml, xpath, value, attr=None): return ET.tostring(root, encoding="utf-8") +def xml_item_remove(xml, xpath): + root = ET.fromstring(xml) + + element = root.find(xpath) + parent = root.find(xpath + "/..") + if parent: + parent.remove(element) + + return ET.tostring(root, encoding="utf-8") + + def dictize(xmlstr): root = objectify.fromstring(xmlstr) return {root.tag: _dictize(root)} -- 1.9.1

4 3