- Kimchi-devel - oVirt List Archives

[PATCH] [Kimchi 0/5] Kimchi testcases fixes
by pvital＠linux.vnet.ibm.com 14 Dec '15

14 Dec '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patchset fixes some Kimchi testcases were failling or finishing with errors in Fedora 23 host. There're 3 tests failling at this moment: 2 tests in test_edit_vm() and test_vlan_tag_bridge(). The solution for "Fix test_async_tasks testcase." depends on the WOK patch "Create utils method get_task_id()" to be applied before. Paulo Vital (5): Fix range for network of NAT and isolated types. Fix test_image_based_template testcase. Fix test_async_tasks testcase. Fix test_vm_lifecycle testcase. fix 2 test_vm_lifecycle testcase model/networks.py | 2 +- tests/test_model.py | 79 +++++++++++++++++++++++++++++++++++++---------------- 2 files changed, 56 insertions(+), 25 deletions(-) -- 2.5.0

3 14

[Kimchi v3] Fix disk creation when pool is netfs
by Ramon Medeiros 14 Dec '15

14 Dec '15

Instead of add io=native for all disks, add only if disk is in a netfs pool. Changes: v2: Instead of passing the complete pool information, pass just pool type. v3: Use .get to retrieve pool_type (this will avoid breaking when pool_type is not available) Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- vmtemplate.py | 2 +- xmlutils/disk.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/vmtemplate.py b/vmtemplate.py index b6e9431..5c6a8d8 100644 --- a/vmtemplate.py +++ b/vmtemplate.py @@ -213,7 +213,7 @@ class VMTemplate(object): img = "%s-%s.img" % (vm_uuid, params['index']) storage_path = self._get_storage_path(disk['pool']['name']) params['path'] = os.path.join(storage_path, img) - + params['pool_type'] = disk['pool']['type'] disks_xml += get_disk_xml(params)[1] return unicode(disks_xml, 'utf-8') diff --git a/xmlutils/disk.py b/xmlutils/disk.py index 2ed2ef4..9e6d8fb 100644 --- a/xmlutils/disk.py +++ b/xmlutils/disk.py @@ -53,7 +53,9 @@ def get_disk_xml(params): driver = E.driver(name='qemu', type=params['format']) if params['type'] != 'cdrom': driver.set('cache', 'none') - driver.set("io", "native") + + if params.get('pool_type') == "netfs": + driver.set("io", "native") disk.append(driver) -- 2.1.0

3 2

[PATCH v2][Kimchi] Fix disk creation when pool is netfs
by Ramon Medeiros 14 Dec '15

14 Dec '15

Instead of add io=native for all disks, add only if disk is in a netfs pool. Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> Changes: v2: Instead of passing the complete pool information, pass just pool type. --- vmtemplate.py | 2 +- xmlutils/disk.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/vmtemplate.py b/vmtemplate.py index b90f221..6299a0a 100644 --- a/vmtemplate.py +++ b/vmtemplate.py @@ -213,7 +213,7 @@ class VMTemplate(object): img = "%s-%s.img" % (vm_uuid, params['index']) storage_path = self._get_storage_path(disk['pool']['name']) params['path'] = os.path.join(storage_path, img) - + params['pool_type'] = disk['pool']['type'] disks_xml += get_disk_xml(params)[1] return unicode(disks_xml, 'utf-8') diff --git a/xmlutils/disk.py b/xmlutils/disk.py index 2ed2ef4..a2035cb 100644 --- a/xmlutils/disk.py +++ b/xmlutils/disk.py @@ -53,7 +53,9 @@ def get_disk_xml(params): driver = E.driver(name='qemu', type=params['format']) if params['type'] != 'cdrom': driver.set('cache', 'none') - driver.set("io", "native") + + if params['pool_type'] == "netfs": + driver.set("io", "native") disk.append(driver) -- 2.1.0

3 4

[PATCH][Kimchi] Fix issue #774 - Invert keys and values in storage volumes boxes
by Rodrigo Trujillo 14 Dec '15

14 Dec '15

Move fields to the right position. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- ui/pages/storage.html.tmpl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/pages/storage.html.tmpl b/ui/pages/storage.html.tmpl index 9f2a978..d11f10c 100644 --- a/ui/pages/storage.html.tmpl +++ b/ui/pages/storage.html.tmpl @@ -161,20 +161,20 @@ </div> <ul class="volume-data"> <li> - <span class="value" title="{format}">{format}</span> <span class="key">$_("Format")</span> + <span class="value" title="{format}">{format}</span> </li> <li> - <span class="value" title="{type}">{type}</span> <span class="key">$_("Type")</span> + <span class="value" title="{type}">{type}</span> </li> <li> - <span class="value" title="{allocation}">{allocation}</span> <span class="key">$_("Allocation")</span> + <span class="value" title="{allocation}">{allocation}</span> </li> <li> - <span class="value" title="{capacity}">{capacity}</span> <span class="key">$_("Capacity")</span> + <span class="value" title="{capacity}">{capacity}</span> </li> </ul> </div> @@ -195,4 +195,4 @@ </script> <div id="modalWindow" class="modal fade storage-modal" tabindex="-1" role="dialog" aria-labelledby="storageModalLabel" aria-hidden="true"> </div> </body> -</html> \ No newline at end of file +</html> -- 2.1.0

4 4

[PATCH] [Wok] Update README to use --remote to update submodules
by Aline Manera 14 Dec '15

14 Dec '15

Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- docs/README.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/README.md b/docs/README.md index aa982f5..952e7c5 100644 --- a/docs/README.md +++ b/docs/README.md @@ -168,19 +168,18 @@ new plugins. Also, by default, Wok is linked to Kimchi (Virtualization To clone Kimchi source code, execute: $ cd src/wok/plugins/kimchi - $ git submodule init - $ git submodule update + $ git submodule update --init --remote To clone Ginger source code, execute: $ cd src/wok/plugins/ginger - $ git submodule init - $ git submodule update + $ git submodule update --init --remote To automatically clone all plugins linked with Wok, use the following git command when cloning Wok project: $ git clone --recursive https://github.com/kimchi-project/wok.git + $ git submodule update --remote Participating -- 2.5.0

1 0

[IMPORTANT] Please, add Wok and Kimchi tag to email subject
by Aline Manera 14 Dec '15

14 Dec '15

Hi all, We will use this same mailing list for Kimchi and Wok. So please, add an appropriated tag to the email subject while sending anything to the mailing list. That way, we can easily identify on which project it is related to. For Wok, update your .git/config file according to instructions at: https://github.com/kimchi-project/wok/wiki/How-to-Contribute#git-sendemail-… For Kimchi, follow the instructions at: https://github.com/kimchi-project/kimchi/wiki/How-to-Contribute#git-sendema… Regards, Aline Manera

1 1

[PATCH] [Kimchi] Bugfix 778: Add volume freezes screen
by Socorro Stoppler 14 Dec '15

14 Dec '15

This patch fixes the screen freezing when adding a storage volume via upload file. The problem was that the item being retrieved from the array was the wrong one since the path has changed. In addition, the modal window is now being closed rather than hidden. That is the reason why the screen seems to be frozen. Socorro Stoppler (1): Fix screen freezing when upload file for storage volume ui/js/src/kimchi.storage_main.js | 6 +++--- ui/js/src/kimchi.storagepool_add_volume_main.js | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 1.9.1

3 3

[PATCH v3] [Kimchi 0/2] Issue 793: Disable Libvirt hot-plugging support for multi-function adapters
by Jose Ricardo Ziviani 14 Dec '15

14 Dec '15

v3: - Change API.md v2: - Apply code review Libvirt does not support multi-function devices hot-plug (but it will). So this patchset will disable hot-plugging for such devices. Jose Ricardo Ziviani (2): Add multi-function field in PCI information Disable hotplugging buttons of multi-function devices docs/API.md | 1 + model/host.py | 33 ++++++++++++++++++++++++++++++++- model/vmhostdevs.py | 3 ++- ui/js/src/kimchi.guest_edit_main.js | 3 +++ 4 files changed, 38 insertions(+), 2 deletions(-) -- 1.9.1

2 3

[PATCH] [Kimchi 0/2 V2] [PATCH] Multiple fixes: page redirection + auth
by Aline Manera 14 Dec '15

14 Dec '15

V1 -> V2: - Fix build Aline Manera (2): Expose HTML tabs files in a specific /tabs URI Remove required authentication from / configure.ac | 1 + kimchi.conf | 1 - tests/test_config.py.in | 3 +- ui/config/tab-ext.xml | 8 +- ui/pages/Makefile.am | 2 +- ui/pages/guests.html.tmpl | 104 -------------------- ui/pages/network.html.tmpl | 105 -------------------- ui/pages/storage.html.tmpl | 198 -------------------------------------- ui/pages/tabs/Makefile.am | 20 ++++ ui/pages/tabs/guests.html.tmpl | 104 ++++++++++++++++++++ ui/pages/tabs/network.html.tmpl | 105 ++++++++++++++++++++ ui/pages/tabs/storage.html.tmpl | 198 ++++++++++++++++++++++++++++++++++++++ ui/pages/tabs/templates.html.tmpl | 102 ++++++++++++++++++++ ui/pages/templates.html.tmpl | 102 -------------------- 14 files changed, 536 insertions(+), 517 deletions(-) delete mode 100644 ui/pages/guests.html.tmpl delete mode 100644 ui/pages/network.html.tmpl delete mode 100644 ui/pages/storage.html.tmpl create mode 100644 ui/pages/tabs/Makefile.am create mode 100644 ui/pages/tabs/guests.html.tmpl create mode 100644 ui/pages/tabs/network.html.tmpl create mode 100644 ui/pages/tabs/storage.html.tmpl create mode 100644 ui/pages/tabs/templates.html.tmpl delete mode 100644 ui/pages/templates.html.tmpl -- 2.5.0

1 3

[PATCH] [Kimchi 0/2] Multiple fixes: page redirection + auth
by Aline Manera 14 Dec '15

14 Dec '15

Depends on Wok patchset: [PATCH] [Wok 0/3] Multiple fixes Aline Manera (2): Expose HTML tabs files in a specific /tabs URI Remove required authentication from / configure.ac | 1 + kimchi.conf | 1 - tests/test_config.py.in | 3 +- ui/config/tab-ext.xml | 8 +- ui/pages/Makefile.am | 2 +- ui/pages/guests.html.tmpl | 104 -------------------- ui/pages/network.html.tmpl | 105 -------------------- ui/pages/storage.html.tmpl | 198 -------------------------------------- ui/pages/tabs/Makefile.am | 20 ++++ ui/pages/tabs/guests.html.tmpl | 104 ++++++++++++++++++++ ui/pages/tabs/network.html.tmpl | 105 ++++++++++++++++++++ ui/pages/tabs/storage.html.tmpl | 198 ++++++++++++++++++++++++++++++++++++++ ui/pages/tabs/templates.html.tmpl | 102 ++++++++++++++++++++ ui/pages/templates.html.tmpl | 102 -------------------- 14 files changed, 536 insertions(+), 517 deletions(-) delete mode 100644 ui/pages/guests.html.tmpl delete mode 100644 ui/pages/network.html.tmpl delete mode 100644 ui/pages/storage.html.tmpl create mode 100644 ui/pages/tabs/Makefile.am create mode 100644 ui/pages/tabs/guests.html.tmpl create mode 100644 ui/pages/tabs/network.html.tmpl create mode 100644 ui/pages/tabs/storage.html.tmpl create mode 100644 ui/pages/tabs/templates.html.tmpl delete mode 100644 ui/pages/templates.html.tmpl -- 2.5.0

2 3