- Kimchi-devel - oVirt List Archives

[PATCH 00/10] FVT testcases base framework
by archus＠linux.vnet.ibm.com 08 Dec '15

08 Dec '15

From: Archana Singh <archus(a)linux.vnet.ibm.com> Patch for adding FVT testcases base framework which can be used across plugins. The changes are: 1) Added fvt package inside tests directory. 2) Added config file inside fvt package to have session details. 3) restapilib.py to have common classes/methods for REST API calls. 4) fvt_base.py, a base test class to take care of doing common setup and treadown required for any fvt test cases like creating/destroying session using config file and restapilib.py. 5) run_test.sh.in script to install all the dependencies and to run all FVT. 6) make file changes to have 'make check-fvt' for running all the FVT. Archana Singh (10): Package for functional verification testcases Wok level config file to have sections required for functional verification test common across plugins. Lists all dependecies for fvt testcases. Common classes/methods for API calls as per config file configuration. Base test class, takes care common actions required for any FVT test cases like creating/destoring session, authorization using wok level fvt config file, creating JSON validator and logging. Install all the dependencies from requirements.txt in python virtualenv and runs all the FVT test cases. Makefile needed for build and run fvt. Added fvt as subdirs and check-fvt to run fvt testcases using make. Added FVT Makefile in AC_CONFIG_FILES list. Added check-fvt to run FVT testcases using make and venv dir to be cleaned. Makefile.am | 8 +- configure.ac | 1 + tests/Makefile.am | 6 + tests/fvt/Makefile.am | 43 +++ tests/fvt/__init__.py | 18 ++ tests/fvt/config | 7 + tests/fvt/fvt_base.py | 92 ++++++ tests/fvt/requirements.txt | 23 ++ tests/fvt/restapilib.py | 760 +++++++++++++++++++++++++++++++++++++++++++++ tests/fvt/run_tests.sh.in | 92 ++++++ 10 files changed, 1048 insertions(+), 2 deletions(-) create mode 100644 tests/fvt/Makefile.am create mode 100644 tests/fvt/__init__.py create mode 100644 tests/fvt/config create mode 100644 tests/fvt/fvt_base.py create mode 100644 tests/fvt/requirements.txt create mode 100644 tests/fvt/restapilib.py create mode 100755 tests/fvt/run_tests.sh.in -- 2.1.0

3 12

[PATCH] Adding Admin New Custom Backup History
by sguimaraes943＠gmail.com 07 Dec '15

07 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> Andre Teodoro (1): Adding Admin New Custom Backup history ui/css/src/modules/_administration.scss | 54 +++++++++++++++++++++++++++++++- ui/js/host-admin.js | Bin 34874 -> 35478 bytes ui/pages/host-admin.html.tmpl | 31 ++++++++++++------ 3 files changed, 74 insertions(+), 11 deletions(-) -- 1.9.3

3 3

[PATCH 0/2] Media Queries and Repositories modals
by sguimaraes943＠gmail.com 07 Dec '15

07 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> This patch adds support for media queries in Gingerbase. The second patch adds wok-radio and wok-checkboxes to the modal windows. It also fixes the "Cancel" button that wasn't working. Regards, Samuel samhenri (2): Adding Media Queries support to Gingerbase Fixed Repository Add and Edit modals ui/css/src/modules/_host.scss | 113 +++++++++++++++++++++++++++++++------ ui/pages/host-dashboard.html.tmpl | 50 ++++++++-------- ui/pages/repository-add.html.tmpl | 8 +-- ui/pages/repository-edit.html.tmpl | 17 +++--- 4 files changed, 133 insertions(+), 55 deletions(-) -- 1.9.3

3 4

[PATCH] [Wok] Create utils method get_task_id()
by pvital＠linux.vnet.ibm.com 07 Dec '15

07 Dec '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> The task_id, used to store the AsyncTasks on objectstore, is a global variable. This patch creates a simple method to return the value of this variable. Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- src/wok/utils.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/wok/utils.py b/src/wok/utils.py index 74c521f..8c8973a 100644 --- a/src/wok/utils.py +++ b/src/wok/utils.py @@ -48,6 +48,11 @@ def get_next_task_id(): return task_id +def get_task_id(): + global task_id + return task_id + + def add_task(target_uri, fn, objstore, opaque=None): id = get_next_task_id() AsyncTask(id, target_uri, fn, objstore, opaque) -- 2.5.0

2 1

[PATCH] [Wok] Create utils method get_task_id()
by pvital＠linux.vnet.ibm.com 07 Dec '15

07 Dec '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> The task_id, used to store the AsyncTasks on objectstore, is a global variable. This patch creates a simple method to return the value of this variable. Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- src/wok/utils.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/wok/utils.py b/src/wok/utils.py index 74c521f..8c8973a 100644 --- a/src/wok/utils.py +++ b/src/wok/utils.py @@ -48,6 +48,11 @@ def get_next_task_id(): return task_id +def get_task_id(): + global task_id + return task_id + + def add_task(target_uri, fn, objstore, opaque=None): id = get_next_task_id() AsyncTask(id, target_uri, fn, objstore, opaque) -- 2.5.0

2 1

[PATCH] [Kimchi] Do not show OVS bridges for now
by Lucio Correia 07 Dec '15

07 Dec '15

This is a temporary fix to not show OVS bridges when creating a new bridged network, since that support is only included in the backend. To be reverted once UI is adapted to support it. Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- netinfo.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/netinfo.py b/netinfo.py index ff91489..4c7a234 100644 --- a/netinfo.py +++ b/netinfo.py @@ -221,7 +221,8 @@ def is_bare_nic(iface): # a slave of bond. # The bridge will not be exposed when all it's port are tap. def all_favored_interfaces(): - return aggregated_bridges() + bare_nics() + bondings() + return list(set(aggregated_bridges() + bare_nics() + bondings()) - + set(ovs_bridges())) def get_interface_type(iface): -- 1.9.1

2 1

[PATCH] [Kimchi] Fix ovs commands output handling
by Lucio Correia 07 Dec '15

07 Dec '15

I've noticed this problem in Kimchi's error output: rc: 1 error: ovs-vsctl: no bridge named \nbr0 returned from cmd: /bin/ovs-vsctl --oneline list-ports \nbr0 Error listing OVS bridge ports for \nbr0 This patch fixes that by: - removing --oneline usage from ovs command; - using list comprehensions to split() each string in the list. Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- netinfo.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/netinfo.py b/netinfo.py index ff91489..c00f603 100644 --- a/netinfo.py +++ b/netinfo.py @@ -94,12 +94,12 @@ def ovs_bridges(): if ovs_cmd is None: return [] - out, error, rc = run_command([ovs_cmd, '--oneline', 'list-br']) + out, error, rc = run_command([ovs_cmd, 'list-br']) if rc != 0: wok_log.info("Error listing OVS bridges") return [] - return list(set(out.split('\n')) - set([''])) + return [x.strip() for x in out.rstrip('\n').split('\n') if x.strip()] def is_ovs_bridge(iface): @@ -113,12 +113,12 @@ def ovs_bridge_ports(ovsbr): if ovs_cmd is None: return [] - out, error, rc = run_command([ovs_cmd, '--oneline', 'list-ports', ovsbr]) + out, error, rc = run_command([ovs_cmd, 'list-ports', ovsbr]) if rc != 0: wok_log.info("Error listing OVS bridge ports for %s" % str(ovsbr)) return [] - return list(set(out.split('\n')) - set([''])) + return [x.strip() for x in out.rstrip('\n').split('\n') if x.strip()] def all_interfaces(): -- 1.9.1

2 1

[PATCH] [Kimchi] Bugfix 786: Undefine button enabled for active storage pool
by Socorro Stoppler 07 Dec '15

07 Dec '15

Undefine button is no longer enabled when storage pool is active Had to use a different function call to disable the 'Undefine' 'button' since this was no longer defined as a 'button' but rather a link. .attr or .prop do not work on links. Socorro Stoppler (1): Bugfix 786: Undefine button enabled for active storage pool ui/js/src/kimchi.storage_main.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.9.1

2 2

[RFC] Change template creation media input
by Ramon Medeiros 04 Dec '15

04 Dec '15

Hi, we have a propose to change how templates are created by Kimchi. Today we do this way: 1) Specify if it's cdrom or disk 2) Pass image path The new propose is: Kimchi will identify if the media is disk or cdrom. So, the user will just pass the media and let kimchi discover it. The main argument of this change is that we won't have errors with users trying to add disks on cdrom template creation, for example. What do you think guys? -- Ramon Nunes Medeiros Kimchi Developer Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn(a)br.ibm.com

3 3

[PATCH 0/2] Live Migration UI v4
by sguimaraes943＠gmail.com 04 Dec '15

04 Dec '15

From: samhenri <samuel.guimaraes(a)eldorado.org.br> This patch adds Live Migration functionality to the new-ui. I'm attaching Socorro initial commit because I had to rebase it with the new-ui in Guests page. v1 - "Delete this VM when the migration is completed" checkbox not working v2 - Added support for checkbox but somehow Live Migration window was hanging instead of displaying error messages. v3 - Fixed problem above and rebased both patches to Kimchi submodule. v4 - Fixed form validation and POST request data. Socorro Stoppler (1): Initial checkin for live migration UI support samhenri (1): Fixing Live Migration for the new-ui Guests tab ui/js/src/kimchi.api.js | 3 +- ui/js/src/kimchi.guest_livemigration.js | 121 ++++++++++++++++++++++++++++++++ ui/js/src/kimchi.guest_main.js | 82 ++++++++++++++++++++-- ui/pages/guest-migration.html.tmpl | 67 ++++++++++++++++++ ui/pages/guest.html.tmpl | 7 +- ui/pages/guests.html.tmpl | 4 +- ui/pages/i18n.json.tmpl | 2 + 7 files changed, 274 insertions(+), 12 deletions(-) create mode 100644 ui/js/src/kimchi.guest_livemigration.js create mode 100644 ui/pages/guest-migration.html.tmpl -- 1.9.3

3 4