- Kimchi-devel - oVirt List Archives

[PATCH 0/3] Storage volume upload UI
by Aline Manera 21 May '15

21 May '15

Aline Manera (3): Storage volume upload: Keep the task tracking to update the UI Storage volume upload: Let the 'format' parameter be an empty string Enable storage volume upload on UI src/kimchi/API.json | 2 +- src/kimchi/mockmodel.py | 3 +- src/kimchi/model/storagevolumes.py | 20 ++++++--- tests/test_model_storagevolume.py | 2 +- ui/js/src/kimchi.api.js | 25 ++++++++--- ui/js/src/kimchi.storagepool_add_volume_main.js | 55 +++++++++++++++++++++---- ui/pages/storagepool-add-volume.html.tmpl | 4 +- 7 files changed, 88 insertions(+), 23 deletions(-) -- 2.1.0

1 3

[PATCH 0/3 V6] Storage volume upload
by Aline Manera 20 May '15

20 May '15

V5 - V6: - Enclose offset information by the lock - Update test case to store file content in a variable to avoid IO v4 -> v5: - Reduce number of locks - Update MockModel and test cases accordingly Aline Manera (2): Upload storage volume Remove storage volume creation from file Royce Lv (1): Update controller to make update accept formdata params docs/API.md | 8 +++- src/kimchi/API.json | 22 ++++++++++ src/kimchi/control/base.py | 6 +-- src/kimchi/i18n.py | 6 +++ src/kimchi/mockmodel.py | 34 +++++++++------ src/kimchi/model/storagevolumes.py | 86 ++++++++++++++++++++----------------- tests/test_model_storagevolume.py | 88 +++++++++++++++++++++++++++++++------- tests/test_rest.py | 45 +------------------ 8 files changed, 180 insertions(+), 115 deletions(-) -- 2.1.0

2 5

[PATCH V2 0/5] View/Edit guest MAC address
by Jose Ricardo Ziviani 20 May '15

20 May '15

V2: - Updated API.json to reflect only mac address as required parameter. - Removed input text filters. - Updated error message. This patchset implements a new feature in Kimchi, it allows users to view and/or edit a guest MAC address. I have a fork of kimchi in my github, so if you prefer to use their diff tool (syntax highlight) you can check this link out: https://github.com/kimchi-project/kimchi/compare/master...jrziviani:guest_m… Jose Ricardo Ziviani (5): Display MAC Address in guest interface tab Fix URI format of guest interfaces Implement backend code to edit MAC address of a guest Implement frontend code to edit MAC address of a guest Update test cases to reflect MAC address update changes src/kimchi/API.json | 13 ++------ src/kimchi/control/vm/ifaces.py | 2 +- src/kimchi/i18n.py | 4 ++- src/kimchi/model/vmifaces.py | 60 ++++++++++++++++++++++++++----------- tests/test_model.py | 17 +++++++++-- tests/test_rest.py | 12 ++++---- ui/css/theme-default/guest-edit.css | 2 +- ui/js/src/kimchi.guest_edit_main.js | 44 ++++++++++++++++++--------- ui/pages/guest-edit.html.tmpl | 8 ++++- 9 files changed, 109 insertions(+), 53 deletions(-) -- 1.9.1

3 12

Scrum meeting is now bi-weekly
by Aline Manera 19 May '15

19 May '15

Hi all, As discussed in the last scrum meeting, it will be bi-weekly from now on. So we will not have scrum meeting tomorrow. See you on May 27th. Regards, Aline Manera

1 0

[RFC] Moving some features of Host tab to Ginger
by Daniel Henrique Barboza 15 May '15

15 May '15

Hi, This is something that has been discussed offline and I would like to share it with everyone. At this moment, Kimchi has host related features that I believe would be a better fit in Ginger, which is a plug-in dedicated to host management. They are in the "Host" tab of Kimchi. These features are: - host shutdown - host reboot - debug reports - software updates - repositories Moving them to Ginger would be beneficial to both Ginger and Kimchi in my opinion. Ginger will have more features to further control and setup the host, Kimchi will be relieved of maintaining them, being able to focus only on its primary goal, virtualization management. When I say "moving" I mean not only the features but all the related bugs and backlog entries too. Thoughts?

4 5

[PATCH] Avoid certificate validation on tests
by Ramon Medeiros 15 May '15

15 May '15

Python 2.7.9 forces https libraries to check if certicate is valid. If not, it will raise an exception. So, a context that unverify the certificate is necessary to run tests. Issue #637: Tests fail with an SSL error on Ubuntu Vivid / Debian Jessie Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- tests/utils.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/utils.py b/tests/utils.py index 2a8929f..2ffe776 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -22,9 +22,11 @@ import base64 import cherrypy import grp import httplib +import inspect import json import os import socket +import ssl import sys import time import threading @@ -148,7 +150,13 @@ def _request(conn, path, data, method, headers): def request(host, port, path, data=None, method='GET', headers=None): - conn = httplib.HTTPSConnection(host, port) + # verify if HTTPSConnection has context parameter + if "context" in inspect.getargspec(httplib.HTTPSConnection.__init__).args: + context = ssl._create_unverified_context() + conn = httplib.HTTPSConnection(host, port, context=context) + else: + conn = httplib.HTTPSConnection(host, port) + return _request(conn, path, data, method, headers) -- 2.1.0

3 2

[PATCH v3 0/5] Allow creating VM storages with ref_cnt > 0
by Crístian Deives 15 May '15

15 May '15

The difference between this and the previous patchset (v2) is: - Patch 2 has been added. - The UI code has been updated in order to display all volumes from a storage volume when attaching a disk to a VM. Crístian Deives (5): fix: Use correct path when setting 'ref_cnt' to a new volume Handle invalid path in 'get_disk_ref_cnt' Replace storage volume 'ref_cnt' with 'used_by' Allow creating VM storages with non-empty 'used_by' Set 'used_by' to [] when creating some volumes docs/API.md | 4 +-- src/kimchi/control/storagevolumes.py | 2 +- src/kimchi/i18n.py | 1 - src/kimchi/mockmodel.py | 4 +-- src/kimchi/model/diskutils.py | 20 ++++++------ src/kimchi/model/storagevolumes.py | 33 ++++++++++---------- src/kimchi/model/vms.py | 14 ++++++--- src/kimchi/model/vmstorages.py | 50 ++++++++++++++++-------------- tests/test_model.py | 6 ++++ tests/test_model_storagevolume.py | 2 +- tests/test_rest.py | 2 +- ui/js/src/kimchi.guest_storage_add.main.js | 2 +- ui/js/src/kimchi.storage_main.js | 2 +- 13 files changed, 76 insertions(+), 66 deletions(-) -- 2.1.0

2 13

[PATCH 0/4 V5] Storage volume upload
by Aline Manera 15 May '15

15 May '15

This patch set depends on "[Kimchi-devel] [PATCH v2 1/4] fix: Use correct path when setting 'ref_cnt' to a new volume", so I included it to this patch set to help testing. v4 -> v5: - Reduce number of locks - Update MockModel and test cases accordingly Aline Manera (2): Upload storage volume Remove storage volume creation from file Crístian Deives (1): fix: Use correct path when setting 'ref_cnt' to a new volume Royce Lv (1): Update controller to make update accept formdata params docs/API.md | 8 +++- src/kimchi/API.json | 22 +++++++++ src/kimchi/control/base.py | 6 +-- src/kimchi/i18n.py | 6 +++ src/kimchi/mockmodel.py | 34 +++++++++----- src/kimchi/model/storagevolumes.py | 93 ++++++++++++++++++++++---------------- tests/test_model_storagevolume.py | 89 ++++++++++++++++++++++++++++++------ tests/test_rest.py | 45 +----------------- 8 files changed, 187 insertions(+), 116 deletions(-) -- 2.1.0

3 16

[PATCH] Bug fix: Build default pools list according to user input
by Aline Manera 15 May '15

15 May '15

Instead of predefine a default pools list, build it according to user input to make it will be always accurated. Specially in case to import the StoragePoolsModel multiple times. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- src/kimchi/model/storagepools.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/src/kimchi/model/storagepools.py b/src/kimchi/model/storagepools.py index e82d6ed..f022deb 100644 --- a/src/kimchi/model/storagepools.py +++ b/src/kimchi/model/storagepools.py @@ -35,9 +35,6 @@ from kimchi.utils import add_task, kimchi_log, pool_name_from_uri, run_command from kimchi.xmlutils.utils import xpath_get_text -DEFAULT_POOLS = {'default': {'path': '/var/lib/libvirt/images'}, - 'ISO': {'path': '/var/lib/kimchi/isos'}} - ISO_POOL_NAME = u'kimchi_isos' POOL_STATE_MAP = {0: 'inactive', @@ -71,25 +68,27 @@ class StoragePoolsModel(object): self._check_default_pools() def _check_default_pools(self): + pools = {} + default_pool = tmpl_defaults['storagepool'] default_pool = default_pool.split('/')[2] - if default_pool != 'default': - del DEFAULT_POOLS['default'] - DEFAULT_POOLS[default_pool] = {} + pools[default_pool] = {} + if default_pool == 'default': + pools[default_pool] = {'path': '/var/lib/libvirt/images'} - if config.get("server", "create_iso_pool") != "true": - del DEFAULT_POOLS['ISO'] + if config.get("server", "create_iso_pool") == "true": + pools['ISO'] = {'path': '/var/lib/kimchi/isos'} error_msg = ("Please, check the configuration in %s/template.conf to " "ensure it has a valid storage pool." % paths.conf_dir) conn = self.conn.get() - for pool_name in DEFAULT_POOLS: + for pool_name in pools: try: pool = conn.storagePoolLookupByName(pool_name) except libvirt.libvirtError, e: - pool_path = DEFAULT_POOLS[pool_name].get('path') + pool_path = pools[pool_name].get('path') if pool_path is None: msg = "Fatal: Unable to find storage pool %s. " + error_msg kimchi_log.error(msg % pool_name) -- 2.1.0

2 2

[PATCH] Fix for section in man page
by Frédéric Bonnard 15 May '15

15 May '15

From: Frederic Bonnard <frediz(a)linux.vnet.ibm.com> Fixed the section number to 8 as in the filename. F. Frederic Bonnard (1): Fixed section number within the man page itself docs/kimchid.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1

4 6