- Kimchi-devel - oVirt List Archives

[PATCH] PPC: Templates have memory always set to 1280. Set minimal memory to 2048
by Rodrigo Trujillo 14 May '15

14 May '15

There is a bug in the osinfo.py when Kimchi generates templates for ppc guests. The amount of memory will always be 1280, in other other, it is overwriting the value set in src/template.conf. This patch fixes this problem and sets the minimal memory for ppc guests as 2048, because there are issues reported by users that 1280 is not sufficient and cause installation hangs. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- src/kimchi/osinfo.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/kimchi/osinfo.py b/src/kimchi/osinfo.py index 67d85be..5c315ea 100644 --- a/src/kimchi/osinfo.py +++ b/src/kimchi/osinfo.py @@ -43,28 +43,26 @@ template_specs = {'x86': {'old': dict(disk_bus='ide', cdrom_bus='scsi', kbd_type="kbd", kbd_bus='usb', mouse_bus='usb', - tablet_bus='usb', memory=1280), + tablet_bus='usb'), 'modern': dict(disk_bus='virtio', nic_model='virtio', cdrom_bus='scsi', kbd_bus='usb', kbd_type="kbd", - mouse_bus='usb', tablet_bus='usb', - memory=1280)}, + mouse_bus='usb', tablet_bus='usb')}, 'ppc64le': {'old': dict(disk_bus='virtio', nic_model='virtio', cdrom_bus='scsi', kbd_bus='usb', kbd_type="keyboard", - mouse_bus='usb', tablet_bus='usb', - memory=1280), + mouse_bus='usb', tablet_bus='usb'), 'modern': dict(disk_bus='virtio', nic_model='virtio', cdrom_bus='scsi', kbd_bus='usb', kbd_type="keyboard", - mouse_bus='usb', tablet_bus='usb', - memory=1280)}} + mouse_bus='usb', + tablet_bus='usb')}} modern_version_bases = {'x86': {'debian': '6.0', 'ubuntu': '7.10', @@ -185,6 +183,10 @@ def lookup(distro, version): if params["arch"] == "ppc64le": params["arch"] = "ppc64" + # set up minimal default amount of memory for powerpc guests + if params["arch"] in ("ppc", "ppc64") and params["memory"] < 2048: + params["memory"] = 2048 + if distro in modern_version_bases[arch]: if LooseVersion(version) >= LooseVersion( modern_version_bases[arch][distro]): -- 2.1.0

2 3

[PATCH 0/5] View/Edit guest MAC address
by Jose Ricardo Ziviani 12 May '15

12 May '15

This patchset implements a new feature in Kimchi, it allows users to view and/or edit a guest MAC address. I have a fork of kimchi in my github, so if you prefer to use their diff tool (syntax highlight) you can check this link out: https://github.com/kimchi-project/kimchi/compare/master...jrziviani:guest_m… Jose Ricardo Ziviani (5): Display MAC Address in guest interface tab Fix URI format of guest interfaces Implement backend code to edit MAC address of a guest Implement frontend code to edit MAC address of a guest Update test cases to reflect MAC address update changes src/kimchi/API.json | 13 +++++++ src/kimchi/control/vm/ifaces.py | 2 +- src/kimchi/i18n.py | 4 +- src/kimchi/model/vmifaces.py | 60 +++++++++++++++++++++--------- tests/test_model.py | 17 +++++++-- tests/test_rest.py | 12 +++--- ui/css/theme-default/guest-edit.css | 2 +- ui/js/src/kimchi.guest_edit_main.js | 74 ++++++++++++++++++++++++++++++------- ui/pages/guest-edit.html.tmpl | 8 +++- 9 files changed, 149 insertions(+), 43 deletions(-) -- 1.9.1

2 7

[PATCH] Increase template minimal memory to 2048 for PPC guests
by Rodrigo Trujillo 12 May '15

12 May '15

Users have seen issues when installing PPC64 and PPC64LE guests using the default 1280M. This patch increases the amount of memory to 2G. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- src/kimchi/osinfo.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/kimchi/osinfo.py b/src/kimchi/osinfo.py index 67d85be..d80f717 100644 --- a/src/kimchi/osinfo.py +++ b/src/kimchi/osinfo.py @@ -43,28 +43,28 @@ template_specs = {'x86': {'old': dict(disk_bus='ide', cdrom_bus='scsi', kbd_type="kbd", kbd_bus='usb', mouse_bus='usb', - tablet_bus='usb', memory=1280), + tablet_bus='usb', memory=2048), 'modern': dict(disk_bus='virtio', nic_model='virtio', cdrom_bus='scsi', kbd_bus='usb', kbd_type="kbd", mouse_bus='usb', tablet_bus='usb', - memory=1280)}, + memory=2048)}, 'ppc64le': {'old': dict(disk_bus='virtio', nic_model='virtio', cdrom_bus='scsi', kbd_bus='usb', kbd_type="keyboard", mouse_bus='usb', tablet_bus='usb', - memory=1280), + memory=2048), 'modern': dict(disk_bus='virtio', nic_model='virtio', cdrom_bus='scsi', kbd_bus='usb', kbd_type="keyboard", mouse_bus='usb', tablet_bus='usb', - memory=1280)}} + memory=2048)}} modern_version_bases = {'x86': {'debian': '6.0', 'ubuntu': '7.10', -- 2.1.0

1 1

[PATCH 0/9] Issue #450 - "test_delete_running_vm" fails on Fedora 20
by Ramon Medeiros 07 May '15

07 May '15

Libvirt does not support special characters on name tag. This patch make Kimchi writes the special name at title tag and use an ascii version in name tag. Ramon Medeiros (9): Create title tag Change the way that get_vm() and vm_list() search for VMs Use get_vm() instead of conn.lookupByName Encode vm_name to generate VNC token Reflect the unicode conversion on token creation Redefine title tag on vm update Fix functions that uses connection as parameter Return name with special characters when taking snapshot Template_test: check assert that verifies the vm name src/kimchi/model/vms.py | 82 +++++++++++++++++++++++++++++++++++------ src/kimchi/model/vmsnapshots.py | 7 ++++ src/kimchi/model/vmstorages.py | 7 +--- src/kimchi/vmtemplate.py | 4 +- tests/test_vmtemplate.py | 8 +++- ui/js/src/kimchi.api.js | 4 +- 6 files changed, 92 insertions(+), 20 deletions(-) -- 2.1.0

2 10

[PATCH] Add documentation for VM suspend/resume
by Crístian Deives 07 May '15

07 May '15

Commit 82e5658 has added support for VM suspend/resume but the project documentation hasn't been updated with the new commands. Add documentation for the VM commands "suspend" and "resume". Signed-off-by: Crístian Deives <cristiandeives(a)gmail.com> --- docs/API.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/API.md b/docs/API.md index 922ded1..62e4063 100644 --- a/docs/API.md +++ b/docs/API.md @@ -140,6 +140,13 @@ the following general conventions: volume, it will be created on the pool 'default'. This action returns a Task. +* suspend: Suspend an active domain. The process is frozen without further + access to CPU resources and I/O but the memory used by the domain at + the hypervisor level will stay allocated. + +* resume: Resume a suspended domain. The process is restarted from the state + where it was frozen by calling "suspend". + ### Sub-resource: Virtual Machine Screenshot **URI:** /vms/*:name*/screenshot -- 2.1.0

3 2

[PATCH v2 0/4] Allow creating VM storages with ref_cnt > 0
by Crístian Deives 07 May '15

07 May '15

The difference between this and the previous patchset is: - Patches 1 and 4 have been added to fix some related bugs. - Patch 2 has been added to change ref_cnt to used_by. ref_cnt indicated how many VMs used a storage volume, whereas used_by indicate which VMs use a storage volume. Crístian Deives (4): fix: Use correct path when setting 'ref_cnt' to a new volume Replace storage volume 'ref_cnt' with 'used_by' Allow creating VM storages with non-empty 'used_by' Set 'used_by' to [] when creating some volumes docs/API.md | 4 +-- src/kimchi/control/storagevolumes.py | 2 +- src/kimchi/i18n.py | 1 - src/kimchi/mockmodel.py | 4 +-- src/kimchi/model/diskutils.py | 18 ++++++------- src/kimchi/model/storagevolumes.py | 33 ++++++++++++------------ src/kimchi/model/vms.py | 14 ++++++---- src/kimchi/model/vmstorages.py | 50 +++++++++++++++++++----------------- tests/test_model.py | 6 +++++ tests/test_model_storagevolume.py | 2 +- tests/test_rest.py | 2 +- 11 files changed, 73 insertions(+), 63 deletions(-) -- 2.1.0

1 4

[PATCH 0/3 V2] Make Template defaults configurable
by Aline Manera 06 May '15

06 May '15

v1 -> v2: - Fix error message format Aline Manera (3): Make Template defaults configurable Verify all networks set as Template defaults prior to server start up Verify storage pool set as Template default prior to server starts up contrib/DEBIAN/control.in | 1 + contrib/kimchi.spec.fedora.in | 2 ++ contrib/kimchi.spec.suse.in | 2 ++ docs/README.md | 8 ++--- src/Makefile.am | 2 +- src/kimchi/model/model.py | 44 +---------------------- src/kimchi/model/networks.py | 63 +++++++++++++++----------------- src/kimchi/model/storagepools.py | 66 ++++++++++++++++++++++++++++++++++ src/kimchi/model/templates.py | 2 -- src/kimchi/osinfo.py | 78 ++++++++++++++++++++++++++++++++++------ src/template.conf | 47 ++++++++++++++++++++++++ 11 files changed, 220 insertions(+), 95 deletions(-) create mode 100644 src/template.conf -- 2.1.0

2 5

[RFC] Split Kimchi into Base Framework and Virtualization layers
by Lucio Correia 05 May '15

05 May '15

Hi, Gustavo (on cc) and me have been analyzing how to split Kimchi Virtualization layer form its Base web framework. We would like to leverage all infrastructure kimchi base framework provides (URI routing, error handling, i18n, authentication, API validation, plugin tabs loading) in other projects, and contribute this back to kimchi-ginger project. The general idea for the web framework is that it provides basic UI with login and tabs menu, and each plugin installed extends the menu with some tabs. We started by making kimchi a plugin, like ginger is. We are way advanced on that and already have most of kimchi's UI running as a plugin over an almost fully running base web framework. Ginger needs minimal changes, mainly on import statements. We can provide changes needed back to ginger too. Currently, we are splitting kimchi specific stuff like this way: (after renaming the dir src/kimchi to src/backend *) * we are using the name "backend" just for disambiguation from virtualization layer (plugins/kimchi). We will need to define a better name for that basic framework. One suggestion is to call it "wok", the base where kimchi is cooked. {src/backend => plugins/kimchi}/API.json | 0 {src/backend/control/vm => plugins/kimchi/control}/Makefile.am | 7 +- {src/backend/control/vm => plugins/kimchi/control}/__init__.py | 2 +- {src/backend => plugins/kimchi}/control/config.py | 0 {src/backend => plugins/kimchi}/control/cpuinfo.py | 0 {src/backend => plugins/kimchi}/control/debugreports.py | 0 {src/backend => plugins/kimchi}/control/groups.py | 0 {src/backend => plugins/kimchi}/control/host.py | 0 {src/backend => plugins/kimchi}/control/interfaces.py | 0 {src/backend => plugins/kimchi}/control/networks.py | 0 {src/backend => plugins/kimchi}/control/peers.py | 0 {src/backend => plugins/kimchi}/control/storagepools.py | 0 {src/backend => plugins/kimchi}/control/storageservers.py | 0 {src/backend => plugins/kimchi}/control/storagevolumes.py | 0 {src/backend => plugins/kimchi}/control/templates.py | 0 {src/backend => plugins/kimchi}/control/users.py | 0 {src/backend => plugins/kimchi}/control/vm/Makefile.am | 0 {src/backend => plugins/kimchi}/control/vm/__init__.py | 0 {src/backend => plugins/kimchi}/control/vm/hostdevs.py | 0 {src/backend => plugins/kimchi}/control/vm/ifaces.py | 0 {src/backend => plugins/kimchi}/control/vm/snapshots.py | 0 {src/backend => plugins/kimchi}/control/vm/storages.py | 0 {src/backend => plugins/kimchi}/control/vms.py | 0 {src/backend => plugins/kimchi}/disks.py | 0 {src/backend => plugins/kimchi}/imageinfo.py | 0 {src/backend => plugins/kimchi}/iscsi.py | 0 {src/backend => plugins/kimchi}/isoinfo.py | 0 {src/backend => plugins/kimchi}/kvmusertests.py | 0 {src/backend => plugins/kimchi}/mockmodel.py | 0 {src/backend/control/vm => plugins/kimchi/model}/Makefile.am | 7 +- {src/backend/control/vm => plugins/kimchi/model}/__init__.py | 8 --- {src/backend => plugins/kimchi}/model/config.py | 0 {src/backend => plugins/kimchi}/model/cpuinfo.py | 0 {src/backend => plugins/kimchi}/model/debugreports.py | 0 {src/backend => plugins/kimchi}/model/diskutils.py | 0 {src/backend => plugins/kimchi}/model/featuretests.py | 0 {src/backend => plugins/kimchi}/model/groups.py | 0 {src/backend => plugins/kimchi}/model/host.py | 0 {src/backend => plugins/kimchi}/model/hostdev.py | 0 {src/backend => plugins/kimchi}/model/interfaces.py | 0 {src/backend => plugins/kimchi}/model/libvirtconnection.py | 0 {src/backend => plugins/kimchi}/model/libvirtstoragepool.py | 0 plugins/kimchi/model/model.py | 93 ++++++++++++++++++++++++++++ {src/backend => plugins/kimchi}/model/networks.py | 0 {src/backend => plugins/kimchi}/model/peers.py | 0 {src/backend => plugins/kimchi}/model/storagepools.py | 0 {src/backend => plugins/kimchi}/model/storageservers.py | 0 {src/backend => plugins/kimchi}/model/storagetargets.py | 0 {src/backend => plugins/kimchi}/model/storagevolumes.py | 0 {src/backend => plugins/kimchi}/model/templates.py | 0 {src/backend => plugins/kimchi}/model/users.py | 0 {src/backend => plugins/kimchi}/model/utils.py | 0 {src/backend => plugins/kimchi}/model/vmhostdevs.py | 0 {src/backend => plugins/kimchi}/model/vmifaces.py | 0 {src/backend => plugins/kimchi}/model/vms.py | 0 {src/backend => plugins/kimchi}/model/vmsnapshots.py | 0 {src/backend => plugins/kimchi}/model/vmstorages.py | 0 {src/backend => plugins/kimchi}/osinfo.py | 0 {src/backend => plugins/kimchi}/scan.py | 0 {config => plugins/kimchi/ui}/Makefile.am | 0 {config/ui => plugins/kimchi/ui/config}/Makefile.am | 0 config/ui/tabs.xml => plugins/kimchi/ui/config/tab-ext.xml | 0 {src/backend => plugins/kimchi}/vmtemplate.py | 0 The remaining generic stuff on the "backend" side, usable or already in use by other plugins, would be: backend |___model | |___model.py | |___plugins.py | |___tasks.py |___control | |___base.py | |___plugins.py | |___tasks.py | |___utils.py |___xmlutils | |___network.py | |___disk.py | |___utils.py | |___graphics.py | |___qemucmdline.py | |___interface.py |___asynctask.py |___auth.py |___basemodel.py |___cachebust.py |___distroloader.py |___exception.py |___i18n.py |___netinfo.py |___network.py |___objectstore.py |___proxy.py |___repositories.py |___rollbackcontext.py |___root.py |___screenshot.py |___server.py |___sslcert.py |___swupdate.py |___template.py |___utils.py |___vnc.py We don't want to make this a too long e-mail and lose the focus on the idea. We have further technical details to discuss in a follow up. Please let us know your thoughts on that, any directions and requirements you have on this, and how could we proceed with that plan. -- Lucio Correia Software Engineer IBM LTC Brazil

2 3

[kimchi-devel][PATCHv4 0/7] Upload storage volume
by lvroyce＠linux.vnet.ibm.com 04 May '15

04 May '15

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com> How to upload: POST /storagepools/<pool-name>/storagevolumes/ {'capacity':size-of-the-volume,'name':name-of-the-volume,'format':'raw'} PUT /storagepools/<pool-name>/storagevolumes/<volume-name> {'chunk':chunk-data,'chunk_size':size-of-chunk,'index':index-of-the-chunk-of-uploaded-file} PATCH 7/7 is a script against real model server, you can use it to verify the logic of upload. Royce Lv (7): Update docs and json schema of storage volume upload Update controller to make update accept formdata params Add lock facility for storage volume upload Update model for storage volume update Fix incomplete record when uploading update test case for storage volume upload A test script against real model server docs/API.md | 7 ++- src/kimchi/API.json | 22 ++++++++ src/kimchi/control/base.py | 6 +-- src/kimchi/i18n.py | 4 ++ src/kimchi/isoinfo.py | 5 +- src/kimchi/model/storagevolumes.py | 61 ++++++++++----------- src/kimchi/model/utils.py | 46 ++++++++++++++++ tests/test_api.py | 108 +++++++++++++++++++++++++++++++++++++ tests/test_model_storagevolume.py | 95 ++++++++++++++++++++++++-------- 9 files changed, 291 insertions(+), 63 deletions(-) create mode 100644 tests/test_api.py -- 2.1.0

3 15

[PATCH 0/5] Support vm name with special characters
by Ramon Medeiros 04 May '15

04 May '15

Ramon Medeiros (5): Create title tag Change the way that get_vm() and vm_list() search for VMs Use get_vm() instead of conn.lookupByName Encode vm_name to generate VNC token Reflect the unicode conversion on token creation src/kimchi/model/vms.py | 50 +++++++++++++++++++++++++++++++++--------- src/kimchi/model/vmstorages.py | 4 ++-- src/kimchi/vmtemplate.py | 4 +++- ui/js/src/kimchi.api.js | 4 ++-- 4 files changed, 47 insertions(+), 15 deletions(-) -- 2.1.0

2 11