- Kimchi-devel - oVirt List Archives

Re: [Kimchi-devel] [kimchi] The auto logout leaves action menu on page (#294)
by Yu Xin Huo 23 Jan '14

23 Jan '14

Sorry, it is not host tab, but guest tab. On 1/23/2014 5:44 AM, Adam King wrote: > Yu Xin, > > I was checking out some of the outstanding issues. I can't recreate this > as there isn't a host action menu, at least not the way I am reading > your issue description. > Can you elaborate, and/or include a picture? > > Thanks, > Adam > On 12/30/2013 3:29 AM, Yu Xin Huo wrote: > > > > Happened to see an issue. > > > > 1. bring up action menu of host and leave it there > > 2. when session timeout, the login dialog popup behind the menu > > > > This looks quite bad although it is not an functional issue. > > > > — > > Reply to this email directly or view it on GitHub > > <https://github.com/kimchi-project/kimchi/issues/294>. > > > > -- > Adam King <rak(a)linux.vnet.ibm.com> > IBM CSI > > — > Reply to this email directly or view it on GitHub > <https://github.com/kimchi-project/kimchi/issues/294#issuecomment-33071839>. >

1 0

Apply code guidelines
by Crístian Viana 22 Jan '14

22 Jan '14

Hi! I am sending this patchset as an attempt to make the Kimchi code more consistent. Some of the changes are specified by the PEP8 Style Guide, some of them are not. This is only *one attempt*; these rules do not need necessarily to be commited. If you do not agree or have any question regarding the patches, feel free to discuss them here. Currently, there is no standard for the Kimchi code and I think we should have an official code guideline, that is why I am trying to apply these patches. It does not need to be exactly these rules but adopting some kind of style instead of the subjectivity of each developer will be a nice addition to the project. As soon as we define our guidelines, we should have a wiki page or some file describing them all.

2 11

[PATCH V2 0/4] support create/delete VMIface
by shaohef＠linux.vnet.ibm.com 22 Jan '14

22 Jan '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> This patch depends on "[PATCH V2 0/6] VM supports interfaces" V1 -> V2 do not support hot plugging attach/detach interface we will support this feature after we implement events. 1. get all vms: $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms 2. get all networks: $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/networks 3. get all ifaces of a vm $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms/test-vm-0/ifaces/ [ { "mac":"52:54:00:00:00:01", "model":"virtio", "type":"network", "network":"default" } ] 4. attach a new iface to vm $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms/test-vm-8/ifaces -X POST -d ' { "type":"network", "network":"test-network-0" } ' { "mac":"52:54:00:00:00:0d", "model":"virtio", "type":"network", "network":"test-network-0" } 5. detach a iface from vm $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms/test-vm-8/ifaces/52:54:00:00:00:0d -X DELETE ShaoHe Feng (4): support create/delete VMIface: update model support create/delete VMIface: update mockmodel support create/delete VMIface: update API.json support create/delete VMIface: update testcase src/kimchi/API.json | 21 ++++++++++++++++++ src/kimchi/mockmodel.py | 21 ++++++++++++++++++ src/kimchi/model.py | 57 ++++++++++++++++++++++++++++++++++++++++++++++++- tests/test_model.py | 22 +++++++++++++++++++ tests/test_rest.py | 27 +++++++++++++++++++++++ 5 files changed, 147 insertions(+), 1 deletion(-) -- 1.8.4.2

1 4

[PATCH V2 0/6] VM supports interfaces
by shaohef＠linux.vnet.ibm.com 22 Jan '14

22 Jan '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> This patch set depends on this patch: [PATCH V3 0/4] improve controller V1 -> V2 use the "mac" to identify the iface and remove "name" parameter $ curl -u user -H 'Accept: application/json' -H 'Content-type: application/json' \ http://localhost:800/vms/test-vm-8/ifaces/ [ { "mac":"52:54:00:00:00:08", "model":"virtio", "type":"network", "network":"default", "name":"52:54:00:00:00:08" } ] $ curl -u user -H 'Accept: application/json' -H 'Content-type: application/json' \ http://localhost:800/vms/test-vm-8/ifaces/52:54:00:00:00:08 { "mac":"52:54:00:00:00:08", "model":"virtio", "type":"network", "network":"default", "name":"52:54:00:00:00:08" } ShaoHe Feng (6): Add a control.vm module VM supports interfaces: update API VM supports interfaces: update model VM supports interfaces: update controller VM supports interfaces: update mockmodel VM supports interfaces: update testcase Makefile.am | 1 + configure.ac | 1 + contrib/kimchi.spec.fedora.in | 1 + contrib/kimchi.spec.suse.in | 1 + docs/API.md | 46 +++++++++++++++++++++++++++++++++++++ src/kimchi/control/Makefile.am | 2 ++ src/kimchi/control/vm/Makefile.am | 32 ++++++++++++++++++++++++++ src/kimchi/control/vm/__init__.py | 30 ++++++++++++++++++++++++ src/kimchi/control/vm/ifaces.py | 48 +++++++++++++++++++++++++++++++++++++++ src/kimchi/control/vms.py | 3 +++ src/kimchi/mockmodel.py | 33 +++++++++++++++++++++++++++ src/kimchi/model.py | 36 +++++++++++++++++++++++++++++ tests/test_model.py | 19 ++++++++++++++++ tests/test_rest.py | 31 +++++++++++++++++++++++++ 14 files changed, 284 insertions(+) create mode 100644 src/kimchi/control/vm/Makefile.am create mode 100644 src/kimchi/control/vm/__init__.py create mode 100644 src/kimchi/control/vm/ifaces.py -- 1.8.4.2

1 6

[PATCH] Remove 'encoding=iso-8859-1' from json.dumps()
by Mark Wu 22 Jan '14

22 Jan '14

The encoding option for json.dumps() is used to indicate the charsets of the passed in str. Currently, we use the encoding of iso-8859-1, but actually we don't have any data encoded in iso-8859-1. It doesn't cause any problem because the strings in the data passed are ascii chars or unicode. If we pass a utf-8 str, it will canse an expected result. So we could remove the option, and after that it can accept utf-8 str too because json.dumps use utf-8 as default encoding. Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com> --- src/kimchi/template.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/kimchi/template.py b/src/kimchi/template.py index 1f19c4a..f854657 100644 --- a/src/kimchi/template.py +++ b/src/kimchi/template.py @@ -84,9 +84,7 @@ def can_accept_html(): def render(resource, data): if can_accept('application/json'): cherrypy.response.headers['Content-Type'] = 'application/json;charset=utf-8' - return json.dumps(data, indent=2, - separators=(',', ':'), - encoding='iso-8859-1') + return json.dumps(data, indent=2, separators=(',', ':')) elif can_accept_html(): filename = config.get_template_path(resource) try: -- 1.8.4.2

4 4

[PATCH v2] Python: Do not allow lines longer than 79 characters
by Crístian Viana 22 Jan '14

22 Jan '14

This is the difference between this and the previous patchset (v1): - Limit line length to 79 characters instead of 80, according to the PEP8 specification. Crístian Viana (1): Python: Do not allow lines longer than 79 characters src/kimchi/__init__.py | 2 +- src/kimchi/mockmodel.py | 26 ++++++++----- src/kimchi/model.py | 99 ++++++++++++++++++++++++++++------------------- src/kimchi/objectstore.py | 5 ++- src/kimchi/osinfo.py | 20 ++++++---- src/kimchi/scan.py | 13 ++++--- src/kimchi/screenshot.py | 5 ++- src/kimchi/sslcert.py | 2 +- src/kimchi/template.py | 5 ++- src/kimchi/utils.py | 2 +- src/kimchi/vmtemplate.py | 12 ++++-- src/kimchi/vnc.py | 2 +- tests/test_exception.py | 2 +- tests/test_osinfo.py | 5 ++- tests/test_server.py | 2 +- tests/test_vmtemplate.py | 2 +- 16 files changed, 123 insertions(+), 81 deletions(-) -- 1.8.4.2

1 1

[PATCH 0/4] support create/delete VMIface
by shaohef＠linux.vnet.ibm.com 22 Jan '14

22 Jan '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> This patch depends on "[PATCH V1 0/6] VM supports interfaces" 1. get all vms: $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms 2. get all networks: $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/networks 3. get all ifaces of a vm $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms/test-vm-0/ifaces/ [ { "mac":"52:54:00:00:00:01", "model":"virtio", "type":"network", "network":"default" } ] 4. attach a new iface to vm $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms/test-vm-8/ifaces -X POST -d ' { "type":"network", "network":"test-network-0" } ' { "mac":"52:54:00:00:00:0d", "model":"virtio", "type":"network", "network":"test-network-0" } 5. detach a iface from vm $ curl -u <user> -H 'Accept: application/json' -H 'Content-type: application/json' http://localhost:8000/vms/test-vm-8/ifaces/52:54:00:00:00:0d -X DELETE ShaoHe Feng (4): support create/delete VMIface: update model support create/delete VMIface: update mockmodel support create/delete VMIface: update API.json support create/delete VMIface: update testcase src/kimchi/API.json | 21 ++++++++++++++++++++ src/kimchi/mockmodel.py | 21 ++++++++++++++++++++ src/kimchi/model.py | 51 ++++++++++++++++++++++++++++++++++++++++++++++++- tests/test_model.py | 22 +++++++++++++++++++++ tests/test_rest.py | 27 ++++++++++++++++++++++++++ 5 files changed, 141 insertions(+), 1 deletion(-) -- 1.8.4.2

4 11

[PATCHv9 0/8] storage servers and targets supprt
by lvroyce＠linux.vnet.ibm.com 22 Jan '14

22 Jan '14

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com> v8>v9, split two types of filter params, fix nits v7>v8, address model break, change xml construction to libxml v6>v7, adopt lxml to parse xml, move parse params to get() to avoid duplicate code, fix bugs when one server support multiple target type. v5>v6, change GET param support to cover more scenario of filter collected results. v4>v5, remove storage server list reload function, merge storage server and targets v3>v4, fix inconsistency between doc and json schema v1>v3, fix racing problem, fix style. Royce Lv (8): Support params for GET method Add testcase for GET param Storage server: Update API.md storage server: update controller.py storage server: Update model and mockmodel storage target: Update API.md storage target: Update controller and json schema storage target: Add model support docs/API.md | 22 +++++++++++ src/kimchi/API.json | 22 +++++++++++ src/kimchi/control/base.py | 31 +++++++++++---- src/kimchi/control/storagepools.py | 4 +- src/kimchi/control/storageserver.py | 55 ++++++++++++++++++++++++++ src/kimchi/control/storagevolumes.py | 2 +- src/kimchi/mockmodel.py | 30 +++++++++++++++ src/kimchi/model.py | 75 ++++++++++++++++++++++++++++++++++++ src/kimchi/root.py | 2 + tests/test_rest.py | 23 +++++++++++ 10 files changed, 256 insertions(+), 10 deletions(-) create mode 100644 src/kimchi/control/storageserver.py -- 1.8.1.2

5 29

Process for Updating the API?
by Christy Perez 22 Jan '14

22 Jan '14

Hi guys, I'm having trouble following the logic for adding a new resource to the API. Could someone outline the general steps you'd need to cover? From the patches on the mailing list, it looks like all anyone ever does is new items to API.md -- but I'm getting a 404 not found error so I am obviously missing something important. Thanks! - Christy

4 3

[PATCH] Avoid useless libvirt error log produced by featuretests
by apporc 22 Jan '14

22 Jan '14

When running feature tests, we get bunch of error messages as below: *** Running feature tests *** libvirt: Domain Config error : internal error unknown protocol type 'http' libvirt: Domain Config error : internal error unknown protocol type 'https' libvirt: Domain Config error : internal error unknown protocol type 'ftp' libvirt: Domain Config error : internal error unknown protocol type 'ftps' libvirt: Domain Config error : internal error unknown protocol type 'tftp' *** Feature tests completed *** By replacing default error handler of libvirt, this patch succeeded to avoid the error. Signed-off-by: apporc <appleorchard2000(a)gmail.com> --- src/kimchi/featuretests.py | 7 +++++++ src/kimchi/model.py | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/kimchi/featuretests.py b/src/kimchi/featuretests.py index a5755a2..641ec5b 100644 --- a/src/kimchi/featuretests.py +++ b/src/kimchi/featuretests.py @@ -30,6 +30,11 @@ import threading from kimchi import config +def libvirt_errorhandler(userdata, error): + # A libvirt error handler to ignore annoying messages in stderr + pass + + ISO_STREAM_XML = """ <domain type='kvm'> <name>ISO_STREAMING</name> @@ -60,6 +65,8 @@ class FeatureTests(object): xml = ISO_STREAM_XML % {'protocol': protocol} conn = None try: + # Register the error handler to hide libvirt error in stderr + libvirt.registerErrorHandler(f=libvirt_errorhandler, ctx=None) conn = libvirt.open('qemu:///system') dom = conn.defineXML(xml) dom.undefine() diff --git a/src/kimchi/model.py b/src/kimchi/model.py index 2c6d3a1..fe1ae5b 100644 --- a/src/kimchi/model.py +++ b/src/kimchi/model.py @@ -222,7 +222,6 @@ class Model(object): sys.exit(1) def _set_capabilities(self): - kimchi_log.info("*** Running feature tests ***") self.qemu_stream = FeatureTests.qemu_supports_iso_stream() self.qemu_stream_dns = FeatureTests.qemu_iso_stream_dns() @@ -231,7 +230,6 @@ class Model(object): if FeatureTests.libvirt_supports_iso_stream(p): self.libvirt_stream_protocols.append(p) - kimchi_log.info("*** Feature tests completed ***") _set_capabilities.priority = 90 def get_capabilities(self): -- 1.7.9.5

4 3