- Kimchi-devel - oVirt List Archives

[PATCH 00/13][WIP] Refactor model
by Aline Manera 22 Jan '14

22 Jan '14

From: Aline Manera <alinefm(a)br.ibm.com> I am sending the first patch set to refactor model It is not completed. I still need to do a lot of tests and so on. But I would like to share it with you to get your suggestion. Basically, the common code between model and mockmodel was placed into model/<resource>.py and the specific code into model/libvirtbackend.py and mockbackend.py *** It still needs a lot of work *** - Tests all functions - Update Makefile and spec files - Update test cases Aline Manera (13): refactor model: Create a separated model for task resource refactor model: Create a separated model for debugreport resource refactor model: Create a separated model for config resource refactor model: Create a separated model for host resource refactor model: Create a separated model for plugin resource refactor model: Create a separated model for libvirt connection refactor model: Move StoragePooldef from model to libvirtstoragepools.py refactor model: Create a separated model for storagepool resource refactor model: Create a separated model for storagevolume resource refactor model: Create a separated model for interface and network resources refactor model: Create a separated model for template resource refactor model: Create a separated model for vm resource refactor model: Update server.py and root.py to use new models src/kimchi/control/base.py | 32 +- src/kimchi/control/config.py | 30 +- src/kimchi/control/debugreports.py | 18 +- src/kimchi/control/host.py | 24 +- src/kimchi/control/interfaces.py | 11 +- src/kimchi/control/networks.py | 11 +- src/kimchi/control/plugins.py | 13 +- src/kimchi/control/storagepools.py | 32 +- src/kimchi/control/storagevolumes.py | 24 +- src/kimchi/control/tasks.py | 11 +- src/kimchi/control/templates.py | 11 +- src/kimchi/control/utils.py | 2 +- src/kimchi/control/vms.py | 17 +- src/kimchi/mockmodel.py | 784 -------------- src/kimchi/model.py | 1827 -------------------------------- src/kimchi/model/__init__.py | 21 + src/kimchi/model/config.py | 52 + src/kimchi/model/debugreports.py | 86 ++ src/kimchi/model/host.py | 49 + src/kimchi/model/interfaces.py | 48 + src/kimchi/model/libvirtbackend.py | 955 +++++++++++++++++ src/kimchi/model/libvirtconnection.py | 123 +++ src/kimchi/model/libvirtstoragepool.py | 225 ++++ src/kimchi/model/mockbackend.py | 338 ++++++ src/kimchi/model/networks.py | 115 ++ src/kimchi/model/plugins.py | 29 + src/kimchi/model/storagepools.py | 86 ++ src/kimchi/model/storagevolumes.py | 95 ++ src/kimchi/model/tasks.py | 45 + src/kimchi/model/templates.py | 89 ++ src/kimchi/model/vms.py | 164 +++ src/kimchi/networkxml.py | 6 +- src/kimchi/root.py | 24 +- src/kimchi/server.py | 16 +- src/kimchi/vmtemplate.py | 18 +- 35 files changed, 2674 insertions(+), 2757 deletions(-) delete mode 100644 src/kimchi/mockmodel.py delete mode 100644 src/kimchi/model.py create mode 100644 src/kimchi/model/__init__.py create mode 100644 src/kimchi/model/config.py create mode 100644 src/kimchi/model/debugreports.py create mode 100644 src/kimchi/model/host.py create mode 100644 src/kimchi/model/interfaces.py create mode 100644 src/kimchi/model/libvirtbackend.py create mode 100644 src/kimchi/model/libvirtconnection.py create mode 100644 src/kimchi/model/libvirtstoragepool.py create mode 100644 src/kimchi/model/mockbackend.py create mode 100644 src/kimchi/model/networks.py create mode 100644 src/kimchi/model/plugins.py create mode 100644 src/kimchi/model/storagepools.py create mode 100644 src/kimchi/model/storagevolumes.py create mode 100644 src/kimchi/model/tasks.py create mode 100644 src/kimchi/model/templates.py create mode 100644 src/kimchi/model/vms.py -- 1.7.10.4

4 23

[RFC] Authorization enhancement
by Shu Ming 22 Jan '14

22 Jan '14

Background In Kimchi, now we have a basic authentication model based on PAM. In this model, all the authenticated user get all of the privileges to access the resources in Kimchi. However, it is too simple to cause some security holes and classifying the user with different roles is a way to address the holes. Roles with very fine grained privileges need huge effort and time, so here we are trying to split the effort with several steps. And we will discuss the first step of the effort in the below which can be achieved in a certain time bound and reserve the forward compatibility for future extensions. First step of the effort In this step, the goal is to authorize the user's action on a resource by roles. The user action here is applied by the REST API exposed by Kimchi. Every action on Kimchi resources should be checked based on the user's role. In this step, we will not try to have roles in a very fine granularity. Naturally, three permanent roles will be created by default, the system administrator role, the infrastructure role and the user role. * The system administrator get the privileges to manage the roles for the other users including assigning a role to a user, removing the role from a user &etc. A default user "admink" will be created by default with a system administrator role assigned to it. And the role of the user "admink" can not be modified. * The infrastructure role get the privileges to manage the physical resources and virtual resources including network's creation and deletion, create or delete storage storage pools or storage volumes' creation and deletion, adding a user to the user list of storage storage pool &etc. * The user role get the privileges to apply action on VMs including VMs' starting and stopping, viewing the VM console by VNC &etc. * Some of the change can be enhanced on the existing REST API like "DELETE /storagepools/poo1/vo1". But we need create new REST APIs for actions like adding a role for a user like " PUT /users/user1 {role: "user role"}" * Database is needed to store the user information including roles and resource user list Beside the privileges inherited from the user's role, Kimchi will check if a user get the permission to access a resource based on a tuple. The tuple is composed from both the privileges of the user and the user list of the resource. An example is, if a user try ti delete a storage volume from the stroage pool, Kimchi will check if it is assigned a infrastructure role and if it is in the user list of the storage pool. Next step of the effort * The roles are defined in a very fine granularity containing the privileges precisely matching what the system administrator expects. * Existing roles can by customized by the system administrator from a set of previleges. The set of privileges should be pre-defined and hierarchy. * The system administrator can create new roles with customized privileges

4 7

[PATCH v3 0/2] Change all CSS files indentation to 4 spaces
by Crístian Viana 21 Jan '14

21 Jan '14

This is the diff between this and the previous patchset (v2): - Add a new patch (1) to split lines longer than 80 characters and align the split lines consistently. Crístian Viana (2): CSS: Do not allow lines longer than 80 characters CSS: Change all CSS files indentation to 4 spaces ui/css/theme-default/button.css | 167 ++++++++++++++++++++---------- ui/css/theme-default/error.css | 15 ++- ui/css/theme-default/grid.css | 36 ++++--- ui/css/theme-default/host.css | 6 +- ui/css/theme-default/jquery-ui.custom.css | 27 +++-- ui/css/theme-default/line-chart.css | 6 +- ui/css/theme-default/list.css | 15 ++- ui/css/theme-default/nav-tree.css | 12 ++- ui/css/theme-default/network.css | 12 ++- ui/css/theme-default/popover.css | 39 ++++--- ui/css/theme-default/report-add.css | 3 +- ui/css/theme-default/reset.css | 8 +- ui/css/theme-default/storage.css | 18 ++-- ui/css/theme-default/template-edit.css | 9 +- ui/css/theme-default/template_add.css | 20 ++-- ui/css/theme-default/template_list.css | 24 +++-- ui/css/theme-default/toolbar.css | 6 +- ui/css/theme-default/topbar.css | 29 ++++-- ui/css/theme-default/window.css | 3 +- 19 files changed, 296 insertions(+), 159 deletions(-) -- 1.8.4.2

1 2

[PATCH v2] Change all CSS files indentation to 4 spaces
by Crístian Viana 21 Jan '14

21 Jan '14

This is the difference between this patchset and the previous one (v1): - Do not change the indentation level in "ui/css/theme-default/topbar.css"; that file contains a @media block, therefore the properties defined inside of it have another indentation level (8 spaces). That case was not considered by the sed regular expression that generated this patch.

2 3

[PATCH V2 0/4] improve controller
by shaohef＠linux.vnet.ibm.com 21 Jan '14

21 Jan '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> V1 -> V2 fix typo. remove print use url_auth instead of _url_sub_node_auth improve the commit description add a method to load root sub collections/resouces automatically ShaoHe Feng (4): improve controller: add a method to load root sub collections/resouces automatically improve controller: tag the collections/resouces of root with @urlSubNode improve controller: Root loads collections/resouces automatically improve controller: set authentication automatically src/kimchi/control/__init__.py | 8 ++++++++ src/kimchi/control/config.py | 2 ++ src/kimchi/control/debugreports.py | 2 ++ src/kimchi/control/host.py | 2 ++ src/kimchi/control/interfaces.py | 2 ++ src/kimchi/control/networks.py | 2 ++ src/kimchi/control/plugins.py | 2 ++ src/kimchi/control/storagepools.py | 2 ++ src/kimchi/control/tasks.py | 2 ++ src/kimchi/control/templates.py | 2 ++ src/kimchi/control/vms.py | 2 ++ src/kimchi/root.py | 26 +++++-------------------- src/kimchi/server.py | 12 +++++------- src/kimchi/utils.py | 39 ++++++++++++++++++++++++++++++++++++++ 14 files changed, 77 insertions(+), 28 deletions(-) -- 1.8.4.2

2 15

[PATCHv6 0/2] nfs prevalidation
by lvroyce0210＠gmail.com 21 Jan '14

21 Jan '14

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com> v4>v5, make temp dir during try mount instead of using the pool mount point v1>v4, Address naming comments, integrate run_command patch and use context manager to deal with umount Royce Lv (2): utils: Add nfs prevalication Integrate nfs path check before create nfs pool src/kimchi/model.py | 34 +++++++++++++++++++++++++++++++--- src/kimchi/utils.py | 8 ++++++++ 2 files changed, 39 insertions(+), 3 deletions(-) -- 1.8.1.2

2 5

[PATCH 1/5] Ubuntu: Add the LVM dependency package to README
by Crístian Viana 21 Jan '14

21 Jan '14

The README file contains instructions to build Kimchi from the source tree, including the exact command to install the dependencies on Ubuntu. But that command does not contain the LVM package which is needed to probe LVM devices when creating a logical storage pool. Add the LVM package ("lvm2") to the apt-get install command in the README file. Signed-off-by: Crístian Viana <vianac(a)linux.vnet.ibm.com> --- docs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/README.md b/docs/README.md index d80486b..a1f02ee 100644 --- a/docs/README.md +++ b/docs/README.md @@ -60,7 +60,7 @@ for more information on how to configure your system to access this repository. python-pam python-m2crypto python-jsonschema \ qemu-kvm libtool python-psutil python-ethtool \ sosreport python-ipaddr python-lxml nfs-common \ - open-iscsi + open-iscsi lvm2 Packages version requirement: python-jsonschema >= 1.3.0 -- 1.8.4.2

2 10

[PATCH] Use cherrypy's default dispatcher for subcollection
by Mark Wu 21 Jan '14

21 Jan '14

Currently, we override the dispatchers of resource StoragePool and IsoPool when the request targets to storagevolumes it holds. But it's not necessary to use a customized dispatcher. It can be done by add an attribute to associate with the subcollcetion. In this case, it's 'storagevolumes'. Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com> --- src/kimchi/control/storagepools.py | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/kimchi/control/storagepools.py b/src/kimchi/control/storagepools.py index 782f5a6..06b7196 100644 --- a/src/kimchi/control/storagepools.py +++ b/src/kimchi/control/storagepools.py @@ -83,6 +83,7 @@ class StoragePool(Resource): self.uri_fmt = "/storagepools/%s" self.activate = self.generate_action_handler('activate') self.deactivate = self.generate_action_handler('deactivate') + self.storagevolumes = StorageVolumes(self.model, ident.decode("utf-8")) @property def data(self): @@ -103,27 +104,14 @@ class StoragePool(Resource): return res - def _cp_dispatch(self, vpath): - if vpath: - subcollection = vpath.pop(0) - if subcollection == 'storagevolumes': - # incoming text, from URL, is not unicode, need decode - return StorageVolumes(self.model, self.ident.decode("utf-8")) - class IsoPool(Resource): def __init__(self, model): super(IsoPool, self).__init__(model, ISO_POOL_NAME) + self.storagevolumes = IsoVolumes(self.model, ISO_POOL_NAME) @property def data(self): return {'name': self.ident, 'state': self.info['state'], 'type': self.info['type']} - - def _cp_dispatch(self, vpath): - if vpath: - subcollection = vpath.pop(0) - if subcollection == 'storagevolumes': - # incoming text, from URL, is not unicode, need decode - return IsoVolumes(self.model, self.ident.decode("utf-8")) -- 1.8.4.2

3 4

[PATCHv8 0/8] storage server and target support
by lvroyce0210＠gmail.com 21 Jan '14

21 Jan '14

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com> v7>v8, address model break, change xml construction to libxml v6>v7, adopt lxml to parse xml, move parse params to get() to avoid duplicate code, fix bugs when one server support multiple target type. v5>v6, change GET param support to cover more scenario of filter collected results. v4>v5, remove storage server list reload function, merge storage server and targets v3>v4, fix inconsistency between doc and json schema v1>v3, fix racing problem, fix style. Royce Lv (8): Support params for GET method Add testcase for GET param Storage server: Update API.md storage server: update controller.py storage server: Update model and mockmodel storage target: Update API.md storage target: Update controller and json schema storage target: Add model support docs/API.md | 22 +++++++++++ src/kimchi/API.json | 20 ++++++++++ src/kimchi/control/base.py | 24 ++++++++---- src/kimchi/control/storagepools.py | 4 +- src/kimchi/control/storageserver.py | 61 +++++++++++++++++++++++++++++ src/kimchi/control/storagevolumes.py | 2 +- src/kimchi/control/utils.py | 7 ++++ src/kimchi/mockmodel.py | 30 +++++++++++++++ src/kimchi/model.py | 75 ++++++++++++++++++++++++++++++++++++ src/kimchi/root.py | 2 + tests/test_rest.py | 36 +++++++++++++++++ 11 files changed, 272 insertions(+), 11 deletions(-) create mode 100644 src/kimchi/control/storageserver.py -- 1.8.1.2

4 12

Open Discussion: Introduce 3rd party jquery widget library for kimchi
by Yu Xin Huo 21 Jan '14

21 Jan '14

Hi, team I would introduce 3rd party jquery widget library for functional widgets like chart/gauge/datagrid to kimchi. I searched the web and got 2 libraries below: http://www.jqwidgets.com/ http://zinoui.com/ Feel free to try these 2 libraries and throw out your opinions about them, and also please actively propose the jquery widget library you know. Adam and Aline, please help to check the license with lawyer.

1 1