October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: /current query parameter is inconsistent with the r...
by mpastern＠redhat.com 24 Oct '12

24 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: /current query parameter is inconsistent with the rest of url parameters ...................................................................... restapi: /current query parameter is inconsistent with the rest of url parameters ?current=true query parameter is depreciated and supported for backward compatibility only - should be dropped at 4.0 https://bugzilla.redhat.com/show_bug.cgi?id=869257 Change-Id: Iced7ff2587d557f0574996515793920e9ab15650 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCdRomResourceTest.java 3 files changed, 41 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iced7ff2587d557f0574996515793920e9ab15650 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: Support filtered capabilities (#868949)
by oourfali＠redhat.com 24 Oct '12

24 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: rest: Support filtered capabilities (#868949) ...................................................................... rest: Support filtered capabilities (#868949) https://bugzilla.redhat.com/868949 Several config parameters aren't exposed to users (as they aren't relevant). These are used in the capabilities resource. Changing the generation of the capabilities response to not contain these values. Also, exposing the cluster levels, as they may be relevant for users as well. Finally, removing the enable local storage test, as it is always enabled in 3.1. Change-Id: I549e680226f0d802872915b8a46c9e5a8c322b44 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java 2 files changed, 14 insertions(+), 14 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/8764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I549e680226f0d802872915b8a46c9e5a8c322b44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed return type on input control (#854926)
by ydary＠redhat.com 24 Oct '12

24 Oct '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed return type on input control (#854926) ...................................................................... reports: fixed return type on input control (#854926) The query contained a case that return either date type or timestamp type, this caused the input control to ignore the user selection of dates. This was fixed by adding a cast. bug-url: https://bugzilla.redhat.com/854926 Change-Id: Id36fbe7ff9fec29de401faf0c7aaff823ce104a9 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/P_Start_Date.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id36fbe7ff9fec29de401faf0c7aaff823ce104a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated parsing old configuration
by juan.hernandez＠redhat.com 23 Oct '12

23 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated parsing old configuration ...................................................................... packaging: Updated parsing old configuration Updated a function that parses web-conf.js and fetches configuration parameters for 3.0 installation. Change-Id: I87d9a3a5689702853f6671c8748322eea213e725 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87d9a3a5689702853f6671c8748322eea213e725 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: refresh audio device for desktop on OS change (#867331...
by ofrenkel＠redhat.com 23 Oct '12

23 Oct '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: refresh audio device for desktop on OS change (#867331) ...................................................................... core: refresh audio device for desktop on OS change (#867331) https://bugzilla.redhat.com/show_bug.cgi?id=867331 when updating desktop vm OS, audio device might need to be changed, according to config (DesktopAudioDeviceType) this patch add logic to replace audio device on vm OS change. Change-Id: Ic2f12f32661fc5276ca7417f48ebb949daf9bf5e Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java 4 files changed, 45 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/8747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2f12f32661fc5276ca7417f48ebb949daf9bf5e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Encrypt CHAP credentials in the database
by dfediuck＠redhat.com 23 Oct '12

23 Oct '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Encrypt CHAP credentials in the database ...................................................................... core: Encrypt CHAP credentials in the database While fixing an issue where CHAP credentials weren't being stored in the database, it was suggested that the credentials should be encrypted. This patch: - updates the database to store the longer, encrypted password values - migrates (encrypts) the passwords during upgrade - updates the DAO to encrypt and decrypt the passwords dynamically as they are read from/written to the db - refactors encryptPassword/decryptPassword methods from class VdsStaticDAODbFacadeImpl to DbFacadeUtils to facilitate reuse Change-Id: I15b4cba7418d9d818fb2fd69c708fdeb20942f9c Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql A backend/manager/dbscripts/upgrade/03_01_1440_encrypt_chap_password.sh M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java 6 files changed, 88 insertions(+), 45 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15b4cba7418d9d818fb2fd69c708fdeb20942f9c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: code format
by mpastern＠redhat.com 23 Oct '12

23 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: core: code format ...................................................................... core: code format Change-Id: Ic769801168028c18a9e97f704eeb42ccdbcd9574 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/WipeAfterDeleteUtils.java 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic769801168028c18a9e97f704eeb42ccdbcd9574 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Use single quote in localization files
by ecohen＠redhat.com 22 Oct '12

22 Oct '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin,userportal: Use single quote in localization files ...................................................................... webadmin,userportal: Use single quote in localization files This patch replaces double quote characters ('') with single quote character (') in all Constants-related localization properties files. This patch was made by executing following bash script: gwtClasses="CommonApplicationConstants ApplicationConstants Constants Enums LocalizedEnums AppErrors ConsoleErrors SpiceRedKeys VdsmErrors" for c in $gwtClasses do mask=$c"*.properties" find . -name $mask -exec sed -i "s/''/'/g" '{}' \; done This is necessary since GWT treats Constants-related localization resources as-is (unlike Messages-related localization resources, where quote characters must be terminated explicitly using double quoting). Change-Id: Ib13cb39fbb8ca502bcb9a7b00fb5f6c807372367 Bug-Url: https://bugzilla.redhat.com/867421 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_fr.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Constants_fr.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/ConsoleErrors_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/ConsoleErrors_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_fr.properties 11 files changed, 1,337 insertions(+), 1,337 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib13cb39fbb8ca502bcb9a7b00fb5f6c807372367 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal+core: Cannot change VM cluster in UP (#863139)
by oourfali＠redhat.com 22 Oct '12

22 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: userportal+core: Cannot change VM cluster in UP (#863139) ...................................................................... userportal+core: Cannot change VM cluster in UP (#863139) https://bugzilla.redhat.com/863139 When trying to change the VM cluster from the user portal, the clusters aren't displayed properly for PowerUsers. This patch changes the behavior to require CREATE_VM on the cluster in order to do that, rather than EDIT_VM_PROPERTIES. Change-Id: I7fd4f6912c21a8d24e79d67c22007e1061ff0b1a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalExistingVmModelBehavior.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fd4f6912c21a8d24e79d67c22007e1061ff0b1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core,engine: Add NetworkView entity
by masayag＠redhat.com 22 Oct '12

22 Oct '12

Moti Asayag has submitted this change and it was merged. Change subject: core,engine: Add NetworkView entity ...................................................................... core,engine: Add NetworkView entity The NetworkView entity represents a view over the network with partial information of its data-center. It will serve the search engine to fetch the required information when searching for network entities. Change-Id: I60d5473347642ed7d96c89accd675977dd86e017 Bug-Url: https://bugzilla.redhat.com/858742 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NetworkView.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkDAODbFacadeImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkViewDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/NetworkViewDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkViewDaoTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 10 files changed, 209 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60d5473347642ed7d96c89accd675977dd86e017 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0