October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add search for Networks
by masayag＠redhat.com 22 Oct '12

22 Oct '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add search for Networks ...................................................................... engine: Add search for Networks The patch adds support for Networks entities in search engine. The network entities could be searched as main entities or as a property related to other entities. Search queries: * Networks : datacenter = DcName (also search by network properties: vlan id, MTU, STP, VM network, name and description) * Cluster: Cluster_network.network_name = networkName * Host : Nic.network_name = networkName * Vm : Vnic.network_name = networkName * Template : Vnic.network_name = networkName Change-Id: I1fd9a483c5c8e3920d2f381132bf4d92d470fc57 Bug-Url: https://bugzilla.redhat.com/858742 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterCrossRefAutoCompleter.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkClusterConditionFieldAutoCompleter.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleter.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkInterfaceConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolCrossRefAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/TemplateCrossRefAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdsCrossRefAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmCrossRefAutoCompleter.java A backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/NetworkConditionFieldAutoCompleterTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java 18 files changed, 270 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fd9a483c5c8e3920d2f381132bf4d92d470fc57 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: expose host subject also in VM properties #867513
by mpastern＠redhat.com 22 Oct '12

22 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: expose host subject also in VM properties #867513 ...................................................................... restapi: expose host subject also in VM properties #867513 https://bugzilla.redhat.com/show_bug.cgi?id=867513 certificate will be shown only when accessing specific vm resource, future api versions will alow user specifying if he wants to get entier entity [1] at collection resource. [1] https://bugzilla.redhat.com/show_bug.cgi?id=868626 Change-Id: I73170653a307aa98d7219af4b792af133349cfd2 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 3 files changed, 36 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8692 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73170653a307aa98d7219af4b792af133349cfd2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #864991 - Vm Custom Properties Ignored
by oliel＠redhat.com 22 Oct '12

22 Oct '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #864991 - Vm Custom Properties Ignored ...................................................................... restapi: #864991 - Vm Custom Properties Ignored Change-Id: I5d9c4ac782edf1779455aeee4121091199b76b3d Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 2 files changed, 14 insertions(+), 16 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d9c4ac782edf1779455aeee4121091199b76b3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ISO domain permission error shouldn't tirgger SPM sele...
by derez＠redhat.com 22 Oct '12

22 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: ISO domain permission error shouldn't tirgger SPM selection. ...................................................................... core: ISO domain permission error shouldn't tirgger SPM selection. Failure while executing getFloppyList command with permission error triggers DC reinitialization instead of just logging the error. GetFloppyListCommand is a IrsBrokerCommands, which means that generally an exception thrown by it would trigger a run of the failure mechanism in IrsBrokerCommand. This patch changes the default thrown exception from this commands to be an exception that doesn't trigger failover, so unless we encounter specific case SPM reselection won't be triggered. Change-Id: I4e75982d1a88dc36251d2c2e693ffafdc7a7a99e Bug-Url: https://bugzilla.redhat.com/854975 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetFloppyListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 4 files changed, 18 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e75982d1a88dc36251d2c2e693ffafdc7a7a99e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #864840 - Connection Details Mandatory For ISCSI LU...
by oliel＠redhat.com 22 Oct '12

22 Oct '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #864840 - Connection Details Mandatory For ISCSI LUN Disk ...................................................................... restapi: #864840 - Connection Details Mandatory For ISCSI LUN Disk Change-Id: I0b7f4aa7fdb5d163a2fed6e149a027139f6888a8 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/DiskResourceUtils.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java 4 files changed, 119 insertions(+), 24 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b7f4aa7fdb5d163a2fed6e149a027139f6888a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Increase AJP timeout to 1 hour
by juan.hernandez＠redhat.com 22 Oct '12

22 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Increase AJP timeout to 1 hour ...................................................................... packaging: Increase AJP timeout to 1 hour We need this longer timeout from some very long operations performed using the REST API. This should be reduced once we implement asynchronous operations. Change-Id: I6fb97b087769f1b19f12ccb590861a2f7b559dc2 Bug-Url: https://bugzilla.redhat.com/853045 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/ovirt-engine-proxy.conf.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fb97b087769f1b19f12ccb590861a2f7b559dc2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: User can't see its permissions (#868304)
by oourfali＠redhat.com 22 Oct '12

22 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: rest: User can't see its permissions (#868304) ...................................................................... rest: User can't see its permissions (#868304) https://bugzilla.redhat.com/868304 When asking for object permissions in the REST API, we call search query, to get all users. This patch changes that to only fetch for users relevant for the permission itself, doing that using GetDbUserById query, and also making it a user query to allow users to view permissions on their objects. Change-Id: I6f21f4b8a845d52276dd7d97b5c7069892bb3b77 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java 6 files changed, 44 insertions(+), 30 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f21f4b8a845d52276dd7d97b5c7069892bb3b77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-dwh[master]: etl: fixed duplications in disks usage tables (#866492)
by ydary＠redhat.com 22 Oct '12

22 Oct '12

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed duplications in disks usage tables (#866492) ...................................................................... etl: fixed duplications in disks usage tables (#866492) This is due to bug in code generation added non ANSI code a workaround till this is fixed. bug-url:https://bugzilla.redhat.com/866492 Change-Id: If4aef381115d54d96861ed827570bd2cf52469bc Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtodaily_3_1/AggregationToDaily.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtohourly_3_1/AggregationToHourly.java M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.1.item M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.1.properties M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.1.item M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.1.properties M data-warehouse/history_etl/tos_project/talend.project 7 files changed, 531 insertions(+), 3,147 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4aef381115d54d96861ed827570bd2cf52469bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improving VdsEventListener.vdsUpEvent
by mkublin＠redhat.com 22 Oct '12

22 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving VdsEventListener.vdsUpEvent ...................................................................... engine: Improving VdsEventListener.vdsUpEvent The following patch will remove an unneeded query for retrieve status of vdsm, in case of moving vdsm to NonOperational, VdsEventListener.vdsUpEvent should return false Change-Id: Idb5d5baecd9cc162e2d9082f42acdc715cf89da6 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 8 insertions(+), 5 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb5d5baecd9cc162e2d9082f42acdc715cf89da6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: revert the remove of a check in VdsSelector
by rgolan＠redhat.com 22 Oct '12

22 Oct '12

Roy Golan has submitted this change and it was merged. Change subject: core: revert the remove of a check in VdsSelector ...................................................................... core: revert the remove of a check in VdsSelector Accidentally removed a check in VdsSelector due to refactoring Change-Id: I70b9bfa8cb6edf3b8833a0b9ee71fe9487f967e9 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70b9bfa8cb6edf3b8833a0b9ee71fe9487f967e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0